1. 14 Oct, 2019 9 commits
    • Sergei Golubchik's avatar
      MDEV-12684 Show what config file a sysvar got a value from · 173ae631
      Sergei Golubchik authored
      Show the config file in I_S.SYSTEM_VARIABLES
      But only if the user has FILE privilege
      173ae631
    • Sergei Golubchik's avatar
      MDEV-12684 Show what config file a sysvar got a value from · f217612f
      Sergei Golubchik authored
      change get_one_option() prototype to pass the filename and
      not to pass the redundant optid.
      f217612f
    • Sergei Golubchik's avatar
      MDEV-12684 Show what config file a sysvar got a value from · 927521a2
      Sergei Golubchik authored
      make load_defaults() store the file name in the generated option list
      using a special marker ---file-marker--- option.
      
      Pick up this filename in handle_options().
      
      Remove ---args-separator---, use ---file-marker--- with an empty file
      name instead - this simplifies checks on the caller, only one special
      option to recognize.
      927521a2
    • Sergei Golubchik's avatar
      cleanup: don't use my_getopt_is_args_separator() · f7b8d144
      Sergei Golubchik authored
      only my_getopt should use it, because it changes my_getopt's behavior.
      If one simply wants to skip the separator - don't ask it to be added
      in the first place
      f7b8d144
    • Sergei Golubchik's avatar
      cleanup: unify --defaults* option handling · 3e569727
      Sergei Golubchik authored
      process all --defaults* options uniformly,
      get rid of special case for --no-defaults and --print-defaults
      use realpath instead of blindly concatenating pwd and relative path.
      3e569727
    • Sergei Golubchik's avatar
      cleanup: my_getopt, get_one_option isn't optional · 3ea51b51
      Sergei Golubchik authored
      it turns out that practically every single user of handle_options()
      used the get_one_option callback. Simplify the code,
      make it mandatory, adjust unit tests.
      3ea51b51
    • Sergei Golubchik's avatar
      cleanup: my_getopt, consistency · eb3431d5
      Sergei Golubchik authored
      almost all my_getopt settings and callbacks are global variables,
      directly assignable to configure my_getopt. Only getopt_get_addr
      was using a setter function. Get rid of it, make it a global
      directly assignable variable like all other settings.
      
      Also make getopt_compare_strings() static.
      eb3431d5
    • Sergei Golubchik's avatar
      cleanup: my_defaults, remove Process_option_func · 8965ae27
      Sergei Golubchik authored
      This is a remnant of "MySQL Instance Manager", which was removed in
      MySQL-5.5.0 and never existed in MariaDB
      
      Remove callback, simplify and optimize the code accordingly.
      8965ae27
    • Alexander Barkov's avatar
      MDEV-20818 ER_CRASHED_ON_USAGE or Assertion `length <= column->length' failed... · 5392726e
      Alexander Barkov authored
      MDEV-20818 ER_CRASHED_ON_USAGE or Assertion `length <= column->length' failed in write_block_record on temporary table
      
      The patch for `MDEV-20795 CAST(inet6 AS BINARY) returns wrong result`
      unintentionally changed what Item_char_typecast::type_handler()
      returns. This broke UNIONs with the BINARY() function, as the Aria
      engine started to get columns of unexpected data types.
      
      Restoring previous behaviour, to return
        Type_handler::string_type_handler(max_length).
      
      The prototype for Item_handed_func::return_type_handler() has changed
      from:
        const Type_handler *return_type_handler() const
      to:
        const Type_handler *return_type_handler(const Item_handled_func *) const
      5392726e
  2. 13 Oct, 2019 8 commits
  3. 12 Oct, 2019 12 commits
  4. 11 Oct, 2019 11 commits