- 09 Apr, 2015 8 commits
-
-
Sergei Golubchik authored
rename to innodb-scrub-log-speed
-
Sergei Golubchik authored
-
Sergei Golubchik authored
move remaning defines to my_crypt, add MY_ namespace prefix
-
Sergei Golubchik authored
with namespace prefixes
-
Sergei Golubchik authored
invoke plugin methods directly
-
Sergei Golubchik authored
* no --encryption-algorithm option anymore * encrypt/decrypt methods in the encryption plugin * ecnrypt/decrypt methods in the encryption_km service * file_km plugin has --file-key-management-encryption-algorithm * debug_km always uses aes_cbc * example_km changes between aes_cbc and aes_ecb for different key versions
-
Sergei Golubchik authored
because it's going to do more than just key management
-
Sergei Golubchik authored
only those tests should be disabled in suite.pm that cannot be disabled from mysqltest files (e.g. when the server is started with a special command-line option - unknown option will abort the server before mysqltest will start its checks).
-
- 08 Apr, 2015 19 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
only one encryption key lookup in most cases instead of three (has_key, get_key_size, get_key).
-
Sergei Golubchik authored
-
Sergei Golubchik authored
numerous issues fixed: * buffer overflows * error conditions aren't checked (crash if file doesn't exist) * accessing random unallocated memory * hard-coded password * arbitrary hard-coded key id limit * incomprehensible error messages (for key_id == 0 it reported "The key could not be initialized", for syntax errors the message was "Wrong match of the keyID, see the template", for a key id larger than hard-coded limit the message was "No asked key", and there was an error "Is comment" for a comment). * tons of small mallocs, many are freed few lines down in the code * malloc(N) and new char[N] are used both, even in the same function * redundant memory copies * pcre - "I can solve it with regular expressions" - with incorrect regexes * parser context stored in a singleton * keys are stored as strings and are strlen-ed and hex2bin-ed on every get_key() request * lots of useless code (e.g. sprintf instead of a pointer assignment, checking of the file length to read a part of it in a fixed buffer, multiplying by sizeof(char) in many places, etc) * this list is not exhaustive
-
Sergei Golubchik authored
not an address of some arbitrarily chosen symbol; not when plugin is successfully loaded (which means - no info when plugin->init failed);
-
Sergei Golubchik authored
-
Sergei Golubchik authored
in particular, "innodb.innodb-page_encryption,xtradb" should select these three tests: innodb.innodb-page_encryption 'cbc,xtradb' [ pass ] 35563 innodb.innodb-page_encryption 'ctr,xtradb' [ pass ] 36858 innodb.innodb-page_encryption 'ecb,xtradb' [ pass ] 36741 and deselect all innodb_plugin tests. This was not the case, because the %test_combs hash was destructively modified in the loop
-
Sergei Golubchik authored
* my_aes.h doesn't compile without my_global.h * typo in a comment * redundant condition * if encryption plugin fails, there's no encryption_key_manager at plugin deinit time * encryption plugin tests must run when plugin.so is present, not when a plugin is active (otherwise the test will be skipped when plugin fails to initialize).
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
for temporary Aria tables. It can use a faster BLOCK_RECORD
-
Sergei Golubchik authored
now IVs are always handled internally
-
Sergei Golubchik authored
-
Sergei Golubchik authored
and simplify Item_func_aes_encrypt/decrypt
-
Sergei Golubchik authored
-
Sergei Golubchik authored
to: different key lengths
-
- 05 Apr, 2015 7 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
* comments * move my_bytes_to_key() and my_aes_hex2uint() into file_key_management_plugin * rename HA_INSERT_ORDER -> HA_PRESERVE_INSERT_ORDER * remove unused variables and declarations * fix casts * don't link innodb with pcre * remove redundant entries from aria's TARGET_LINK_LIBRARIES
-
Sergei Golubchik authored
they should've been deleted long ago, but weren't
-
Sergei Golubchik authored
followup
-
Sergei Golubchik authored
(one generally should not do that, these messages are printed on every cmake run)
-
- 03 Apr, 2015 4 commits
-
-
Sergei Petrunia authored
Print r_rows. There is no table tracking for reading from tmp table, yet.
-
Oleksandr Byelkin authored
-
Alexander Barkov authored
-
Jan Lindström authored
-
- 01 Apr, 2015 1 commit
-
-
Nirbhay Choubey authored
-
- 31 Mar, 2015 1 commit
-
-
Jan Lindström authored
-