- 24 Sep, 2020 3 commits
-
-
Marko Mäkelä authored
In merge commit 34212233 buf_page_create() passed the wrong parameter to one of the buf_LRU_block_free_non_file_page() calls.
-
Marko Mäkelä authored
When commit 0fd3def2 removed the MLOG_UNDO_ERASE_END record in MariaDB 10.3.3 in an attempt to reduce our redo log volume, it introduced technical debt for commit 56f6dab1 (MDEV-21174) and commit 7ae21b18 (MDEV-12353), which optimized mtr_t::write() (née mlog_write_ulint()) so that the initial bytes that are unchanged are not logged. trx_undo_report_row_operation(): Write a log record for the memset() operation if the page is not going to be freed.
-
Vladislav Vaintroub authored
-
- 23 Sep, 2020 2 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Port some CMake tweaks of commit 4adc1269 from 10.5.
-
- 22 Sep, 2020 14 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
It turns out that we must check for DISCARD TABLESPACE both when the table is being rebuilt and when the AUTO_INCREMENT value of the table is being added. This was caught by the test innodb.alter_missing_tablespace. Somehow I failed to run all tests. Sorry!
-
Marko Mäkelä authored
The statement ALTER TABLE...DISCARD TABLESPACE is problematic, because its designed purpose is to break the referential integrity of the data dictionary and make a table point to nowhere. ha_innobase::commit_inplace_alter_table(): Check whether the table has been discarded. (This is a bit late to check it, right before committing the change.) Previously, we performed this check only in a specific branch of the function commit_set_autoinc(). Note: We intentionally allow non-rebuilding ALTER TABLE even if the tablespace has been discarded, to remain compatible with MySQL. (See the various tests with "wl5522" in the name, such as innodb.innodb-wl5522.) The test case would crash starting with 10.3 only, but it does not hurt to minimize the code and test difference between 10.2 and 10.3.
-
Marko Mäkelä authored
dict_load_table_low(): Copy the 'discarded' flag to file_unreadable. This allows to avoid a potentially harmful call to dict_stats_init() in ha_innobase::open().
-
Marko Mäkelä authored
The test that was added in commit e05650e6 would break a subsequent run of a test encryption.innodb-bad-key-change because some pages in the system tablespace would be encrypted with a different key. The failure was repeatable with the following invocation: ./mtr --no-reorder \ encryption.create_or_replace,cbc \ encryption.innodb-bad-key-change,cbc Because the crash was unrelated to the code changes that we reverted in commit eb38b1f7 we can safely re-apply those fixes.
-
Jan Lindström authored
-
Jan Lindström authored
Add error printout when mysql.wsrep_streaming_log lock fails. However, tests are very undeterministic and not suitable for mtr environment. Thus, they are removed.
-
Marko Mäkelä authored
After DISCARD TABLESPACE, the tablespace of a table will no longer exist, and dict_get_and_save_data_dir_path() would invoke dict_get_first_path() to read an entry from SYS_DATAFILES. For some reason, DISCARD TABLESPACE would not to remove the entry from there. dict_get_and_save_data_dir_path(): If the tablespace has been discarded, do not bother trying to read the name. Side note: The tables SYS_TABLESPACES and SYS_DATAFILES are redundant and subject to removal in MDEV-22343.
-
Marko Mäkelä authored
This reverts commit e33f7b6f. The change seems to have introduced intermittent failures of the test encryption.innodb-bad-key-change on many platforms. The failure that we were trying to address was not reproduced on 10.2. It could be related to commit a7dd7c89 (MDEV-23651) or de942c9f (MDEV-15983) or other changes that reduced contention on fil_system.mutex in 10.3. The fix that we are hereby reverting from 10.2 seems to work fine on 10.3 and 10.4.
-
Daniel Black authored
This is just to make sure no ExecStartPre/Post actions from the multi-instance MariaDB service definition are executed when a user attempts to start mariadb@bootstrap. Fixes: 3723c70a
-
- 21 Sep, 2020 13 commits
-
-
Marko Mäkelä authored
We omit commit a3bdce8f and commit a0e2a293 because they would make the test galera_3nodes.galera_gtid_2_cluster fail and disable it.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
This was forgotten in commit a9d8f5c1.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Let us shrink the test encryption.create_or_replace so that it can run on the CI system, also on the embedded server. encryption.create_or_replace_big: Renamed from the original test, with the subset of encryption.create_or_replace omitted.
-
Marko Mäkelä authored
The test encryption.create_or_replace would occasionally fail with a warning message from fil_check_pending_ops(). fil_crypt_find_space_to_rotate(): While waiting for available I/O capacity, check fil_space_t::is_stopping() and release a handle if necessary. fil_space_crypt_close_tablespace(): Wake up the waiters in fil_crypt_find_space_to_rotate().
-
Jan Lindström authored
-
Jan Lindström authored
-
Vlad Lesin authored
-
Vlad Lesin authored
log_group_read_log_seg() returns error when: 1) Calculated log block number does not correspond to read log block number. This can be caused by: a) Garbage or an incompletely written log block. We can exclude this case by checking log block checksum if it's enabled(see innodb-log-checksums, encrypted log block contains checksum always). b) The log block is overwritten. In this case checksum will be correct and read log block number will be greater then requested one. 2) When log block length is wrong. In this case recv_sys->found_corrupt_log is set. 3) When redo log block checksum is wrong. In this case innodb code writes messages to error log with the following prefix: "Invalid log block checksum." The fix processes all the cases above.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 20 Sep, 2020 1 commit
-
-
Elena Stepanova authored
Temporarily disable failing S3 tests to allow the suite to run in buildbot: s3.partition and s3.partition_move are disabled due to MDEV-23648. While the problem is supposedly generic, the tests don't fail with Amazon setup, so they are disabled conditionally for emulator (MinIO). s3.replication_partition is disabled due to MDEV-23730, it fails both with Amazon and MinIO. s3.replication_mixed and s3.replication_stmt are disabled due to MDEV-23770, they also fail both with Amazon and the emulator.
-
- 19 Sep, 2020 1 commit
-
-
Sergei Petrunia authored
Add the printout
-
- 18 Sep, 2020 2 commits
-
-
Jan Lindström authored
Fix assertion text it was too tight for some systems. This is backport from 10.4 and for Galera 3.
-
Jan Lindström authored
Fix assertion text it was too tight for some systems.
-
- 17 Sep, 2020 4 commits
-
-
Vladislav Vaintroub authored
The presumed reason for the error is that the file was opened by 3rd party antivirus or backup program, causing ERROR_SHARING_VIOLATION on rename. The fix, actually a workaround, is to retry MoveFileEx couple of times before finally giving up. We expect 3rd party programs not to hold file for extended time.
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
Add CRC32C code to mysys. The x86-64 implementation uses PCMULQDQ in addition to CRC32 instruction after Intel whitepaper, and is ported from rocksdb code. Optimized ARM and POWER CRC32 were already present in mysys.
-
Marko Mäkelä authored
The counter buffer_flush_background_total_pages may be unreliable, because pages can be flushed in different means. So, let us only check INNODB_BUFFER_POOL_PAGES_FLUSHED.
-