An error occurred fetching the project authors.
  1. 23 Oct, 2009 1 commit
    • Michael Widenius's avatar
      Fixes for binary distribution in tar file · 1d8424d7
      Michael Widenius authored
      - mysql_install_db doesn't require --basedir option anymore
      - Fix that mysql_install_db mysqld_safe mysql_fix_privilege_tables has right paths for tar binary install
      - Move some files from share/mysql to where they have always been (1.0 - 5.0)
      - Move scripts used when installing MariaDB to the scripts directory (Added symlinks in old place for compatibility)
      - Move man files to 'man' (from 'share/man')
      - Ensure that all scripts are executable
      
      mysql_secure_installation.sh
      - Added support for --basedir flag
      - Don't assume that the mysql binary is in the path
      
      Other:
      - Fixed crash when one got kill signal during bootstrap
      
      Docs/INSTALL-BINARY:
        Change references from MySQL to MariaDB
      Docs/mysql.info:
        Change references from MySQL to MariaDB
      README:
        Removed duplicate row
      configure.in:
        Change references from MySQL to MariaDB
      libmysql/libmysql.c:
        Assume that if version string contains '-maria-' we are also using MariaDB
      scripts/make_binary_distribution.sh:
        Fix that mysql_install_db mysqld_safe mysql_fix_privilege_tables has right paths for tar binary install
        Remove some files that should not be part of a MariaDB binary install
        Move some files from share/mysql to where they have always been (1.0 - 5.0)
        Move man files to 'man' (from 'share/man')
        Move scripts used when installing MariaDB to the scripts directory (Added symlinks in old place for compatibility)
        Removed generation of 'netware/init_db.sql', as it was never used
        Remove old reference to bk tree
      scripts/mysql_secure_installation.sh:
        Added support for --basedir flag
        Don't assume that the mysql binary is in the path
        Use .my.cnf files
        Removed a lot of useless 'echo' rows
      sql/mysqld.cc:
        Fixed crash when one got kill signal during bootstrap
      storage/maria/Makefile.am:
        Don't add internal test files to binary distributions
      storage/myisam/Makefile.am:
        Don't add internal test files to binary distributions
      support-files/Makefile.am:
        Make scripts executable
      support-files/config.huge.ini.sh:
        Removed execution bit
      support-files/config.medium.ini.sh:
        Removed execution bit
      support-files/config.small.ini.sh:
        Removed execution bit
      support-files/mysql.server.sh:
        Ensure this works also mysqld is in the 'bin' directory
      1d8424d7
  2. 16 Oct, 2009 1 commit
  3. 15 Oct, 2009 1 commit
  4. 07 Oct, 2009 1 commit
  5. 02 Oct, 2009 1 commit
  6. 17 Sep, 2009 1 commit
  7. 15 Sep, 2009 1 commit
  8. 03 Sep, 2009 2 commits
    • Michael Widenius's avatar
      Updated documentation files to reflect MariaDB and not the Maria storage engine or MySQL · 24ed0ad3
      Michael Widenius authored
      Added (rewritten) patch from Percona to get extended statistics in slow.log:
      - Added handling of 'set' variables to set_var.cc. Changed sql_mode to use this
      - Added extra logging to slow log of 'Thread_id, Schema, Query Cache hit, Rows sent and Rows examined'
      - Added optional logging to slow log, through log_slow_verbosity, of query plan statistics
      - Added new user variables log_slow_rate_limit, log_slow_verbosity, log_slow_filter
      - Added log-slow-file as synonym for 'slow-log-file', as most slow-log variables starts with 'log-slow'
      - Added log-slow-time as synonym for long-query-time
      Some trivial MyISAM optimizations:
      - In prepare for drop, flush key blocks
      - Don't call mi_lock_database if my_disable_locking is used
      
      KNOWN_BUGS.txt:
        Updated file to reflect MariaDB and not the Maria storage engine
      README:
        Updated file to reflect MariaDB
      mysql-test/r/log_slow.result:
        Test new options for slow query log
      mysql-test/r/variables.result:
        Updated result (old version cut of things at 79 characters)
      mysql-test/t/log_slow.test:
        Test new options for slow query log
      sql/Makefile.am:
        Added log_slow.h
      sql/event_data_objects.cc:
        Removed not needed test for enable_slow_log (is done when the flag is tested elsewhere)
      sql/events.cc:
        Use the general make_set() function instead of 'symbolic_mode_representation'
      sql/filesort.cc:
        Added status for used query plans
      sql/log.cc:
        Reset counters if no query_length (from Percona's patch; Not sure if needed, but can do no harm)
        Added extra logging to slow log of 'Thread_id, Schema, Query Cache hit, Rows sent and Rows examined'
        Added optional logging to slow log, through log_slow_verbosity, of query plan statistics
        Fixed wrong test of error condition
      sql/log_slow.h:
        Defines and variables for log_slow_verbosity and log_slow_filter
      sql/mysql_priv.h:
        Include log_slow.h
      sql/mysqld.cc:
        Added new user variables log_slow_rate_limit, log_slow_verbosity, log_slow_filter
        Added log-slow-file as synonym for 'slow-log-file', as most slow-log variables starts with 'log-slow'
        Added log-slow-time as synonym for long-query-time
        Added note that one should use log-slow-filter instead of log-slow-admin-statements
        Updated comment from 'slow_query_log_file'
      sql/set_var.cc:
        Added long_slow_time as synonym for long_query_time
        Added new user variables log_slow_rate_limit, log_slow_verbosity, log_slow_filter
        dded handling of 'set' variables to set_var.cc. Changed sql_mode to use this
      sql/set_var.h:
        - Added handling of 'set' variables. Changed sql_mode to use this
      sql/slave.cc:
        Use global filter also for slaves
      sql/sp_head.cc:
        Simplify saving of general_slow_log state
        Use the general make_set() function instead of 'symbolic_mode_representation'
      sql/sql_cache.cc:
        Added status for used query plans
      sql/sql_class.cc:
        Remember/restore query_plan_flags over complex statements
      sql/sql_class.h:
        Added variables to handle extended slow log statistics
      sql/sql_parse.cc:
        Added status for used query plans
        Added test for filtering slow_query_log
      sql/sql_select.cc:
        Added status for used query plans
      sql/sql_show.cc:
        Use the general make_set() function instead of 'symbolic_mode_representation'
      sql/strfunc.cc:
        Report first error (not last) if something is wrong in a set
        Removed compiler warning
      storage/myisam/mi_extra.c:
        In prepare for drop, flush key blocks (speed optimization)
      storage/myisam/mi_locking.c:
        Don't call mi_lock_database if my_disable_locking is used (speed optimization)
      24ed0ad3
    • unknown's avatar
      Fix most Compiler warnings seen in buildbot. · 78ad51d7
      unknown authored
      Add suppressions for a few warnings that cannot be meaningfully fixed by
      MariaDB developers.
      
      Changes for XtraDB, PBXT, and YaSSL also submitted upstream.
      
      Also add a `ccfilter` wrapper that can be used to filter out suppressed warnings in a
      local build (to check that new warnings are not introduced).
      
      
      client/mysqlbinlog.cc:
        Fix compiler warnings.
      config/ac-macros/misc.m4:
        Fix wrong naming, autoconfig requires _cv_ in cached names.
      extra/yassl/include/yassl_int.hpp:
        Fix compiler warnings.
      extra/yassl/src/handshake.cpp:
        Fix compiler warnings.
      extra/yassl/src/yassl_imp.cpp:
        Fix compiler warnings.
      extra/yassl/src/yassl_int.cpp:
        Fix compiler warnings.
      extra/yassl/taocrypt/include/modes.hpp:
        Fix compiler warnings.
      extra/yassl/taocrypt/src/asn.cpp:
        Fix compiler warnings.
      mysys/my_compress.c:
        Fix compiler warnings.
      sql/mysqld.cc:
        Fix compiler warnings.
      sql/strfunc.cc:
        Fix compiler warnings.
      storage/pbxt/src/discover_xt.cc:
        Fix compiler warnings.
      storage/xtradb/fil/fil0fil.c:
        Fix compiler warnings.
      storage/xtradb/mtr/mtr0mtr.c:
        Fix compiler warnings.
      storage/xtradb/srv/srv0srv.c:
        Fix compiler warnings.
      storage/xtradb/srv/srv0start.c:
        Fix compiler warnings.
      strings/decimal.c:
        Fix compiler warnings.
      support-files/ccfilter:
        Add helper for suppressing compiler warnings in local developer source tree.
            
        Allows to check for not introducing new warnings into Buildbot without having to actually
        run the build through Buildbot.
      support-files/compiler_warnings.supp:
        Suppress a few warnings that cannot be meaningfully fixed in source code.
      78ad51d7
  9. 25 Aug, 2009 1 commit
    • Sergey Petrunya's avatar
      MWL#17: Table elimination · 5dcd894b
      Sergey Petrunya authored
      - Add more testcases.
      - Fix trivial compile failure
      - Remove handling of "column IN (one_element)". This is converted to equality 
        elsewhere
      
      mysql-test/r/table_elim.result:
        MWL#17: Table elimination
        - Add more testcases.
        - Fix trivial compile failure
      mysql-test/t/table_elim.test:
        MWL#17: Table elimination
        - Add more testcases
      sql/mysqld.cc:
        MWL#17: Table elimination
        - Fix trivial compile failure
      sql/opt_table_elimination.cc:
        MWL#17: Table elimination
        - Add more testcases.
        - Remove handling of "column IN (one_element)".This is converted to equality 
          elsewhere
      5dcd894b
  10. 24 Aug, 2009 1 commit
    • Sergey Petrunya's avatar
      MWL#17: Table elimination: last fixes · 0913cda0
      Sergey Petrunya authored
      - Add an @@optimizer_switch flag for table_elimination for debug build
      - Better comments 
      
      mysql-test/t/index_merge_myisam.test:
        MWL#17: Table elimination: last fixes
        - Add an @@optimizer_switch flag for table_elimination for debug build
      sql/mysql_priv.h:
        MWL#17: Table elimination: last fixes
        - Add an @@optimizer_switch flag for table_elimination for debug build
      sql/mysqld.cc:
        MWL#17: Table elimination: last fixes
        - Add an @@optimizer_switch flag for table_elimination for debug build
      0913cda0
  11. 06 Aug, 2009 1 commit
  12. 31 Jul, 2009 1 commit
  13. 30 Jul, 2009 1 commit
    • Davi Arnaut's avatar
      Bug#43435: LOCK_open does not use MY_MUTEX_INIT_FAST · b8122e8c
      Davi Arnaut authored
      Initialize LOCK_open as a adapative mutex on platforms where the
      PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP macro is available. The flag
      indicates that a thread should spin (busy wait) for some time on a
      locked adaptive mutex before blocking (sleeping). It's intended to
      to alleviate performance problems due to LOCK_open being a highly
      contended mutex.
      
      sql/mysqld.cc:
        Initialize LOCK_open as a adapative mutex.
      b8122e8c
  14. 27 Jul, 2009 1 commit
    • Davi Arnaut's avatar
      Bug#46385: [Warning] option 'max_join_size': unsigned value 18446744073709551615 adjusted t · f9551a9c
      Davi Arnaut authored
      The maximum value of the max_join_size variable is set by converting
      a signed type (long int) with negative value (-1) to a wider unsigned
      type (unsigned long long), which yields the largest possible value of
      the wider unsigned type -- as per the language conversion rules. But,
      depending on build options, the type of the max_join_size might be a
      shorter type (ha_rows - unsigned long) which causes the warning to be
      thrown once the large value is truncated to fit.
      
      The solution is to ensure that the maximum value of the variable is
      always set to the maximum value of integer type of max_join_size.
      
      Furthermore, it would be interesting to always have a fixed type for
      this variable, but this would incur in a change of behavior which is
      not acceptable for a GA version. See Bug#35346.
      
      sql/mysqld.cc:
        Set max value for type.
      f9551a9c
  15. 24 Jul, 2009 1 commit
  16. 23 Jul, 2009 1 commit
    • Staale Smedseng's avatar
      Bug #45770 errors reading server SSL files are printed, but · 94db736d
      Staale Smedseng authored
      not logged
              
      Errors encountered during initialization of the SSL subsystem
      are printed to stderr, rather than to the error log.
              
      This patch adds a parameter to several SSL init functions to
      report the error (if any) out to the caller. The function
      init_ssl() in mysqld.cc is moved after the initialization of
      the log subsystem, so that any error messages can be logged to
      the error log. Printing of messages to stderr has been 
      retained to get diagnostic output in a client context.
      
      
      include/violite.h:
        Adding an enumeration for the various errors that can
        occur during initialization of the SSL module.
      sql/mysqld.cc:
        Adding more logging of SSL init errors, and moving
        init_ssl() till after initialization of logging 
        subsystem.
      vio/viosslfactories.c:
        Define error strings, provide an access method for these
        strings, and maintain an error parameter in several funcs
        to return the error (if any) to the caller.
      94db736d
  17. 16 Jul, 2009 1 commit
  18. 23 Jun, 2009 1 commit
    • Andrei Elkin's avatar
      Bug #38240 Crash in safe_mutex_lock () thr_mutex.c line 97 on rotate_relay_log · c9538baf
      Andrei Elkin authored
                  
      The reason for the crash was rotate_relay_log (mi=0x0) did not verify
      the passed value of active_mi.  There are more cases where active_mi
      is supposed to be non-zero e.g change_master(), stop_slave(), and it's
      reasonable to protect from a similar crash all of them with common
      fixes.
                  
      Fixed with spliting end_slave() in slave threads release and slave
      data clean-up parts (a new close_active_mi()). The new function is
      invoked at the very end of close_connections() so that all users of
      active_mi are proven to have left.
      
      sql/mysqld.cc:
        added the 2nd part (data) of the slave's clean up.
      sql/slave.cc:
        end_slave() is split in two part to release the slave threads and the remained
        resources separately.
        The new close_active_mi() should be called after all possible users ofactive_mi
        has left, i.e at the very end of close_connections().
      sql/slave.h:
        interface to the new end_active_mi() function is added.
      c9538baf
  19. 19 Jun, 2009 1 commit
    • Sergey Glukhov's avatar
      Bug#44834 strxnmov is expected to behave as you'd expect · 524191be
      Sergey Glukhov authored
      The problem: described in the bug report.
      The fix:
      --increase buffers where it's necessary
        (buffers which are used in stxnmov)
      --decrease buffer lengths which are used
      
      
      client/mysql.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/ha_ndbcluster.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/ha_ndbcluster_binlog.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/handler.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/log.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/mysqld.cc:
        removed unnecessary line
      sql/parse_file.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_acl.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_base.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_db.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_delete.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_partition.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_rename.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_show.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_table.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      sql/sql_view.cc:
        --increase buffers where it's necessary
          (buffers which are used in stxnmov)
        --decrease buffer lengths which are used
          as argument for strxnmov function
      524191be
  20. 10 Jun, 2009 1 commit
    • Vladislav Vaintroub's avatar
      Backport WL#3653 to 5.1 to enable bundled innodb plugin. · dd86e2cd
      Vladislav Vaintroub authored
      Remove custom DLL loader code from innodb plugin code, use 
      symbols exported from mysqld.
      
      
      storage/innodb_plugin/handler/ha_innodb.cc:
        Remove a Win32 workaround for current_thd.
        The original  problem that innodb plugin used
        value of TLS variable across DLL boundaries is 
        solved in MySQL server (current_thd is a function
        not TLS variable now)
      storage/innodb_plugin/handler/handler0alter.cc:
        Remove custom delay loader
      storage/innodb_plugin/handler/handler0vars.h:
        Remove custom delay loader
      storage/innodb_plugin/handler/i_s.cc:
        Remove custom delay loader
      storage/innodb_plugin/handler/win_delay_loader.cc:
        Remove custom delay loader
      storage/innodb_plugin/plug.in:
        Remove commented out MYSQL_PLUGIN_STATIC, 
        CMake would not parse that correctly
      dd86e2cd
  21. 08 Jun, 2009 1 commit
    • Davi Arnaut's avatar
      Fix for a valgrind warning due to use of a uninitialized · de425ebd
      Davi Arnaut authored
      variable. The problem was that THD::connect_utime could be
      used without being initialized when the main thread is used
      to handle connections (--thread-handling=no-threads).
      
      sql/mysqld.cc:
        Set THD::start_utime even in no-threads handling mode.
      sql/sql_class.cc:
        Initialize variable.
      sql/sql_class.h:
        Rename connect_utime to prior_thr_create_utime as to
        better reflect it's use intention.
      sql/sql_connect.cc:
        Check only if a thread was actually created.
      de425ebd
  22. 02 Jun, 2009 1 commit
  23. 15 May, 2009 1 commit
    • Satya B's avatar
      Fix for BUG#10206 - InnoDB: Transaction requiring Max_BinLog_Cache_size > 4GB · 143d70a9
      Satya B authored
                          always rollsback.
      
      The global variable max_binlog_cache_size cannot be set more than 4GB on
      32 bit systems, limiting transactions of all storage engines to 4G of changes.
      
      The problem is max_binlog_cache_size is declared as ulong which is 4 bytes
      on 32 bit and 8 bytes on 64 bit machines.
      
      Fixed by using ulonglong for max_binlog_cache_size which is 8bytes on 32 
      and 64 bit machines.The range for max_binlog_cache_size on 32 bit and 64 bit
      systems is 4096-18446744073709547520 bytes.
      
      mysql-test/r/variables.result:
        Result file for BUG#10206
      mysql-test/t/variables.test:
        Testcase for BUG#10206
      sql/mysql_priv.h:
        change the extern declaration of max_binlog_cache_size to ulonglong
      sql/mysqld.cc:
        change the declaration of max_binlog_cache_size to ulonglong and the option is fixed to extend the range of max_binlog_cache_size
      sql/set_var.cc:
        change the variable declaration of max_binlog_cache_size to ulonglong
      143d70a9
  24. 06 May, 2009 1 commit
    • unknown's avatar
      We are now using Valgrind rather than purify, and have for quite some time. · 8eee7808
      unknown authored
      Consequently, rename HAVE_purify to HAVE_valgrind, and related changes.
      Leave some comments about purify when not clear that they apply also to Valgrind.
      Fix redundant IF_VALGRIND declaration.
      
      Misc. small fixes:
       - Fixes for pool-of-threads patch.
       - Fixes for push of PBXT storage engine.
       - mysql-test-run.pl fix.
       - Fix build problem in compile-pentium64-max.
      
      
      BUILD/SETUP.sh:
        Rename purify -> valgrind.
      BUILD/build_mccge.sh:
        Rename purify -> valgrind.
      BUILD/compile-dist:
        Fix that PBXT was missing in source tarball after `BUILD/compile-dist && make dist`
      BUILD/compile-pentium64-max:
        Fix a build problem with BUILD/compile-pentium64-max on CentOS/Fedora Core 10 amd64.
              
        On these systems, there is libz.so but no libz.a. Finding libz.so, ./configure decides
        to use system zlib. But since BUILD/compile-pentium64-max builds a fully static binary
        with -all-static, the link of mysqld fails due to missing libz.a.
              
        Fix by using bundled zlib in the build script.
      BUILD/compile-solaris-sparc-purify:
        Rename purify -> valgrind.
      include/m_string.h:
        Rename purify -> valgrind.
      include/my_global.h:
        Rename purify -> valgrind.
      mysql-test/Makefile.am:
        Fix that PBXT test suite was missing from `make dist` source tarball.
      mysql-test/lib/mtr_unique.pm:
        Better fix to avoid races when chmod'ing the semaphore file.
        (Though using chmod 666 shared files in /tmp/ is still not a very good solution).
      mysql-test/t/pool_of_threads.cnf:
        Fix that test case pool_of_threads fails if run on mysqld with no --with-libevent support.
      mysys/mf_qsort.c:
        Rename purify -> valgrind.
      mysys/my_alloc.c:
        Rename purify -> valgrind.
      mysys/my_init.c:
        Rename purify -> valgrind.
      mysys/my_rnd.c:
        Rename purify -> valgrind.
      mysys/safemalloc.c:
        Rename purify -> valgrind.
      scripts/mysql_config.pl.in:
        Rename purify -> valgrind.
      scripts/mysql_config.sh:
        Rename purify -> valgrind.
      sql/field_conv.cc:
        Rename purify -> valgrind.
      sql/filesort.cc:
        Rename purify -> valgrind.
      sql/ha_partition.cc:
        Rename purify -> valgrind.
      sql/hostname.cc:
        Rename purify -> valgrind.
      sql/item_timefunc.cc:
        Rename purify -> valgrind.
      sql/log_event.cc:
        Rename purify -> valgrind.
      sql/log_event_old.cc:
        Rename purify -> valgrind.
      sql/my_decimal.h:
        Rename purify -> valgrind.
      sql/mysqld.cc:
        Rename purify -> valgrind.
        Fix redundant IF_VALGRIND declaration.
      sql/opt_range.cc:
        Rename purify -> valgrind.
      sql/opt_range.h:
        Rename purify -> valgrind.
      sql/records.cc:
        Rename purify -> valgrind.
      sql/rpl_rli.cc:
        Rename purify -> valgrind.
      sql/rpl_rli.h:
        Rename purify -> valgrind.
      sql/set_var.cc:
        Fix missing static declaration on pool_of_threads.
      sql/slave.cc:
        Rename purify -> valgrind.
      sql/sql_base.cc:
        Rename purify -> valgrind.
      sql/sql_binlog.cc:
        Rename purify -> valgrind.
      sql/sql_class.cc:
        Rename purify -> valgrind.
      sql/sql_list.h:
        Rename purify -> valgrind.
      sql/sql_load.cc:
        Rename purify -> valgrind.
      sql/sql_select.cc:
        Rename purify -> valgrind.
      sql/table.cc:
        Rename purify -> valgrind.
      storage/archive/azio.c:
        Rename purify -> valgrind.
      storage/innobase/buf/buf0buf.c:
        Rename purify -> valgrind.
      storage/innobase/include/univ.i:
        Rename purify -> valgrind.
      storage/innobase/srv/srv0start.c:
        Rename purify -> valgrind.
      storage/maria/ha_maria.cc:
        Rename purify -> valgrind.
      storage/maria/ma_blockrec.c:
        Rename purify -> valgrind.
      storage/maria/ma_check.c:
        Rename purify -> valgrind.
      storage/maria/ma_loghandler.c:
        Rename purify -> valgrind.
      storage/maria/ma_packrec.c:
        Rename purify -> valgrind.
      storage/maria/ma_page.c:
        Rename purify -> valgrind.
      storage/maria/ma_pagecrc.c:
        Rename purify -> valgrind.
      storage/maria/ma_search.c:
        Rename purify -> valgrind.
      storage/myisam/mi_check.c:
        Rename purify -> valgrind.
      storage/myisam/mi_page.c:
        Rename purify -> valgrind.
      storage/myisam/mi_search.c:
        Rename purify -> valgrind.
      storage/myisammrg/ha_myisammrg.cc:
        Rename purify -> valgrind.
      strings/bcmp.c:
        Rename purify -> valgrind.
      strings/decimal.c:
        Rename purify -> valgrind.
      strings/strmake.c:
        Rename purify -> valgrind.
      8eee7808
  25. 05 May, 2009 1 commit
  26. 24 Apr, 2009 1 commit
  27. 08 Apr, 2009 2 commits
    • Michael Widenius's avatar
      Fixed wrong test for extra_ip_sock that caused mysqld to die on Mac if --extra-port was used · a98ccec6
      Michael Widenius authored
      sql/sql_string.cc:
        Optimized tests to do fewer reallocs
      sql/strfunc.cc:
        Indentation fix
      a98ccec6
    • unknown's avatar
      Fix Valgrind errors seen in buildbot. · 406ccdff
      unknown authored
      Fix mysql-test-run.pl to not terminate early when warnings in error logs are detected during
      server shutdown. Instead, give a nice summary report at the end of the failures.
      
      Fix code to make 100% sure no failures will go undetected.
      
      Revert earlier wrong change.
      
      Fix race with port allocation semaphore file permissions.
      
      Adjust testsuite to copy with new PBXT engine now in the tree. The PBXT engine causes an
      extra table to appear in the INFORMATION_SCHEMA. This causes different output for a few
      test cases.
      
      dbug/dbug.c:
        If DbugParse() is called multiple times, the stack->keywords for the
        top stack frame could be overwritten without being freed, causing a
        memory leak reported by Valgrind.
      include/my_global.h:
        Add useful macro for different values when Valgrind (HAVE_purify) and not.
      mysql-test/extra/rpl_tests/rpl_auto_increment.test:
        Omit pbxt variables from show variables output.
      mysql-test/include/have_pbxt.inc:
        Add facility to disable test if PBXT engine is not available.
      mysql-test/lib/mtr_report.pm:
        Give a nice summary report at the end of tests of any warnings seen in logs during
        server shutdowns.
      mysql-test/lib/mtr_unique.pm:
        Move chmod 777 to greatly reduce the risk of leaving the port semaphore file unaccessible
        bu other users.
      mysql-test/mysql-test-run.pl:
        Don't abort in case of warnings detected, instead give a nice summary report.
        
        Fix code to make 100% sure no failures will go undetected.
        
        Revert earlier wrong change when master disconnects early.
      mysql-test/r/information_schema.result:
        Omit PBXT INFORMATION_SCHEMA table from output.
        Move part of test to information_schema_all_engines.
      mysql-test/r/information_schema_all_engines.result:
        New file for information_schema tests that depend on which engines are available.
      mysql-test/r/information_schema_db.result:
        Move part of test to information_schema_all_engines.
      mysql-test/r/innodb-autoinc.result:
        Omit pbxt variables from show variables output.
      mysql-test/r/mysqlshow.result:
        Move part of test to information_schema_all_engines.
      mysql-test/suite/rpl/r/rpl_auto_increment.result:
        Omit pbxt variables from show variables output.
      mysql-test/t/information_schema.test:
        Omit PBXT INFORMATION_SCHEMA table from output.
        Move part of test to information_schema_all_engines.
      mysql-test/t/information_schema_all_engines.test:
        New file for information_schema tests that depend on which engines are available.
      mysql-test/t/information_schema_db.test:
        Move part of test to information_schema_all_engines.
      mysql-test/t/innodb-autoinc.test:
        Omit pbxt variables from show variables output.
      mysql-test/t/mysqlshow.test:
        Move part of test to information_schema_all_engines.
      mysql-test/valgrind.supp:
        Add variant suppression (different system library versions).
        Add suppression for problem with inet_ntoa().
      sql/mysqld.cc:
        Fix missing DBUG_RETURN.
        Fix uninitialised thd->connect_utime, likely introduced by pool_of_threads.
      sql/set_var.cc:
        Fix one-byte buffer overflow in several places.
        Fix unsafe use of String::c_ptr() of stack-allocated String buffer.
      sql/sql_select.cc:
        Silence valgrind warning due to GCC bug.
      sql/sql_string.h:
        Document potential problem with String::c_ptr() and String() constructor with caller-supplied buffer.
      storage/archive/azio.c:
        Silence Valgrind false warning for libz.
      406ccdff
  28. 18 Mar, 2009 1 commit
  29. 14 Mar, 2009 1 commit
  30. 13 Mar, 2009 3 commits
    • unknown's avatar
      Fix build error in some configs. · 8a32a1b0
      unknown authored
      Remove non-source file from bzr.
      8a32a1b0
    • Sergey Glukhov's avatar
      compilation(embedded server) failure fix · c6bf2e33
      Sergey Glukhov authored
      c6bf2e33
    • Sergey Glukhov's avatar
      Bug#42610 Dynamic plugin broken in 5.1.31 · c6591be5
      Sergey Glukhov authored
      --added ability to obtain plugin variables from my.cnf on INSTALL PLUGIN stage
      --option 'ignore-builtin-innodb' disables all InnoDB builtin plugins
        (including I_S plugins)
      
      
      sql/mysql_priv.h:
        --added ability to obtain plugin variables from my.cnf on INSTALL PLUGIN stage
      sql/mysqld.cc:
        --added ability to obtain plugin variables from my.cnf on INSTALL PLUGIN stage
      sql/sql_plugin.cc:
        --added ability to obtain plugin variables from my.cnf on INSTALL PLUGIN stage
        --option 'ignore-builtin-innodb' disables all InnoDB builtin plugins
          (including I_S plugins)
      c6591be5
  31. 12 Mar, 2009 1 commit
    • Michael Widenius's avatar
      Added "pool-of-threads" handling (with libevent) · 67a0eb64
      Michael Widenius authored
      This is a backport of code from MySQL 6.0 with cleanups and extensions
      
      The following new options are supported
      configure options:
        --with-libevent                  ; Enable use of libevent, which is needed for pool of threads
      
      mysqld options:
      --thread-handling=pool-of-threads  ; Use a pool of threads to handle queries
      --thread-pool-size=#               ; Define how many threads should be created to handle all queries
      --extra-port=#                     ; Extra tcp port that uses the old one-thread-per-connection method
      --extra-max-connections=#          ; Number of connections to accept to 'extra-port'
      --test-ignore-wrong-options        ; Ignore setting an enum value to a wrong option (for mysql-test-run)
      
      
      
      BUILD/SETUP.sh:
        Added libevents (and thus pool-of-threads) to max builds
      CMakeLists.txt:
        Added libevent
      Makefile.am:
        Added libevents
      config/ac-macros/libevent.m4:
        Libevent code for configure
      config/ac-macros/libevent_configure.m4:
        Libevent code for configure
      configure.in:
        Added libevents
      dbug/dbug.c:
        Added _db_is_pushed(); Needed for pool-of-threads code
      extra/Makefile.am:
        Added libevents
      extra/libevent:
        Libevent initial code
      extra/libevent/CMakeLists.txt:
        Libevent initial code
      extra/libevent/Makefile.am:
        Libevent initial code
      extra/libevent/README:
        Libevent initial code
      extra/libevent/WIN32-Code:
        Libevent initial code
      extra/libevent/WIN32-Code/config.h:
        Libevent initial code
      extra/libevent/WIN32-Code/misc.c:
        Libevent initial code
      extra/libevent/WIN32-Code/misc.h:
        Libevent initial code
      extra/libevent/WIN32-Code/tree.h:
        Libevent initial code
      extra/libevent/WIN32-Code/win32.c:
        Libevent initial code
      extra/libevent/buffer.c:
        Libevent initial code
      extra/libevent/compat:
        Libevent initial code
      extra/libevent/compat/sys:
        Libevent initial code
      extra/libevent/compat/sys/_time.h:
        Libevent initial code
      extra/libevent/compat/sys/queue.h:
        Libevent initial code
      extra/libevent/compat/sys/tree.h:
        Libevent initial code
      extra/libevent/devpoll.c:
        Libevent initial code
      extra/libevent/epoll.c:
        Libevent initial code
      extra/libevent/epoll_sub.c:
        Libevent initial code
      extra/libevent/evbuffer.c:
        Libevent initial code
      extra/libevent/evdns.c:
        Libevent initial code
      extra/libevent/evdns.h:
        Libevent initial code
      extra/libevent/event-config.h:
        Libevent initial code
      extra/libevent/event-internal.h:
        Libevent initial code
      extra/libevent/event.c:
        Libevent initial code
      extra/libevent/event.h:
        Libevent initial code
      extra/libevent/event_tagging.c:
        Libevent initial code
      extra/libevent/evhttp.h:
        Libevent initial code
      extra/libevent/evport.c:
        Libevent initial code
      extra/libevent/evrpc-internal.h:
        Libevent initial code
      extra/libevent/evrpc.c:
        Libevent initial code
      extra/libevent/evrpc.h:
        Libevent initial code
      extra/libevent/evsignal.h:
        Libevent initial code
      extra/libevent/evutil.c:
        Libevent initial code
      extra/libevent/evutil.h:
        Libevent initial code
      extra/libevent/http-internal.h:
        Libevent initial code
      extra/libevent/http.c:
        Libevent initial code
      extra/libevent/kqueue.c:
        Libevent initial code
      extra/libevent/log.c:
        Libevent initial code
      extra/libevent/log.h:
        Libevent initial code
      extra/libevent/min_heap.h:
        Libevent initial code
      extra/libevent/poll.c:
        Libevent initial code
      extra/libevent/select.c:
        Libevent initial code
      extra/libevent/signal.c:
        Libevent initial code
      extra/libevent/strlcpy-internal.h:
        Libevent initial code
      extra/libevent/strlcpy.c:
        Libevent initial code
      include/config-win.h:
        Libevent support
      include/my_dbug.h:
        ADded _db_is_pushed
      include/mysql.h.pp:
        Update to handle new prototypes
      include/typelib.h:
        Split find_type_or_exit() into two functions
      include/violite.h:
        Added vio_is_pending()
      libmysqld/Makefile.am:
        Added libevent
      mysql-test/include/have_pool_of_threads.inc:
        Added test for pool-of-threads
      mysql-test/mysql-test-run.pl:
        Don't abort based on time and don't retry test cases when run under --gdb or --debug
      mysql-test/r/crash_commit_before.result:
        USE GLOBAL for debug variable
      mysql-test/r/have_pool_of_threads.require:
        Added test for pool-of-threads
      mysql-test/r/pool_of_threads.result:
        Added test for pool-of-threads
      mysql-test/r/subselect_debug.result:
        USE GLOBAL for debug variable
      mysql-test/t/crash_commit_before.test:
        USE GLOBAL for debug variable
      mysql-test/t/merge-big.test:
        USE GLOBAL for debug variable
      mysql-test/t/pool_of_threads-master.opt:
        Added test for pool-of-threads
      mysql-test/t/pool_of_threads.test:
        Added test for pool-of-threads
      mysys/typelib.c:
        Split find_type_or_exit() into find_type_with_warning()
      sql/Makefile.am:
        Added libevent
      sql/handler.cc:
        Indentation fix.
        Fixed memory loss bug
        Fixed crash on exit when handler plugin failed
      sql/mysql_priv.h:
        Added extra_max_connections and mysqld_extra_port
        Added extern functions from sql_connect.cc
      sql/mysqld.cc:
        Added support for new mysqld options
        Added code for 'extra-port' and 'extra-max-connections'
        Split some functions into smaller pieces to be able to reuse code
        Added code for test-ignore-wrong-options
      sql/scheduler.cc:
        Updated schduler code from MySQL 6.0
      sql/scheduler.h:
        Updated schduler code from MySQL 6.0
      sql/set_var.cc:
        Added support for changing "extra_max_connections"
      sql/sql_class.cc:
        Iniitalize thread schduler options in THD
      sql/sql_class.h:
        Added to extra_port and scheduler to 'THD'
      sql/sql_connect.cc:
        Use thd->schduler to check number of connections and terminate connection
        Made some local functions global (for scheduler.cc)
      vio/viosocket.c:
        Added 'vio_pending', needed for scheduler..c
      67a0eb64
  32. 11 Mar, 2009 2 commits
    • Davi Arnaut's avatar
      Bug#36540: CREATE EVENT and ALTER EVENT statements fail with large server_id · 4b4dd989
      Davi Arnaut authored
      The problem is that creating a event could fail if the value of
      the variable server_id didn't fit in the originator column of
      the event system table. The cause is two-fold: it was possible
      to set server_id to a value outside the documented range (from
      0 to 2^32-1) and the originator column of the event table didn't
      have enough room for values in this range.
      
      The log tables (general_log and slow_log) also don't have a proper
      column type to store the server_id and having a large server_id
      value could prevent queries from being logged.
      
      The solution is to ensure that all system tables that store the
      server_id value have a proper column type (int unsigned) and that
      the variable can't be set to a value that is not within the range.
      
      mysql-test/r/events_bugs.result:
        Add test case result for Bug#36540
      mysql-test/r/log_tables.result:
        Update column type.
      mysql-test/r/system_mysql_db.result:
        Update column type.
      mysql-test/r/variables.result:
        Add test case result for server_id value range.
      mysql-test/suite/sys_vars/r/server_id_basic_64.result:
        Update test case results.
      mysql-test/t/events_bugs.test:
        Add test case for Bug#36540
      mysql-test/t/log_tables.test:
        Fix column type.
      mysql-test/t/variables.test:
        Add test case for server_id value range.
      scripts/mysql_system_tables.sql:
        Columns that store the server_id value must be of type INT UNSIGNED,
        fix event (originator), general_log and slow_log (server_id) tables
        in accordance.
      scripts/mysql_system_tables_fix.sql:
        Columns that store the server_id value must be of type INT UNSIGNED,
        fix event (originator), general_log and slow_log (server_id) tables
        in accordance.
      sql/mysqld.cc:
        Set min and max values for the server_id variable.
        Unfortunately we can't easily change server_id variable type
        from ulong to uint32 because of the sys_var classes.
      4b4dd989
    • Sergey Petrunia's avatar
      Change optimizer_switch from no_xxx to xxx=on/xx=off. · d61f3264
      Sergey Petrunia authored
      mysql-test/r/index_merge_myisam.result:
        Testcases
      mysql-test/t/index_merge_myisam.test:
        Testcases
      sql/strfunc.cc:
        Change optimizer_switch from no_xxx to xxx=on/xx=off.
        - Add functions to parse the new syntax
      d61f3264
  33. 10 Mar, 2009 1 commit
  34. 05 Mar, 2009 1 commit
    • Narayanan V's avatar
      Bug#42790 Test 'main.innodb' fails from "InnoDB: Error: in ALTER TABLE" · 91c7c703
      Narayanan V authored
            
      The problem here seem to be that when mysql
      is redirecting stderr to a file, stderr becomes 
      buffered, whereas it is unbuffered by definition.
      
      The solution is to unbuffer it by setting buffer
      to null.
      
      sql/log.cc:
        use setbuf(stderr, NULL) to set the buffer to null.
      sql/mysqld.cc:
        use setbuf(stderr, NULL) to set the buffer to null.
      91c7c703
  35. 25 Feb, 2009 1 commit
    • Alexey Kopytov's avatar
      Fixed a build failure on Ubuntu 8.10 introduced by the patch · 4a5393e4
      Alexey Kopytov authored
      for bug #15936.
      
      On some platforms fenv.h may #undef the min/max macros
      defined in my_global.h.
      
      Fixed by moving the #include directive for fenv.h from
      mysqld.cc to my_global.h before definitions for min/max.
      
      include/my_global.h:
        Moved #include <fenv.h> from mysqld.cc.
      sql/mysqld.cc:
        Moved #include <fenv.h> to my_global.h.
      4a5393e4