- 10 Nov, 2009 5 commits
-
-
Davi Arnaut authored
------------------------------------------------------------ revno: 2630.39.3 revision-id: davi.arnaut@sun.com-20081210215359-i876m4zgc2d6rzs3 parent: kostja@sun.com-20081208222938-9es7wl61moli71ht committer: Davi Arnaut <Davi.Arnaut@Sun.COM> branch nick: 36649-6.0 timestamp: Wed 2008-12-10 19:53:59 -0200 message: Bug#36649: Condition area is not properly cleaned up after stored routine invocation The problem is that the diagnostics area of a trigger is not isolated from the area of the statement that caused the trigger invocation. In MySQL terms, it means that warnings generated during the execution of the trigger are not removed from the "warning area" at the end of the execution. Before this fix, the rules for MySQL message list life cycle (see manual entry for SHOW WARNINGS) did not apply to statements inside stored programs: - The manual says that the list of messages is cleared by a statement that uses a table (any table). However, such statement, if run inside a stored program did not clear the message list. - The manual says that the list is cleared by a statement that generates a new error or a warning, but this was not the case with stored program statements either and is changed to be the case as well. In other words, after this fix, a statement has the same effect on the message list regardless of whether it's executed inside a stored program/sub-statement or not. This introduces an incompatible change: - before this fix, a, e.g. statement inside a trigger could never clear the global warning list - after this fix, a trigger that generates a warning or uses a table, clears the global warning list - however, when we leave a trigger or a function, the caller's warning information is restored (see more on this below). This change is not backward compatible as it is intended to make MySQL behavior similar to the SQL standard behavior: A stored function or trigger will get its own "warning area" (or, in standard terminology, diagnostics area). At the beginning of the stored function or trigger, all messages from the caller area will be copied to the area of the trigger. During execution, the message list will be cleared according to the MySQL rules described on the manual (SHOW WARNINGS entry). At the end of the function/trigger, the "warning area" will be destroyed along with all warnings it contains, except that if the last statement of the function/trigger generated messages, these are copied into the "warning area" of the caller. Consequently, statements that use a table or generate a warning *will* clear warnings inside the trigger, but that will have no effect to the warning list of the calling (outer) statement.
-
Kristofer Pettersson authored
-
Kristofer Pettersson authored
Correction of backport patch: * Fixed signature of check_access_table() for embedded build * Fixed typo for last argument in a check_access() call from UINT_MAX to 0.
-
Davi Arnaut authored
------------------------------------------------------------ revno: 3624 revision-id: jon.hauglid@sun.com-20090928163426-2lg1gofzz44xzzxf parent: alik@sun.com-20090928050057-r0a62x9czr01q7oe committer: Jon Olav Hauglid <jon.hauglid@sun.com> branch nick: mysql-6.0-codebase-bugfixing-bug47304 timestamp: Mon 2009-09-28 18:34:26 +0200 message: Bug #47304 Test main.mdl_sync fails on embedded server The problem was that SHOW PROCESSLIST was trying to access a thread that was not properly running and therefore had an uninitialized mutex. This patch explicitly resets thd->mysys_var after each embedded server command to prevent the mutex from being accessed in an illegal state. The patch also re-enables lock_multi.test and mdl_sync.test for embedded server as they had been disabled because of this bug.
-
Davi Arnaut authored
------------------------------------------------------------ revno: 2617.31.21 revision-id: davi.arnaut@sun.com-20090402193933-2zbhg15kd0z3xh8r parent: alik@sun.com-20090402081500-78l1hpkx03twe4bf committer: Davi Arnaut <Davi.Arnaut@Sun.COM> branch nick: 41971-6.0 timestamp: Thu 2009-04-02 16:39:33 -0300 message: Bug#41971: Thread state on embedded server is always "Writing to net" The problem is that the state of a thread on a embedded server is always displayed as "Writing to net", which is wrong as there is no "network" in the embedded server. The solution is only exclude, on a embedded server, the thread state conditions that are related to network operations. Other thread states related to waiting on conditions or other operations are preserved.
-
- 05 Nov, 2009 1 commit
-
-
Magne Mahre authored
SIGWINCH is not defined in termios.h on HP/UX.
-
- 04 Nov, 2009 6 commits
-
-
Magne Mahre authored
Added this option, named as "--dump-slave". The purpose of this option is to be able to produce a dump from a slave used for making backups of the master. Originally, dumping from the main master was fine, but as more data accumulated, the dump process would take over 30 minutes, locking up the master database hence website for 30 minutes. A slave dedicated to producing backups was the answer, but I needed a dump that could be used to restore a slave instantly and in order to do that, it has to have three things contained in the dump: 1. "STOP SLAVE;" at the beginning 2. "CHANGE MASTER TO ...<the master - info from 'show slave status'>" 3. "START SLAVE;" at the end These options in this changeset contain this. --stop-slave adds "STOP SLAVE" to the beginning of the dump and "STOP SLAVE" to the end of the dump. --include-host gives the user the option to have the host explicitely added to the "CHANGE MASTER TO ..." line. --dump-slave adds the "CHANGE MASTER ..." to the dump representing not the slave's master binlog info, but the slave's master's info from "SHOW SLAVE STATUS"
-
Magne Mahre authored
Feature from Eric Bergen, CLA signed 2007-06-27. Adds new mysql client option "--auto-vertical-output", which causes the client to test whether a result table is too wide for the current window (where available) and emit vertical results in that case. Otherwise, it sends normal tabular results.
-
Jon Olav Hauglid authored
deadlocks Backport of revno: 2617.68.35 The problem was that if one connection is running a multi-statement transaction which involves a single partitioned table, and another connection attempts to alter the table to drop a non-existing partition, (which of course will fail), the first connection still gets ER_LOCK_DEADLOCK and cannot proceed anymore. This bug is no longer reproducable. This has also been tested with the patch for Bug#46654 "False deadlock on concurrent DML/DDL with partitions, inconsistent behavior" which concerned a similar problem but where the ALTER TABLE is semantically correct. Test case added in partition_sync.test.
-
Magne Mahre authored
Another code-path dropped sign of TIME, presuming all time is positive. Minds sign now. Patch depends on ChangeSet for 42661.
-
Magne Mahre authored
-
Magne Mahre authored
Bug#42662: maketime() and signedness Item_time_typecast::val_int() dropped sign from MYSQL_TIME gotten using from get_time(). Propagates sign now. Backported to 5.5.0 (6.0-codebase revid: 1810.3897.1)
-
- 03 Nov, 2009 2 commits
-
-
Magne Mahre authored
When less than six places are given for microseconds, we zerofill from the right (leftmost place is always 1/10s). We only did this when all announced date/time fields were given; now we also format fractional seconds when more significant fields are left out.
-
Magne Mahre authored
The presence of "--skip" parameters is obscure, when it should be obvious from the text. Now, for boolean options, when they're default to ON and the --skip is more useful parameter, then tell the user of its existence. Backported from 6.0-codebase, revid 2572.14.1
-
- 02 Nov, 2009 2 commits
-
-
Alexander Nozdrin authored
```--------------------------------------------------------- revno: 2599.178.12 revision-id: alik@mysql.com-20080812161845-we7cx9f22yrghob1 committer: Alexander Nozdrin <alik@mysql.com> branch nick: 6.0-rt-build timestamp: Tue 2008-08-12 20:18:45 +0400 message: Fix memory leak. ``` ---------------------------------------------------------
-
Alexander Nozdrin authored
-
- 31 Oct, 2009 2 commits
-
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
- 29 Oct, 2009 8 commits
-
-
Marc Alff authored
Backport for 5.5 In non debug builds, the statements: - SHOW PROCEDURE CODE - SHOW FUNCTION CODE used to fail with a "syntax error", which is misleading. These statements have been changed to return the following error for non debug builds: ERROR HY000: The 'SHOW PROCEDURE|FUNCTION CODE' feature is disabled; you need MySQL built with '--with-debug' to have it working For debug builds (./configure --with-debug), nothing is changed.
-
Kristofer Pettersson authored
-
Marc Alff authored
Backport for 5.5
-
Marc Alff authored
-
Marc Alff authored
Backport to 5.5
-
Alexander Nozdrin authored
-
Kristofer Pettersson authored
When the query cache is disabled, the server shouldn't attempt to take the query cache mutex. By using the command line option --query_cache_type=0, the user can disable (backport from mysql-pe)
-
Alexey Botchkov authored
per-file comments: mysql-test/r/mysql_upgrade.result result updated mysql-test/t/mysql_upgrade.test --skip-verbose option added to the call
-
- 28 Oct, 2009 6 commits
-
-
Tor Didriksen authored
-
Tor Didriksen authored
Item_sum::set_aggregator() may be called multiple times during query preparation. On subsequent calls: verify that the aggregator type is the same, and re-use the existing Aggregator.
-
Alexey Botchkov authored
(backport) mysql_upgrade script accepts --upgrade-system-tables option, fixing only system tables in this case. per-file comments: client/mysql_upgrade.c WL#4991 mysql_upgrade --fix-privilege-tables --upgrade-system-tables option added. if it is set, the tool won't look for the mysqlcheck then run_mysqlcheck_fixnames() and run_mysqlcheck_upgrade won't be called. mysql-test/r/mysql_upgrade.result WL#4991 mysql_upgrade --fix-privilege-tables test result added mysql-test/t/mysql_upgrade.test WL#4991 mysql_upgrade --fix-privilege-tables test case added
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
- 27 Oct, 2009 8 commits
-
-
Vladislav Vaintroub authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Alexander Nozdrin authored
-
Dmitry Lenev authored
Disabled execution of this test for embedded server until fix for bug 41971 'Thread state on embedded server is always "Writing to net"' is back-ported to this tree.
-
Alexander Nozdrin authored
clean up message list).
-