An error occurred fetching the project authors.
  1. 29 Mar, 2007 1 commit
    • unknown's avatar
      WL#3629 - Replication of Invocation and Invoked Features · b5932225
      unknown authored
      This patch adds code to the binlog calls for replication of the
      CREATE, DROP, and UPDATE event commands. An extra gate was added 
      to ensure a query with length 0 is not binlogged. This corrects 
      the problem of events_scheduling and rpl_events failing on some
      build machines.
      
      
      sql/events.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        
        This patch adds code to the binlog calls for replication of the
        CREATE, DROP, and UPDATE event commands. An extra gate was added 
        to ensure a query with length 0 is not binlogged. This corrects 
        problems found when the patch for this worklog was pushed.
      b5932225
  2. 16 Mar, 2007 2 commits
    • unknown's avatar
      BUG#16420: Events: timestamps become UTC · 086fba76
      unknown authored
      BUG#26429: SHOW CREATE EVENT is incorrect for an event that
                 STARTS NOW()
      BUG#26431: Impossible to re-create an event from backup if its
                 STARTS clause is in the past
      WL#3698: Events: execution in local time zone
      
      The problem was that local times specified by the user in AT, STARTS
      and ENDS of CREATE EVENT/ALTER EVENT statement were converted to UTC,
      and the original time zone was forgotten.  This way, event scheduler
      couldn't honor Daylight Saving Time shifts, and times shown to the
      user were also in UTC.  Additionally, CREATE EVENT didn't allow times
      in the past, thus preventing straightforward event restoration from
      old backups.
      
      This patch reworks event scheduler time computations, performing them
      in the time zone associated with the event.  Also it allows times to
      be in the past.
      
      The patch adds time_zone column to mysql.event table.
      
      NOTE: The patch is almost final, but the bug#9953 should be pushed
      first.
      
      
      client/mysqldump.c:
        Before every CREATE EVENT, output its time zone.
      mysql-test/include/wait_condition.inc:
        Add optional $wait_timeout parameter.
      mysql-test/lib/init_db.sql:
        Add time_zone column.
      mysql-test/r/events.result:
        Update result.
      mysql-test/r/events_bugs.result:
        Update result.
      mysql-test/r/events_grant.result:
        Update result.
      mysql-test/r/events_restart_phase1.result:
        Update result.
      mysql-test/r/events_scheduling.result:
        Update result.
      mysql-test/r/mysqldump.result:
        Update result.
      mysql-test/r/ps.result:
        Update result.
      mysql-test/r/system_mysql_db.result:
        Update result.
      mysql-test/t/events.test:
        Remove STARTS from the result, as it depends on current time.
      mysql-test/t/events_bugs.test:
        Time in the past is no longer an error.
      mysql-test/t/events_restart_phase1.test:
        Fill new column 'time_zone' in mysql.event.
      mysql-test/t/events_scheduling.test:
        Cleanup: disable event scheduler.
      scripts/mysql_create_system_tables.sh:
        Add new column 'time_zone' to mysql.event.
      scripts/mysql_fix_privilege_tables.sql:
        Add new column 'time_zone' to mysql.event.
      sql/event_data_objects.cc:
        The essence of the change is the following:
         - for internal times use my_time_t instead of TIME.  Assignment and
           comparison is done now on plain numbers.
         - in init_execute_at(), init_starts(), init_ends() convert given time
           to number of seconds since Epoch (aka Unix time, in UTC).
         - handle time_zone field loading and storing.
         - in get_next_time(), Unix time is converted back to event time zone,
           interval is added, and the result is converted to UTC again.
         - fix Event_timed::get_create_event() to report STARTS and ENDS.
         - before executing the event body we set thread time zone to the
           event time zone.
      sql/event_data_objects.h:
        Add time_zone member to Event_basic class.
        
        Store internal times in my_time_t (number of seconds since Epoch),
        rather than in broken down TIME structure.
      sql/event_db_repository.cc:
        Add time_zone column handling.
        
        Give a warning and do not create an event if its execution time is in
        the past, and ON COMPLETION NOT PRESERVE is set, because such an event
        should be dropped by that time.  Also, do not allow ALTER EVENT to
        set execution time in the past when ON COMPLETION NOT PRESERVE is set.
      sql/event_db_repository.h:
        Add enum member for new time zone column.
      sql/event_queue.cc:
        Replace handling of broken down times with simple handling of
        my_time_t.
      sql/event_queue.h:
        Store internal times in my_time_t (number of seconds since Epoch),
        rather than in broken down TIME structure.
      sql/event_scheduler.cc:
        Add TODO comment.
      sql/events.cc:
        Send time_zone column for SHOW CREATE EVENT.
      sql/share/errmsg.txt:
        Update error message, and add two more errors.
      sql/sql_show.cc:
        Add TIME_ZONE column to the output of SHOW EVENTS.
      mysql-test/r/events_time_zone.result:
        BitKeeper file /home/tomash/src/mysql_ab/mysql-5.1-wl3698/mysql-test/r/events_time_zone.result
      mysql-test/t/events_time_zone.test:
        BitKeeper file /home/tomash/src/mysql_ab/mysql-5.1-wl3698/mysql-test/t/events_time_zone.test
      086fba76
    • unknown's avatar
      WL#3629 - Replication of Invocation and Invoked Features · 62b41b5f
      unknown authored
      This changeset adds replication of events and user-defined functions. 
      There are several bug reports involved in this change:
      
      BUG#16421, BUG#17857, BUG#20384:
      This patch modifies the mysql.events table to permit the addition of
      another enum value for the status column. The column now has values
      of ('DISABLED','SLAVESIDE_DISABLED','ENABLED'). A status of
      SLAVESIDE_DISABLED is set on the slave during replication of events.
      This enables users to determine which events werereplicated from the 
      master and to later enable them if they promote the slave to a master.
      The CREATE, ALTER, and DROP statements are binlogged.
      A new test was added for replication of events (rpl_events).
      
      BUG#17671:
      This patch modifies the code to permit logging of user-defined functions.
      Note: this is the CREATE FUNCTION ... SONAME variety. A more friendly error 
      message to be displayed should a replicated user-defined function not be
      found in the loadable library or if the library is missing from the
      slave.The CREATE andDROP statements are binlogged. A new test was added 
      for replication of user-defined functions (rpl_udf). 
      
      The patch also adds a new column to the mysql.event table named
      'originator' that is used to store the server_id of the server that
      the event originated on. This enables users to promote a slave to a 
      master and later return the promoted slave to a slave and disable the
      replicated events.
      
      
      mysql-test/lib/init_db.sql:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the SLAVESIDE_DISABLED to the list of enumerated 
        values for the mysql.event table.
        
        This patch adds the column 'originator' to the mysql.event table.
      mysql-test/r/events.result:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the 'originator' column to the events test results.
        This was necessary to ensure the manual insert into mysql.event table 
        succeeds because the originator column is set to NOT NULL.
      mysql-test/r/events_grant.result:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the 'originator' column to the events_grant test results.
        This was necessary to ensure the manual insert into mysql.event table 
        succeeds because the originator column is set to NOT NULL.
      mysql-test/r/events_restart_phase1.result:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the 'originator' column to the events_restart_phase1
        test results. This was necessary to ensure the manual insert into 
        mysql.event table succeeds because the originator column is set to 
        NOT NULL.
      mysql-test/r/system_mysql_db.result:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the SLAVESIDE_DISABLED to the list of enumerated 
        values for the mysql.event table.
        
        This patch adds the column 'originator' to the mysql.event table.
        
        These changes to the result file were necessary to ensure correct test
        results.
      mysql-test/t/events.test:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the 'originator' column to the events
        test. This was necessary to ensure the manual insert into 
        mysql.event table succeeds because the originator column is set to 
        NOT NULL.
      mysql-test/t/events_restart_phase1.test:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the 'originator' column to the events_restart_phase1
        test. This was necessary to ensure the manual insert into 
        mysql.event table succeeds because the originator column is set to 
        NOT NULL.
      scripts/mysql_create_system_tables.sh:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the SLAVESIDE_DISABLED to the list of enumerated 
        values for the mysql.event table.
        
        This patch adds the column 'originator' to the mysql.event table.
      scripts/mysql_fix_privilege_tables.sql:
        WL#3629 - Replication of Invocation and Invoked Feature
        This patch adds the SLAVESIDE_DISABLED to the list of enumerated 
        values for the mysql.event table.
        
        This patch adds the column 'originator' to the mysql.event table.
      sql/event_data_objects.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to permit processing of the new enum
        SLAVESIDE_DISABLED which is set on the slave during replication
        of events. 
        
        This patch uses the new Event_basic:: enumerated values.
      sql/event_data_objects.h:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch moves the duplicated enumeration values for ENABLED, 
        SLAVESIDE_DISABLED, and DISABLED to the Event_basic class removing
        them from the other Event_* classes.
      sql/event_db_repository.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to permit processing of the new enum
        SLAVESIDE_DISABLED which is set on the slave during replication
        of events. 
        
        The patch also adds a new column to the mysql.event table named
        'originator' that is used to store the server_id of the server that
        the event originated on. This enables users to promote a slave to a 
        master and later return the promoted slave to a slave and disable the
        replicated events.
      sql/event_db_repository.h:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to add a new field named 'originator' 
        to the enum_event_table_field and associated structure.
      sql/event_queue.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to permit processing of the new enum
        SLAVESIDE_DISABLED which is set on the slave during replication
        of events.
      sql/events.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to permit processing of the new enum
        SLAVESIDE_DISABLED which is set on the slave during replication
        of events.
      sql/lex.h:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to add the new SLAVESIDE_DISABLE symbol
        to the lexical parser.
      sql/slave.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to permit the capture of the error on
        the slave when a UDF from a loadable library is not loaded on the server
        when replicated from the master.
      sql/sql_parse.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch removes the comment because drop functions commands 
        are replicated.
      sql/sql_show.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to permit processing of the new enum
        SLAVESIDE_DISABLED which is set on the slave during replication
        of events. The code also adds changes the display width of the status
        column for the schema table for the show events command and also adds
        the new column 'originator' to the events_field_info structure.
      sql/sql_udf.cc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to add the binlogging of the create and
        drop function events.
      sql/sql_yacc.yy:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch modifies the code to change the enumeration of the status
        column for the events in the parser. The code uses the Event_basic::
        enumerations allowing the enums to be defined in one place.
      mysql-test/t/rpl_events.test:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch adds a new test for testing replication of events. The test
        uses include files so that the test can test under both RBR and SBR.
      mysql-test/r/rpl_events.result:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch adds a new result file for testing replication of events.
      mysql-test/r/rpl_udf.result:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch adds a new result file for testing replication of UDFs.
      mysql-test/t/rpl_udf.test:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch adds a new test for testing replication of UDFs. The test
        uses include files so that the test can test under both RBR and SBR.
      mysql-test/include/rpl_events.inc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch adds a new include file for testing replication of events.
        This file contains the core test procedures.
      mysql-test/include/rpl_udf.inc:
        WL#3629 - Replication of Invocation and Invoked Features
        This patch adds a new include file for testing replication of UDFs.
        This file contains the core test procedures.
      62b41b5f
  3. 02 Mar, 2007 1 commit
  4. 01 Mar, 2007 1 commit
    • unknown's avatar
      Fixed compiler warnings · 2e346023
      unknown authored
      server-tools/instance-manager/angel.cc:
        Compiler warnings
      sql/event_queue.cc:
        Compier warnings
      sql/event_scheduler.cc:
        Compiler warnings
      sql/events.cc:
        Compiler warnings
      2e346023
  5. 29 Jan, 2007 1 commit
    • unknown's avatar
      Fix for bug#22740 Events: Decouple Event_queue from Event_db_repository · 3c39b0d8
      unknown authored
      This patch implements the idea of the bug report by making Event_queue
      unaware of Event_db_repository by making a higher level class - Events,
      which is aware of most of all classes, responsible for passing all data
      needed for adding/updating/deleting an event to/from the queue.
      
      Introduces few new classes :
       - Event_worker_thread
       - Event_queue_element_for_exec
      
      
      sql/event_data_objects.cc:
        Introduced a new class Event_queue_element_for_exec
        According to Konstantin it should be named Event_name and hold
        only two LEX_STRINGs but `dropped` is not saved on disk and will
        require additional logic in Event_worker_thread class, after loading
        to compute whether the event should be dropped or not. It's easier
        just to pass this flag around.
        
        Removed Event_queue_element::drop(). This method was a source of a
        race condition. At the place where the event should be dropped we
        call Events::drop_event() which is the only code-flow for dropping.
        In addition, because ::drop_event() holds Events::LOCK_metadata there is
        no source of race conditions. Before this patch dropping from ::drop()
        wasn't under LOCK_metadata and races were possible.
        
        Because Events::open_event_table was removed as a method, provisionally
        events_event_db_repository was exported from events.cc till a solution is
        build where Event_queue_element does not access directly mysql.event.
      sql/event_data_objects.h:
        New class Event_queue_element_for_exec added which is returned
        from Event_queue::get_top_if_time() and passed through Event_scheduler
        to Event_worker_thread. There by using the (db)name Event_job_data is
        instanciated and executed.
        
        Dropped Event_queue_element::drop()
        
        thd was moved out of Event_job_data as it is now part of
        Event_queue_element_for_exec
      sql/event_queue.cc:
        Removed dependency of Event_queue on Event_db_repository.
        The instantiation of Event_job_data was moved to class Event_worker_thread
        In place is a return of an object of Event_queue_element_for_exec is used
        later for instantiating Event_job_data.
        
        The `dropped` flag of Event_queue_element is passed over
        Event_queue_element_for_exec to the code in Event_worker_thread.
      sql/event_queue.h:
        Removed dependency of Event_queue on Event_db_repository
        Removed dependency on Event_scheduler
      sql/event_scheduler.cc:
        Added class Event_worker_thread, which is used during
        the execution of an event. It has a static init() method
        to get a pointer to Event_db_repository to be used for
        instantiation of Event_job_data object. This object it then
        executed.
      sql/event_scheduler.h:
        Added class Event_worker_thread, which is used during
        the execution of an event.
      sql/events.cc:
        Removed Events::open_event_table() because it was a product of
        a bad architecture.
      sql/events.h:
        Removed friend definition, unneeded.
        
        Fixed Events::drop_event() to have the previous signature without
        bool only_from_disk
      sql/sql_parse.cc:
        Fix call
      3c39b0d8
  6. 27 Dec, 2006 1 commit
    • unknown's avatar
      Many files: · 92e68d49
      unknown authored
        Changed header to GPL version 2 only
      
      
      client/mysqlslap.c:
        Changed header to GPL version 2 only
      include/atomic/nolock.h:
        Changed header to GPL version 2 only
      include/atomic/rwlock.h:
        Changed header to GPL version 2 only
      include/atomic/x86-gcc.h:
        Changed header to GPL version 2 only
      include/atomic/x86-msvc.h:
        Changed header to GPL version 2 only
      include/my_atomic.h:
        Changed header to GPL version 2 only
      include/my_trie.h:
        Changed header to GPL version 2 only
      include/my_vle.h:
        Changed header to GPL version 2 only
      include/mysql/plugin.h:
        Changed header to GPL version 2 only
      mysys/my_atomic.c:
        Changed header to GPL version 2 only
      mysys/my_getncpus.c:
        Changed header to GPL version 2 only
      mysys/my_memmem.c:
        Changed header to GPL version 2 only
      mysys/my_vle.c:
        Changed header to GPL version 2 only
      mysys/trie.c:
        Changed header to GPL version 2 only
      plugin/Makefile.am:
        Changed header to GPL version 2 only
      server-tools/instance-manager/IMService.h:
        Changed header to GPL version 2 only
      server-tools/instance-manager/WindowsService.h:
        Changed header to GPL version 2 only
      server-tools/instance-manager/exit_codes.h:
        Changed header to GPL version 2 only
      server-tools/instance-manager/user_management_commands.h:
        Changed header to GPL version 2 only
      sql/authors.h:
        Changed header to GPL version 2 only
      sql/contributors.h:
        Changed header to GPL version 2 only
      sql/event_data_objects.cc:
        Changed header to GPL version 2 only
      sql/event_data_objects.h:
        Changed header to GPL version 2 only
      sql/event_db_repository.cc:
        Changed header to GPL version 2 only
      sql/event_db_repository.h:
        Changed header to GPL version 2 only
      sql/event_queue.cc:
        Changed header to GPL version 2 only
      sql/event_queue.h:
        Changed header to GPL version 2 only
      sql/event_scheduler.cc:
        Changed header to GPL version 2 only
      sql/event_scheduler.h:
        Changed header to GPL version 2 only
      sql/events.cc:
        Changed header to GPL version 2 only
      sql/events.h:
        Changed header to GPL version 2 only
      sql/ha_ndbcluster_binlog.cc:
        Changed header to GPL version 2 only
      sql/ha_ndbcluster_binlog.h:
        Changed header to GPL version 2 only
      sql/ha_ndbcluster_tables.h:
        Changed header to GPL version 2 only
      sql/ha_partition.cc:
        Changed header to GPL version 2 only
      sql/ha_partition.h:
        Changed header to GPL version 2 only
      sql/item_xmlfunc.cc:
        Changed header to GPL version 2 only
      sql/item_xmlfunc.h:
        Changed header to GPL version 2 only
      sql/log.h:
        Changed header to GPL version 2 only
      sql/partition_element.h:
        Changed header to GPL version 2 only
      sql/partition_info.cc:
        Changed header to GPL version 2 only
      sql/partition_info.h:
        Changed header to GPL version 2 only
      sql/rpl_filter.cc:
        Changed header to GPL version 2 only
      sql/rpl_filter.h:
        Changed header to GPL version 2 only
      sql/rpl_injector.cc:
        Changed header to GPL version 2 only
      sql/rpl_injector.h:
        Changed header to GPL version 2 only
      sql/rpl_mi.cc:
        Changed header to GPL version 2 only
      sql/rpl_mi.h:
        Changed header to GPL version 2 only
      sql/rpl_rli.cc:
        Changed header to GPL version 2 only
      sql/rpl_rli.h:
        Changed header to GPL version 2 only
      sql/rpl_tblmap.cc:
        Changed header to GPL version 2 only
      sql/rpl_tblmap.h:
        Changed header to GPL version 2 only
      sql/rpl_utility.cc:
        Changed header to GPL version 2 only
      sql/rpl_utility.h:
        Changed header to GPL version 2 only
      sql/sql_binlog.cc:
        Changed header to GPL version 2 only
      sql/sql_partition.cc:
        Changed header to GPL version 2 only
      sql/sql_partition.h:
        Changed header to GPL version 2 only
      sql/sql_plugin.cc:
        Changed header to GPL version 2 only
      sql/sql_plugin.h:
        Changed header to GPL version 2 only
      sql/sql_servers.cc:
        Changed header to GPL version 2 only
      sql/sql_servers.h:
        Changed header to GPL version 2 only
      sql/sql_tablespace.cc:
        Changed header to GPL version 2 only
      sql/sql_yacc.yy.bak:
        Changed header to GPL version 2 only
      storage/Makefile.am:
        Changed header to GPL version 2 only
      storage/archive/Makefile.am:
        Changed header to GPL version 2 only
      storage/blackhole/Makefile.am:
        Changed header to GPL version 2 only
      storage/csv/Makefile.am:
        Changed header to GPL version 2 only
      storage/example/Makefile.am:
        Changed header to GPL version 2 only
      storage/federated/Makefile.am:
        Changed header to GPL version 2 only
      storage/innobase/handler/Makefile.am:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/AllocNodeId.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/CreateFilegroup.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/CreateFilegroupImpl.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/CreateObj.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/DictObjOp.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/DihFragCount.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/DropFilegroup.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/DropFilegroupImpl.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/DropObj.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/Extent.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/LgmanContinueB.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/PgmanContinueB.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/RestoreContinueB.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/RestoreImpl.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/RouteOrd.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/kernel/signaldata/TsmanContinueB.hpp:
        Changed header to GPL version 2 only
      storage/ndb/include/ndbapi/NdbIndexStat.hpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/mgmapi_logevent/mgmapi_logevent.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/mgmapi_logevent_dual/mgmapi_logevent_dual.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_async/ndbapi_async.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_async1/ndbapi_async1.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_event/ndbapi_event.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_retries/ndbapi_retries.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_scan/ndbapi_scan.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_simple/ndbapi_simple.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_simple_dual/ndbapi_simple_dual.cpp:
        Changed header to GPL version 2 only
      storage/ndb/ndbapi-examples/ndbapi_simple_index/ndbapi_simple_index.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbdih/printSysfile.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtup/DbtupDiskAlloc.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtup/DbtupVarAlloc.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtup/Undo_buffer.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtup/Undo_buffer.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtup/tuppage.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtup/tuppage.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/dbtux/DbtuxStat.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/diskpage.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/lgman.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/lgman.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/pgman.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/pgman.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/print_file.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/record_types.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/restore.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/restore.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/tsman.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/blocks/tsman.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/DLCFifoList.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/DLCHashTable.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/DynArr256.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/DynArr256.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/KeyTable2Ref.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/LinearPool.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/NdbdSuperPool.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/NdbdSuperPool.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/Pool.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/Pool.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/RWPool.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/RWPool.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/Rope.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/SLFifoList.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/WOPool.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/WOPool.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/bench_pool.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/ndbd_malloc_impl.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/kernel/vm/ndbd_malloc_impl.hpp:
        Changed header to GPL version 2 only
      storage/ndb/src/mgmsrv/ParamInfo.cpp:
        Changed header to GPL version 2 only
      storage/ndb/src/ndbapi/NdbIndexStat.cpp:
        Changed header to GPL version 2 only
      storage/ndb/test/ndbapi/testIndexStat.cpp:
        Changed header to GPL version 2 only
      storage/ndb/test/tools/listen.cpp:
        Changed header to GPL version 2 only
      storage/ndb/tools/restore/ndb_nodegroup_map.h:
        Changed header to GPL version 2 only
      strings/my_strchr.c:
        Changed header to GPL version 2 only
      unittest/mysys/base64-t.c:
        Changed header to GPL version 2 only
      unittest/mysys/bitmap-t.c:
        Changed header to GPL version 2 only
      unittest/mysys/my_atomic-t.c:
        Changed header to GPL version 2 only
      unittest/mytap/tap.c:
        Changed header to GPL version 2 only
      unittest/mytap/tap.h:
        Changed header to GPL version 2 only
      win/Makefile.am:
        Changed header to GPL version 2 only
      92e68d49
  7. 26 Nov, 2006 1 commit
    • unknown's avatar
      Fixed a LOT of compiler warnings · 788ad30f
      unknown authored
      Added missing DBUG_RETURN statements (in mysqldump.c)
      Added missing enums
      Fixed a lot of wrong DBUG_PRINT() statements, some of which could cause crashes
      Removed usage of %lld and %p in printf strings as these are not portable or produces different results on different systems.
      
      
      client/mysqldump.c:
        Fixed some compiler warnings
        Added some missing DBUG_RETURN
        Remove copying of 'cluster' database
      client/mysqlslap.c:
        Fixed compiler warnings
      client/mysqltest.c:
        After merge fix
      extra/yassl/taocrypt/include/algebra.hpp:
        Removed compiler warning
      mysql-test/include/im_check_env.inc:
        Fixed race condition (mysqld1 could report 'starting' or 'online'
      mysql-test/mysql-test-run.pl:
        After merge fixes
        Added missing directory to LD_LIBRARY_PATH
      mysql-test/r/ctype_cp1250_ch.result:
        After merge fix
      mysql-test/r/im_cmd_line.result:
        Fixed race condition
      mysql-test/r/im_daemon_life_cycle.result:
        Fixed race condition
      mysql-test/r/im_instance_conf.result:
        Fixed race condition
      mysql-test/r/im_life_cycle.result:
        Fixed race condition
      mysql-test/r/im_utils.result:
        Fixed race condition
      mysql-test/r/log_tables.result:
        Fixed wrong result
      mysql-test/t/disabled.def:
        Disabled ndb_restore_partion, as ndb_restore_compate caused it to fail, becasue of table 'cluster/def/schema' which is stored in ndb_backup50
      mysys/my_compress.c:
        Removed compiler warnings
      mysys/my_getopt.c:
        Ensure we always have at least one space between option name and value
      plugin/fulltext/plugin_example.c:
        Removed compiler warnings
      server-tools/instance-manager/mysql_connection.cc:
        After merge fix
      sql/event_data_objects.cc:
        Fixed compiler warnings
        Fixed platform compatibility issues (%lld is not portable)
      sql/event_data_objects.h:
        Fixed compiler warnings
      sql/event_db_repository.cc:
        Fixed compiler warnings
      sql/event_queue.cc:
        Fixed compiler warnings
      sql/event_scheduler.cc:
        Fixed compiler warnings
      sql/events.cc:
        Fixed compiler warnings
      sql/field.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warnings
      sql/ha_partition.cc:
        Fixed compiler warnings
      sql/handler.cc:
        Fixed compiler warnings
      sql/item_cmpfunc.cc:
        Fixed DBUG_PRINT style
      sql/item_func.cc:
        Fixed compiler warnings
      sql/log.cc:
        Fixed compiler warnings
      sql/log_event.cc:
        Fixed compiler warnings
      sql/mysqld.cc:
        Fixed compiler warnings
      sql/opt_range.cc:
        Fixed compiler warnings
      sql/repl_failsafe.cc:
        Indentation fixes
      sql/rpl_rli.cc:
        Fixed compiler warnings
      sql/rpl_tblmap.cc:
        Fixed compiler warnings
      sql/set_var.cc:
        Fixed compiler warnings
      sql/slave.cc:
        Fixed compiler warnings
      sql/sp_head.cc:
        Fixed compiler warnings
      sql/sql_base.cc:
        Fixed compiler warnings
        Fixed indentation
      sql/sql_binlog.cc:
        Fixed compiler warnings
      sql/sql_cache.cc:
        Fixed compiler warnings
      sql/sql_class.cc:
        Fixed compiler warnings
      sql/sql_handler.cc:
        Fixed compiler warnings
      sql/sql_lex.cc:
        Fixed compiler warnings
      sql/sql_parse.cc:
        Fixed compiler warnings
      sql/sql_partition.cc:
        Fixed compiler warnings
      sql/sql_prepare.cc:
        Fixed compiler warnings
      sql/sql_table.cc:
        Fixed compiler warnings
      sql/sql_test.cc:
        Fixed DBUG_PRINT style
      sql/sql_trigger.cc:
        Fixed DBUG_PRINT style
      sql/table.cc:
        Fixed compiler warnings
      storage/federated/ha_federated.cc:
        Fixed compiler warnings
      storage/myisam/mi_rsamepos.c:
        Fixed compiler warnings
      storage/ndb/include/ndb_global.h.in:
        After merge fix
      storage/ndb/include/util/NdbOut.hpp:
        Inform gcc that ndbout_c takes a printf() string as argument
      storage/ndb/include/util/SimpleProperties.hpp:
        After merge fixes
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbacc/DbaccMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Fixed compiler warnings
        Fixed usage of uninitialized value (Got help from Jonas with patch)
      storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/lgman.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/pgman.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/restore.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupCommit.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupDiskAlloc.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupFixAlloc.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/suma/Suma.cpp:
        Fixed compiler warnings
        Added missing enum's to switch
      storage/ndb/src/kernel/vm/Configuration.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/DLHashTable.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/RWPool.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/SimulatedBlock.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/WOPool.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/ndbd_malloc_impl.cpp:
        Fixed compiler warnings
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Fixed compiler warnings
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/DictCache.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbIndexOperation.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbIndexStat.cpp:
        Initialize possible uninitialized variable
      storage/ndb/src/ndbapi/NdbOperationInt.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbRecAttr.cpp:
        Added missing enum's (To avoid compiler warnings)
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/ObjectMap.hpp:
        Fixed compiler warnings
      storage/ndb/tools/desc.cpp:
        Fixed compiler warnings
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warnings
      storage/ndb/tools/restore/consumer_restore.cpp:
        Fixed compiler warnings
      unittest/mytap/t/basic-t.c:
        Fixed compiler warnings
      unittest/mytap/tap.c:
        Fixed compiler warnings
      788ad30f
  8. 12 Sep, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 04a5f335
      unknown authored
      Remove SHOW SCHEDULER STATUS command and migrate the
      information output to `mysqladmin debug` (COM_DEBUG)
      
      SHOW SCHEDULER STATUS was introduced in 5.1.11, provided
      some debug information about event scheduler internals and
      was enabled only in debug builds.
      
      
      sql/event_queue.cc:
        Remove SHOW SCHEDULER STATUS. Reporting still will be
        there but through COM_DEBUG (mysqladmin debug)
      sql/event_queue.h:
        dump_internal_status cannot return an error, therefore it
        should be void.
      sql/event_scheduler.cc:
        Remove SHOW SCHEDULER STATUS. Reporting still will be
        there but through COM_DEBUG (mysqladmin debug)
      sql/event_scheduler.h:
        dump_internal_status cannot return an error, therefore it
        should be void.
      sql/events.cc:
        Change from outputting the internal data from
        the wire to the standard output. SHOW SCHEDULER STATUS was
        removed.
      sql/events.h:
        dump_internal_status() cannot return an error, therefore
        it should be void
      sql/lex.h:
        remove SCHEDULER as recognized word. This is part
        of removing SHOW SCHEDULER STATUS
      sql/sp_head.cc:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      sql/sql_lex.h:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      sql/sql_parse.cc:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      sql/sql_test.cc:
        Dump Events' internal information on COM_DEBUG
      sql/sql_yacc.yy:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      04a5f335
  9. 01 Sep, 2006 3 commits
    • unknown's avatar
      remove unused artifacts · e22b6703
      unknown authored
      sql/event_db_repository.cc:
        remove unused variables - reported by MS compiler
      sql/event_queue.cc:
        remove unused variables - reported by MS compiler
      sql/event_scheduler.cc:
        remove unused label
      sql/events.cc:
        remove unused variable and a label - reported by MS compiler
      e22b6703
    • unknown's avatar
      post-merge fix · c67c49fc
      unknown authored
      sql/event_scheduler.cc:
        fix typo
      sql/events.cc:
        This check is not needed since UNINITIALIZED state was introduced
        in the Event_scheduler
      c67c49fc
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · da4734c3
      unknown authored
      This is a post-review patch.
      
      Fixes the typelib implementation, available only in 5.1.11.
      
      --event-scheduler cmdline : DISABLED | ON | OFF | 0 | 1
      DISABLED - makes the scheduler unavailable during the server run
      (ON|1)-  When the server is started the scheduler will be started. It can
               be stopped and restarted by setting appropriate values to
               GLOBAL event_scheduler
      (OFF|0)- When the server is started, the scheduler won't be started. It
               can be started and again stopped by setting appropriate values to
               GLOBAL event_scheduler. _DEFAULT_ value
      
      The GLOBAL variable event_scheduler can have the following values:
      OFF | ON | 0 | 1
      DISABLED is not possible and every attempt will end with an error that
      it's not a valid value for the variable.
      OFF | 0 - This is the pre-5.1.11 behavior - The scheduler stops, if not
                already stopped, and can be started again  by setting
                the value of the variable to ON|1.
      ON | 1  - This is the pre-5.1.11 behavior - The scheduler starts, if not
                already started, and can be stopped again by setting the value
                of the variable to OFF|0.
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/r/events_bugs.result:
        update result
      mysql-test/r/events_logs_tests.result:
        update result
      mysql-test/r/events_restart_phase1.result:
        update result
      mysql-test/r/events_restart_phase3.result:
        update result
      mysql-test/r/events_scheduling.result:
        update result
      mysql-test/r/events_stress.result:
        update result
      mysql-test/t/events.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_bugs.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_logs_tests.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_restart_phase1.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_restart_phase2-master.opt:
        update master file : 1 => on
      mysql-test/t/events_scheduling.test:
        update test:
        2 -> off
        1 -> on
        
        add tests for event_scheduler global variable representation from
        SHOW VARIABLES.
      mysql-test/t/events_stress.test:
        update test:
        2 -> off
        1 -> on
      sql/events.cc:
        Implement two different TYPELIBs for --event-scheduler cmd line
        option and for GLOBAL variable event_scheduler
        
        --event-scheduler cmdline : DISABLED | ON | OFF | 0 | 1
        DISABLED - makes the scheduler unavailable during the server run
        (ON|1)-  When the server is started the scheduler will be started. It can
                 be stopped and restarted by setting appropriate values to
                 GLOBAL event_scheduler
        (OFF|0)- When the server is started, the scheduler won't be started. It
                 can be started and again stopped by setting appropriate values to
                 GLOBAL event_scheduler. _DEFAULT_ value
        
        The GLOBAL variable event_scheduler can have the following values:
        OFF | ON | 0 | 1
        DISABLED is not possible and every attempt will end with an error that
        it's not a valid value for the variable.
        OFF | 0 - This is the pre-5.1.11 behavior - The scheduler stops, if not
                  already stopped, and can be started again  by setting
                  the value of the variable to ON|1.
        ON | 1  - This is the pre-5.1.11 behavior - The scheduler starts, if not
                  already started, and can be stopped again by setting the value
                  of the variable to OFF|0.
      sql/events.h:
        additional TYPELIB for GLOBAL event_scheduler
      sql/mysqld.cc:
        --event-scheduler should be checked against a TYPELIB and
        therefore should be GET_STR, as well as we make the parameter optional.
        When not provided OFF|0 is used.
      sql/set_var.cc:
        Implement typelib for event_scheduler variable.
        If allows both INT_RESULT -> 0 | 1 
        and STRING_RESULT -> OFF | ON
        The variable is shown as DISABLED | ON | OFF
      sql/set_var.h:
        Implement typelib, which expects both STRING and INT,
        for event_scheduler.
      da4734c3
  10. 31 Aug, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 0410cc3a
      unknown authored
      This patch makes the relationship between Event_scheduler and Event_queue
      unidirectional from the former to the latter.
      
      
      
      
      The change is that the conditional on which the scheduler sleeped has been
      moved to the Event_queue and the latter does not call anymore
      Event_scheduler::queue_changed(), which in turn has be removed.
      
      
      sql/event_queue.cc:
        Remove dependency of Event_queue on Event_scheduler but not vice versa.
        Event_scheduler polls whether there is time to execute an event.
        
        Removed notify_observers() as the way of calling has changed.
        Added Event_queue::cond_wait() similar to Event_scheduler::cond_wait().
      sql/event_queue.h:
        init_queue() does not need anymore Event_scheduler object because
        the relationship is now one-way. Event_scheduler knows about Event_queue
        but not vice versa.
        
        get_top_execution_if_time() does by itself the waiting instead of
        returning abstime. This simplifies the code in Event_scheduler::run()
        get_top_execution_if_time() returns only if job_data != NULL or if
        the scheduler thread was killed.
        
        notify_observers() is no more used and therefore removed.
        
        Added Event_queue::cond_wait() because now there is waiting on a
        conditional variable in Event_queue too (like in Event_scheduler for
        ::stop()).
      sql/event_scheduler.cc:
        Change the relationship between Event_scheduler & Event_queue.
        Event_queue does not know anymore about Event_scheduler. When
        the scheduler calls get_top_element_if_time() it may fall asleep
        on a conditional of Event_queue, if either the queue is empty or
        it's still not time for activation. When the method returns it
        will return a non-null address, namely an object to be executed.
        If the return value is NULL, the thread was killed by a call to
        Event_scheduler::stop() (we assert this).
      sql/event_scheduler.h:
        Remove queue_changed() as it is obsoleted by making the relationship
        between Event_scheduler and Event_queue one-way, from the former to the
        latter. Event_queue now does not know about Event_scheduler.
        
        get_state() is changed to is_running(). The state enum should be private,
        as it is not needed to be seen from outside anymore.
      sql/events.cc:
        Event_queue does not need anymore a pointer to Event_scheduler.
      0410cc3a
  11. 28 Aug, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · f18ec676
      unknown authored
      Don't send affected rows after CREATE/ALTER/DROP EVENT as this is
      inconsistent with the rest of the server in terms of CREATE/ALTER/DROP
      DDLs
      
      
      sql/event_data_objects.cc:
        Events::drop_event() does not expect anymore a parameter named affected_rows
      sql/event_db_repository.cc:
        Remove rows_affected as the behavior exposed by Events is not
        coherent with the behavior of many other DDL, like CREATE PROCEDURE, etc.
      sql/event_db_repository.h:
        Remove rows_affected as the behavior exposed by Events is not
        coherent with the behavior of many other DDL, like CREATE PROCEDURE, etc.
      sql/events.cc:
        Remove rows_affected as the behavior exposed by Events is not
        coherent with the behavior of many other DDL, like CREATE PROCEDURE, etc.
      sql/events.h:
        Remove rows_affected as the behavior exposed by Events is not
        coherent with the behavior of many other DDL, like CREATE PROCEDURE, etc.
      sql/sql_parse.cc:
        Don't send affected rows, because this behavior is not consistent
        with the rest of the server for CREATE/ALTER/DROP DDLs
      f18ec676
  12. 17 Aug, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 99adbd13
      unknown authored
      Post-review fixes. Mostly whitespace, int-to-bool return value, fixed comments
      
      
      sql/Makefile.am:
        compile all submodules of Events before compiling the facade
      sql/event_data_objects.cc:
        - Use initialization list
        - Clean whitespaces
        - Shorten comments
        - Fix comments
      sql/event_data_objects.h:
        - Fix whitespace
      sql/event_db_repository.cc:
        - Change return type from int to bool where only one error code is
          returned.
        - Don't use macros but get the maximal number of characters in a column
          from the column
        - Fix  comments
        - Make functions which has return value but it's not used - void.
      sql/event_db_repository.h:
        - Methods with only one error code int -> bool return value
        - Remove declaration of fill_schema_events, a function that does not exist
      sql/event_queue.cc:
        - Use initialization lists
        - Let find_n_remove_event delete the object thus making the code more robust.
          The caller could forget to destruct the object. In addition, find_n_remove_element()
          does not return a value.
        - Move check_system_tables() to class Events
        - Fix comments
      sql/event_queue.h:
        - Whitespace changes
        - init_queue() should allow passing of THD
        - check_system_tables moved to class Events
        - find_n_remove_event() is now void
      sql/event_scheduler.cc:
        - Initialize res before use
        - Remove end stop from message
      sql/event_scheduler.h:
        Add uninitialized state. The scheduler is in it before init_scheduler()
        is called. The rationale is that otherwise state has no value before
        the call. If the system tables were damaged the scheduler won't be initialized
        but in Events::deinit() Event_scheduler::stop() will be called and this will
        touch state, generating valgrind warning at minimum.
      sql/events.cc:
        - Whitespace changes
        - Fix comments
        - Make methods which have only one error code be bool instead of int
        - Create temporarily a THD to be used for the initialization of Event_queue
        - Event_queue::check_system_tables() moved to Events::check_system_tables
        - is_started() is renamed to is_execution_of_events_started()
      sql/events.h:
        - Whitespace changes
        - When a method returns only one error code it should be bool, not int
        - is_started() renamed to is_execution_of_events_started()
      sql/set_var.cc:
        is_started() is renamed to is_execution_of_events_started()
      sql/sql_db.cc:
        The return code is not used, thus don't return anything and drop_schema_events()
        is now void.
      sql/sql_yacc.yy:
        - Fix comments
        - Remove unneeded initialization which is performed in lex_init()
      sql/share/errmsg.txt:
        New error message
      sql/table.cc:
        - Fix comments
        - make table_check_intact() accespt const *table_def
      sql/table.h:
        Make table_check_intact() accespt const *table_def
      99adbd13
  13. 17 Jul, 2006 1 commit
    • unknown's avatar
      WL#3337 (Events new architecture) · e69e640f
      unknown authored
      Small updates before patch submit.
      
      
      client/mysqltest.c:
        allow --valgrind option to mysqltest so one can be able to detect
        whether the test is running under valgrind by having $VALGRIND_TEST,
        similar to BIG_TEST, in the test file.
      mysql-test/mysql-test-run.pl:
        If the test suite is running under valgrind start mysqltest with --valgrind
        to inform that we run valgrind. mysqltest will provide $VALGRIND_TEST for the
        test cases.
      mysql-test/r/events_bugs.result:
        update result
      mysql-test/r/events_scheduling.result:
        update result
      mysql-test/t/events.test:
        Increase times or the test will fail under valgrind
      mysql-test/t/events_bugs.test:
        Increase times or the test will fail under valgrind
      mysql-test/t/events_scheduling.test:
        Remove faulty test
        Disable the test case for valgrind
      sql/event_data_objects.cc:
        count the number of executions
      sql/event_data_objects.h:
        flags is not used at all
        add execution_count to count the number of executions
      sql/event_db_repository.cc:
        Initialize wherever needed.
        Add a comment regarding valgrind warning.
      sql/event_queue.cc:
        more debug info in the trace log
      sql/event_scheduler.cc:
        Use macro COND_STATE_WAIT() in all cases we need waiting
        on condition. Hence, we can trace locking, attemption to lock
        and more with SHOW SCHEDULER STATUS
      sql/event_scheduler.h:
        Change the declaration of cond_wait to accept THD
      sql/events.cc:
        fix memory leak. Destroy event_queue
      mysql-test/include/not_valgrind.inc:
        New BitKeeper file ``mysql-test/include/not_valgrind.inc''
      mysql-test/r/not_valgrind.require:
        New BitKeeper file ``mysql-test/r/not_valgrind.require''
      e69e640f
  14. 13 Jul, 2006 1 commit
    • unknown's avatar
      WL #3337 (Events new architecture) · 31caa8c4
      unknown authored
      Final stroke, events should be loaded from disk on server startup.
      Also check the validity of their bodies if possible during loading.
      
      
      sql/event_data_objects.cc:
        Remove Event_job_data::free_sp(), move the code to the destructor
        Change the way we change the security context
        Steal some code from sql_parse.cc
      sql/event_data_objects.h:
        Remove free_sp()
        Make compile() public, to be used when booting for verifying the integrity of mysql.event
      sql/event_queue.cc:
        Make the queue load events from disk on server boot.
        Compile and thus check for integrity the events.
      sql/event_queue.h:
        shift methods around. add queue_loaded boolean.
      sql/event_scheduler.cc:
        Rename init_event_thread() to pre_init_event_thread()
        and make it more generic.
        Add post_init_event_thread()
        Export these two as well as deinit_event_thread().
        Now it is quite easy to write code to spawn a new event thread
        whenever needed.
      sql/event_scheduler.h:
        export pre_init_event_thread(), post_init_event_thread() and deinit_event_thread()
        to simplify writing of thread functions.
      sql/events.cc:
        Events::init() returns only one error code, then make it bool
      sql/events.h:
        Events::init() returns only one error code, then make it bool
      sql/mysqld.cc:
        Check the return code of Events::init()
      sql/sp_head.cc:
        Add trace info
      sql/sql_class.cc:
        Reorganize thd::change_security_context() to load main_security_ctx
      sql/sql_class.h:
        Reorganize thd::change_security_context() to load main_security_ctx
      sql/sql_lex.cc:
        Initialize lex->spname
      sql/sql_yacc.yy:
        Add a comment
      31caa8c4
  15. 12 Jul, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 628be8a7
      unknown authored
      event_scheduler_ng.cc/h is no more
      
      
      BitKeeper/deleted/.del-event_scheduler_ng.cc~8896b89040dbc4f6:
        Delete: sql/event_scheduler_ng.cc
      BitKeeper/deleted/.del-event_scheduler_ng.h~1431af5b185376f:
        Delete: sql/event_scheduler_ng.h
      mysql-test/r/not_embedded_server.result:
        fix test
      sql/Makefile.am:
        event_scheduler_ng.cc/h is no more
      sql/event_queue.cc:
        event_scheduler_ng.cc/h is no more
      sql/event_queue.h:
        event_scheduler_ng.cc/h is no more
      sql/event_scheduler.cc:
        event_scheduler_ng.cc/h is no more
      sql/event_scheduler.h:
        event_scheduler_ng.cc/h is no more
      sql/events.cc:
        event_scheduler_ng.cc/h is no more
      sql/events.h:
        event_scheduler_ng.cc/h is no more
      628be8a7
  16. 11 Jul, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 42a8e2c9
      unknown authored
      More small fixes to the API : use LEX_STRING instead of LEX_STRING* and if error
      then return bool(true) instead of error code.
      Merged functions. Reduced usage of sp_name.
      Fixed a lot of function documentation errors.
      Added function documentation wherever needed.
      Removed some unused defines and error codes.
      
      Next to come is batch rename of Event_scheduler_ng to Event_scheduler.
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/r/events_logs_tests.result:
        update result
      mysql-test/t/events.test:
        more test coverage
      mysql-test/t/events_logs_tests.test:
        fix test
      sql/event_data_objects.cc:
        Cosmetics.
        Fix function documentation whenever needed.
        Move Event_job_data::compile() next to Event_job_data::execute()
      sql/event_data_objects.h:
        Remove unneeded error codes and defines
        Move function declarations at the end of the header
      sql/event_db_repository.cc:
        Fix function documentation.
        Event_db_repository::update_event() now uses LEX_STRING *-s instead of
        sp_name . Lower coupling.
      sql/event_db_repository.h:
        Event_db_repository::update_event() now uses LEX_STRING *-s instead of
        sp_name . Lower coupling.
        find_event -> find_named_event
        find_event_by_name is not used externally, merge with load_named_event()
      sql/event_queue.cc:
        LEX_STRING* to LEX_STRING
        Fix comments.
        Fix and add function documentation.
        Remove Event_queue::events_count() as it is unused
        Change get_top_for_execution_if_time() to return status code as return value
        and the object is in out parameter.
      sql/event_queue.h:
        LEX_STRING* to LEX_STRING
        Fix comments.
        Fix and add function documentation.
        Remove Event_queue::events_count() as it is unused
        Change get_top_for_execution_if_time() to return status code as return value
        and the object is in out parameter.
        Try to detect also lock attemptions for deadlocks.
      sql/event_scheduler_ng.cc:
        Always execute on thd->mem_root
        Fix according to changed API of Event_queue::get_top_for_execution_if_time()
      sql/events.cc:
        Fix function documentation.
        Fix code after API changes of internal Event module classes.
      sql/events.h:
        sp_name -> LEX_STRINGs
      sql/sql_parse.cc:
        Fix according to changed API of Events::show_create_event()
      sql/sql_yacc.yy:
        Don't pass NULL as third parameter to sp_head::init_strings()
      42a8e2c9
  17. 10 Jul, 2006 2 commits
    • unknown's avatar
      Remove trailing whitespace. · 084f7442
      unknown authored
      After merge fixes.
      
      
      sql/event_data_objects.cc:
        after merge fix. use thd->strmake instead of strmake_root
        Remove commented out code.
        Remove trailing whitespace.
      sql/event_db_repository.cc:
        After merge fix.
        Before closing thread tables check whether table is actuall non-NULL.
        And always initialize it to NULL.
      sql/event_queue.cc:
        Remove trailing whitespace.
      sql/event_scheduler_ng.cc:
        Remove trailing whitespace.
        Tabs to spaces.
      sql/events.cc:
        Remove trailing whitespace.
      084f7442
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 974eecc2
      unknown authored
      This patch introduces specialized Event data objects
      Event_basic as parent.
      Event_queue_element used for queue storage
      Event_timed used for SHOW EVENTS/ I_S.EVENTS / SHOW CREATE EVENT
      Event_job_data using during execution.
      Methods were moved out of Event_timed to other classes.
      
      This patch also introduces Events::LOCK_event_metadata.
      This patch gives new implementation of Events::dump_internal_status().
      Now both the Event_scheduler and Event_queue return information during
      their ::dump_internal_status().
      
      Shortened a bit the runtime for executing events test cases.
      
      
      mysql-test/r/events.result:
        update results
      mysql-test/r/events_bugs.result:
        update results
      mysql-test/r/events_logs_tests.result:
        update results
      mysql-test/r/events_scheduling.result:
        update results
      mysql-test/t/events.test:
        update test
        make --sleep more appropriate . saving some time could mean failure on loaded boxes though :(
        add tests for previously uncovered branches.
      mysql-test/t/events_bugs.test:
        update test
        make --sleep more appropriate . saving some time could mean failure on loaded boxes though :(
        add tests for previously uncovered branches.
      mysql-test/t/events_logs_tests.test:
        make the test shorter by time
      mysql-test/t/events_scheduling.test:
        when selecting always use ORDER BY
      mysql-test/t/events_stress.test:
        sleep 2.5secs for shorter stress test
      sql/event_data_objects.cc:
        Event_timed is no more used during execution.
        Event_timed is no more used during in the memory queue.
        Event_timed is only used for SHOW CREATE EVENT/ I_S.EVENTS/ SHOW EVENTS
        Event_basic is the parent of almost all Event data objects.
        Event_basic -> Event_queue_element (used for the memory queue) -> Event_timed
        Event_basic -> Event_job_data (the object used for execution)
        Sql_alloc -> Event_parse_data (used during parsing)
      sql/event_data_objects.h:
        Event_timed is no more used during execution.
        Event_timed is no more used during in the memory queue.
        Event_timed is only used for SHOW CREATE EVENT/ I_S.EVENTS/ SHOW EVENTS
        Event_basic is the parent of almost all Event data objects.
        Event_basic -> Event_queue_element (used for the memory queue) -> Event_timed
        Event_basic -> Event_job_data (the object used for execution)
        Sql_alloc -> Event_parse_data (used during parsing)
      sql/event_db_repository.cc:
        Cosmetics.
        load_named_event now uses Event_basic, for polymorphism
        find_event uses Event_basic, to be polymorphic.
        use Field **fields= table->field and then index fields[...]
        Add documentation.
        Fix documentation.
      sql/event_db_repository.h:
        Event_db_repository depends only on Event_basic's interface
      sql/event_queue.cc:
        Cosmetics.
        Don't use Event_timed for the queue and giving back object for execution.
        Event_queue_element is for the queue, Event_job_data is for execution.
        Add Event_queue::dump_internal_status() for SHOW SCHEDULER STATUS command
      sql/event_queue.h:
        Cosmetics.
        Don't use Event_timed for the queue and giving back object for execution.
        Event_queue_element is for the queue, Event_job_data is for execution.
        Add Event_queue::dump_internal_status() for SHOW SCHEDULER STATUS command
      sql/event_scheduler_ng.cc:
        Add back Event_scheduler::cond_wait()
        Add back Event_scheduler::dump_internal_status()
        Using Event_job_data for execution. Make the scheduler thread unkillable (thd->command= COM_DAEMON).
        Add a lot of documentation.
      sql/event_scheduler_ng.h:
        Add back Event_scheduler::cond_wait()
        Add back Event_scheduler::dump_internal_status()
        Using Event_job_data for execution.
      sql/events.cc:
        Documentation
        Add LOCK_event_metadata
      sql/events.h:
        Change the signature of Events::drop_event() not to use sp_name but LEX_STRING
      sql/share/errmsg.txt:
        Fix error message
      sql/sql_parse.cc:
        Events::drop_event() has new signature
      974eecc2
  18. 07 Jul, 2006 1 commit
    • unknown's avatar
      Another post-merge fix. · 57a20557
      unknown authored
      sql/events.cc:
        Fix a bug I introduced with the merge: dbchanged is read
        even if it's not passed to sp_use_new_db.
      57a20557
  19. 06 Jul, 2006 1 commit
    • unknown's avatar
      After merge fixes. · 71e84df0
      unknown authored
      sql/event_timed.cc:
        After merge fixes: dbname can never be NULL.
      sql/events.cc:
        After merge fixes: use a new signature of sp_use_new_db
      sql/sp_head.cc:
        After merge fixes: replace assert with an if for events code to work.
      sql/sql_parse.cc:
        After merge fixes: put back free_items, it's used in partitioning.
        Whether it is not a bug is to be investigated.
        Remove check_db_used, as planned.
      71e84df0
  20. 05 Jul, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · b9a7fe27
      unknown authored
      Cleaned up the code a bit. Fixed few leaks.
      This code still does not load events on server startup
      from disk. The problem is that there is a need for a THD instance, which
      does not exist during server boot. This will be solved soon.
      Still Event_timed is used both for the memory queue and for exectution.
      This will be changed according to WL#3337 probably in the next commit.
      
      
      sql/event_data_objects.cc:
        Strip unneeded stuff from class Event_timed
        Event_timed is still used for the queue and execution.
        That will be changed in the next commit.
      sql/event_data_objects.h:
        Strip unneeded stuff from class Event_timed
        Event_timed is still used for the queue and execution.
        That will be changed in the next commit.
      sql/event_db_repository.cc:
        Cosmetics.
        Add a new method load_named_event_job, to be made complete in the 
        next commit. It will load from disk an instance of Event_job_data to
        be used during execution.
      sql/event_db_repository.h:
        find_event does not need MEM_ROOT anymore
        because the memory is allocated on Event's own root.
      sql/event_queue.cc:
        Remove dead code.
        Move dumping of the queue to separate method.
        Make critical sections in create_event & update_event
        as small as possible - load the new event outside of the section
        and free the object also outside of it.
      sql/event_queue.h:
        init -> init_queue -> easier for ctags
        deinit -> deinit_queue -> easier for ctags
      sql/event_scheduler.cc:
        empty this file
      sql/event_scheduler.h:
        empty this file
      sql/event_scheduler_ng.cc:
        add back DBUG_RETURN(0) in thread handlers.
        We don't stop running events when stopping the scheduler. Therefore
        remove this method now. If it is needed later it can be added back.
      sql/event_scheduler_ng.h:
        Remove stop_all_running_threads()
        init -> init_scheduler
        deinit -> deinit_scheduler
        easier for ctags
      sql/events.cc:
        Cosmetics
      sql/events.h:
        Cosmetics
      sql/set_var.cc:
        Remove references to dead code
      sql/sql_parse.cc:
        Reorganize a bit.
      b9a7fe27
  21. 04 Jul, 2006 1 commit
    • unknown's avatar
      WL #3337 (Event scheduler new architecture) · a5dfeb02
      unknown authored
      Cut Nr. 8.
      
      All tests pass.
      
      Separated Event_scheduler into Event_queue and Event_scheduler.
      Added new Event_scheduler_ng which is the new scheduler and is used
      system-wide. Will be moved to the event_scheduler.cc in the future.
      Using Event_timed in Event_queue as well as cloned during execution.
      Next step is to have Event_worker_data which will be used during execution
      and will take ::compile()/::execute() out of Event_timed.
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/r/events_bugs.result:
        update result
      mysql-test/r/ps_1general.result:
        update result
      mysql-test/r/skip_name_resolve.result:
        update result
      mysql-test/r/sp-threads.result:
        update result
      mysql-test/r/sp_notembedded.result:
        update result
      mysql-test/r/status.result:
        update result
      mysql-test/t/events_stress.test:
        Make event_stress a bit longer
      sql/Makefile.am:
        Add new event_scheduler_ng.h/cc . These are only to be in the experimental
        clone. Later their content will be moved to event_scheduler.h/cc
      sql/event_data_objects.cc:
        Allocate strings memory on own memory root, instead
        on the schedulers. Thus don't "leak" memory. This should
        fix bug#18683 memory leak in event scheduler
      sql/event_data_objects.h:
        add mem_root
        add THD - this is only temporal, will be moved to class Event_job_data
        once Event_job_data is responsible for the execution.
      sql/event_db_repository.cc:
        Remove unused code.
        Cosmetic changes
      sql/event_queue.cc:
        Now use the Event_scheduler_ng (NextGen)
      sql/event_queue.h:
        Now use the Event_scheduler_ng (NextGen)
      sql/event_scheduler.cc:
        This file is no more used, but will be soon.
      sql/event_scheduler.h:
        This file is no more used but will be soon
      sql/events.cc:
        Now use the Event_scheduler_ng (NextGen)
      sql/events.h:
        Now use the Event_scheduler_ng (NextGen)
      sql/mysqld.cc:
        Make it again possible to kill the scheduler thread
      sql/set_var.cc:
        Now use the Event_scheduler_ng (NextGen)
      sql/share/errmsg.txt:
        Shorten the message.
      sql/sql_show.cc:
        Loading is on a own root, then don't use thd->mem_root
      a5dfeb02
  22. 03 Jul, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 377446fa
      unknown authored
      This is the first cut of separating Event_scheduler in two
      classes which are more specialized.
      Inheritance was used to separate methods and member variables.
      Still Event_scheduler is a child of Event_queue. This dependency
      will be removed soon.
      
      
      sql/event_data_objects.cc:
        add comments
      sql/event_db_repository.cc:
        coding style
      sql/event_db_repository.h:
        add a call, will be implemented later
      sql/event_queue.cc:
        Event_queue, still as super-class of Event_scheduler
      sql/event_queue.h:
        Event_queue as super-class of Event_scheduler. Trying to
        separate the two classes
      sql/event_scheduler.cc:
        Event_scheduler as child class of Event_queue.
        Trying to separate both classes.
      sql/event_scheduler.h:
        Event_scheduler as child class of Event_queue.
        Trying to separate both classes.
      sql/events.cc:
        Don't allocate on the stack the scheduler but on the heap.
        The exact way it is done will be changed, that's ok for now.
      377446fa
  23. 28 Jun, 2006 4 commits
    • unknown's avatar
      WL#3337 (Events new architecture) · 9fa9378b
      unknown authored
      This cut No 7 should finish the part of fixing the parsing of the events :
      - Event_timed is no more used during parsing. Less problems because it has
        a mutex. Event_parse_data class is used during parsing. It is suited only
        for this purpose. It's pretty lightweight
      - Late checking of data from parsing is being performed. This should solve
        the problems of nested events in SP or other events (for the situation 
        of no nested bodies). Before if an ALTER EVENT was in a SP, then when the
        SP was compiled, and not executed, the actual init_xxx methods of Event_timed
        were called, which is wrong.
      - It could be a side effect of using a specialized class, but test events_stress is
        now 25% quicker.
      
      Cut No8 will start splitting Event_scheduler into 2 parts, the QUEUE will be moved
      to Event_queue.
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/t/events.test:
        disabled is actually wrong, should be disable, but because of the early
        checking it was never parsed.
      sql/event_data_objects.cc:
        move add init_xxx methods from Event_timed to Event_parse_data
        Event_parse data does not need definer_user and definer_host
        in Event_timed::compile() do not use lex.et, well there is no more lex.et :)
      sql/event_data_objects.h:
        move parsing responsibilities from Event_timed to Event_parse_data
      sql/event_db_repository.cc:
        No more Event_timed comes from parsing but Event_parse_data
        The initialization of Item*-s from parsing is done late, and not
        during the actual parsing. This is the right way to go because
        if an ALTER EVENT is inside a SP or CREATE EVENT it should not be
        executed (initialized) during parsing, as it was done.
      sql/event_db_repository.h:
        No more Event_timed comes from parsing but Event_parse_data
        The initialization of Item*-s from parsing is done late, and not
        during the actual parsing. This is the right way to go because
        if an ALTER EVENT is inside a SP or CREATE EVENT it should not be
        executed (initialized) during parsing, as it was done.
      sql/event_scheduler.cc:
        No more Event_timed comes from parsing but Event_parse_data
        The initialization of Item*-s from parsing is done late, and not
        during the actual parsing. This is the right way to go because
        if an ALTER EVENT is inside a SP or CREATE EVENT it should not be
        executed (initialized) during parsing, as it was done.
      sql/event_scheduler.h:
        No more Event_timed comes from parsing but Event_parse_data
        The initialization of Item*-s from parsing is done late, and not
        during the actual parsing. This is the right way to go because
        if an ALTER EVENT is inside a SP or CREATE EVENT it should not be
        executed (initialized) during parsing, as it was done.
      sql/events.cc:
        No more Event_timed comes from parsing but Event_parse_data
        The initialization of Item*-s from parsing is done late, and not
        during the actual parsing. This is the right way to go because
        if an ALTER EVENT is inside a SP or CREATE EVENT it should not be
        executed (initialized) during parsing, as it was done.
      sql/events.h:
        No more Event_timed comes from parsing but Event_parse_data
        The initialization of Item*-s from parsing is done late, and not
        during the actual parsing. This is the right way to go because
        if an ALTER EVENT is inside a SP or CREATE EVENT it should not be
        executed (initialized) during parsing, as it was done.
      sql/sql_lex.cc:
        lex->et_compile_phase and lex->et are no more.
        Use lex->event_parse_data
      sql/sql_lex.h:
        lex->et_compile_phase and lex->et are no more.
        Use lex->event_parse_data
      sql/sql_parse.cc:
        lex->et_compile_phase and lex->et are no more.
        Use lex->event_parse_data
        ACL checks were moved inside the Events subsystem.
        Also ending of the transaction is performed only just
        before doing disk operation. Therefore only when needed.
      sql/sql_yacc.yy:
        lex->et and lex->et_parse_phase are no more
        Use the specialized for parsing Event_parse_data
      9fa9378b
    • unknown's avatar
      after merge fix · 739ea377
      unknown authored
      739ea377
    • unknown's avatar
      WL#3337 (Events new architecture) · 400276c2
      unknown authored
      Cut 7 (refactoring)
      
      db_repository is no more embedded in the Events
      singleton. Therefore a change to Events_db_repository
      won't mean recompile of all files in the server which include events.h
      
      
      sql/event_data_objects.cc:
        db_repository is no more embedded in the Events
        singleton. Therefore a change to Events_db_repository
        won't mean recompile of all files in the server which include events.h
      sql/event_db_repository.cc:
        db_repository is no more embedded in the Events
        singleton. Therefore a change to Events_db_repository
        won't mean recompile of all files in the server which include events.h
      sql/events.cc:
        db_repository is no more embedded in the Events
        singleton. Therefore a change to Events_db_repository
        won't mean recompile of all files in the server which include events.h
      sql/events.h:
        db_repository is no more embedded in the Events
        singleton. Therefore a change to Events_db_repository
        won't mean recompile of all files in the server which include events.h
      sql/mysqld.cc:
        db_repository is no more embedded in the Events
        singleton. Therefore a change to Events_db_repository
        won't mean recompile of all files in the server which include events.h
      400276c2
    • unknown's avatar
      WL#3337 (Events new architecture) · 8ca78787
      unknown authored
      Cut number 6. Move code from sql_show.cc to event_db_repository.cc
      that more belongs to the latter.
      
      
      sql/event_db_repository.cc:
        move code that works with mysql.event from sql_show.cc to 
        event_db_repository.cc . Route through Event_db_repository's interface
        which is proxied by class Events. The code relies on a function from
        sql_show.cc which does the actual storage in the schema table. I think
        it's better to leave the function there because the structure of 
        I_S.EVENTS is defined in sql_show.cc
      sql/event_db_repository.h:
        I_S / SHOW EVENTS handling hooks
      sql/event_scheduler.cc:
        use the pointer to db_repository which Event_scheduler already has
      sql/events.cc:
        Put a comment to get_instance
      sql/events.h:
        callback for I_S (sql_show.cc)
      sql/sql_show.cc:
        move code that belongs more to Event_db_repository than to here.
        Use a callback of class Events. Only 1 function is left here, because
        it copies data into the actual rows of I_S.EVENTS and belongs to this file.
      sql/sql_show.h:
        export this function will be called from event_db_repository.cc
      8ca78787
  24. 27 Jun, 2006 4 commits
    • unknown's avatar
      WL#3337 (Events new architecture) · acefb78b
      unknown authored
      5th cut, moved DB related code to Event_db_repository and
      updated accordingly the remanining code.
      Moved change/restore_security_context() to class THD
      Removed events_priv.h
      Next step is to reorganize create/update_event() and parsing for them.
      But probably some other refactoring could be done in the meanwhile.
      The changes so far pass the test suite.
      
      
      BitKeeper/deleted/.del-events_priv.h~2e8bce2cf35997df:
        Delete: sql/events_priv.h
      sql/Makefile.am:
        events_priv.h is no more
      sql/event_data_objects.cc:
        reorganize events code
      sql/event_data_objects.h:
        reorganize events code
      sql/event_db_repository.cc:
        reorganize events code
      sql/event_db_repository.h:
        reorganize events code
      sql/event_scheduler.cc:
        reorganize events code
      sql/event_scheduler.h:
        reorganize events code
      sql/events.cc:
        reorganize events code
      sql/events.h:
        reorganize events code
      sql/mysqld.cc:
        reorganize events code
      sql/set_var.cc:
        reorganize events code
      sql/sql_class.cc:
        add ::change_security_context() and restore_security_context()
      sql/sql_class.h:
        add ::change_security_context() and restore_security_context()
      sql/sql_db.cc:
        reorganize Events code
      sql/sql_parse.cc:
        reorganize Events code
      sql/sql_show.cc:
        reorganize Events code
      acefb78b
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · ef9a97e6
      unknown authored
      Third cut to simplify parsing phase. Now DROP EVENT works.
      
      Overloaded few functions to be able to use either sp_name or pass two LEX_STRINGs
      instead of a Event_timed pointer. This is transitional and eventually the old
      functions will be removed. For now DROP EVENT also works, does not need anymore
      a parsing object (Event_timed) and definer initialization because everyone who
      has EVENT_ACL can drop events, and this is checked on execution time in sql_parse.cc
      from the security context, as it should be.
      
      
      sql/event_data_objects.cc:
        overload few functions
      sql/event_scheduler.cc:
        Event_scheduler::drop_event() actually does not need Event_timed object
        but just an identifier, hence pass only sp_name.
        
        Overloaded Event_scheduler::find_event() to work with sp_name object. Eventually
        the old version will be removed. This is being done as transitional step to
        be able to test frequently code.
      sql/event_scheduler.h:
        Event_scheduler::drop_event() actually does not need Event_timed object
        but just an identifier, hence pass only sp_name.
        
        Overloaded Event_scheduler::find_event() to work with sp_name object. Eventually
        the old version will be removed. This is being done as transitional step to
        be able to test frequently code.
      sql/events.cc:
        Change db_drop_event() not to use Event_timed, either coming from parsing
        or from Event_timed::drop, but use LEX_STRINGs. sp_name is not convinient
        because in Event_timed::drop a temporary object has to be created. Hence, 
        dereference the sp_name in Events::drop_event() and pass the LEX_STRINGs.
      sql/events.h:
        Change db_drop_event() not to use Event_timed, either coming from parsing
        or from Event_timed::drop, but use LEX_STRINGs. sp_name is not convinient
        because in Event_timed::drop a temporary object has to be created. Hence, 
        dereference the sp_name in Events::drop_event() and pass the LEX_STRINGs.
      sql/events_priv.h:
        Change db_drop_event() not to use Event_timed, either coming from parsing
        or from Event_timed::drop, but use LEX_STRINGs. sp_name is not convinient
        because in Event_timed::drop a temporary object has to be created. Hence, 
        dereference the sp_name in Events::drop_event() and pass the LEX_STRINGs.
      sql/sql_parse.cc:
        SQLCOM_DROP_EVENT does not need lex->event_parse_data object and 
        is more like SQLCOM_SHOW_CREATE_EVENT. Therefore, move it to the block that
        handles the latter.
      sql/sql_yacc.yy:
        DROP EVENT does not need a parsing object, just a name.
        Store it as lex->spname. Pretty similar handling to the one of
        SHOW CREATE EVENT.
      ef9a97e6
    • unknown's avatar
      WL#3337 (Events new infrasctructure) · d2db48c6
      unknown authored
      Second cut of separating parsing phase from execution phase
      Separate Event_timed from parsing phase and introducing Event_parse_data.
      
      
      sql/event_data_objects.cc:
        second cut,
        copy Event_timed::init_body() to Event_parse_data::init_body()
        Init the body during parsing, everything else keep as a pointer to
        Item or some other pointer to use for later initialization.
      sql/event_data_objects.h:
        get the identifier as sp_name*, later will initialize our structures
      sql/events.cc:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      sql/events.h:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      BitKeeper/etc/ignore:
        Added libmysql/viosocket.o.6WmSJk libmysqld/event_data_objects.cc libmysqld/event_db_repository.cc libmysqld/event_queue.cc server-tools/instance-manager/net_serv.cc to the ignore list
      sql/share/errmsg.txt:
        remove this message, not used and needed for now
      sql/sql_lex.h:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      sql/sql_parse.cc:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      sql/sql_yacc.yy:
        for easy transition add temporarily parse_data, later Event_timed *et will be removed.
        Do slow transition because Event_timed is so tightly integrated that a front-attack
        by removing things from this class was unsuccessful. Do things step by step by eliminating
        dependencies. Hence, the code could be checked with the current test suite too
        (early testing)
      d2db48c6
    • unknown's avatar
      first cut of WL#3337 (New event scheduler locking infrastructure). · e5f8163b
      unknown authored
      Infrastructure built. Added the  foreseen files and change Makefile.am/CMakeLists.txt
      accordingly.
      
      
      libmysqld/Makefile.am:
        add new files. this is first cut of WL3337u
      sql/CMakeLists.txt:
        add more files to build
      sql/Makefile.am:
        add new files. this is first cut of WL3337
      sql/event_scheduler.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/events.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/share/errmsg.txt:
        new error message
      sql/event_data_objects.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/event_data_objects.h:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/sql_parse.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/sql_show.cc:
        event_timed.h -> event_data_objects.h (WL#3337)
      sql/sql_yacc.yy:
        event_timed.h -> event_data_objects.h (WL#3337)
      e5f8163b
  25. 08 Jun, 2006 1 commit
    • unknown's avatar
      Reorganize, physically the events code · 99438424
      unknown authored
      Unify method naming -> create/update/drop_event
      Move class Event_timed to event_timed.h
      class Events is in events.h (renamed from event.h)
      The implementation is in events.cc (renamed from event.h)
      
      
      BitKeeper/deleted/.del-event_executor.cc~f4a4645b973838ab:
        Delete: sql/event_executor.cc
      include/my_time.h:
        add a boundary
      libmysqld/CMakeLists.txt:
        event.cc -> events.cc
      libmysqld/Makefile.am:
        event.cc -> event.cc
      sql/CMakeLists.txt:
        event.cc -> events.cc
      sql/Makefile.am:
        event.cc -> events.cc
        event_priv.h -> events_priv.h
      sql/event_scheduler.cc:
        event.h -> events.h
        add_event -> create_event
        replace_event -> update_event()
        event_timed_compare_q is only used in event_scheduler.cc , so moving it
        from event.cc and making it static
      sql/event_scheduler.h:
        add_event -> create_event
        replace_event -> update_event
      sql/event_timed.cc:
        moved extern interval_type_to_name to mysql_priv.h
      sql/mysql_priv.h:
        moved my_time_compare to time.cc
      sql/mysqld.cc:
        event.h -> events.h
      sql/sql_db.cc:
        event.h -> events.h
      sql/sql_parse.cc:
        event.h -> events.h
        class Event_timed moved to event_timed.h
      sql/sql_show.cc:
        event.h -> events.h
        class Event_timed moved to event_timed.h
      sql/sql_yacc.yy:
        event.h -> events.h
        class Event_timed moved to event_timed.h
      sql/events.cc:
        add_event -> create_event
        replace_event -> update_event
        event_timed_compare_q moved to event_scheduler.cc
      sql/events.h:
        class Event_timed moved to event_timed.h
      sql/events_priv.h:
        my_time_compare moved to mysql_priv.h
        event_timed_compare_q is static in event_scheduler.cc
      sql/time.cc:
        moved interval_type_to_name from event.cc to here.
      BitKeeper/etc/ignore:
        Added libmysqld/events.cc to the ignore list
      99438424
  26. 04 Jun, 2006 1 commit
    • unknown's avatar
      This changeset is largely a handler cleanup changeset (WL#3281), but includes... · 01d03e7b
      unknown authored
      This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
      
      Changes that requires code changes in other code of other storage engines.
      (Note that all changes are very straightforward and one should find all issues
      by compiling a --debug build and fixing all compiler errors and all
      asserts in field.cc while running the test suite),
      
      - New optional handler function introduced: reset()
        This is called after every DML statement to make it easy for a handler to
        statement specific cleanups.
        (The only case it's not called is if force the file to be closed)
      
      - handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
        should be moved to handler::reset()
      
      - table->read_set contains a bitmap over all columns that are needed
        in the query.  read_row() and similar functions only needs to read these
        columns
      - table->write_set contains a bitmap over all columns that will be updated
        in the query. write_row() and update_row() only needs to update these
        columns.
        The above bitmaps should now be up to date in all context
        (including ALTER TABLE, filesort()).
      
        The handler is informed of any changes to the bitmap after
        fix_fields() by calling the virtual function
        handler::column_bitmaps_signal(). If the handler does caching of
        these bitmaps (instead of using table->read_set, table->write_set),
        it should redo the caching in this code. as the signal() may be sent
        several times, it's probably best to set a variable in the signal
        and redo the caching on read_row() / write_row() if the variable was
        set.
      
      - Removed the read_set and write_set bitmap objects from the handler class
      
      - Removed all column bit handling functions from the handler class.
        (Now one instead uses the normal bitmap functions in my_bitmap.c instead
        of handler dedicated bitmap functions)
      
      - field->query_id is removed. One should instead instead check
        table->read_set and table->write_set if a field is used in the query.
      
      - handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
        handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
        instead use table->read_set to check for which columns to retrieve.
      
      - If a handler needs to call Field->val() or Field->store() on columns
        that are not used in the query, one should install a temporary
        all-columns-used map while doing so. For this, we provide the following
        functions:
      
        my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
        field->val();
        dbug_tmp_restore_column_map(table->read_set, old_map);
      
        and similar for the write map:
      
        my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
        field->val();
        dbug_tmp_restore_column_map(table->write_set, old_map);
      
        If this is not done, you will sooner or later hit a DBUG_ASSERT
        in the field store() / val() functions.
        (For not DBUG binaries, the dbug_tmp_restore_column_map() and
        dbug_tmp_restore_column_map() are inline dummy functions and should
        be optimized away be the compiler).
      
      - If one needs to temporary set the column map for all binaries (and not
        just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
        methods) one should use the functions tmp_use_all_columns() and
        tmp_restore_column_map() instead of the above dbug_ variants.
      
      - All 'status' fields in the handler base class (like records,
        data_file_length etc) are now stored in a 'stats' struct. This makes
        it easier to know what status variables are provided by the base
        handler.  This requires some trivial variable names in the extra()
        function.
      
      - New virtual function handler::records().  This is called to optimize
        COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
        (stats.records is not supposed to be an exact value. It's only has to
        be 'reasonable enough' for the optimizer to be able to choose a good
        optimization path).
      
      - Non virtual handler::init() function added for caching of virtual
        constants from engine.
      
      - Removed has_transactions() virtual method. Now one should instead return
        HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
        transactions.
      
      - The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
        that is to be used with 'new handler_name()' to allocate the handler
        in the right area.  The xxxx_create_handler() function is also
        responsible for any initialization of the object before returning.
      
        For example, one should change:
      
        static handler *myisam_create_handler(TABLE_SHARE *table)
        {
          return new ha_myisam(table);
        }
      
        ->
      
        static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
        {
          return new (mem_root) ha_myisam(table);
        }
      
      - New optional virtual function: use_hidden_primary_key().
        This is called in case of an update/delete when
        (table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
        but we don't have a primary key. This allows the handler to take precisions
        in remembering any hidden primary key to able to update/delete any
        found row. The default handler marks all columns to be read.
      
      - handler::table_flags() now returns a ulonglong (to allow for more flags).
      
      - New/changed table_flags()
        - HA_HAS_RECORDS	    Set if ::records() is supported
        - HA_NO_TRANSACTIONS	    Set if engine doesn't support transactions
        - HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
                                  Set if we should mark all primary key columns for
      			    read when reading rows as part of a DELETE
      			    statement. If there is no primary key,
      			    all columns are marked for read.
        - HA_PARTIAL_COLUMN_READ  Set if engine will not read all columns in some
      			    cases (based on table->read_set)
       - HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
         			    Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
       - HA_DUPP_POS              Renamed to HA_DUPLICATE_POS
       - HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
      			    Set this if we should mark ALL key columns for
      			    read when when reading rows as part of a DELETE
      			    statement. In case of an update we will mark
      			    all keys for read for which key part changed
      			    value.
        - HA_STATS_RECORDS_IS_EXACT
      			     Set this if stats.records is exact.
      			     (This saves us some extra records() calls
      			     when optimizing COUNT(*))
      			    
      
      - Removed table_flags()
        - HA_NOT_EXACT_COUNT     Now one should instead use HA_HAS_RECORDS if
      			   handler::records() gives an exact count() and
      			   HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
        - HA_READ_RND_SAME	   Removed (no one supported this one)
      
      - Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
      
      - Renamed handler::dupp_pos to handler::dup_pos
      
      - Removed not used variable handler::sortkey
      
      
      Upper level handler changes:
      
      - ha_reset() now does some overall checks and calls ::reset()
      - ha_table_flags() added. This is a cached version of table_flags(). The
        cache is updated on engine creation time and updated on open.
      
      
      MySQL level changes (not obvious from the above):
      
      - DBUG_ASSERT() added to check that column usage matches what is set
        in the column usage bit maps. (This found a LOT of bugs in current
        column marking code).
      
      - In 5.1 before, all used columns was marked in read_set and only updated
        columns was marked in write_set. Now we only mark columns for which we
        need a value in read_set.
      
      - Column bitmaps are created in open_binary_frm() and open_table_from_share().
        (Before this was in table.cc)
      
      - handler::table_flags() calls are replaced with handler::ha_table_flags()
      
      - For calling field->val() you must have the corresponding bit set in
        table->read_set. For calling field->store() you must have the
        corresponding bit set in table->write_set. (There are asserts in
        all store()/val() functions to catch wrong usage)
      
      - thd->set_query_id is renamed to thd->mark_used_columns and instead
        of setting this to an integer value, this has now the values:
        MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
        Changed also all variables named 'set_query_id' to mark_used_columns.
      
      - In filesort() we now inform the handler of exactly which columns are needed
        doing the sort and choosing the rows.
      
      - The TABLE_SHARE object has a 'all_set' column bitmap one can use
        when one needs a column bitmap with all columns set.
        (This is used for table->use_all_columns() and other places)
      
      - The TABLE object has 3 column bitmaps:
        - def_read_set     Default bitmap for columns to be read
        - def_write_set    Default bitmap for columns to be written
        - tmp_set          Can be used as a temporary bitmap when needed.
        The table object has also two pointer to bitmaps read_set and write_set
        that the handler should use to find out which columns are used in which way.
      
      - count() optimization now calls handler::records() instead of using
        handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
      
      - Added extra argument to Item::walk() to indicate if we should also
        traverse sub queries.
      
      - Added TABLE parameter to cp_buffer_from_ref()
      
      - Don't close tables created with CREATE ... SELECT but keep them in
        the table cache. (Faster usage of newly created tables).
      
      
      New interfaces:
      
      - table->clear_column_bitmaps() to initialize the bitmaps for tables
        at start of new statements.
      
      - table->column_bitmaps_set() to set up new column bitmaps and signal
        the handler about this.
      
      - table->column_bitmaps_set_no_signal() for some few cases where we need
        to setup new column bitmaps but don't signal the handler (as the handler
        has already been signaled about these before). Used for the momement
        only in opt_range.cc when doing ROR scans.
      
      - table->use_all_columns() to install a bitmap where all columns are marked
        as use in the read and the write set.
      
      - table->default_column_bitmaps() to install the normal read and write
        column bitmaps, but not signaling the handler about this.
        This is mainly used when creating TABLE instances.
      
      - table->mark_columns_needed_for_delete(),
        table->mark_columns_needed_for_delete() and
        table->mark_columns_needed_for_insert() to allow us to put additional
        columns in column usage maps if handler so requires.
        (The handler indicates what it neads in handler->table_flags())
      
      - table->prepare_for_position() to allow us to tell handler that it
        needs to read primary key parts to be able to store them in
        future table->position() calls.
        (This replaces the table->file->ha_retrieve_all_pk function)
      
      - table->mark_auto_increment_column() to tell handler are going to update
        columns part of any auto_increment key.
      
      - table->mark_columns_used_by_index() to mark all columns that is part of
        an index.  It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
        it to quickly know that it only needs to read colums that are part
        of the key.  (The handler can also use the column map for detecting this,
        but simpler/faster handler can just monitor the extra() call).
      
      - table->mark_columns_used_by_index_no_reset() to in addition to other columns,
        also mark all columns that is used by the given key.
      
      - table->restore_column_maps_after_mark_index() to restore to default
        column maps after a call to table->mark_columns_used_by_index().
      
      - New item function register_field_in_read_map(), for marking used columns
        in table->read_map. Used by filesort() to mark all used columns
      
      - Maintain in TABLE->merge_keys set of all keys that are used in query.
        (Simplices some optimization loops)
      
      - Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
        but the field in the clustered key is not assumed to be part of all index.
        (used in opt_range.cc for faster loops)
      
      -  dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
         tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
         mark all columns as usable.  The 'dbug_' version is primarily intended
         inside a handler when it wants to just call Field:store() & Field::val()
         functions, but don't need the column maps set for any other usage.
         (ie:: bitmap_is_set() is never called)
      
      - We can't use compare_records() to skip updates for handlers that returns
        a partial column set and the read_set doesn't cover all columns in the
        write set. The reason for this is that if we have a column marked only for
        write we can't in the MySQL level know if the value changed or not.
        The reason this worked before was that MySQL marked all to be written
        columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
        bug'.
      
      - open_table_from_share() does not anymore setup temporary MEM_ROOT
        object as a thread specific variable for the handler. Instead we
        send the to-be-used MEMROOT to get_new_handler().
        (Simpler, faster code)
      
      
      
      Bugs fixed:
      
      - Column marking was not done correctly in a lot of cases.
        (ALTER TABLE, when using triggers, auto_increment fields etc)
        (Could potentially result in wrong values inserted in table handlers
        relying on that the old column maps or field->set_query_id was correct)
        Especially when it comes to triggers, there may be cases where the
        old code would cause lost/wrong values for NDB and/or InnoDB tables.
      
      - Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
        OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
        This allowed me to remove some wrong warnings about:
        "Some non-transactional changed tables couldn't be rolled back"
      
      - Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
        (thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
        some warnings about
        "Some non-transactional changed tables couldn't be rolled back")
      
      - Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
        which could cause delete_table to report random failures.
      
      - Fixed core dumps for some tests when running with --debug
      
      - Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
        (This has probably caused us to not properly remove temporary files after
        crash)
      
      - slow_logs was not properly initialized, which could maybe cause
        extra/lost entries in slow log.
      
      - If we get an duplicate row on insert, change column map to read and
        write all columns while retrying the operation. This is required by
        the definition of REPLACE and also ensures that fields that are only
        part of UPDATE are properly handled.  This fixed a bug in NDB and
        REPLACE where REPLACE wrongly copied some column values from the replaced
        row.
      
      - For table handler that doesn't support NULL in keys, we would give an error
        when creating a primary key with NULL fields, even after the fields has been
        automaticly converted to NOT NULL.
      
      - Creating a primary key on a SPATIAL key, would fail if field was not
        declared as NOT NULL.
      
      
      Cleanups:
      
      - Removed not used condition argument to setup_tables
      
      - Removed not needed item function reset_query_id_processor().
      
      - Field->add_index is removed. Now this is instead maintained in
        (field->flags & FIELD_IN_ADD_INDEX)
      
      - Field->fieldnr is removed (use field->field_index instead)
      
      - New argument to filesort() to indicate that it should return a set of
        row pointers (not used columns). This allowed me to remove some references
        to sql_command in filesort and should also enable us to return column
        results in some cases where we couldn't before.
      
      - Changed column bitmap handling in opt_range.cc to be aligned with TABLE
        bitmap, which allowed me to use bitmap functions instead of looping over
        all fields to create some needed bitmaps. (Faster and smaller code)
      
      - Broke up found too long lines
      
      - Moved some variable declaration at start of function for better code
        readability.
      
      - Removed some not used arguments from functions.
        (setup_fields(), mysql_prepare_insert_check_table())
      
      - setup_fields() now takes an enum instead of an int for marking columns
         usage.
      
      - For internal temporary tables, use handler::write_row(),
        handler::delete_row() and handler::update_row() instead of
        handler::ha_xxxx() for faster execution.
      
      - Changed some constants to enum's and define's.
      
      - Using separate column read and write sets allows for easier checking
        of timestamp field was set by statement.
      
      - Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
      
      - Don't build table->normalized_path as this is now identical to table->path
        (after bar's fixes to convert filenames)
      
      - Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
        do comparision with the 'convert-dbug-for-diff' tool.
      
      
      Things left to do in 5.1:
      
      - We wrongly log failed CREATE TABLE ... SELECT in some cases when using
        row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
        Mats has promised to look into this.
      
      - Test that my fix for CREATE TABLE ... SELECT is indeed correct.
        (I added several test cases for this, but in this case it's better that
        someone else also tests this throughly).
        Lars has promosed to do this.
      
      
      BitKeeper/etc/ignore:
        added mysys/test_bitmap
      include/base64.h:
        Removed my_global.h, as this must be included first in any program
      include/heap.h:
        Added heap_reset() (Required by new handler interface)
      include/my_base.h:
        Removed HA_EXTRA_RESET. MySQL will now call ::reset() instead of ::extra(HA_EXTRA_RESET).
        HA_EXTRA_RETRIVE_ALL_COLS and HA_EXTRA_RETRIVE_PRIMARY key are deleted as the column bitmaps makes these unnecessary
      include/my_bitmap.h:
        Remove my_pthread.h (should be included at upper level)
        Introduced my_bitmap_map typedef to make it the bitmap handling more like a black box
        Added bitmap_is_overlapping(), bitmap_test_and_clear(), bitmap_copy() and bitmap_cmp()
        Made bitmap_set_bit(), bitmap_flip_bit(), bitmap_clear_bit() return void
      include/myisam.h:
        Added mi_reset() (Required by new handler interface)
      include/myisammrg.h:
        Added myrg_reset() (Required by new handler interface)
      include/mysql_com.h:
        Added flag FIELD_IN_ADD_INDEX to be able to remove Field->add_index
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        Added testing of CREATE ... SELECT in a mixed environment
        (This found some bugs that Mats is going to fix shortly)
      mysql-test/install_test_db.sh:
        Simplify ldata usage
        Added --tmpdir=. option to mysqld bootstrap (Removed some warnings when TMPDIR was wrongly set)
      mysql-test/mysql-test-run.pl:
        Added --tmpdir=. to bootstrap
      mysql-test/mysql-test-run.sh:
        Use copy instead of INSTALL_DB for master and slave databases.
        (Speeds up startup time a lot!)
        Remove snapshot directories at startup (removes some strange warnings)
      mysql-test/r/binlog_row_mix_innodb_myisam.result:
        Added testing of CREATE ... SELECT in a mixed environment
        (This found some bugs that Mats is going to fix shortly)
      mysql-test/r/binlog_stm_mix_innodb_myisam.result:
        Added testing of CREATE ... SELECT in a mixed environment
      mysql-test/r/create.result:
        Some extra tests of warnings and number of tables opened by CREATE ... SELECT
      mysql-test/r/federated.result:
        Drop some left over tables
        Added testing of multiple table update and multiple table delete (with and without keys)
      mysql-test/r/func_gconcat.result:
        Enable some disabled tests (converted them slightly to be predictable)
      mysql-test/r/func_time.result:
        Added drop of test function
      mysql-test/r/innodb_mysql.result:
        Added tests for CREATE ... SELECT
      mysql-test/r/insert.result:
        More tests
        Added testing of duplicate columns in insert
      mysql-test/r/loaddata.result:
        Added testing LOAD DATA ... SET ...
      mysql-test/r/multi_update.result:
        Test multi updates and deletes using primary key and without
      mysql-test/r/ndb_index_unique.result:
        Better error message
      mysql-test/r/ndb_replace.result:
        New correct result after fixing REPLACE handling with NDB
      mysql-test/r/rpl_ddl.result:
        Now we don't get these (wrong) warnings anymore
      mysql-test/r/view_grant.result:
        Drop used views
      mysql-test/t/create.test:
        Some extra tests of warnings and number of tables opened by CREATE ... SELECT
      mysql-test/t/federated.test:
        Drop some left over tables
        Added testing of multiple table update and multiple table delete (with and without keys)
      mysql-test/t/func_gconcat.test:
        Enable some disabled tests (converted them slightly to be predictable)
      mysql-test/t/func_time.test:
        Added drop of test function
      mysql-test/t/innodb_mysql.test:
        Added tests for CREATE ... SELECT
      mysql-test/t/insert.test:
        More tests
        Added testing of duplicate columns in insert
      mysql-test/t/loaddata.test:
        Added testing LOAD DATA ... SET ...
      mysql-test/t/multi_update.test:
        Test multi updates and deletes using primary key and without
      mysql-test/t/view_grant.test:
        Drop used views
      mysql-test/valgrind.supp:
        Added supression of not needed warnings when printing stack trace
      mysys/base64.c:
        Include my_global.h first
      mysys/my_bitmap.c:
        Added bitmap_is_overlapping(), bitmap_test_and_clear() and bitmap_copy()
        Changed logic of bitmap handling to be a bit more efficent (Did this together with Mikael Ronström)
        Now the 'extra, not used bits' in the bitmap are assumed to have a 'random value' and the bitmap functions are free to change them whenever needed.
        Changed how mutex is allocated to make 'bitmap_free()' function simpler.
      mysys/thr_lock.c:
        Added 0x before thread pointers (for easier comparison of DBUG traces)
      sql/event.cc:
        Ensure 'use_all_columns()' is used for event tables
        Don't print warning that event table is damaged if it doesn't exists.
      sql/field.cc:
        Added ASSERT_COLUMN_MARKED_FOR_WRITE in all store() methods and ASSERT_COLUMN_MARKED_FOR_READ in all val() methods to catch wrong setting if table->read_set and table->write_set
        (Rest of changes are only indentation cleanups)
      sql/field.h:
        Removed Field->query_id (replaced by table->read_set and table->write_set)
        Removed Field->fieldnr (use Field->field_index instead)
        Removed Field->add_index (Use Field->flags instead)
        Add Field->part_of_key_not_clustered (for usage in opt_range.cc)
      sql/filesort.cc:
        Added paramater sort_postion to filesort() to force sorting by position instead of storing all fields in the result set.
        This allowed me to remove checking of sql_command.
        Create a temporary column bitmap for fields that are used by the sorting process.
        Use column bitmaps instead of query_id
      sql/ha_berkeley.cc:
        Update to 'newer' table handler interface
      sql/ha_berkeley.h:
        Update to 'newer' table handler interface
      sql/ha_federated.cc:
        Update to 'newer' table handler interface
        Only read columns that are needed from remote server.
        In case of eq ranges, don't generate two conditions in the WHERE clause
        (this can still be optimized, but would require a bigger code change)
        Use 'simpler to use' XXXX_LEN' macros
        A bit simpler logic in ::write_row() when creating statements.
        In update, only include test of fields actually read.
        (This greatly simplifies the queries sent by the federated engine)
        Similar changes done for delete_row()
      sql/ha_federated.h:
        Update to 'newer' table handler interface
        Changed XXX_LEN macros to use sizeof(...)-1, to simplify usage in ha_federated.cc
        Added HA_PRIMARY_KEY_REQUIRED_FOR_DELETE to tell MySQL to read all primary key columns in case of DELETE
      sql/ha_heap.cc:
        Update to 'newer' table handler interface
      sql/ha_heap.h:
        Update to 'newer' table handler interface
      sql/ha_innodb.cc:
        Update to 'newer' table handler interface
        - Update innobase_create_handler() to new interface
        - Removed HA_NOT_EXACT_COUNT (not needed)
        - Renamed HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
        - Prefixed base status variables with 'stats'
        - Use table column bitmaps instead of ha_get_bit_in_read_set()
        - Added ::reset(), with code from ::extra(HA_EXTRA_RESET)
        - Removed HA_EXTRA_RETRIVE_ALL_COLS and HA_EXTRA_RETRIEVE_PRIMARY_KEY as
          the table->read_set and table->write_set bitmaps now are accurate
      sql/ha_innodb.h:
        Update to 'newer' table handler interface
        - table_flags are now ulonglong
        - Added reset() method
        - Removed not needed ha_retrieve_all_cols() and ha_retrieve_all_pk() columns.
        - Made build_template() a class function to be able to easier access class variables
      sql/ha_myisam.cc:
        Update to 'newer' table handler interface
      sql/ha_myisam.h:
        Update to 'newer' table handler interface
      sql/ha_myisammrg.cc:
        Update to 'newer' table handler interface
      sql/ha_myisammrg.h:
        Update to 'newer' table handler interface
      sql/ha_ndbcluster.cc:
        Update to 'newer' table handler interface
        Fixed use_blob_value() to be accurate
        In ::complemented_read() we have to check both the read and write bitmap as the old code did mark all changed columns also in the read map
        Correct dumping of field data with DBUG_DUMP
        Prefix addresses in DBUG_PRINT with 0x
        Fixed usage of not initialized memory
        Update to use field->flags & FIELD_IN_ADD_INDEX instead of field->add_index.
      sql/ha_ndbcluster.h:
        Update to 'newer' table handler interface
      sql/ha_ndbcluster_binlog.cc:
        Mark usage of all columns in ndbcluster binlog tables
        false -> FALSE, true -> TRUE
        Use table->s->all_set instead of creating a temporary bitmap.
      sql/ha_partition.cc:
        Update to 'newer' table handler interface
        Added memroot to initialise_partitions() and related functions to get faster memory allocation.
        partition_create_handler() is now responsible for initialisation of the partition object
        Some trivial optimizations and indentation fixes
        Ensure that table_flags() are up to date
        Removed documentation for removed HA_EXTRA flags
        Fixed 'strange' usage of m_file[i] in new_handlers_from_part_info()that worked in current code 'by chance'
      sql/ha_partition.h:
        Update to 'newer' table handler interface
      sql/handler.cc:
        create_xxx handler now takes MEMROOT as an argument to simplify memory allocation.
        Much simpler get_new_handler()
        (Initialization of the object is now handled by the create method for the engine)
        Moved all allocation of bitmap handling to the TABLE object (in table.cc)
        Added column_bitmaps_signal() to signal column usage changes.
        Changed binlog_log_row() to use the exiusting all_set bitmap in the table object.
        Added ha_reset() function to test that the file object is ok at end of statement and call handler::reset()
        Added use_hidden_primary_key() to signal handler that we we are going to read and update + delete the row and the handler should thus remember the position for the row
      sql/handler.h:
        Added HA_NO_TRANSACTIONS, HA_PARTIAL_COLUMN_READ, HA_REQUIRES_KEY_COLUMNS_FOR_DELETE,HA_PRIMARY_KEY_REQUIRED_FOR_DELETE and HA_HAS_RECORDS
        Removed HA_NOT_EXACT_COUNT, HA_READ_RND_SAME
        HA_DUPP_POS -> HA_DUPLICATE_POS
        HA_NOT_EXACT_COUNT replaced by HA_STATS_RECORDS_IS_EXACT, HA_HAS_RECORDS and records()
        HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION
        Added future row type 'ROW_TYPE_PAGES'
        Added MEM_ROOT to handlerton 'create' function
        Added ha_statistics, a structure for all status variable in the base handler class.
        Moved all status variables in the handler class into a stats structs to improve readability.
        ha_table_flags() is now a cached (not virtual) version of table_flags()
        reset() doesn't anymore call extra(HA_EXTRA_RESET) but is a function of it's own.
        Renamed dupp_ref to dup_ref
        Renamed not used handler::sortkey
        Moved read_set and write_set to TABLE structure
        handler::init() function added for cacheing of virtual constants from engine.
      sql/item.cc:
        Added register_field_in_read_map() for marking used columns in expression.
        This is used by filesort() for creating an optimal column bitmap while retrieving columns for sorting.
        Initalize value.cs_info.character_set_client to fix core dump bug with --debug
        set_query_id -> mark_used_columns
        Mark used columns in read_set OR write_set.
      sql/item.h:
        Removed reset_query_id_processor() as it's not needed anymore.
        Added register_field_in_read_map()
        Added extra argument to Item::walk() to indicate if we should also
        traverse sub queries.
      sql/item_cmpfunc.cc:
        Temporary mark used columns to be read/writable
        Update Item::walk to new interface
      sql/item_cmpfunc.h:
        Added extra argument to Item::walk() to indicate if we should also traverse sub queries.
      sql/item_func.cc:
        Update Item::walk() to new interface
        table_flags() -> ha_table_flags()
      sql/item_func.h:
        Update Item::walk() to new interface
      sql/item_row.cc:
        Update Item::walk() to new interface
      sql/item_row.h:
        Update Item::walk() to new interface
      sql/item_strfunc.h:
        Update Item::walk() to new interface
      sql/item_subselect.cc:
        Added Item_subselect::walk()
        (It was a bug it was missing before. Not sure what kind of bugs this could have caused)
      sql/item_subselect.h:
        Update Item::walk() to new interface
      sql/item_sum.cc:
        Update Item::walk() to new interface
        Updates for new handler interace
      sql/item_sum.h:
        Update Item::walk() to new interface
      sql/key.cc:
        Updates for new handler interace
      sql/log.cc:
        Mark all columns used for log tables
        Split options flag
        Ensured that second argument to trans_register_ha is a bool
      sql/log_event.cc:
        Fixed comments to be withing 79 characters
        Use OPTION_KEEP_LOG instead of OPTION_STATUS_NO_TRANS_UPDATE to remove wrong warnings
        Updates for new handler interface
        Use 0x%lx instead of %p (portability problem)
      sql/mysql_priv.h:
        Added OPTION_KEEP_LOG to indicate that we should replicate the binlog even on rollback
        Removed not used 'conds' argument to setup_tables
      sql/mysqld.cc:
        Indentation fixes and removed old comment
      sql/opt_range.cc:
        Update to new handler and bitmap interface.
        Fixed calls to cp_buffer_from_ref() and walk() (new argument).
        Create new temporary bitmaps for ror scans.
        (Needed because of handler changes and to get more accurate column bitmaps than before)
        Remove not needed file->ha_reset() call before file->close().
        Some trivial optimization and indentation fixes.
        Use Field->part_of_key_not_clustered() to check if field is part of a key, instead of looping over all key parts.
        
        Added flag 'in_ror_merged_scan' to allow ::get_next() to know that we need a special column bitmap to only fetch pointer to record.
        This is needed because ror scan uses the same TABLE object but different file objects, which creates problem for the column bitmap handling.
        (This is a temporary solution. A better one would be to allocate an own TABLE object for ROR scans)
        
        Optimized bitmap handling in ror scans:
        - Start bitmap at position 0, not 1
        - Use same bitmap size as in TABLE
        - Use table->read_set and table->write_set to create column bitmaps instead of looping over all fields in table
      sql/opt_range.h:
        Added 'in_ror_merged_scan' to indicate if we are doing a ROR scan
        Added temporary column bitmaps used in ROR scans
      sql/opt_sum.cc:
        Added get_ext_record_count() which is used in COUNT() optimization if handler has HA_HAS_RECORDS
        Note that we don't call this if handler has HA_STATS_RECORDS_IS_EXACT set.
      sql/protocol.cc:
        We need to mark columns as readable in ::store() as we sometimes return default value for fields to the user
      sql/records.cc:
        Updates for new handler interface
      sql/set_var.cc:
        Handle splitting OPTION_STATUS_NO_TRANS_UPDATE to two flags
      sql/share/errmsg.txt:
        Fixed wrong
      sql/sp.cc:
        Mark that we are using all columns for the proc table
        Update call to setup_tables() to use new prototype
      sql/sp_head.cc:
        Removed QQ comment
      sql/spatial.cc:
        Removed wrong QQ comment
      sql/sql_acl.cc:
        Mark that we need all columns for acl tables
        Supply memroot to some 'new' calls.
        Indentation fixes
      sql/sql_base.cc:
        set_query_id removed
        Ensure we call ha_reset() at end of each statement
        Mark read columns in read_set and changed columns in write_set (Before all columns was marked in read set)
        Fixed marking of some columns that was not proplerly marked before
        Maintain in TABLE->merge_keys set of all keys that are used in some way
        Removed not used 'conds' argument from setup_tables()
        Remove not used setting of 'dupp_field' in insert_fields()
        Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
        (This has probably caused us to not properly remove temporary files after crash)
      sql/sql_bitmap.h:
        Added is_overlapping()
      sql/sql_class.cc:
        Slow_logs was not properly initialized, which could maybe cause extra/lost entries in slow log.
        set_query_id -> mark_used_columns
        Simpler variable usage in pack_row()  (cleanup)
        Moved some variable declartion at start of function for better code readability
      sql/sql_class.h:
        Added enum_mark_columns
        Updated comments
        Renamed dupp_field -> dup_field
        Added virtual function 'can_rollback_data()' to select_insert() to be used in CREATE ... SELECT to optimize use of OPTION_STATUS_NO_TRANS_UPDATE.
        (This fixes a bug in CREATE ... SELECT where we did give wrong warnings when using non transacational tables)
      sql/sql_delete.cc:
        Updates to new handler interface
        Call table->mark_columns_needed_for_delete() to allow us to put additional columns in column usage maps if handler so requires.
        Call table->prepare_for_position() to tell handler that we are going to call ha_position().
        Removed call to free_io_cache(). (io_cache is now removed in ha_reset()).
        Fixed calls to setup_tables()
      sql/sql_do.cc:
        Update call to setup_fields()
      sql/sql_handler.cc:
        Tell handler tables to always read all columns.
        Use temporary column map when storing value in field for later index usage
      sql/sql_help.cc:
        Makr all used fields to be read
        Update call to setup_fields()
      sql/sql_insert.cc:
        Tell handler we are going to update the auto_increment column
        dupp_field -> dup_field
        Set column usage bits for timestamp field.
        Call table->mark_columns_needed_for_insert() and table->mark_auto_increment_column()
        Removed not used argument from mysql_prepare_insert_check_table().
        
        If we get an duplicate row on insert, change column map to read and write all columns while retrying the operatation.
        This is required by the definition of REPLACE and also ensures that fields that are only part of UPDATE are properly handled.
        This fixed a bug in NDB and REPLACE where REPLACE wrongly copied some column values from the replaced row.
        
        Setup new bitmaps for delayed insert rows
        Remove reseting of next_number_fields as it will be reset on next call to handler_insert()
        
        Fixed usage of thd->options and OPTION_STATUS_NO_TRANS_UPDATE.
        The issue was that one should not to reset this flag as it may be set by a previous statement.
        The way it was now used caused us to loose some warnings and get other wrong warnings when using non transactional tables mixed with transactional.
        I fixed it by introducing 'select_insert::can_rollback_data' to inform send_error() that the given statement can be rolled back (which in case of CREATE TABLE can always be done)
        Don't close tables created with CREATE ... SELECT but keep them in the table cache.
        
        Moved out MY_HOOKS from inside function (better readability)
      sql/sql_load.cc:
        Update to use new handler and column marking interface
        Update using setup_tables()
      sql/sql_olap.cc:
        Update calls to setup_tables
        Use enums instead of constants to setup_fields()
      sql/sql_parse.cc:
        Handle OPTION_KEEP_LOG:
        - Set it on CREATE TEMPORARY TABLE / DROP TABLE
        - Reset it when OPTION_STATUS_NO_TRANS_UPDATE is reset
        - Don't set it for CREATE ... SELECT (this is handled in select_create class)
        Remove reseting of OPTION_STATUS_NO_TRANS_UPDATE in begin_trans() as this should already be reset.
        If in autocommit mode, reset OPTION_KEEP_LOG and OPTION_STATUS_NO_TRANS_UPDATE to not give warnings in future commands
      sql/sql_partition.cc:
        Update walk() usage
        Trivial indentation fixes
      sql/sql_plugin.cc:
        Mark all columns as used for plugins
      sql/sql_prepare.cc:
        Added assert to find out hidden bugs in character_set_client (got an error in debug binary when this not set correctly)
        Updates for new handler interface
        Update calls to setup_fields()
      sql/sql_repl.cc:
        Indentation fixes
      sql/sql_select.cc:
        Update call to setup_tables() and setup_fields()
        Remove some old disabled code
        Update to new hadler interface
        Indentation cleanups
        Added column bitmaps for temporary tables.
        Remove updating of the removed slots in the Field class
        Added TABLE argument to cp_buffer_from_ref() (To be able to install temporary column maps)
        For internal temporary tables, use handler::write_row(), handler::delete_row() and handler::update_row() instead of handler::ha_xxxx() for faster execution.
      sql/sql_select.h:
        Indentaition fixes.
        Install temporary column usage maps when needed
        Added TABLE element to cp_buffer_from_ref()
      sql/sql_show.cc:
        Update to new handler interface
        Mark all columns used for internal tables.
        Style fixes.
        Added support for 'future' ROW_TYPE_PAGES.
        Don't allocate TMP_TABLE_PARAM with calloc. The 'init()' function will initialize the structure properly.
      sql/sql_table.cc:
        Update to new handler interface
        Simple my_snprintf -> strmake()
        Changed some constants to defines
        Don't test for NULL in primary key (as we a couple of line above force the PRIMARY KEY to be NOT NULL)
        Change field->add_index to use field->flags & FIELD_IN_ADD_INDEX
        Mark all columns as used for ALTER TABLE
        Style fixes
        Update call to filesort()
      sql/sql_trigger.h:
        Added friend functions to be able to test if triggers exists for table we are going to insert/update or delete in.
      sql/sql_udf.cc:
        Mark all columns as used for udf system table.
      sql/sql_union.cc:
        Update call to walk()
        Update to new handler interface
      sql/sql_update.cc:
        Remove query_id argument from compare_record()
        Use column bitmaps instead of query_id.
        We can't use compare_records() to skip updates for handlers that returns a partial column set and the read_set doesn't cover all columns in the write set, because compare_record() can't in this case know if a not read column changed value.
        Update call to setup_fields()
        Using separate column read and write sets allows for easier checking of timestamp field was set by statement.
        Removed call to free_io_cache() as this is now done in ha_reset()
        Call table->mark_columns_needed_for_update() and table->prepare_for_position()
        Style fixes
      sql/sql_view.cc:
        Style fixes
      sql/table.cc:
        Remove implicitely include 'errno.h'
        Remove code for building normalized path, as this is now identical to 'path'
        Remove field->fieldnr
        Added update of field->part_of_key_not_clustered()
        Create column bitmaps in TABLE and TABLE_SHARE
        Don't setup a temporary MEM_ROOT object as a thread specific variable for the handler. Instead we send the to-be-used MEMROOT to get_new_handler()
        Update to new handler interface
        Update call to walk()
        Added new functions:
        - st_table::clear_column_bitmaps()
        - st_table::prepare_for_position()
        - st_table::mark_columns_used_by_index()
        - st_table::restore_column_maps_after_mark_index()
        - st_table::mark_columns_used_by_index_no_reset()
        - st_table::mark_auto_increment_column()
        - st_table::mark_columns_needed_for_delete()
        - st_table::mark_columns_needed_for_update()
        - st_table::mark_columns_needed_for_insert()
      sql/table.h:
        Moved column usage bitmaps from handler to TABLE
        Added to TABLE_SHARE all_set and column_bitmap_size
        Added to TABLE merge_keys, bitmap_init_values, def_read_set, def_write_set, tmp_set, read_set and write_set.
        Declared all new table column bitmap functions
        Added TABLE functions column_bitmaps_set(), column_bitmaps_set_no_signal(), use_all_columns() and default_column_bitmaps()
        Added functions: tmp_use_all_columns() and tmp_restore_column_map() to temporarly switch column bitmaps
        Added functions: dbug_tmp_use_all_columns() and dbug_tmp_restore_column_map() to temporarly switch column bitmaps to avoid asserts in Field::store() and Field::val().
      sql/tztime.cc:
        Mark all columns as used for timezone tables
      storage/archive/ha_archive.cc:
        Update to new handler interface
      storage/archive/ha_archive.h:
        Update to new handler interface
      storage/blackhole/ha_blackhole.cc:
        Update to new handler interface
      storage/blackhole/ha_blackhole.h:
        Update to new handler interface
        removed not needed flag HA_DUPP_POS
      storage/csv/ha_tina.cc:
        Update to new handler interface
      storage/csv/ha_tina.h:
        Update to new handler interface
      storage/example/ha_example.cc:
        Update to new handler interface
      storage/example/ha_example.h:
        Update to new handler interface
      storage/heap/hp_extra.c:
        Added heap_reset() (Required by new handler interface)
      storage/heap/hp_test2.c:
        Use heap_reset()
      storage/myisam/ft_boolean_search.c:
        Fixed compiler warning
      storage/myisam/mi_extra.c:
        Added mi_reset() (Required by new handler interface)
      storage/myisam/mi_search.c:
        Fixed DBUG_PRINT messages to use 0x%lx instead of %lx
      storage/myisam/mi_test2.c:
        Use mi_reset()
      storage/myisam/myisampack.c:
        Use mi_reset()
      storage/myisammrg/myrg_extra.c:
        Added myrg_reset() (Required by new handler interface)
      unittest/mysys/base64.t.c:
        Include my_global.h
        Don't include implictely include file 'stdlib.h'
      01d03e7b
  27. 29 May, 2006 1 commit
    • unknown's avatar
      Fix for bug #17394 - Events namespace is wrong · bdda0116
      unknown authored
      mysql-test/lib/init_db.sql:
        remove definer from PK
      mysql-test/r/events.result:
        update results
      mysql-test/r/system_mysql_db.result:
        update results
      mysql-test/t/events.test:
        remove I_S.EVENTS test and move it to events_grant.test
      scripts/mysql_fix_privilege_tables.sql:
        change table definition
      sql/event.cc:
        make events non-user specific (namespace change)
      sql/event.h:
        make events non-user specific (namespace change)
      sql/event_priv.h:
        make events non-user specific (namespace change)
      sql/event_scheduler.cc:
        make events non-user specific (namespace change)
      sql/event_timed.cc:
        make events non-user specific (namespace change)
      sql/sql_parse.cc:
        make events non-user specific (namespace change)
      sql/sql_show.cc:
        SHOW EVENTS is available to everyone who has EVENT on specific schema.
        No additional privileges are needed to see others' events.
        - user A has events in db1 and db2
        - user B has events in db1 and db3
        A will see all his events from db1 and db2 as well as B's events
        from db1 but not from db3.
        B will see her events from db1 and db3. In addition B will see
        only A's events from db1 but not db2.
      bdda0116
  28. 22 May, 2006 1 commit
    • unknown's avatar
      fix for bug #17619 Scheduler race conditions · f4781a7e
      unknown authored
      - Scheduler is either initialized at server start or never.
        Starting & stopping is now suspending & resuming.
      - The scheduler has clear OO interface
      - Now all calls to the scheduler are synchronous
      - GLOBAL event_scheduler uses thd::sys_var_tmp (see set_var.cc)
      - External API is encapsulated into class Events
      - Includes fixes for all comments of Kostja's review of 19.05.2005
      
      Starting to merge into 5.1-release (5.1.10) and push
      
      
      BitKeeper/etc/ignore:
        Added libmysqld/event_scheduler.cc to the ignore list
      libmysqld/Makefile.am:
        executor -> scheduler
      mysql-test/r/events.result:
        update result
      mysql-test/r/events_bugs.result:
        update result
      mysql-test/r/events_logs_tests.result:
        update result
      mysql-test/r/events_microsec.result:
        update result
      mysql-test/r/events_scheduling.result:
        update result
      mysql-test/r/events_stress.result:
        update result
      mysql-test/t/disabled.def:
        enable these tests
      mysql-test/t/events.test:
        optimize the test a bit for speed, save some seconds runtime
        remove FULL from SHOW EVENTS
        mostly use I_S.EVENTS
      mysql-test/t/events_bugs.test:
        Skip irrelevant for the current design tests - all events are loaded
        on server startup. Change in mysql.event will be visible on next server start.
        Don't use numeric error codes.
      mysql-test/t/events_logs_tests.test:
        optimize the test a bit for speed
      mysql-test/t/events_microsec.test:
         Skip irrelevant for the current design tests - all events are loaded
            on server startup. Change in mysql.event will be visible on next server start.
            Don't use numeric error codes.
      mysql-test/t/events_scheduling.test:
        broader test
      mysql-test/t/events_stress.test:
        Rework the test to the new architecture of suspending/resuming.
        Use less events, no need for thousands, hundreds is still ok.
      sql/Makefile.am:
        executor -> scheduler
      sql/cmakelists.txt:
        executor -> scheduler
      sql/event.cc:
        - remove todo comments
        - remove unneded evex_queue abstraction functions
        - move events_init() and events_shutdown() from event_executor.cc to here
        - export db_create_event
        - remove evex_load_and_compile_event, part of class Event_scheduler
        - integrate the public interface found in event.h and used by sql_parse.cc
          to use the new class Event_scheduler.
      sql/event.h:
        - add COND_finished so if one thread kills a running event it waits on this
        - export callback event_timed_definer_equal, event_timed_identifier_equal(),
          event_timed_name_equal and event_timed_db_equal()
          to be used by Event_scheduler::drop_matching_events()
        - cleanup event.h
        - encapsulated all external interface into class Events
      sql/event_executor.cc:
        make it empty, will delete after that
      sql/event_priv.h:
        - more things in the private header
        - remove event queue abstraction functions. tightly bind to QUEUE
        - export privately db_drop_event, db_find_event, db_create_event()
        - made change_security_context() and restore_security_context() free functions
      sql/event_timed.cc:
        - fix calculation of time when ENDS is set (STARTS is always set)
        - during Event_timed::compile() set the right Security_ctx. Prevents a crash
              during Event_scheduler::load_events_from_db()
        - add Event_timed::kill_thread()
        - implement event_timed_*_equal()
        - made change_security_context() and restore_security_context() free functions.
        - Comments cleanups
      sql/lex.h:
        new word scheduler for SHOW SCHEDULER STATUS (available only debug builds)
      sql/log.cc:
        move these from event_scheduler.cc
      sql/mysql_priv.h:
        refactor kill_one_thread
        export sql_print_message_func and sql_print_message_handlers
      sql/mysqld.cc:
        In close_connections, called by kill_server() skip the main scheduler
        thread and use events_shutdown() for shutting down the scheduler, in the same
        manner it's done for RPL.
        Add a new value to --event-scheduler :
        0 <- No scheduler available
        1 <- Start with scheduler enabled
        2 <- Start with scheduler suspended
      sql/repl_failsafe.cc:
        refactor thd::system_thread to be an enum
      sql/set_var.cc:
        move sys_var_event_executor::update() to set_var.cc
        executor -> scheduler
        use thd::sys_var_tmp
      sql/set_var.h:
        executor -> scheduler
      sql/share/errmsg.txt:
        3 new error messages
      sql/sql_class.cc:
        refactor thd::system_thread to be an enum . more type-safety
      sql/sql_class.h:
        refactor thd::system_thread to be an enum . more type-safety
      sql/sql_db.cc:
        get the error from evex_drop_schema_events
      sql/sql_error.h:
        export warning_level_names
      sql/sql_lex.h:
        new command SHOW SCHEDULER STATUS, available only in debug build and
        for debug purposes.
      sql/sql_parse.cc:
        refactor kill_one_thread() -> does the *dirty* work, and sql_kill
        just the reporting.
        add handler for SQLCOM_SHOW_SCHEDULER_STATUS
      sql/sql_show.cc:
        fix verbosity handling (this will be obsoleted anyway by the fix for 17394).
      sql/sql_yacc.yy:
        remove FULL from SHOW EVENTS
        add SHOW SCHEDULER STATUS in debug builds
      sql/table.cc:
        Fix valgrind warning.
      f4781a7e
  29. 07 Apr, 2006 1 commit
    • unknown's avatar
      fix for bug #17494 (The algorithm for calculating execution times is not fully correct) · 7c596993
      unknown authored
      This also should fix 17493 and 17346, and probably 16397 (not tested).
      WL#1034 (Internal CRON)
      (post-review commit)
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/t/events.test:
        update test
      sql/event.cc:
        seems we get a crash if we compile it this way. better let the worker thread do it,
        this increases the stability.
      sql/event_executor.cc:
        kick in more often
      sql/event_timed.cc:
        - don't NULLify last_executed
        - implement (fix) better get_next_time() which does not use last_executed as basis
          but STARTS. STARTS is used as basis and the next point of time which is before ENDS,
          if set, is being found. The point > now and (point-starts) % interval_expression == 0.
      sql/item_timefunc.cc:
        move calc_time_diff to time.cc as it can be reused in other parts of the 
        server code (see event_timed.cc)
      sql/mysql_priv.h:
        export calc_time_diff() moved to time.cc from item_timefunc.cc
      sql/sql_show.cc:
        - fix presenting of LAST_EXECUTED
        - cleanup a bit
      sql/time.cc:
        - move calc_time_diff() from item_timefunc.cc to here
      7c596993
  30. 29 Mar, 2006 1 commit
    • unknown's avatar
      Fixed compiler and valgrind warnings · 59eaf292
      unknown authored
      Added missing DBUG_xxx_RETURN statements
      Fixed some usage of not initialized variables (as found by valgrind)
      Ensure that we don't remove locked tables used as name locks from open table cache until unlock_table_names() are called.
      This was fixed by having drop_locked_name() returning any table used as a name lock so that we can free it in unlock_table_names()
      This will allow Tomas to continue with his work to use namelocks to syncronize things.
      
      Note: valgrind still produces a lot of warnings about using not initialized code and shows memory loss errors when running the ndb tests
      
      
      BitKeeper/etc/ignore:
        added mysql-test/r/*.log
      client/mysqltest.c:
        Change type of variables to get rid of compiler warnings
        More debugging
        Fix memory leak
      mysql-test/mysql-test-run.sh:
        Collect warnings about missing DBUG_RETURN statements
      mysql-test/r/lock_multi.result:
        Add test of new code
      mysql-test/r/ndb_condition_pushdown.result:
        Drop used tables before test
      mysql-test/t/lock_multi.test:
        Add test of new code
      mysql-test/t/ndb_condition_pushdown.test:
        Drop used tables before test
      mysql-test/valgrind.supp:
        Ignore 'safe' warnings from libz (when used with archive)
      sql/event.cc:
        More comments
        Simplify code
        Fixed memory leak found by valgrind
      sql/ha_archive.cc:
        Remove compiler warnings (Wrong handlerton structure and signed/unsigned comparison)
      sql/ha_berkeley.cc:
        Fixed compiler warning
      sql/ha_blackhole.cc:
        Fixed compiler warning
      sql/ha_federated.cc:
        Fixed compiler warning
      sql/ha_heap.cc:
        Fixed compiler warning
      sql/ha_myisam.cc:
        Fixed compiler warning
      sql/ha_myisammrg.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/ha_partition.cc:
        Fixed compiler warning
        Fixed error noticed by valgrind in ha_partition::rnd_init()
      sql/handler.cc:
        Fixed compiler warning
      sql/handler.h:
        Fixed compiler warning
      sql/item.cc:
        Fixed compiler warning
      sql/item_xmlfunc.cc:
        Fixed warning from valgrind when calling memcpy with wrong address
      sql/lock.cc:
        More debugging
      sql/log.cc:
        Fixed compiler warning
        Indentation fixes
      sql/log.h:
        Fixed compiler warning
      sql/mysql_priv.h:
        Changed prototype for 'drop_locked_tables'
      sql/opt_range.cc:
        Indentation fix
      sql/password.c:
        Removed compiler warnings
      sql/set_var.cc:
        Fixed compiler warning
      sql/slave.cc:
        Fixed compiler warning
      sql/sp_head.cc:
        Fixed compiler warning
      sql/sql_acl.cc:
        Fixed compiler warning
      sql/sql_analyse.cc:
        Added missing DBUG_RETURN statements
      sql/sql_base.cc:
        Removed de-reference of not initialized pointer
        More comments
        drop_locked_tables() changed to not delete tables used for name locking
        Fixed compiler warnings
      sql/sql_delete.cc:
        Fixed usage of not initialized variable
        (deleted could be referenced in some not common error conditions)
      sql/sql_parse.cc:
        Added missing DBUG_VOID_RETURN
        Simplify code
      sql/sql_partition.cc:
        Fixed usage of wrong variable (noticed by valgrind)
      sql/sql_plugin.cc:
        Removed compiler warning
      sql/sql_show.cc:
        Removed compiler warning
      sql/sql_table.cc:
        Ensure that we don't remove locked tables used as name locks from open table cache until unlock_table_names() are called.
        This was fixed by having drop_locked_name() returning any table used as a name lock so that we can free it in unlock_table_names()
        This will allow Tomas to continue with his work to use namelocks to syncronize things.
        
        Fixed wrong test of 'table_type' (path_length could otherwise be accessed uninitialized)
        
        Remove compile warnings about not initialized variables.
      sql/sql_yacc.yy:
        Ensure that no_write_to_binlog is properly initialized
        (Was accessed uninitialized by partition code)
      sql/table.cc:
        Removed valgrind warnings (not fatal)
        Removed compiler warnings
      sql/tztime.cc:
        Removed valgrind warning
      storage/ndb/include/ndbapi/NdbIndexStat.hpp:
        Removed compiler warning
      59eaf292