1. 28 Aug, 2007 1 commit
    • unknown's avatar
      Bug #30596 GROUP BY optimization gives wrong result order · 22440b53
      unknown authored
        
      The optimization that uses a unique index to remove GROUP BY did not 
      ensure that the index was actually used, thus violating the ORDER BY
      that is implied by GROUP BY.
      Fixed by replacing GROUP BY with ORDER BY if the GROUP BY clause contains
      a unique index over non-nullable field(s). In case GROUP BY ... ORDER BY 
      null is used, GROUP BY is simply removed.
      
      
      mysql-test/include/mix1.inc:
        Bug#30596: Test case for InnoDB
        Here, as opposed to for MyISAM, row lookup is done using index 
        whenever the index covers the group list.
      mysql-test/r/distinct.result:
        Bug#30596: Changed test case. 
        Prior to Bug#16458, These queries use temp table and filesort. The
        bug was that they used a temp table. However, that patch removed
        filesort also, in which case we can no longer gurantee correct ordering.
      mysql-test/r/group_by.result:
        Bug#30596: Correct result
        The test case for IGNORE INDEX FOR GROUP BY gets degraded performance 
        (unneccesary filesort). This is due to Bug#30665, which will be fixed separately.
      mysql-test/r/innodb_mysql.result:
        Bug#30596: Test result
      mysql-test/t/group_by.test:
        Bug#30596: Test case
      sql/sql_select.cc:
        Bug#30596: The fix: 
        - replace GROUP BY with ORDER BY unless ORDER BY [NULL|<constant>]
        - make sure to use the keys for GROUP BY in this ORDER BY.
      22440b53
  2. 22 Aug, 2007 2 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-30201 · 4512a993
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      sql/sql_cache.cc:
        SCCS merged
      4512a993
    • unknown's avatar
      Fixed bug #30201. · 891b1659
      unknown authored
      Killing a SELECT query with KILL QUERY or KILL CONNECTION
      causes a server crash if the query cache is enabled.
      
      Normal evaluation of a query may be interrupted by the
      KILL QUERY/CONNECTION statement, in this case the mysql_execute_command
      function returns TRUE, and the thd->killed flag has true value.
      In this case the result of the query may
      be cached incompletely (omitting call to query_cache_insert inside
      the net_real_write function), and next call to query_cache_end_of_result
      may lead to server crash.
      Thus, the query_cache_end_of_result function has been modified to abort
      query cache in the case of killed thread.
      
      
      
      sql/sql_cache.cc:
        Fixed bug #30201.
        The  query_cache_end_of_result function has been modified to abort query
        cache in the case of query execution failure. Also this function has been
        modified to remove incomplete query block.
      891b1659
  3. 21 Aug, 2007 14 commits
  4. 20 Aug, 2007 3 commits
    • unknown's avatar
      Fixed bug #30287. · 7c3d5bc5
      unknown authored
      The server created temporary tables for filesort in the working directory
      instead of the specified tmpdir directory.
      
      
      sql/item.cc:
        Fixed bug #30287.
        The Item_field::set_field method has been modified to reset the any_privileges
        flag to false in case of system temporary table. This modification prevents the
        server from unnecessary checking of user privileges to access system temporary
        tables.
      sql/sql_select.cc:
        Fixed bug #30287.
        Bugfix for #29015 has been removed: TABLE_SHARE::table_name of system
        temporary tables contains full path to table file basename again.
      sql/sql_view.cc:
        Fixed bug #30287.
        Commentary has been added.
      7c3d5bc5
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d48e35b9
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      d48e35b9
    • unknown's avatar
      Bug#27629 Possible security flaw in INFORMATION_SCHEMA and SHOW statements · 29ee5ed0
      unknown authored
      added SUPER_ACL check for I_S.TRIGGERS
      
      
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/r/information_schema_db.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        added SUPER_ACL check for I_S.TRIGGERS
      29ee5ed0
  5. 18 Aug, 2007 5 commits
    • unknown's avatar
      Bug #29307: status.test fails with different Table_locks_immediate · 0ece5608
      unknown authored
      Finish premature patch which was accidentally pushed; remove debugging
      info and correct the test.
      
      
      mysql-test/r/status.result:
        Correct test results
      mysql-test/t/status.test:
        Disable query log for one statement, and correct some comments
      0ece5608
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 994625d6
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      994625d6
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/51 · 92838cc4
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      92838cc4
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/50 · c68c271a
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      c68c271a
    • unknown's avatar
      Bug #29307: status.test fails with different Table_locks_immediate · 4f3c8e77
      unknown authored
      When using --log --log-output=table, we increment Table_locks_immediate
      with every query.  The wait_condition.inc runs a query a variable number
      of times, depending on server load, etc.  This is a problem, when the
      test is checking the Table_locks_immediate value.
      
      Fix is to adjust the Table_locks_immediate value based on how many times
      the wait_condition query was executed.
      
      
      mysql-test/include/wait_condition.inc:
        Add a $wait_condition_reps variable, which lets the caller check how
        many times the wait_condition query was executed.
        
        This is used in the main.status test to adjust the value of
        Table_locks_immediate (it gets incremented with each query
        when --log --log-output=table).
      mysql-test/t/status.test:
        Adjust Table_locks_immediate value based on how many times the
        wait_condition query had to run.
      4f3c8e77
  6. 17 Aug, 2007 6 commits
  7. 16 Aug, 2007 8 commits
    • unknown's avatar
      Empty changeset to restart pushbuild · 8f8eab9c
      unknown authored
      8f8eab9c
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/50 · 430df009
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/51
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        SCCS merged
      sql/sql_handler.cc:
        SCCS merged
      430df009
    • unknown's avatar
      Bug #29474: 21587 Regression Ever increasing open tables/fd when using HANDLER READ + DELETE · 163420d2
      unknown authored
      Revert the fix for bug 21587.  That bug will be re-opened, and a new
      fix must be created.
      
      
      163420d2
    • unknown's avatar
      Post-merge fix of error number · 51c9bbf4
      unknown authored
      51c9bbf4
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f4a163c3
      unknown authored
      into  dl145s.mysql.com:/data0/mhansson/my50-bug28570
      
      
      sql/opt_range.cc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Bug#28570: Manual Merge
      mysql-test/t/innodb_mysql.test:
        Bug#28570: Manual Merge
      f4a163c3
    • unknown's avatar
      Minor code fixes to help Doxygen generate good documentation. · 29393eaf
      unknown authored
      
      sql/rpl_rli.h:
        Removing redundant "class" keyword.
      29393eaf
    • unknown's avatar
      Renaming MASTER_INFO to Master_info in order to follow the coding · 9a7658a3
      unknown authored
      standards (and help Doxygen generating good documentation).
      
      
      sql/ha_ndbcluster.cc:
        Renaming MASTER_INFO to Master_info.
      sql/log_event.cc:
        Renaming MASTER_INFO to Master_info.
      sql/repl_failsafe.cc:
        Renaming MASTER_INFO to Master_info.
      sql/repl_failsafe.h:
        Renaming MASTER_INFO to Master_info.
      sql/rpl_mi.cc:
        Renaming MASTER_INFO to Master_info.
      sql/rpl_mi.h:
        Renaming MASTER_INFO to Master_info.
      sql/rpl_rli.h:
        Renaming MASTER_INFO to Master_info.
      sql/slave.cc:
        Renaming MASTER_INFO to Master_info.
      sql/slave.h:
        Renaming MASTER_INFO to Master_info.
      sql/sql_repl.cc:
        Renaming MASTER_INFO to Master_info.
      sql/sql_repl.h:
        Renaming MASTER_INFO to Master_info.
      9a7658a3
    • unknown's avatar
      Renaming RELAY_LOG_INFO and st_relay_log_info to follow coding standards · 044a4a3e
      unknown authored
      (and be more friendly to Doxygen by removing unnecessary typedefs).
      
      
      sql/log.cc:
        Renaming struct st_relay_log_info to class Relay_log_info.
      sql/log.h:
        Renaming struct st_relay_log_info to class Relay_log_info.
      sql/log_event.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/log_event.h:
        Renaming struct st_relay_log_info to class Relay_log_info.
        Renaming RELAY_LOG_INFO to Relay_log_info.
        Removing typedef RELAY_LOG_INFO.
      sql/log_event_old.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/log_event_old.h:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_mi.h:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_record.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_record.h:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_record_old.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_record_old.h:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_rli.cc:
        Renaming struct st_relay_log_info to class Relay_log_info.
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_rli.h:
        Renaming struct st_relay_log_info to class Relay_log_info.
        Renaming RELAY_LOG_INFO to Relay_log_info.
        Removing typedef RELAY_LOG_INFO.
      sql/rpl_utility.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/rpl_utility.h:
        Renaming struct st_relay_log_info to class Relay_log_info.
        Renaming RELAY_LOG_INFO to Relay_log_info.
        Removing typedef RELAY_LOG_INFO.
      sql/slave.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/slave.h:
        Renaming struct st_relay_log_info to class Relay_log_info.
        Renaming RELAY_LOG_INFO to Relay_log_info.
        Removing typedef RELAY_LOG_INFO.
      sql/sql_binlog.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      sql/sql_class.h:
        Renaming struct st_relay_log_info to class Relay_log_info.
        Renaming RELAY_LOG_INFO to Relay_log_info.
        Removing typedef RELAY_LOG_INFO.
      sql/sql_repl.cc:
        Renaming RELAY_LOG_INFO to Relay_log_info.
      044a4a3e
  8. 15 Aug, 2007 1 commit
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/inno/aug13/50 · e0f1a29e
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/inno/aug13/51
      
      
      storage/innobase/fsp/fsp0fsp.c:
        Use local (null merge)
      storage/innobase/handler/ha_innodb.cc:
        Use local (null merge)
      storage/innobase/include/fsp0fsp.h:
        Use local (null merge)
      storage/innobase/include/univ.i:
        Use local (null merge)
      storage/innobase/log/log0recv.c:
        Use local (null merge)
      storage/innobase/os/os0file.c:
        Use local (null merge)
      storage/innobase/srv/srv0srv.c:
        Use local (null merge)
      storage/innobase/trx/trx0trx.c:
        Use local (null merge)
      e0f1a29e