1. 22 Aug, 2019 1 commit
  2. 20 Aug, 2019 1 commit
    • Jan Lindström's avatar
      MDEV-20378: Galera uses uninitialized memory · 7b4de104
      Jan Lindström authored
      Problem was that wsrep thread argument was deleted on wrong
      place. Furthermore, scan method incorrectly used unsafe c_ptr().
      Finally, fixed wsrep thread initialization to correctly set
      up thread_id and pass correct argument to functions and
      fix signess problem causing compiler errors.
      7b4de104
  3. 19 Aug, 2019 5 commits
    • Julius Goryavsky's avatar
      MDEV-20185: Windows: Use of uninitialized value $bpath in string eq · c5bc0ced
      Julius Goryavsky authored
      The execution of mtr in the Windows environment fails due to
      the fact that the new code from MDEV-18565 does not take into
      account the need to add the ".exe" extension to the names of
      executable files when searching for pre-requisites that are
      needed to run SST scripts (especially when using mariabackup)
      and when searching paths to some other Galera utilities.
      This patch fixes this flaw.
      
      Also adding paths to the PATH environment variable is now
      done with the correct delimiter character.
      c5bc0ced
    • Julius Goryavsky's avatar
      MDEV-18863: Galera SST scripts can't read [mysqldN] option groups · 89fb295b
      Julius Goryavsky authored
      Some users and some scripts (for example, mysqld_multi.sh) use special
      option groups with names like [mysqld1], [mysqld2], ..., [mysqldN].
      
      But SST scripts can't currently fully support these option groups.
      The only option group-related value it gets from the server is
      --defaults-group-suffix, if that option was set for mysqld when
      the server was started.
      
      However, the SST scripts does not get told by the server to read
      these option groups, so this means that the SST script will fail
      to read options like innodb-data-home-dir when it is in a option
      group like [mysqld1]...[mysqldN].
      
      Moreover, SST scripts ignore many parameters that can be passed
      to them explicitly and cannot transfer them further, for example,
      to the input of mariabackup utility. Ideally, we want to transfer
      all the parameters of the original mysqld call to utilities such
      as mariabackup, however the SST script does not receive these
      parameters from the server and therefore cannot transfer them to
      mariabackup.
      
      To correct these shortcomings, we need to transfer to the scripts
      all of the parameters of the original mysqld call, and in the SST
      scripts themselves provide for the transfer all of these parameters
      to utilities such as mariabackup. To prevent these parameters from
      mixing with the script's own parameters, they should be transferred
      to SST script after the special option "--mysqld-args", followed by
      the string argument with the original parameters, as it received by
      the mysqld call at the time of launch (further all these parameters
      will be passed to mariabackup, for example).
      
      In addition, the SST scripts themselves must be refined so that
      they can read the parameters from the user-selected group, not just
      from the global mysqld configuration group. And also so that they
      can receive the parameters (which important for their work) as
      command-line arguments.
      89fb295b
    • Marko Mäkelä's avatar
      MDEV-20383 Use of uninitialized value in Datafile::find_space_id() for ROW_FORMAT=COMPRESSED · fcae2a63
      Marko Mäkelä authored
      Datafile::find_space_id(): Fix a regression that was introduced
      in c0f47a4a for MDEV-12026.
      Because the function buf_page_is_corrupted() now determines
      the physical page size from the fsp_flags, our buffer size must
      agree with the fsp_flags.
      
      buf_page_is_corrupted(): Use the correct accessor
      fil_space_t::zip_size() for convering the tablespace flags.
      ROW_FORMAT=COMPRESSED files never use innodb_checksum_algorithm=full_crc32.
      fcae2a63
    • Alexander Barkov's avatar
    • Sergei Petrunia's avatar
      MDEV-20374: innodb.innodb_mysql fails sporadically in BB · 850bf331
      Sergei Petrunia authored
      Stabilize the test:
      - replace Rows column in EXPLAIN output for one query
      - Use EITS statistics for another query (in that testcase, the
        query must use LooseScan)
      850bf331
  4. 16 Aug, 2019 8 commits
    • Varun Gupta's avatar
      MDEV-20349: Assertion `to_len >= 8' failed in convert_to_printable · 4d538250
      Varun Gupta authored
      Use convert_to_printable function to write only non-empty ranges to the optimizer trace
      4d538250
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · c221bcdc
      Marko Mäkelä authored
      c221bcdc
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 395e1dcd
      Marko Mäkelä authored
      395e1dcd
    • Marko Mäkelä's avatar
      MDEV-19200: shutdown timeout on innodb.undo_truncate_recover · fe6eac0c
      Marko Mäkelä authored
      Optimize the test by dropping the table early and by using only
      one undo log thread, so that purge will be doing more useful work
      and less busy work of suspending and resuming the worker threads.
      
      The test used to cause shutdown timeout on 10.4 on buildbot, and
      for me locally when using --mysqld=--innodb-sync-debug.
      With these tweaks, it passes for me with --mysqld=--innodb-sync-debug.
      fe6eac0c
    • Marko Mäkelä's avatar
      MDEV-8588/MDEV-19740: Restore a condition · 555af003
      Marko Mäkelä authored
      It looks like the merge of MySQL 5.7.9 to MariaDB 10.2.2 conflicted with
      earlier changes that were made in MDEV-8588.
      
      row_search_mvcc(): If the page is corrupted, avoid invoking
      btr_cur_store_position(). The caller should not try to fetch
      the next record after a hard error.
      555af003
    • Jan Lindström's avatar
      Remove file accidentally pushed. · 3bbf0080
      Jan Lindström authored
      3bbf0080
    • Marko Mäkelä's avatar
      Silence GCC 9.2.1 -Warray-bounds · 130d9490
      Marko Mäkelä authored
      No memory access violated the bounds of fake_extra_buf[],
      but GCC does not like the fact that the pointer fake_extra
      ends up pointing before the array.
      Allocate a dummy element at the start of fake_extra_buf[]
      in order to silence the warning.
      130d9490
    • Jan Lindström's avatar
      MDEV-18778: mysql_tzinfo_to_sql does not work correctly in MariaDB Galera · e6b505fd
      Jan Lindström authored
      There were two problems:
      
      (1) If user wanted same time zone information on all nodes in the Galera
      cluster all updates were not replicated as time zone information was
      stored on MyISAM tables. This is fixed on Galera by altering time zone
      tables to InnoDB while they are modified.
      
      (2) If user wanted different time zone information to nodes in the Galera
      cluster TRUNCATE TABLE for time zone tables was replicated by Galera
      destroying time zone information from other nodes. This is fixed
      on Galera by introducing new option for mysql_tzinfo_to_sql_symlink
      tool --skip-write-binlog to disable Galera replication while
      time zone tables are modified.
      
      Changes to be committed:
              modified:   mysql-test/r/mysql_tzinfo_to_sql_symlink.result
              modified:   mysql-test/suite/wsrep/r/mysql_tzinfo_to_sql_symlink.result
              new file:   mysql-test/suite/wsrep/r/mysql_tzinfo_to_sql_symlink_skip.result
              new file:   mysql-test/suite/wsrep/t/mysql_tzinfo_to_sql_symlink_skip.test
              modified:   sql/tztime.cc
      
      This is 10.4 version of commit fa740888
      e6b505fd
  5. 15 Aug, 2019 11 commits
  6. 14 Aug, 2019 10 commits
  7. 13 Aug, 2019 4 commits