- 11 Sep, 2015 2 commits
-
-
Kristian Nielsen authored
-
Kristian Nielsen authored
The code was using the wrong variable when comparing the binlog name for the UNTIL position. This could cause the comparison to fail after binlog rotation, in turn causing the UNTIL clause to not trigger slave stop.
-
- 06 Sep, 2015 1 commit
-
-
Oleksandr Byelkin authored
Expression in macro protected by ()
-
- 04 Sep, 2015 1 commit
-
-
Jan Lindström authored
Reduce the number of rounds and operations to avoid testcase timeout.
-
- 03 Sep, 2015 1 commit
-
-
Oleksandr "Sanja" Byelkin authored
Add parenthesis in macro definitions to prevent order of operation problems
-
- 02 Sep, 2015 3 commits
-
-
Kristian Nielsen authored
-
Kristian Nielsen authored
If a transaction T1 needs to wait for a transaction T2, T2's commit will skip the normal binlog_commit_wait_usec delay, in order not to needlessly stall throughput. This works by checking if T2 is already ready to commit. If so, it is woken up. If not, we set a flag in T2 so that when it gets ready to commit, it will do so immediately. But there was a potential race due to insufficient locking, if T2 gets ready to commit just at the point where T1 does the check. If the race hits, the wakeup (and early commit) of T2 might be lost. The race is only theoretical (from code inspection, no known test case), but seems best to fix it anyway, by properly locking LOCK_prepare_ordered around the check.
-
Kristian Nielsen authored
MDEV-8725: Assertion `!(thd->rgi_slave && thd-> rgi_slave->did_mark_start_commit)' failed in ha_rollback_trans The assertion is there to catch cases where we rollback while mark_start_commit() is active. This can allow following event groups to be replicated too early, causing conflicts. But in this case, we have an _explicit_ ROLLBACK event in the binlog, which should not assert. We fix this by delaying the mark_start_commit() in the explicit ROLLBACK case. It seems safest to delay this in ROLLBACK case anyway, and there should be no reason to try to optimise this corner case.
-
- 31 Aug, 2015 1 commit
-
-
Oleksandr Byelkin authored
MDEV-6219: Server crashes in Bitmap<64u>::merge (this=0x180, map2=...) on 2nd execution of PS with INSERT .. SELECT, derived_merge Problem: Not all permanent Item_direct_view_ref was in permanent list of used items of the view. Solution: Detect creating permenent view/derived table reference and put them in the permanent list at once.
-
- 23 Aug, 2015 2 commits
-
-
Elena Stepanova authored
-
Elena Stepanova authored
Test failed because it hit net_write_timeout. It might happen in different circumstances, and that's not what the testcase tests, so the timeout is now set to a bigger value.
-
- 18 Aug, 2015 1 commit
-
-
Sergei Petrunia authored
- Make semi-join optimizer not to choose LooseScan when 1) the index is not covered and 2) full index scan will be required. - Make sure that the code in make_join_select() that may change full index scan into a range scan is not invoked when the table uses full scan.
-
- 12 Aug, 2015 2 commits
-
-
Monty authored
Test did not clean up after itself properly
-
Monty authored
of more than 45G with a key_cache_block_size of 1024 or less. The problem was that some of the arguments to my_multi_malloc() got to be more than 4G. Fix: - Inntroduced my_multi_malloc_large() that can handle big regions. - Changed MyISAM and Aria key caches to use my_multi_malloc_large(). I didn't change the default my_multi_malloc() as this would be a too big patch and we don't allocate 4G blocks anywhere else.
-
- 05 Aug, 2015 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
5.5 without InnoDB/XtraDB changes
-
- 04 Aug, 2015 8 commits
-
-
Sergei Golubchik authored
5.5 with our InnoDB changes
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
-
Kristian Nielsen authored
This bug is essentially another variant of MDEV-7458. If a transaction conflict caused a deadlock kill of T2 in record_gtid() during commit, the code would do a rollback _before_ running rgi->unmark_start_commit(). This creates a race where following transactions could start too early (before T2 has completed its transaction retry). This in turn could lead to replication failure, if there was a conflict that caused eg. duplicate key error or similar. The fix is to remove these rollbacks (in Query_log_event::do_apply_event() and Xid_log_event::do_apply_event(). They seem out-of-place; code in log_event.cc generally does not roll back on error, this is handled higher up. In addition, because of the extreme difficulty of reproducing bugs like MDEV-7458 and MDEV-8302, this patch adds some extra precations to try to detect (in debug builds) or prevent (in release builds) similar bugs. ha_rollback_trans() will now call unmark_start_commit() if needed (and assert in debug build when a caller does rollback without unmark first). We also add an extra check for thd->killed() so that we avoid doing mark_start_commit() if we already have a pending deadlock kill. And we add a missing unmark_start_commit() call in the error case, found by the above assertion.
-
Jan Lindström authored
-
- 03 Aug, 2015 12 commits
-
-
Jan Lindström authored
Conflicts: client/mysql_upgrade.c mysql-test/r/func_misc.result mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result mysql-test/suite/innodb/r/innodb-fk.result mysql-test/t/subselect_sj_mat.test sql/item.cc sql/item_func.cc sql/log.cc sql/log_event.cc sql/rpl_utility.cc sql/slave.cc sql/sql_class.cc sql/sql_class.h sql/sql_select.cc storage/innobase/dict/dict0crea.c storage/innobase/dict/dict0dict.c storage/innobase/handler/ha_innodb.cc storage/xtradb/dict/dict0crea.c storage/xtradb/dict/dict0dict.c storage/xtradb/handler/ha_innodb.cc vio/viosslfactories.c
-
Sergei Petrunia authored
The problem was with Materialized_cursor and temporary table it uses. Temorary table's fields had Field::orig_table pointing to the tables that were used in the query that produced data for the cursor. When "FETCH INTO sp_var" statement is executed, those original tables were already closed. However, copying from Materialized_cursor's table into SP variable may cause field_conv() to be invoked which calls field->type() which may access field->orig_table (for certain field types). Fixed by setting Materialized_cursor->table->field[i]->orig_table to point to Materialized_cursor->table. (this is how it is done for regular base tables)
-
Sergei Petrunia authored
-
Sergei Petrunia authored
THD::>save_prep_leaf_list was set to true by multi-table update statements with mergeable selects and never reset. Make every statement reset it at start.
-
Sergei Petrunia authored
THD::>save_prep_leaf_list was set to true by multi-table update statements with mergeable selects and never reset. Make every statement reset it at start.
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
5.6.26
-
Sergei Golubchik authored
5.6.26
-
Sergei Golubchik authored
XtraDB 5.6.25-73.1
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 01 Aug, 2015 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
removed unused directory
-
Sergei Golubchik authored
Support for VS2013 and WiX 3.9 (patch by Andrey Kuznetsov)
-