1. 24 Nov, 2008 1 commit
  2. 22 Nov, 2008 2 commits
  3. 21 Nov, 2008 10 commits
  4. 20 Nov, 2008 6 commits
  5. 19 Nov, 2008 5 commits
    • Vladislav Vaintroub's avatar
      Bug#39494 : key_buffer_size > 4GB does not work on 64 bit Windows · 7d5e156c
      Vladislav Vaintroub authored
      Cache size  is truncated via 32bit ulong  in  ha_init_key_cache() and 
      ha_resize_key_cache() 
      
      This change fixes the cast to size_t instead of ulong. This cast is safe,
      because key_buffer_size parameter is limited to SIZE_T_MAX
      7d5e156c
    • Alexey Botchkov's avatar
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing · b8cd1725
      Alexey Botchkov authored
         additional fix - the 'debug' keyword removed
      b8cd1725
    • Alexey Botchkov's avatar
      merging · a24dce13
      Alexey Botchkov authored
      a24dce13
    • Alexey Botchkov's avatar
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing · 70e8a4fd
      Alexey Botchkov authored
          That's a Win-specific error.
          When we create libmysqld.dll we have many libraries like mysys, dbug,
          strings, etc linked into that dll, so the application built upon
          this library shouldn't link these libraries to itself, rather use
          those inside the dll.
      
          Fixed by redirecting calls into the libmysqld.dll
      
      per-file comments:
        dbug/dbug.c
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
          fake _db_something definitions added
      
        include/my_dbug.h
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
        fake _db_something declarations added
      
        libmysqld/examples/CMakeLists.txt
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
          superfluous libraries removed from linking
      
        libmysqld/libmysqld.def
      Bug#38293 Libmysqld crash in mysql_library_init if language file missing
          set of mysys functions added to the export section
      70e8a4fd
    • Alexey Botchkov's avatar
      merging · 63b02e2b
      Alexey Botchkov authored
      63b02e2b
  6. 18 Nov, 2008 7 commits
  7. 17 Nov, 2008 5 commits
    • Alexey Botchkov's avatar
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server. · 58701cae
      Alexey Botchkov authored
            GLOBAL STATUS is calculated by studying the list of threads. In the
              embedded server threads were not linked to the internal list, so the
              calculation always returns 0. Fixed by 'linking' the embedded-server
              threads to the same list
      
      per-file comments:
        libmysqld/lib_sql.cc
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          Add newly created 'threads' to the internal thread list.
          Remove them from the list as they're freed.
      
        mysql-test/r/information_schema.result
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          test result
      
        mysql-test/t/information_schema.test
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          test case added
      58701cae
    • Alexey Botchkov's avatar
      merging · ef3600b8
      Alexey Botchkov authored
      ef3600b8
    • Alexey Botchkov's avatar
      Bug#31616 div_precision_increment description looks wrong · 56dc6b2e
      Alexey Botchkov authored
      Item_func_div didn't calculate the precision of the result properly.
        The result of 5/0.0001 is 5000 so we have to add decimals of the divisor
        to the planned precision.
      
      per-file comments:
        mysql-test/r/type_newdecimal.result
      Bug#31616 div_precision_increment description looks wrong
          test result fixed
      
        mysql-test/t/type_newdecimal.test
      Bug#31616 div_precision_increment description looks wrong
          test case
      
        sql/item_func.cc
      Bug#31616 div_precision_increment description looks wrong
          precision must be increased with args[1]->decimals parameter
      56dc6b2e
    • Kristofer Pettersson's avatar
      Automerge · b3bb760c
      Kristofer Pettersson authored
      b3bb760c
    • Kristofer Pettersson's avatar
      Bug#40778 thd_security_context has bad architecture; allocates on unprotected memroot · 11493dfd
      Kristofer Pettersson authored
                        
      The function thd_security_context allocates memory on an unprotected MEM_ROOT if the
      message length becomes longer than requested and the initial buffer memory needs to
      be reallocated.
                        
      This patch fixes the design error by copying parts of the reallocated buffer 
      to the destination buffer. This works because the destination buffer isn't
      owned by the String object and thus isn't freed when a new buffer is allocated.
      Any new memory allocated by the String object is reclaimed when the object
      is destroyed at the end of the function call.
      11493dfd
  8. 14 Nov, 2008 4 commits
    • Mattias Jonsson's avatar
      merge · 93f88cb9
      Mattias Jonsson authored
      93f88cb9
    • Mattias Jonsson's avatar
      Bug#40595: Non-matching rows not released with READ-COMMITTED on tables · c0240bca
      Mattias Jonsson authored
      with partitions
      
      Pre push fix, optimized replace_regex, to cut 2 seconds
      from test time.
      c0240bca
    • Gleb Shchepa's avatar
      manual merge 5.0-bugteam --> 5.1-bugteam (bug 40021) · fa430818
      Gleb Shchepa authored
      sql_view.cc: required_view_parameters has been decreased by 2 
      (not by 1) because its value was incorrect: 16 instead of 15
      (minor performance issue).
      fa430818
    • Gleb Shchepa's avatar
      Bug #40021: Renaming view fails, archived .frm for view is · b82094a0
      Gleb Shchepa authored
                  missing after downgrade
      
      Obsolete arc/ directory and view .frm file backup support
      has been removed by the patch for bug 17823. However, that
      bugfix caused a problem with "live downgrades" of the
      server: if we rename some view 4 times under 5.1.29/5.0.72
      and then try to rename it under 5.1.28/5.0.70 on the same
      database, the server fails with a error:
      
        query 'RENAME TABLE ... TO ...' failed: 6: Error on
        delete of '....frm-0001' (Errcode: 2)
      
      Also .frm file of that view may be lost (renamed to .frm~).
      
      The server failed because it tried to rename latest 3
      backup .frm files renaming the view: the server used an
      integer value of the "revision" field of .frm file to
      extract those file names. After the fix for bug 17823 those
      files were not created/maintained any more, however the
      "revision" field was incremented as usual. So, the server
      failed renaming non existent files.
      
      This fix solves the problem by removing the support for
      "revision" .frm file field:
      1. New server silently ignores existent "revision" fields
         in old .frm files and never write it down;
      2. Old server assumes, that missing "revision" field in new
         .frm files means default value of 0.
      3. Accordingly to the fix for bug 17823 the new server
         drops arc/ directory on alter/rename view, so after
         "live downgrade" old server begins maintenance of the
         arc/ directory from scratch without conflicts with .frm
         files.
      b82094a0