1. 07 Apr, 2022 1 commit
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-27783 InnoDB: Failing assertion: table->get_ref_count() == 0 upon ALTER... · 27b0030b
      Thirunarayanan Balathandayuthapani authored
      MDEV-27783 InnoDB: Failing assertion: table->get_ref_count() == 0 upon ALTER TABLE ... MODIFY COLUMN
      
      - There is a race condition occurs between purge thread and DDL.
      So purge thread can increment n_ref_count even after DDL does
      purge_sys_t::stop_FTS().
      
      - dict_table_open_on_id for purge thread should check
      purge_sys.must_wait_FTS() before acquring the table.
      
      - purge_sys.stop_FTS() does acquire dict_sys.latch for setting
      the purge system flag and check table ref count on auxilary tables.
      27b0030b
  2. 06 Apr, 2022 14 commits
  3. 05 Apr, 2022 6 commits
  4. 04 Apr, 2022 7 commits
    • Monty's avatar
      Fixed that mysql_upgrade doesn't give errors about mariadb.sys · c4ebb2bd
      Monty authored
      The reason for this fix was that when I tried to run mysql_upgrade
      at home to update an old 10.5 installation, mysql_upgrade failed
      with warnings about mariadb.sys user not existing.
      
      If the server was started with --skip-grants, there would be no warnings
      from mysql_upgrade, but in some cases running mysql_upgrade again could
      produce new warnings.
      
      The reason for the warnings was that any access of the mysql.user view
      will produce a warning if the mariadb.sys user does not exists.
      
      Fixed with the following changes:
      - Disable warnings about mariadb.sys user not existing
      - Don't overwrite old mariadb.sys entries in tables_priv and global_priv
      - Ensure that tables_priv has an entry for mariadb.sys if the user exists.
        This fixes an issue that tables_priv would not be updated if there
        was a failure directly after global_priv was updated.
      c4ebb2bd
    • Monty's avatar
      Fixed double free issue in events · 09c7f78c
      Monty authored
      Server crashed during shutdown with:
      "corrupted double-linked list"
      when running mysql_upgrade multiple times against the server.
      
      Reason was that db_repostitory could be freed twice.
      09c7f78c
    • Julius Goryavsky's avatar
      MDEV-28204: The tr utility does not work as expected on rsync SST · daed558b
      Julius Goryavsky authored
      This commit contains a fix to use modern syntax for selecting
      character classes in the tr utility options.
      
      Also one of the tests for SST via rsync (galera_sst_rysnc2) is made
      more reliable (to avoid rare failures during automatic testing).
      daed558b
    • Vlad Lesin's avatar
      MDEV-26322 Last binlog file and position are "empty" in mariabackup --prepare output · 6a3545dd
      Vlad Lesin authored
      The issue is caused by 59a0236d commit.
      The initial intention of the commit was to speed up
      "mariabackup --prepare".
      
      The call stack of binlog position reading is the following:
      ▾ trx_rseg_mem_restore
        ▾ trx_rseg_array_init
            ▾ trx_lists_init_at_db_start
                  ▸ srv_start
      Both trx_lists_init_at_db_start() and trx_rseg_mem_restore() contain
      special cases for srv_operation == SRV_OPERATION_RESTORE condition, and
      on this condition only rseg headers are read to parse binlog position.
      Performance impact is not so big.
      
      The solution is to revert 59a0236d.
      6a3545dd
    • Daniel Black's avatar
      MDEV-28231: innodb: format string warning on aix UINT64PFx (ib_id_t) · 7f5a3cd2
      Daniel Black authored
      ib_id_t is a uint64. On AIX this isn't a long long unsigned and to
      prevent the compile warnings and potential wrong type, the UINT64PFx
      defination is corrected.
      
      As INT64PF is unused (last use, xtradb in 10.2), it is removed to
      remove the confusion that INT64PF and UINT64PFx would be different
      types otherwise.
      7f5a3cd2
    • Alexander Barkov's avatar
      Adding a "const" qualifier to arguments of create_func(), create_native() etc · 0ffaf19c
      Alexander Barkov authored
      The "const" qualifier was obviously forgotten.
      
      This change will also simpily fixing of MDEV-27744.
      0ffaf19c
    • Alexander Barkov's avatar
      MDEV-28224 error: cannot initialize return object of type 'bool' with an rvalue of type 'nullptr_t' · d271fbd3
      Alexander Barkov authored
      Fixing a typo in the fix for MDEV-19804, wrong return value in a bool function:
       < return NULL;
       > return true;
      
      The problem was found because it did not compile on some platforms.
      
      Strangley, it did not have visible problems on other platforms,
      which did not fail to compile, although "return NULL" should compile to
      "return false" rather than "return true".
      d271fbd3
  5. 03 Apr, 2022 1 commit
    • Daniel Black's avatar
      MDEV-26136: Correct AIX/macOS cast warning (my_time.h) · 75b9014f
      Daniel Black authored
      tv_usec is a (suseconds_t) so we cast to it. Prevents the AIX(gcc-10) warning:
      
      include/my_time.h: In function 'void my_timeval_trunc(timeval*, uint)':
      include/my_time.h:249:65: warning: conversion from 'long int' to 'suseconds_t' {aka 'int'} may change value [-Wconversion]
        249 |   tv->tv_usec-= my_time_fraction_remainder(tv->tv_usec, decimals);
            |
      
      macOS is: conversion from 'long int' to '__darwin_suseconds_t' {aka 'int'} may change value
      
      On Windows suseconds_t isn't defined so we use the existing
      long return type of my_time_fraction_remainder.
      
      Reviewed by Marko Mäkelä
      
      Closes: #2079
      75b9014f
  6. 02 Apr, 2022 1 commit
    • Dmitry Shulga's avatar
      MDEV-28220: Assert failure in sp_head::~sp_head on parsing a syntax incorrect... · 8c169f5e
      Dmitry Shulga authored
      MDEV-28220: Assert failure in sp_head::~sp_head on parsing a syntax incorrect statement CREATE SEQUENCE ... RESTART inside CREATE PROCEDURE/CREATE FUNCTION
      
      This bug report is about the same issue as MDEV-28129 and MDEV-21173.
      The issue is that the macros YYABORT is called instead of MYSQL_YYABORT
      on parse error. In result the method LEX::cleanup_lex_after_parse_error
      is not called to clean up data structures created on parsing of
      the statement.
      8c169f5e
  7. 01 Apr, 2022 3 commits
  8. 31 Mar, 2022 2 commits
  9. 30 Mar, 2022 5 commits
    • Vlad Lesin's avatar
      MDEV-27343 Useless warning "InnoDB: Allocated tablespace ID <id> for... · c1ab0e6f
      Vlad Lesin authored
      MDEV-27343 Useless warning "InnoDB: Allocated tablespace ID <id> for <tablename>, old maximum was 0" during backup stage
      
      mariabackup does not load dictionary during backup, but it loads
      tablespaces, that is why fil_system.max_assigned_id is not set with
      dict_check_tablespaces_and_store_max_id(). There is no sense to issue the
      warning during backup.
      c1ab0e6f
    • Marko Mäkelä's avatar
      Cleanup: Remove some unused functions · 35425cfc
      Marko Mäkelä authored
      35425cfc
    • Rucha Deodhar's avatar
      MDEV-13005: Fixing bugs in SEQUENCE, part 3, 5/5 · 2eaaa887
      Rucha Deodhar authored
      Task 6:
      We can find the .frm type of file. If it is sequence then is_sequence
      passed to dd_frm_type() will be true. Since there is already a check
      to give error message if we trigger is on temporary table or view, an
      additional condition is added to check if .frm is sequence
      (is_sequence==true) and error message is changed to show
      "Trigger's '%-.192s' is view, temporary table or sequence" instead of
      "Trigger's '%-.192s' is view or temporary table".
      2eaaa887
    • Rucha Deodhar's avatar
      MDEV-13005: Fixing bugs in SEQUENCE, part 3, 4/5 · a8e7e7c0
      Rucha Deodhar authored
      Task 4 and 5:
      Already fixed when I started working on bug. Task 4 correctly gives syntax
      error ('(' and ')' are not part of create sequence syntax). Task 5 also
      gives correct error because s1 is table not sequence. Fails with
      ER_NOT_SEQUENCE2
      a8e7e7c0
    • Rucha Deodhar's avatar
      MDEV-13005: Fixing bugs in SEQUENCE, part 3, 3/5 · c6eeacd1
      Rucha Deodhar authored
      Task 3:
      Added an additional condition for SEQUENCE option to check if cache < 0.
      c6eeacd1