1. 25 Jan, 2011 3 commits
    • Marko Mäkelä's avatar
      29deba81
    • Marko Mäkelä's avatar
      Bug#59707 Unused compression-related parameters in buffer pool functions · c6ee5666
      Marko Mäkelä authored
      buf_block_alloc(): ulint zip_size is always 0.
      buf_LRU_get_free_block(): ulint zip_size is always 0.
      buf_LRU_free_block(): ibool* buf_pool_mutex_released is always NULL.
      
      Remove these parameters.
      
      buf_LRU_get_free_block(): Simplify the initialization of block->page.zip
      and release buf_pool_mutex() earlier.
      c6ee5666
    • Sunny Bains's avatar
      Fix Bug #59683 :InnoDB latch deadlock detector/violation debug code is very slow · 2a0bcbc9
      Sunny Bains authored
      There are two main pain points, one is lookup by thread id for sync_thread_t
      and the other is to do a lookup  by latch or level in sync_thread_t::levels.
      Changed the sync_thread_t::levels lookup and reserve operation from O(N)
      to O(1).
      
      Pure lookups are still O(N), the main change for pure lookup is that we no
      longer need to search up to SYNC_THREAD_N_LEVELS but only up to the number
      of slots actually ever used ie. it is possible some were used in the past
      but are now on the free list. If the in_use count drops to 0 we reset the
      free list too.
      
      Overload the sync_level_t::level field to track the free list. If
      sync_thread_t::latch == NULL then sync_thread_t::level contains the ordinal
      value of the previous free entry.
      
      rb://580 Approved by Jimmy Yang.
      2a0bcbc9
  2. 24 Jan, 2011 5 commits
  3. 20 Jan, 2011 3 commits
  4. 19 Jan, 2011 10 commits
  5. 18 Jan, 2011 19 commits
    • Libing Song's avatar
      Automerge · 921dcabe
      Libing Song authored
      921dcabe
    • Anitha Gopi's avatar
      automerge · 72a109bf
      Anitha Gopi authored
      72a109bf
    • Anitha Gopi's avatar
    • Libing Song's avatar
      Manual merge · 2d0fcc1d
      Libing Song authored
      2d0fcc1d
    • Libing Song's avatar
      Bug#58546 test rpl_packet timeout failure sporadically on PB · 5d75729c
      Libing Song authored
                  
      rpl_packet got a timeout failure sporadically on PB when stopping
      slave. The real reason of this bug is that STOP SLAVE stopped
      IO thread first and then stopped SQL thread. It was
      possible that IO thread stopped after replicating part of a
      transaction which SQL thread was executing. SQL thread would
      be hung if the transaction could not be rolled back safely.
                  
      After this patch, STOP SLAVE will stop SQL thread first and then stop IO
      thread, which guarantees that IO thread will fetch the reset of the
      events of the transaction that SQL thread is executing, so that SQL
      thread can finish the transaction if it cannot be rolled back safely.
                  
      Added below auxiliary files to make the test code neater.
      restart_slave_sql.inc
      rpl_connection_master.inc
      rpl_connection_slave.inc
      rpl_connection_slave1.inc
      5d75729c
    • John H. Embretsen's avatar
      Post push test fix for show_check.test. · 634b1025
      John H. Embretsen authored
      Fix for bug#45740 introduced test case using SHOW TABLE STATUS against a Memory table using latin1 character in table name.
      The test failed on Windows and FreeBSD due to a difference in the value for Avg_row_length.
      The average row length normally depends on the values for data length and row count. According to the 5.5 manual data length is approximate with Memory tables.
      With MyISAM and InnoDB the Avg_row_length is the same on Windows and Solaris.
      The solution implemented by this patch is to mask out the value for Avg_row_length, as it may vary when using Memory tables.
      634b1025
    • Bjorn Munch's avatar
      upmerge undo of 59063 · 8379f01b
      Bjorn Munch authored
      8379f01b
    • Bjorn Munch's avatar
      Bug #59063 rpl_migration_crash_safe fails on Windows · 9c7abc25
      Bjorn Munch authored
      Undoing the patch, it complicates the code but is not the solution
      
      I do not beleive newline mismatch could be the cause of this failure
      First, I cannot see how this could be a problem, mtr ignores the newline
        when reading the expect file, and the file is written and read on Windows.
      Second, if this really was the problem it should have been deterministic:
        either the newline is correctly interepreted or it is not.
      9c7abc25
    • Bjorn Munch's avatar
      oops forgot one file in last commit · 813af29b
      Bjorn Munch authored
      813af29b
    • Bjorn Munch's avatar
      Some more copyright fixes in mtr · 9093399b
      Bjorn Munch authored
      9093399b
    • Bjorn Munch's avatar
      Some more copyright fixes in mtr · 89aa03ae
      Bjorn Munch authored
      89aa03ae
    • Marko Mäkelä's avatar
      761bc05d
    • Marko Mäkelä's avatar
      Bug#59579 rw_lock_debug_print outputs to stderr · fe09f9e2
      Marko Mäkelä authored
      rw_lock_debug_print(): Add parameter FILE* for specifying the output stream.
      rw_lock_list_print_info(): Invoke rw_lock_debug_print() on file, not stderr.
      fe09f9e2
    • Bjorn Munch's avatar
      Fixed copyright headers in mtr src files · 7b9c4380
      Bjorn Munch authored
      7b9c4380
    • Bjorn Munch's avatar
      Fixed copyright headers in mtr src files · 097445eb
      Bjorn Munch authored
      097445eb
    • Alexander Barkov's avatar
      Merging from 5.1. · 8a576b83
      Alexander Barkov authored
      8a576b83
    • Alexander Barkov's avatar
      Bug#44332 my_xml_scan reads behind the end of buffer · cf0e22fe
      Alexander Barkov authored
      Problem: the scanner function tested for strings "<![CDATA[" and
      "-->" without checking input string boundaries, which led to valgrind's
      "Conditional jump or move depends on uninitialised value(s)" error.
      
      Fix: Adding boundary checking.
      
        @ mysql-test/r/xml.result
        @ mysql-test/t/xml.test
        Adding test
      
        @ strings/xml.c
        Adding a helper function my_xml_parser_prefix_cmp(),
        with input string boundary check.
      cf0e22fe
    • Vinay Fisrekar's avatar
      Merge from mysql-5.1 for · 3712d6c1
      Vinay Fisrekar authored
      sys_vars.innodb_max_dirty_pages_pct_func fails sporadically
            
      3712d6c1
    • Vinay Fisrekar's avatar
      · f25ab9fe
      Vinay Fisrekar authored
      BUG#58858 : sys_vars.innodb_max_dirty_pages_pct_func fails sporadically
      
      Committing After latest merge.      
      Modified check_pct procedure to check return value of wait condition instead 
      of calling "dirty_pct".
         
      Adding Review comments:
      1) Added comment for success variable value
      2) Procedure check_pct changed For Adding BOOLEAN input and SELECT QUERY Change
      f25ab9fe