- 01 Sep, 2005 1 commit
-
-
unknown authored
multi-threaded environment". To avoid deadlocks between several simultaneously run account management commands (particularly between FLUSH PRIVILEGES/SET PASSWORD and GRANT commands) we should always take table and internal locks during their execution in the same order. In other words we should first open and lock privilege tables and only then obtain acl_cache::lock/LOCK_grant locks. mysql-test/r/grant2.result: Added test for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in multi-threaded environment". mysql-test/t/grant2.test: Added test for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in multi-threaded environment". sql/mysqld.cc: acl_init/grant_init() are now used only at server start up so they always allocate temporary THD object and don't need argument for passing pointer to it. sql/sql_acl.cc: To avoid deadlocks between several simultaneously run account management commands (particularly between FLUSH PRIVILEGES/SET PASSWORD and GRANT commands) we should always take table and internal locks during their execution in the same order. In other words we should first open and lock privilege tables and only then obtain acl_cache::lock/LOCK_grant locks. Changed acl_reload()/grant_reload() and change_password()/update_user_table() in such way that they obey this principle. Now in acl_reload()/grant_reload()/ change_password() we open and lock privilege tables, then obtain internal locks and then call acl_load()/grant_load()/update_user_table() functions to do actual loading or updating. sql/sql_acl.h: acl_init/grant_init() are now used only at server start up so they always allocate temporary THD object and don't need argument for passing pointer to it. acl_reload()/grant_reload() now are able to report about their success or failure through return value. sql/sql_parse.cc: If reload_acl_and_cache() is called from SIGHUP handler we have to allocate temporary THD for execution of acl_reload()/grant_reload().
-
- 21 Aug, 2005 1 commit
-
-
unknown authored
into mysql.com:/Users/emurphy/src/bk-clean/mysql-4.1
-
- 20 Aug, 2005 2 commits
- 19 Aug, 2005 8 commits
-
-
unknown authored
into rurik.mysql.com:/home/igor/dev/mysql-4.1-0
-
unknown authored
mysql-test/r/ctype_cp932.result: Update results to make them deterministic mysql-test/t/ctype_cp932.test: Updated test to be deterministic on all machines
-
unknown authored
into radha.local:/Users/patg/mysql-build/mysql-4.1.clean sql/mysqld.cc: Auto merged
-
unknown authored
into rurik.mysql.com:/home/igor/dev/mysql-4.1-0
-
unknown authored
include/my_sys.h: Fixes from review (use version in log_event.cc instead) mysql-test/r/ctype_cp932.result: Updated test for bug#11338 (logging of prepared statement w/ blob type) mysql-test/t/ctype_cp932.test: udpated test for bug#11338 (logging of prepared statement w/ blob type) mysys/charset.c: Fixes from review (use version in log_event.cc instead) sql/item.cc: Fixes from review (store character_set_client differently so that fix can be merged forward to 5.0) sql/item.h: Fixes from review sql/log_event.cc: Fixes from review, str_to_hex is now used by item.cc sql/log_event.h: Added prototype for str_to_hex (now used by item.cc) sql/sql_prepare.cc: Fixes from review, store character_set_client differently so that Item_param::query_val_str can use it.
-
unknown authored
Added test cases for bug #12625. sql_select.cc: Fixed bug #12625. Fixed invalid removal of constant items from the DISTINCT list in the function create_distinct_group. sql/sql_select.cc: Fixed bug #12625. mysql-test/r/distinct.result: Added test cases for bug #12625. mysql-test/t/distinct.test: Added test cases for bug #12625.
-
unknown authored
sql/mysqld.cc: BUG #12498 Fixed Mispelled 'type'
-
unknown authored
We binlog the DROP TABLE for each table that was actually dropped. Per Sergei's suggestion a fixed buffer for the DROP TABLE query is pre-allocated from THD pool, and logging now is done in batches - new batch is started if the buffer becomes full. Reduced memory usage by reusing the table list instead of accumulating a list of dropped table names. Also fixed the problem if the table was not actually dropped, eg due to permissions. Extended the test case to make sure batched query logging does work. mysql-test/r/rpl_drop_db.result: test for query buffer overrun mysql-test/t/rpl_drop_db.test: test for query buffer overrun sql/mysql_priv.h: updated patch for BUG#4680 (incomplete DROP DATABASE breaking replication) BitKeeper/etc/ignore: Added support-files/MacOSX/postflight support-files/MacOSX/preflight to the ignore list sql/sql_db.cc: updated patch for BUG#4680 (incomplete DROP DATABASE breaking replication) sql/sql_table.cc: updated patch for BUG#4680 (incomplete DROP DATABASE breaking replication) sql/table.h: updated patch for BUG#4680 (incomplete DROP DATABASE breaking replication)
-
- 18 Aug, 2005 4 commits
-
-
unknown authored
into a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-4.1 netware/BUILD/nwbootstrap: Auto merged sql/mysqld.cc: Auto merged include/config-netware.h: Manual merge from 4.0 to 4.1.
-
unknown authored
against a later version of libc. include/config-netware.h: Changes for Netware. Needed to build against newer libc. netware/BUILD/nwbootstrap: Fix to build script. sql/mysqld.cc: Added an include.
-
unknown authored
than we've used before.
-
unknown authored
into mysql.com:/home/stewart/Documents/MySQL/4.1/main
-
- 17 Aug, 2005 7 commits
-
-
unknown authored
into asksasha.com:/reiser-data/mysql-dev/mysql-4.1 sql/mysql_priv.h: Auto merged
-
unknown authored
into linux.site:/home/reggie/bk/mysql-4.1
-
unknown authored
-
unknown authored
Bug#12615: Host name might not resolve, use short host name mysql-test/lib/mtr_misc.pl: Bug#12615: Host name might not resolve, use short host name mysql-test/mysql-test-run.pl: Bug#12615: Host name might not resolve, use short host name
-
unknown authored
into mysql.com:/Users/emurphy/src/work/mysql-4.1-bug11338 sql/item.h: Auto merged
-
unknown authored
In cp932, '\' character can be the second byte in a multi-byte character stream. This makes it difficult to use mysql_escape_string. Added flag to indicate which languages allow '\' as second byte of multibyte sequence so that when putting a prepared statement into the binlog we can decide at runtime whether hex encoding is really needed. include/m_ctype.h: Added bool to indicate character sets which allow '\' as the second byte of a multibyte character set (currently only cp932). For these character sets, escaping with '\' is dangerous and leads to corruption in replication. include/my_sys.h: Add function to enocde a string as hex with no prefix (bare) mysys/charset.c: Add function to encode string as hex with no prefix (bare). sql/item.cc: Check the connection character set to see if escape_string_for_mysql is safe, or if character set requires unambiguous (hex) encoding sql/item.h: Pass thd to query_val_str for access to charset() sql/sql_prepare.cc: Pass thd to query_val_str. strings/ctype-big5.c: Add escape_with_backslash_is_dangerous flag. strings/ctype-bin.c: Add escape_with_backslash_is_dangerous flag strings/ctype-cp932.c: Add escape_with_backslash_is_dangerous flag. strings/ctype-czech.c: Add escape_with_backslash_is_dangerous flag. strings/ctype-euc_kr.c: Add escape_with_backslash_is_dangerous flag. strings/ctype-extra.c: Add escape_with_backslash_is_dangerous flag. strings/ctype-gb2312.c: Add escape_with_backslash_is_dangerous flag. strings/ctype-gbk.c: Added escape_with_backslash_is_dangerous flag. strings/ctype-latin1.c: Added escape_with_backslash_is_dangerous flag. strings/ctype-sjis.c: Added escape_with_backslash_is_dangerous flag. strings/ctype-tis620.c: Added esacpe_with_backslash_character_is_dangerous flag. strings/ctype-uca.c: Added escape_with_backslash_is_dangerous flag. strings/ctype-ucs2.c: Added escape_with_backslash_is_dangerous. strings/ctype-ujis.c: Added escape_with_backslash_is_dangerous flag. strings/ctype-utf8.c: Added escape_with_backslash_is_dangerous. strings/ctype-win1250ch.c: Added escape_with_backslash_is_dangerous.
-
unknown authored
Bug#11884: Corrected --start-and-exit, start the server as if the default/specified test case would have been run mysql-test/mysql-test-run.pl: Bug#11884: Corrected --start-and-exit, start the server as if the default/specified test case would have been run
-
- 16 Aug, 2005 6 commits
-
-
unknown authored
Bug#11792: Check all of status code, to catch a crash as a failure mtr_cases.pl: Code cleanup for skipped/disabled handling mtr_process.pl: In debug mode, report if mysqladmin did not at least make the server stop listening to the port. Increased the time waiting for terminating to 20 seconds, to wait for really slow slave shutdown. Added call to start_reap_all(), to avoid zombies. mtr_report.pl: Removed prototype for unused function mtr_report_test_disabled() mysql-test/lib/mtr_report.pl: Removed prototype for unused function mtr_report_test_disabled() mysql-test/lib/mtr_cases.pl: Code cleanup for skipped/disabled handling mysql-test/lib/mtr_process.pl: Bug#11792: Check all of status code, to catch a crash as a failure
-
unknown authored
Bug#12094: Let sleep_until_file_created() return the pid as intended mysql-test/lib/mtr_process.pl: Bug#12094: Let sleep_until_file_created() return the pid as intended
-
unknown authored
into mysql.com:/Users/kent/mysql/bk/mysql-4.1
-
unknown authored
into mysql.com:/home/stewart/Documents/MySQL/4.1/bug11538 acinclude.m4: Auto merged
-
unknown authored
Added missing drop statement subselect.test: Added missing drop statement. mysql-test/t/subselect.test: Added missing dro statement. mysql-test/r/subselect.result: Added missing drop statement
-
unknown authored
Fixed bug #11479. The JOIN::reinit method cannot call setup_tables after the optimization phase since this function removes some optimization settings for joined tables. E.g. it resets values of the null_row flag to 0. subselect.result, subselect.test: Added a test case for bug #11479. mysql-test/t/subselect.test: Added a test case for bug #11479. mysql-test/r/subselect.result: Added a test case for bug #11479. sql/sql_select.cc: Fixed bug #11479. The JOIN::reinit method cannot call setup_tables after the optimization phase since this function removes some optimization settings for joined tables. E.g. it resets values of the null_row flag to 0.
-
- 15 Aug, 2005 5 commits
- 13 Aug, 2005 4 commits
-
-
unknown authored
into 50.0.168.192.in-addr.arpa:/Users/bell/mysql/bk/work-bug2-4.1
-
unknown authored
into 50.0.168.192.in-addr.arpa:/Users/bell/mysql/bk/work-bug2-4.1
-
unknown authored
mysql-test/r/subselect.result: testst of IN subqueries with row mysql-test/t/subselect.test: tests of ion subqueries with row sql/item.h: add method to prevent of removing Item_ref_null_helper from HAVING sql/item_cmpfunc.h: Prevented removing of Item_test_isnotnull from HAVING sql/item_subselect.cc: fixed converting row IN subqueries sql/sql_select.cc: fixed debug print
-
unknown authored
Don't skip SET command even if --replicate-wild* says to. E.g., SET ONE_SHOT TIME_ZONE = 'XYZ' should be executed (BUG #12542) sql/sql_parse.cc: Don't skip SET command even if --replicate-wild* says to. E.g., SET ONE_SHOT TIME_ZONE = 'XYZ' should be executed (BUG #12542)
-
- 12 Aug, 2005 2 commits