1. 23 Aug, 2021 6 commits
  2. 21 Aug, 2021 1 commit
  3. 20 Aug, 2021 3 commits
    • Faustin Lammler's avatar
      Unused flag creates cleaning issue (piuparts) · 557bb344
      Faustin Lammler authored
      The "$mysql_statedir/debian-$MAJOR_VER.flag" is not used by any
      maintainer script ("$mysql_datadir/debian-$MAJOR_VER.flag" is used,
      https://github.com/MariaDB/server/blob/10.6/debian/mariadb-server-10.6.postinst#L164).
      
      See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985870
      
      Fix also some minor typo.
      557bb344
    • Marko Mäkelä's avatar
      MDEV-26443 HAVE_C99_INITIALIZERS is not applicable to C++ · 0b2241ae
      Marko Mäkelä authored
      Designated initializers were introduced in ISO/IEC 9899:1999 (C99),
      but the C code base of MariaDB is supposed to be compatible with the
      1990 version of the standard.
      
      The InnoDB code based was switched from C to C++ in
      MySQL 5.6 and MariaDB 10.0. C++ did not introduce syntax for
      designated initializers until ISO/IEC 14882:2020.
      Our C++ code base is still stuck with the 2011 or earlier version of
      that standard.
      
      Therefore, this check as well as the macro STRUCT_FLD are best removed.
      0b2241ae
    • Daniel Black's avatar
      deb: columnstore not 32bit (fix stretch) · a6621867
      Daniel Black authored
      This corrects the autobake on Stretch
      
      Caused by commit 0268b871
      and commit 3d16e0e1.
      
      For very strange reasons (still a mistery) the above commits caused the
      federatedx, archive and blackhole plugins to be missing in the
      install location even though they where built in the build log.
      
      This only occured on Stretch and not recent Ubuntu and Debian
      distros.
      
      The stretch autobake output contained:
      
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_archive.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_archive.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_blackhole.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_blackhole.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_federatedx.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_federatedx.sodh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_archive.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_archive.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_blackhole.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_blackhole.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_federatedx.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_federatedx.so
      a6621867
  4. 19 Aug, 2021 10 commits
  5. 18 Aug, 2021 13 commits
  6. 17 Aug, 2021 3 commits
    • Eugene Kosov's avatar
      MDEV-20931 ALTER...IMPORT can crash the server · 890f2ad7
      Eugene Kosov authored
      Main idea: don't log-and-crash but propogate error to the upper layers of stack
      to handle it and show to a user.
      890f2ad7
    • Vlad Lesin's avatar
      MDEV-26206 gap lock is not set if implicit lock exists · 2d259187
      Vlad Lesin authored
      If lock type is LOCK_GAP or LOCK_ORDINARY, and the transaction holds
      implicit lock for the record, then explicit gap-lock will not be set for
      the record, as lock_rec_convert_impl_to_expl() returns true and
      lock_rec_convert_impl_to_expl() bypasses lock_rec_lock() call.
      
      The fix converts explicit lock to implicit one if requested lock type is
      not LOCK_REC_NOT_GAP.
      
      innodb_information_schema test result is also changed as after the fix
      the following statements execution:
      
      SET autocommit=0;
      INSERT INTO t1 VALUES (5,10);
      SELECT * FROM t1 FOR UPDATE;
      
      leads to additional gap lock requests.
      2d259187
    • Marko Mäkelä's avatar
      MDEV-16264 fixup: Add missing 'static' · cce33787
      Marko Mäkelä authored
      cce33787
  7. 16 Aug, 2021 4 commits
    • Marko Mäkelä's avatar
      MDEV-26372 enforce-storage-engine=InnoDB has no usability as an option to mysqld-install-db · dc58303c
      Marko Mäkelä authored
      Creation of tables by the three names mysql.user, mysql.host, mysql.db
      was being blocked in the function row_mysql_is_system_table().
      
      Since commit 4abb8216 (MDEV-17658),
      mysql.user is a view, not a table. Since commit
      ead9a34a (MDEV-15851), mysql.host
      is not being created at all.
      
      Let us remove the special handling of table names in InnoDB,
      and allow mysql.db to be created in InnoDB. The special handling
      was originally added in commit e84ef2b7
      without any explanation.
      
      Reviewed by: Sergei Golubchik
      dc58303c
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-26273 InnoDB FTS DDL fails when innodb_force_recovery is set to 2 · 25531304
      Thirunarayanan Balathandayuthapani authored
      InnoDB DDL fails when it tries to sync the table
      when innodb_force_recovery is set to 2. Problem
      is that fts_optimize_wq is not initialized when
      there are no background threads. fts_sync_during_ddl()
      should check whether fts_optimize_wq is initialized.
      25531304
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-26131 SEGV in ha_innobase::discard_or_import_tablespace · 89445b64
      Thirunarayanan Balathandayuthapani authored
      Import operation without .cfg file fails when there is mismatch of index
      between metadata table and .ibd file. Moreover, MDEV-19022 shows
      that InnoDB can end up with index tree where non-leaf page has only
      one child page. So it is unsafe to find the secondary index root page.
      
      This patch does the following when importing the table without .cfg file:
      
      1) If the metadata contains more than one index then InnoDB stops
      the import operation and report the user to drop all secondary
      indexes before doing import operation.
      
      2) When the metadata contain only clustered index then InnoDB finds the
      index id by reading page 0 & page 3 instead of traversing the
      whole tablespace.
      89445b64
    • Marko Mäkelä's avatar
      MDEV-26376 pars_info_bind_id() unnecessarily copies strings · 4cd063b9
      Marko Mäkelä authored
      pars_info_bind_id(): Remove the parameter copy_name. It was always
      being passed as constant TRUE or true. It turns out that copying
      the string is completely unnecessary. In all calls except the one
      in fts_get_select_columns_str() and fts_doc_fetch_by_doc_id(),
      the parameter is being passed as a compile-time constant, and therefore
      the pointer cannot become stale. In that special call, the string
      that is being passed is allocated from the same memory heap that
      pars_info_bind_id() would have been using.
      
      pars_info_add_id(): Remove (unused declaration).
      4cd063b9