An error occurred fetching the project authors.
  1. 20 Jan, 2005 1 commit
    • unknown's avatar
      - renamed client_test -> mysql_client_test · 5a35a07f
      unknown authored
      - renamed the tests that use the embedded server (client_test -> 
        mysql_client_test_embedded, mysqltest -> mysql_test_embedded
        and changed some Makefiles and scripts so they are installed in $bindir
        (required to be able to run the test suite against the embedded server)
      
      
      tests/mysql_client_test.c:
        Rename: tests/client_test.c -> tests/mysql_client_test.c
      libmysql/libmysql.c:
        - renamed client_test.c to mysql_client_test.c in a comment
      libmysqld/examples/Makefile.am:
        - renamed client_test -> mysql_client_test_embedded
        - renamed mysqltest -> mysqltest_embedded
        - both will be installed in $bindir
      scripts/make_binary_distribution.sh:
        - install mysql_client_test, mysql_client_test_embedded and mysqltest_embedded
          into bin directory
      tests/Makefile.am:
        - renamed client_test to mysql_client_test
      BitKeeper/etc/ignore:
        Added tests/mysql_client_test to the ignore list
      5a35a07f
  2. 12 Jan, 2005 1 commit
  3. 21 Dec, 2004 1 commit
    • unknown's avatar
      Fix to perform correctly with charsets in embedded server · 2f7249f9
      unknown authored
      BitKeeper/deleted/.del-ctype_recoding.result.es~45c6fe567949af:
        Delete: mysql-test/r/ctype_recoding.result.es
      BitKeeper/deleted/.del-func_test.result.es~4de135264090aa14:
        Delete: mysql-test/r/func_test.result.es
      BitKeeper/deleted/.del-ps_2myisam.result.es~5132bde9c07c41e8:
        Delete: mysql-test/r/ps_2myisam.result.es
      BitKeeper/deleted/.del-ps_3innodb.result.es~a3613f0e86132472:
        Delete: mysql-test/r/ps_3innodb.result.es
      BitKeeper/deleted/.del-ps_4heap.result.es~956ae2c46b66b6ed:
        Delete: mysql-test/r/ps_4heap.result.es
      BitKeeper/deleted/.del-ps_5merge.result.es~6093a834fec21efe:
        Delete: mysql-test/r/ps_5merge.result.es
      BitKeeper/deleted/.del-ps_6bdb.result.es~57b94c3756e3d093:
        Delete: mysql-test/r/ps_6bdb.result.es
      libmysqld/lib_sql.cc:
        Charset conversion implemented
      mysql-test/r/query_cache.result.es:
        correct test result provided
      tests/client_test.c:
        now it works
      2f7249f9
  4. 16 Dec, 2004 1 commit
    • unknown's avatar
      Making 4.1 tree compile with -ansi -pedantic · 39a1942e
      unknown authored
      include/raid.h:
        Fixing compile-time warning: pragma interface is not supported in C,
        let's move it to C++ part of the header.
      ndb/include/kernel/signaldata/CreateEvnt.hpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/include/kernel/signaldata/PackedSignal.hpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/include/kernel/signaldata/SumaImpl.hpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/common/debugger/signaldata/DictTabInfo.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/common/debugger/signaldata/NFCompleteRep.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/common/logger/FileLogHandler.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/backup/BackupInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbacc/DbaccInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbdih/DbdihInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dblqh/DblqhInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbtc/DbtcInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbtup/DbtupGen.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbtux/Dbtux.hpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbtux/DbtuxGen.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/dbutil/DbUtil.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/grep/GrepInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/ndbcntr/NdbcntrInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/ndbfs/VoidFs.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/qmgr/QmgrInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/suma/Suma.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/suma/SumaInit.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/kernel/blocks/trix/Trix.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/ndbapi/NdbEventOperation.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/src/ndbapi/NdbScanFilter.cpp:
        - remove extra erroneous ; from ends of function definitions
      ndb/tools/restore/Restore.cpp:
        - remove extra erroneous ; from ends of function definitions
      sql/item_create.h:
        - remove extra erroneous ;
      sql/sql_cache.cc:
        - remove extra erroneous ;
      tests/client_test.c:
        - fix -pedantic warning
      39a1942e
  5. 14 Dec, 2004 3 commits
    • unknown's avatar
      A fix of return value of mysql_stmt_bind_result() and cleanup. · 06b7c998
      unknown authored
      include/errmsg.h:
        New libmysql error status code CR_NO_STMT_METADATA
      libmysql/errmsg.c:
        Error message for CR_STMT_NO_METADATA.
        Adding an empty line to shorten further diffs when new error
        messages are added (as suggested by Monty).
      libmysql/libmysql.c:
        Return error from mysql_stmt_bind_result() if the statement contains
        no metadata.
        A few comments fixed.
      tests/client_test.c:
        Tests fixed: mysql_stmt_bind_result now returns error if there is no
        metadata.
      06b7c998
    • unknown's avatar
      bug#6275 "client_test" fail in 4.1.7 make test · efa3f502
      unknown authored
      bug#6911 resultset metadata always return client character set
      
      efa3f502
    • unknown's avatar
      Test for BUG#7242: Testing prepare + several times execute · 06fc7b5c
      unknown authored
      (here in client_test.c because we need to check if several PS execution works and the bug shows up with binary protocol only ) 
      
      
      tests/client_test.c:
        Test for BUG#7242: Testing prepare + several times execute
      06fc7b5c
  6. 07 Dec, 2004 1 commit
    • unknown's avatar
      Fix for a bug #6996 · 086dc7fd
      unknown authored
      BitKeeper/etc/ignore:
        Added analyse.test client/mysqladmin.c to the ignore list
      libmysql/libmysql.c:
        Fix for a bug #6996
        
        This fix enables that after all rows are read from a buffered result,
        mysql_stmt_data_seek(stmt,0) can rewind a counter to the beginning,
        so that rows can be re-fetched.
      tests/client_test.c:
        Addition of a test for fix of the bug #6996 in client_test.c
      086dc7fd
  7. 02 Dec, 2004 1 commit
    • unknown's avatar
      Fixes to make mysql-test-run --embedded-server working · f9c1ad60
      unknown authored
      mysql-test/mysql-test-run.sh:
        Tests that can't be fixed now showed in the ignore-list
      mysql-test/r/query_cache.result.es:
        test result renewed
      mysql-test/r/select.result.es:
        test result renewed
      mysql-test/r/type_blob.result.es:
        test result renewed
      mysql-test/r/type_float.result.es:
        test result renewed
      sql/sql_prepare.cc:
        time values sending fixed
      tests/client_test.c:
        that doesnt work in embedded server
      BitKeeper/etc/ignore:
        Added libmysqld/ha_archive.cc libmysqld/ha_example.cc libmysqld/ha_tina.cc to the ignore list
      f9c1ad60
  8. 18 Nov, 2004 1 commit
  9. 15 Nov, 2004 1 commit
    • unknown's avatar
      Fix for bug #6266 "Invalid DATETIME value is not handled properly". · 1ef40cb2
      unknown authored
      In server we assume that datetime values stored in MYSQL_TIME struct
      are normalized (and year is not greater than 9999), so we should 
      perform range checks in all places then we convert something to
      MYSQL_TIME. 
      
      
      include/my_time.h:
        Added one more argument to set_zero_time() function to make it more 
        convinient.
        Added comment clarifying why MAX_DATE_STRING_REP_LENGTH value is 30.
      include/mysql_time.h:
        Documented MySQL's internal assumptions for members of MYSQL_TIME
        structure.
      libmysql/libmysql.c:
        It does not make sense to set MYSQL_TIME::time_type twice in case of 
        errors.
      mysql-test/r/type_datetime.result:
        Added test for bug #6266 "Invalid DATETIME value not handled properly".
      mysql-test/t/type_datetime.test:
        Added test for bug #6266 "Invalid DATETIME value not handled properly".
      sql-common/my_time.c:
        str_to_datetime(): Added missing check for too big year values.
        set_zero_time(): added time_type argument, since MYSQL_TIMESTAMP_NONE
          is not the value that we want in most cases.
      sql/field.cc:
        Field_datetime::store_time():
          clarified why we don't perform any range checks here.
      sql/item.cc:
        Item_param::set_time():
         Added comment describing this method and range checking for TIME
         values.
      sql/sql_prepare.cc:
        Removed comments about range checking for TIME values in prepared 
        statements, which are no longer true.
        set_zero_time() has one more argument now.
      tests/client_test.c:
        Added test for bug #6266 "Invalid DATETIME value not handled properly"
      1ef40cb2
  10. 12 Nov, 2004 2 commits
  11. 11 Nov, 2004 1 commit
  12. 07 Nov, 2004 1 commit
    • unknown's avatar
      Simpler arena swapping code · dda7a6a9
      unknown authored
      Now thd->mem_root is a pointer to thd->main_mem_root and THR_MALLOC is a pointer to thd->mem_root.
      This gives us the following benefits:
      - Allow us to easily detect if arena has already been swapped before (this fixes a bug in setup_conds() where arena was swaped twice in some cases)
      - Faster swaps of arenas (as we don't have to copy the whole MEM_ROOT)
      - We don't anymore have to call my_pthread_setspecific_ptr(THR_MALLOC,...) to change where memory is alloced. Now it's enough to set thd->mem_root
      
      
      
      client/mysqltest.c:
        Remove some not needed defines
        (Things like this should be done in config-win.h)
      include/config-win.h:
        Added popen() and pclose() compatibility macros
      mysql-test/t/rpl_failed_optimize-master.opt:
        Portability fix
      sql/ha_berkeley.cc:
        New thd->memroot handling
      sql/item_cmpfunc.cc:
        Simpler arena swapping code
      sql/item_func.cc:
        Simpler arena swapping code
      sql/item_subselect.cc:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/item_sum.cc:
        New thd->mem_root handling
      sql/item_timefunc.cc:
        Fixed not-initalized usage errors found by valgrind
      sql/log_event.cc:
        New thd->mem_root handling
      sql/mysql_priv.h:
        New thd->mem_root handling
      sql/mysqld.cc:
        New thd->mem_root handling
      sql/opt_range.cc:
        New thd->mem_root handling
      sql/repl_failsafe.cc:
        New thd->mem_root handling
      sql/set_var.cc:
        New thd->mem_root handling
      sql/sql_acl.cc:
        New thd->mem_root handling
      sql/sql_base.cc:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/sql_class.cc:
        New thd->mem_root handling
      sql/sql_class.h:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/sql_db.cc:
        New thd->mem_root handling
      sql/sql_error.cc:
        New thd->mem_root handling
      sql/sql_help.cc:
        New thd->mem_root handling
      sql/sql_insert.cc:
        New thd->mem_root handling
      sql/sql_parse.cc:
        New thd->mem_root handling
        Added some extra checking of return value of new
      sql/sql_prepare.cc:
        New thd->mem_root handling
      sql/sql_select.cc:
        New thd->mem_root handling
      sql/sql_select.h:
        New thd->mem_root handling
      sql/sql_union.cc:
        Simpler arena swapping code
      sql/sql_yacc.yy:
        New thd->mem_root handling
      sql/table.cc:
        New thd->mem_root handling
      sql/thr_malloc.cc:
        New thd->mem_root handling
      tests/client_test.c:
        Added drop table to some tests
        Changed some table names to 't1'
      dda7a6a9
  13. 05 Nov, 2004 1 commit
    • unknown's avatar
      A fix and test case for the bug reported by Reggie: if character set · a93f4948
      unknown authored
      of client equals to character set of connection, possibly required
      conversion to character set of column is not performed
      (prepared statements, data is supplied using placeholders).
      
      
      sql/item.cc:
        Fix for the bug reported by Reggie: if character_set_connection
        is equal to character_set_client, placeholder's value is not converted
        furhter to character set of column when it's different.
        This is because the original implementation left placeholder's character
        set intact (binary) if there were no need for client->connection conversion.
      tests/client_test.c:
        A test case for the conversion bug.
      a93f4948
  14. 04 Nov, 2004 1 commit
    • unknown's avatar
      A test case for Bug#4172 "Floating point conversion looses precision · 8f0b8699
      unknown authored
      (prepared staements)": adding the test case to close the bug
      (the bug was fixed along with other conversion incompatibilities 
      in 4.1.7)
      
      
      tests/client_test.c:
        A test case for Bug#4172: "Floating point conversion loses precision 
        (prepared staements)"
        Fix memleak.
      8f0b8699
  15. 02 Nov, 2004 2 commits
    • unknown's avatar
      bad automerge (?) fixed · 65d027bd
      unknown authored
      65d027bd
    • unknown's avatar
      Remove usage of !$ from mysql-tests · 2bcfcbfe
      unknown authored
      Added protocol::flush() for easier embedded-server code
      Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      Added option --silent to client_test
      
      
      client/mysqltest.c:
        Removed compiler warning
        Fixed identation & comments from earlier push
        Renamed variable 'disable_abort_on_error' to 'abort_on_error'
        Ensure that '$mysql_errno' also with --ps-protocol
      include/mysql_com.h:
        Removed special handling of net_flush for embedded server
      mysql-test/r/mysqltest.result:
        Remove usage of !$ in tests
      mysql-test/t/client_test.test:
        Use --silent
      mysql-test/t/comments.test:
        Remove usage of !$ in tests
      mysql-test/t/join_outer.test:
        Remove usage of !$ in tests
      mysql-test/t/key.test:
        Remove usage of !$ in tests
      mysql-test/t/mysqltest.test:
        Remove usage of !$ in tests
      mysql-test/t/show_check.test:
        Remove usage of !$ in tests
      mysql-test/t/temp_table.test:
        Remove usage of !$ in tests
      mysql-test/t/type_ranges.test:
        Remove usage of !$ in tests
      sql/mysqld.cc:
        Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      sql/net_serv.cc:
        Remove special usage of net_flush in embedded server
      sql/protocol.cc:
        Added protocol::flush() for easier embedded-server code
      sql/protocol.h:
        Added protocol::flush() for easier embedded-server code
      sql/sql_prepare.cc:
        Added protocol::flush() for easier embedded-server code
        Remove one extra flush() for prepared statements
      sql/sql_show.cc:
        Added protocol::flush() for easier embedded-server code
      tests/client_test.c:
        Added option --silent
      2bcfcbfe
  16. 27 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6096 "field.max_length is always zero for · 7c040432
      unknown authored
      numeric columns (stmt_resultset_metadata)"
      
      
      libmysql/libmysql.c:
        A fix for Bug#6096 "field.max_length is always zero for numeric columns
         (stmt_resultset_metadata)": set field->max_lenght for numeric
        columns when we set up skip_result functions. A minor drawback for this 
        approach is that field->max_length  can be not zero even if 
        STMT_ATTR_UPDATE_MAX_LENGTH is not set.
      sql-common/my_time.c:
        Fix valgrind warning.
      tests/client_test.c:
        A test case for Bug#6096 "field.max_length is always zero for numeric 
        columns (stmt_resultset_metadata)
      7c040432
  17. 26 Oct, 2004 1 commit
  18. 22 Oct, 2004 1 commit
  19. 21 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for bug#6059 "mysql_stmt_field_count returns · 454cc94e
      unknown authored
      positive numbers when no resultset is available": when sending
      result set metadata we need to use virtual select_result::send_fields, 
      and not address protocol directly, because select_result descendents may 
      intercept result set (it's the case for example for SELECT INTO OUTFILE).
      
      
      sql/sql_class.h:
        A fix for bug#6059 "mysql_stmt_field_count returns positive numbers 
        when no resultset is available": introducing select_result::field_count()
        method to report actual number of fields in a result set, if any result
        set is sent to client.
      sql/sql_prepare.cc:
        A fix for bug#6059 "mysql_stmt_field_count returns 
        positive numbers when no resultset is available": when sending
        result set metadata we need to use virtual select_result::send_fields, 
        and not address protocol directly, because select_result descendents may 
        intercept result set (it's the case for example for SELECT INTO OUTFILE).
        Now we need to always have lex->result set if we're in prepared statements.
      tests/client_test.c:
        A test case for Bug#6059 "mysql_stmt_field_count returns positive 
        numbers when no resultset is available"
      454cc94e
  20. 20 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for bug#6058 "Prepared statements return '0000-00-00' · 140d842a
      unknown authored
      (date) as empty  string": preserve time type (date, time, or datetime) for
      zero dates, times, and datetimes.
      
      
      libmysql/libmysql.c:
        A fix for bug#6058 "Prepared statements return '0000-00-00' (date) as empty
         string": preserve time type (date, time, or datetime) for zero 
        dates, times, and datetimes.
      tests/client_test.c:
        A test case for Bug#6058, the existing tests required some adjustments too.
      140d842a
  21. 19 Oct, 2004 1 commit
    • unknown's avatar
      Review of all code pushed since last review · da02110d
      unknown authored
      Simple optimzations and cleanups
      Removed compiler warnings and fixed portability issues
      Added client functions 'mysql_embedded()' to allow client to check if we are using embedded server
      Fixes for purify
      
      
      client/mysqlimport.c:
        Remove not used variable
      client/mysqltest.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
        Simplified code
        Remove usage of sprintf("%llu") as this is not portable
      include/mysql.h:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      innobase/srv/srv0start.c:
        Don't use memcmp() when using purify (to avoid false warnings)
      libmysql/libmysql.c:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      libmysql/libmysql.def:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      myisam/myisam_ftdump.c:
        Remove compiler warning
      myisam/myisamchk.c:
        Remove compiler warning
      myisam/rt_test.c:
        #ifdef not used code
      mysys/hash.c:
        Remove compiler warning (from last push)
      mysys/my_gethwaddr.c:
        Remove compiler warning
      ndb/src/ndbapi/ndberror.c:
        #ifdef not used code
      regex/regcomp.c:
        Remove not used code
      regex/regcomp.ih:
        Remove not used code (to remove compiler warnings)
      sql-common/client.c:
        Remove compiler warnings
      sql/field.cc:
        Simple optimization
      sql/ha_innodb.cc:
        Rename mysql_embedded -> mysqld_embedded
      sql/item.cc:
        Fix comments
        Move variables first on block
        Remove else after return
        Simple optimizations
        (no logic changes)
      sql/item_cmpfunc.cc:
        Added comment
      sql/mysql_priv.h:
        Rename mysql_embedded -> mysqld_embedded
      sql/mysqld.cc:
        Rename mysql_embedded -> mysqld_embedded
      sql/sql_acl.cc:
        Added comments
        simple optimization
        Fixed 'very unlikely' bug when doing REVOKE ALL PRIVILEGES
      sql/sql_select.cc:
        More comments
        Simple optimization
      sql/sql_show.cc:
        Simple changes to make similar code similar
        More comments
      sql/sql_string.cc:
        Trivial optimization and better code layout
      strings/Makefile.am:
        Change xml.c to use bcmp to avoid warnings from purify
      strings/xml.c:
        Change xml.c to use bcmp to avoid warnings from purify
      tests/client_test.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
      da02110d
  22. 17 Oct, 2004 1 commit
    • unknown's avatar
      Fix for bug #6081 "Call to deprecated mysql_create_db() function crashes · cb9b1672
      unknown authored
      server".
      
      Altough mysql_create_db()/mysql_drop_db() API calls are deprecated
      since 4.0, they should not crash server and should not stall connection
      in case of errors. 
      
      
      sql/sql_parse.cc:
        Handling of COM_CREATE_DB, COM_DROP_DB:
          mysql_create_db() requires from its second parameter to be non-zero.
          We also should call send_error() if mysql_create_db or mysql_drop_db
          return error (like we do it for SQL versions of these commands).
      tests/client_test.c:
        Added test for bug #6081 "Execution of deprecated mysql_create_db()
        crashes server".
      cb9b1672
  23. 15 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6049 "Loss of sign when using prepared · 50129a20
      unknown authored
      statements and negative time/date values". 
      The bug was in wrong sprintf format used in the client library.
      The fix moves TIME -> string conversion functions to sql-common and
      utilized them in the client library.
      
      
      include/my_time.h:
        Declarations for new functions shared between the client and server.
      libmysql/libmysql.c:
        Fix for Bug#6049 "Loss of sign when using prepared statements and negative
        time/date values": use the same function as the server to convert
        date/time/datetime values to strings.
      sql-common/my_time.c:
        Implementation of my_{time,datetime,date,TIME}_to_str: it's
        needed by the client library, so it should be shared.
      sql/field.cc:
        Don't create String object if it's not needed.
      sql/item.cc:
        Don't create String object if it's not needed: TIME_to_string was
        moved to my_TIME_to_str, with different arguments.
      sql/item_timefunc.cc:
        Don't create String object if it's not needed.
      sql/mysql_priv.h:
        TIME_to_string and MAX_DATE_REP_LENGTH moved to the client library.
        MAX_DATE_REP_LENGTH was renamed to MAX_DATE_STRING_REP_LENGTH to not 
        conflict with the same name in libmysql.c
      sql/protocol.cc:
        Don't create String object if it's not needed.
      sql/time.cc:
        Implementation of my_{time,date,datetime,TIME}_to_str moved to my_time.c
        shared between the client and the server.
      tests/client_test.c:
        A test case for Bug#6049.
      50129a20
  24. 13 Oct, 2004 1 commit
    • unknown's avatar
      tests/client_test.c: · 8a559cfe
      unknown authored
        Make checks (asserts) performed in client_test.c work in non-debug
        builds.
      
      
      tests/client_test.c:
        Make checks (asserts) performed in client_test.c work in non-debug
        builds: all asserts/DBUG_ASSERTs replaced with if (!(expr)) abort();
      8a559cfe
  25. 07 Oct, 2004 1 commit
    • unknown's avatar
      A fix for Bug#5748 "Prepared statement with BETWEEN and bigint values · 5eba8d3a
      unknown authored
      crashes mysqld": implementation for a generic item tree modifications
      registry. Every item tree modification which should be rolled back for
      subsequent execution of a prepared statement or stored procedure should
      be saved in the registry. All such modifications are rolled back at once
      during cleanup stage of PS.
      Actual fix for the bug just adds a call to register modifications to
      convert_constant_item.
      Post review fixes implemented.
      
      
      mysql-test/r/ps.result:
        A fix for bug#5748, test results fixed.
      mysql-test/t/ps.test:
        A test case for Bug#5748 "Prepared statement with BETWEEN and bigint 
        values crashes mysqld"
      sql/item.cc:
        Fix for Bug#5748 "Prepared statement with BETWEEN and bigint values
        crashes mysqld":
        First step in removing up item-specific cleanups: now all such
        tree modifications should be done using the genericm mechanism implemented
        in this changeset.
      sql/item.h:
        Fix for Bug#5748 "Prepared statement with BETWEEN and bigint values
        crashes mysqld": no need for an item-specific change record any more.
      sql/item_cmpfunc.cc:
        A fix for Bug#5748 "Prepared statement with BETWEEN and bigint 
        values crashes mysqld": register item tree transformation performed by
        convert_constant_item.
      sql/sql_class.cc:
        Implementation for item tree transformations registry.
      sql/sql_class.h:
        Declarations, necessary for the tree transformations registry.
      sql/sql_parse.cc:
        Assert that the item tree transformations registry is not used for 
        conventional execution.
      sql/sql_prepare.cc:
        Use of the item tree modifications registry in prepared statements:
        rollback all modifications in the end of statement prepare and execute.
        Also we now always set thd->current_arena to be able to determine that
        this is an execution of prepared statement inside the registry code.
      tests/client_test.c:
        A typo fixed.
      5eba8d3a
  26. 28 Sep, 2004 1 commit
    • unknown's avatar
      client_test.test: · c7a18f63
      unknown authored
        Run client_test as a testcase
        new file
      mysql-test-run.sh:
        More clearly report failure if --force, also exit 1
      client_test.c:
        Use MAXPATHLEN in test_frm_bug()
        Renable test cases disabled for running from mysql-test-run
      mysqltest.c:
        Don't check errno from popen, may not be set
      
      
      client/mysqltest.c:
        Don't check errno from popen, may not be set
      tests/client_test.c:
        Use MAXPATHLEN in test_frm_bug()
        Renable test cases disabled for running from mysql-test-run
      mysql-test/mysql-test-run.sh:
        More clearly report failure if --force, also exit 1
      mysql-test/t/client_test.test:
        Run client_test as a testcase
      c7a18f63
  27. 25 Sep, 2004 1 commit
    • unknown's avatar
      client_test.c: · cb77c4d2
      unknown authored
        Return exit(1) instead of exit(0) on failure.
        Allow longer path names using MAXPATHLEN.
        Added option --testcase that skips some failing tests.
        Replaced 'return' with exit(1) in test_frm_bug().
      mysqltest.c:
        Let --exec fail if command fails
      
      
      client/mysqltest.c:
        Let --exec fail if command fails
      tests/client_test.c:
        Return exit(1) instead of exit(0) on failure.
        Allow longer path names using MAXPATHLEN.
        Added option --testcase that skips some failing tests.
        Replaced 'return' with exit(1) in test_frm_bug().
      cb77c4d2
  28. 23 Sep, 2004 1 commit
  29. 22 Sep, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#5315 "mysql_change_user() doesn't free · 0d44f8d4
      unknown authored
      prepared statements."
      
      
      include/hash.h:
        New declaration for hash_reset() function. The old version was not used.
      libmysql/client_settings.h:
        Declaration for mysql_detach_stmt_list().
      libmysql/libmysql.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        add call to mysql_detach_stmt_list(prepared statements) to
        mysql_change_user(): all statements are freed by server, so client
        counterparts need to be marked as not usable.
      mysys/hash.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of hash_reset(), which frees all hash elements
        and prepares the hash for reuse.
      sql-common/client.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of mysql_detach_stmt_list(): zero connection pointer
        in given statement list, thus marking given statements as not usable.
      sql/sql_class.cc:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        reset prepared statements map in THD::change_user().
      sql/sql_class.h:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of Statement_map::reset().
        A little cleanup of ~Statement_map(): first empty names_hash, as st_hash
        has a free function, which will delete statements.
      tests/client_test.c:
        A test case for bug #5315 "mysql_change_user() doesn't free prepared
        statements".
      0d44f8d4
  30. 14 Sep, 2004 2 commits
  31. 09 Sep, 2004 1 commit
    • unknown's avatar
      client_test.c: · c5e7051d
      unknown authored
        fix typos noticed while poking around in test program.
      
      
      tests/client_test.c:
        fix typos noticed while poking around in test program.
      c5e7051d
  32. 08 Sep, 2004 2 commits
    • unknown's avatar
      A fix and test case for Bug#5194 "Bulk Insert Failures with Prepared · b197e1f1
      unknown authored
      Statements": 
      - fix a couple of net->buff overruns in libmysql,
      - check in the server that statement parameter count is less than
        65535 (maximum value supported by prepared statements protocol).
       
      
      
      libmysql/libmysql.c:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - clean up my_realloc_str()
        - ensure that net buffer has space when storing null bits and
          parameter typecodes.
      sql/net_serv.cc:
        - set net->last_errno if packet is too big, even on client
          (Why was it ifdefed before?)
      sql/sql_prepare.cc:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - if placeholder count is bigger than 65535, give error.
          We have only 2 bytes reserved for transferring placeholder count
          in 4.1 protocol.
        - can't add a proper error code and message in 4.1 because of
          possible merge difficulties."
      tests/client_test.c:
        A test case for Bug#5194 "Bulk Insert Failures with Prepared 
        Statements".
      b197e1f1
    • unknown's avatar
      A fix and test case for bug#5399 "Wrong statement executed by MySQL · b816fa37
      unknown authored
       server" (use my_charset_bin for stmt id hash).
      
      
      sql/sql_class.cc:
        Fix for bug#5399 "Wrong statement executed by MySQL server": 
        we hash stmt ids bytewise, need to use binary collation for it.
      tests/client_test.c:
        Test case for bug#5399 "Wrong statement executed by MySQL server":
        create number of statements returning different results, execute them
        one by one.
      b816fa37
  33. 02 Sep, 2004 2 commits
    • unknown's avatar
      A fix and test case for Bug#4231 "Wrong result with MYSQL_TIME · a6fe5f24
      unknown authored
      parameters": when unpacking binary time recieved from client, handle
      the case when length is 0: it means all MYSQL_TIME members are zero.
      
      
      include/my_time.h:
        Declaration for set_zero_time: a tiny piece of code, which I
        see no reason to not reuse.
      libmysql/libmysql.c:
        set_zero_time implementation is now shared between client and
        server.
      sql-common/my_time.c:
        set_zero_time implementation added.
      sql/sql_prepare.cc:
        A fix for Bug#4231 "Wrong result with MYSQL_TIME parameters": 
        when unpacking binary time recieved from client, handle the
        case when length is 0: it means all MYSQL_TIME members are zero.
      tests/client_test.c:
        Test case for bug#4231 "Wrong result with MYSQL_TIME parameters"
      a6fe5f24
    • unknown's avatar
      After merge fixes · 16701793
      unknown authored
      mysql-test/mysql-test-run.sh:
        Export MASTER_MYSOCK (used in some tests)
      mysql-test/t/alter_table.test:
        Use MASTER_MYSOCK instead of master.sock
      16701793