1. 13 Dec, 2016 1 commit
    • Sreeharsha Ramanavarapu's avatar
      Bug #24595937: INCORRECT BEHAVIOR WHEN LOADING DATA TO VIEW · 30a59a8d
      Sreeharsha Ramanavarapu authored
      Issue:
      ------
      While using the LOAD statement to insert data into an
      updateable view, the check to verify whether a column
      is actually updatable is missing.
      
      Solution for 5.5 and 5.6:
      -------------------------
      For a view whose column-list in specified in the LOAD
      command, this check is not performed. This fix adds the
      check.
      
      This is a partial backport of Bug#21097485.
      
      Solution for 5.7 and trunk:
      ---------------------------
      For a view whose column-list is specified in the LOAD
      command, this check is already performed. This fix adds the
      same check when no column-list is specified.
      30a59a8d
  2. 12 Dec, 2016 1 commit
  3. 06 Dec, 2016 1 commit
  4. 05 Dec, 2016 3 commits
    • Georgi Kodinov's avatar
      Bug #25111907: XML TEST FAILS WITH UNDEFINED BEHAVIOR · dafbdc78
      Georgi Kodinov authored
      The XML parser position stack for each level is with a fixed depth.
      So a bounds check was done to ensure that this depth is not exceeded.
      But it was off by one (i.e. the size of the array was a valid index).
      Fixed by decreasing the allowable depth by one to match the maximum
      number of elements in the position stack.
      dafbdc78
    • Terje Rosten's avatar
      Bug#22240513 REMOVE GITIGNORE / BZRIGNORE FROM OFFICIAL RELEASE · 67226995
      Terje Rosten authored
      Add .gitattributes to let git archive ignore .gitignore.
      67226995
    • Pavan Naik's avatar
      BUG#25147154 : MTR TRIES TO COPY CONTENTS FROM /TMP/DATA · 6786caed
      Pavan Naik authored
      Description :
      =============
      When a MTR test run is started, it initializes the server and creates
      the datadir under '$MYSQL_TEST_DIR/var'('/tmp/var' or '/dev/shm/var'
      if --mem option is used) location and then copies it to the datadir
      location of server(s).
      
      If $parallel == 1, datadir location of the server is
      '$MYSQL_TEST_DIR/var/data'. If $parallel > 1, datadir location of any
      server is '$MYSQL_TEST_DIR/var/<thread_num>/data'.
      
      This is the reason MTR searches for the initialized datadir in 2
      locations('$opt_vardir' and '$opt_vardir/..') from the current vardir
      location..
      
      But this can cause few problems. If a directory with the name 'data'
      already exists under '$MYSQL_TEST_DIR' and if the MTR run is started
      with parallel value 1, then
      
      1. copytree($install_db, '$opt_vardir/..') command will fail if the
      user doesn't have the access permission to '$MYSQL_TEST_DIR/data'
      directory.
      2. Unnecessary contents from '$MYSQL_TEST_DIR/data' directory will be
      copied to server datadir location and this might affect the server
      startup.
      
      Fix :
      =====
      Depending on the $parallel value decide whether the path for the
      initialize datadir is "$opt_vardir"(i.e $parallel = 1) or
      "$opt_vardir/.."(i.e $parallel > 1).
      Reviewed-by: default avatarDeepa Dixit <deepa.dixit@oracle.com>
      Reviewed-by: default avatarSrikanth B R <srikanth.b.r@oracle.com>
      RB: 14773
      6786caed
  5. 04 Dec, 2016 1 commit
  6. 29 Nov, 2016 2 commits
    • Shishir Jaiswal's avatar
      Bug#24449076 - INTEGER OVERFLOW IN FUNCTION DOINSERT · 52b0c814
      Shishir Jaiswal authored
      DESCRIPTION
      ===========
      Performing a pattern match of a Regex resulting into a very
      large string, leads to crash due to integer wraparound.
      
      ANALYSIS
      ========
      doinsert() - The length calculated here (to copy the
      number of bytes) comes out to be too large to be stored in
      the "int" variable 'length'. We need to ensure that the
      variable can accommodate large lengths.
      
      FIX
      ===
      'length' in doinsert() is now defined as of type "size_t"
      instead of "int"
      52b0c814
    • Shishir Jaiswal's avatar
      Bug#24449090 - BUFFER OVERFLOW IN FUNCTION DUPL · 8f297058
      Shishir Jaiswal authored
      DESCRIPTION
      ===========
      Performing a pattern match of a Regex resulting into a very
      large string, leads to crash due to failed realloc().
      
      ANALYSIS
      ========
      dupl() calls enlarge(). It in turn calls realloc() for
      pointer p->strip. This eventually fails due to OOM.
      However we are still using the same pointer in memcpy()
      causing a SEGFAULT!
      
      FIX
      ===
      1) In dupl(), checking for error code (which would be set
      if realloc fails) immediately after call to enlarge().
      Returning now with this error code.
      
      2) Handling the same in the caller functions.
      8f297058
  7. 28 Nov, 2016 4 commits
  8. 26 Nov, 2016 2 commits
  9. 25 Nov, 2016 3 commits
  10. 24 Nov, 2016 2 commits
  11. 16 Nov, 2016 1 commit
    • Terje Rosten's avatar
      Bug#25088048 ADDITIONAL ISSUES IN MYSQLD_SAFE · cdd57aa7
      Terje Rosten authored
      Don't read --ledir option from config file.
      Ignore current working for finding location of mysqld
      Remove use of chown/chmod in scripts.
      Be helpful only when basedir is /var/log or /var/lib.
      Removed unused systemd files for SLES.
      Set explicit basedir in scripts.
      cdd57aa7
  12. 10 Nov, 2016 1 commit
    • Karthik Kamath's avatar
      BUG#24437124: POSSIBLE BUFFER OVERFLOW ON CREATE TABLE · a63185e8
      Karthik Kamath authored
      ANALYSIS:
      =========
      'CREATE TABLE' query with a large value for 'CONNECTION'
      string reports an incorrect error.
      
      The length of connection string is stored in .frm in two
      bytes (max value= 65535). When the string length exceeds
      the max value, the length is truncated to fit the two
      bytes limit. Further processing leads to reading only a
      part of the string as the length stored is incorrect. The
      remaining part of the string is treated as engine type and
      hence results in an error.
      
      FIX:
      ====
      We are now restricting the connection string length to 1024.
      An appropriate error is reported if the length crosses this
      limit.
      
      NOTE:
      =====
      The 'PASSWORD' table option is documented as unused and
      processed within a dead code. Hence it will not cause
      similar issue with large strings.
      a63185e8
  13. 09 Nov, 2016 1 commit
  14. 05 Nov, 2016 1 commit
  15. 31 Oct, 2016 1 commit
  16. 28 Oct, 2016 1 commit
    • Thayumanavar S's avatar
      BUG#24487120 - SLAVE'S SLAVE_SQL_RUNNING IS STOPPED DURING · c3cf7f47
      Thayumanavar S authored
       LOAD DATA AT MASTER.
      
      Revert "BUG#23080148 - BACKPORT BUG 14653594 AND BUG 20683959 TO"
      
      This reverts commit 1d31f5b3090d129382b50b95512f2f79305715a1.
      The commit causes replication incompatibility between minor revisions
      and based on discussion with Srinivasarao, the patch is reverted.
      c3cf7f47
  17. 24 Oct, 2016 1 commit
    • Terje Rosten's avatar
      Bug#24925181 INCORRECT ISA DETECTION CODE IN OEL RPM SPEC · 63b2c976
      Terje Rosten authored
      Wrapper for mysql_config used in multilib installs modified to work as
      intended, added more archs (aarch64, ppc64le, s390x, s390, sparc and
      sparc64) to lists in fallback mode and use same script for EL and
      Fedora.
      
      Thanks to Alexey Kopytov for report and fix.
      63b2c976
  18. 13 Oct, 2016 1 commit
    • Karthik Kamath's avatar
      BUG#23499695: MYSQL SERVER NORMAL SHUTDOWN WITH TIME STAMP · 14921277
      Karthik Kamath authored
                    700101
      
      ANALYSIS:
      =========
      To set the time 'start_time' of query in THD, current time
      is obtained by calling 'gettimeofday()'. On Solaris
      platform, due to some system level issues, time obtained is
      invalid i.e. its either greater than 2038 (max signed value
      to hold microseconds since 1970) or 1970 (0 microseconds
      since 1970). In these cases, validation checks infer that
      the 'start_time' is invalid and mysql server initiates the
      shutdown process. But the reason for shutdown is not logged.
      
      FIX:
      ====
      We are now logging appropriate message when shutdown is
      triggered in the above mentioned scenarios. Now, even if
      the initial validation checks infer that the 'start_time'
      is invalid, server shutdown is not initiated immediately.
      Before initiating the server shutdown, the process of
      setting 'start_time' and validating it is reiterated (for
      max 5 times). If correct time is obtained in these 5
      iterations then server continues to run.
      14921277
  19. 12 Oct, 2016 1 commit
  20. 06 Oct, 2016 1 commit
    • Terje Rosten's avatar
      Bug#24483092 UNSAFE USE OF VARIOUS SHELL UTILITIES · 1f93f438
      Terje Rosten authored
       - Remove use of touch and chmod.
       - Restrict usage of chown to cases where target directory is /var/log.
       - Due to limited feature set in /bin/sh on Solaris, /bin/bash will be
         used on this platform.
       - Give error if directory for UNIX socket file is missing.
       - Privileged user should not log to files owned by different user
         (mysqld will log as before).
      1f93f438
  21. 03 Oct, 2016 1 commit
  22. 29 Sep, 2016 1 commit
  23. 28 Sep, 2016 3 commits
  24. 27 Sep, 2016 1 commit
  25. 26 Sep, 2016 2 commits
  26. 08 Sep, 2016 1 commit
    • Georgi Kodinov's avatar
      Bug #24496214: MISLEADING ERROR EXECUTING MYSQLADMIN SHUTDOWN AGAINST A SERVER · 0d43e570
      Georgi Kodinov authored
      RUNNING FIREWALL
      
      mysqladmin shutdown will try to extract the server's pid file before executing
      the actual shutdown command.
      It will do that by executing a SHOW VARIABLES query and processing the result.
      However if that query fails it print a (somewhat confusing) error mesasage
      and will still continue to do the shutdown command.
      If that passes then the mysqladmin user will get an error but the shutdown will
      still be successful.
      This is confusing so the error message text is changed to say that this is a
      non-fatal error and execution continues.
      No test case added since it'd require a selective query failure device that's
      not available in 5.5.
      0d43e570
  27. 06 Sep, 2016 1 commit