1. 28 Nov, 2006 1 commit
    • unknown's avatar
      A fix for Bug#24486 "Valgrind warnings: sp_head(), · 31855d98
      unknown authored
      deadlock_innodb:events_grant". This was a memory leak introduced by 
      the patch for Bug 22830.
      Post-review fixes.
      
      
      sql/sql_parse.cc:
        A fix for Bug#24486 "Valgrind warnings: sp_head(),
         deadlock_innodb:events_grant": delete the sphead object before
        returning with an error.
      31855d98
  2. 23 Nov, 2006 3 commits
    • unknown's avatar
      BUG#24488 (Valgrind warnings on invalid read in mysql_client_binlog_statement): · c4b99c85
      unknown authored
      Disabling debug printouts for valgrind builds that print unallocated memory.
      
      
      sql/sql_binlog.cc:
        Disabling debug printouts for valgrind builds that print unallocated memory
      c4b99c85
    • unknown's avatar
      BUG#24533 (uninitialized null bits in m_after_image): · 18ea1f45
      unknown authored
      Removing valgrind memory checks from code.
      
      
      sql/log_event.cc:
        Removing valgrind memory checks from code.
      18ea1f45
    • unknown's avatar
      BUG#24533 (uninitialized null but of m_after_image): · 0cf3b1bd
      unknown authored
      Patch to fix valgrind warning that uninitialized bytes were written. 
      The warning was caused by set_default(), which assumes that the field pointer is pointing
      into record[0], while all other functions honors the move_field_offset().
      
      
      sql/log_event.cc:
        Changing unpack_row() to always unpack into table->record[0] since the Field class hierarchy
        contain too many dependencies on the record to operate on being in table->record[0].
        Changing code to use the new unpack_row(), which requires some juggling of records in
        one case.
      0cf3b1bd
  3. 21 Nov, 2006 2 commits
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1 · a3fcd8b2
      unknown authored
      into  romeo.(none):/home/bk/memcheck-mysql-5.1
      
      a3fcd8b2
    • unknown's avatar
      BUG#24403 (valgrind complaint on uninited st_table for innodb + rbr): · c6eb7737
      unknown authored
      Removing DBUG_DUMP printouts for valgrind builds since they trigger warnings.
      Removing valgrind memory checks completely.
      Removing bzero() of record when opening table that was added earlier.
      
      
      sql/log_event.cc:
        Removing DBUG_DUMP of records for valgrind builds since they trigger false valgrind
        warnings.
        Removing valgrind checks completely, since they can trigger false valgrind warnings.
      sql/sql_class.cc:
        Removing DBUG_DUMP of records for valgrind builds since they trigger false valgrind
        warnings.
      sql/table.cc:
        Removing extreneous bzero() that were added previously.
      c6eb7737
  4. 20 Nov, 2006 5 commits
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1 · 2b33f02a
      unknown authored
      into  romeo.(none):/home/bk/memcheck-mysql-5.1
      
      2b33f02a
    • unknown's avatar
      BUG#24403 (valgrind complained on uninited st_table for InnoDB and RBR): · 180c24d9
      unknown authored
      Fix to correct behaviour of find_and_fetch_row() for tables that have primary keys stored
      in storage engines that support the fast method to fetch rows given a primary key. The
      method uses position() to retrieve the key for a given record and rnd_pos() to position
      the internal "cursor" at the row. Rnd_pos() returns the found record in table->record[0],
      so the record has to be moved to table->record[1] for further processing after calling
      find_and_fetch_row().
      
      
      sql/log_event.cc:
        Adding code to one exit branch of find_and_fetch_row() to move output record from
        table->record[0] to table->record[1].
        Adding function to do valgrind memory check.
        Adding valgrind memory checks to check that records are defined when they should be.
        Adding Doxygen comment to find_and_fetch_row() with pre- and post-conditions.
      180c24d9
    • unknown's avatar
      Merge amd64.:D:/src/mysql-5.1 · 115b461d
      unknown authored
      into  amd64.:D:/src/mysql-5.1_bug23983
      
      115b461d
    • unknown's avatar
      Bug#23983 ps.test fails to open shared library · 758758de
      unknown authored
      - When a shared library argument is supplied, it's checked for an OS
      specific directory separator. The expected error is different
      depending on the separator used. Create OS specific versions of these
      tests.
      
      
      mysql-test/r/ps.result:
        Bug#23983 ps.test fails to open shared library
        - Moving to OS specific results.
      mysql-test/r/windows.result:
        Bug#23983 ps.test fails to open shared library
        - OS Specific result for shared library argument with path
      mysql-test/t/ps.test:
        Bug#23983 ps.test fails to open shared library
        - Moving to OS specific tests.
      mysql-test/t/windows.test:
        Bug#23983 ps.test fails to open shared library
        - OS Specific test for shared library argument with path
      mysql-test/r/ps_not_windows.result:
        Bug#23983 ps.test fails to open shared library
        - OS Specific result for shared library argument with path
      mysql-test/t/ps_not_windows.test:
        Bug#23983 ps.test fails to open shared library
        - OS Specific test for shared library argument with path
      758758de
    • unknown's avatar
      Bug#24361 valgrind error when shutting down mysqld connected to cluster · 583995b6
      unknown authored
        - Disconnect from transporter before starting to delete objects
      
      
      storage/ndb/src/ndbapi/Ndbinit.cpp:
        Make sure to disconnect from transporter to stop signals from coming in
        before starting to delete the objects that would recieve the signals
      583995b6
  5. 17 Nov, 2006 1 commit
  6. 16 Nov, 2006 1 commit
  7. 15 Nov, 2006 12 commits
  8. 14 Nov, 2006 12 commits
  9. 13 Nov, 2006 3 commits
    • unknown's avatar
      Modify search path for mysql_client_test to look in "bin" not to look for "bin", · 2e7e228a
      unknown authored
      this caused mysql_client_test to fail when running from binary dist 
      
      
      mysql-test/mysql-test-run.pl:
        Modify search path for mysql_client_test to look in "bin" not to look for "bin"
      2e7e228a
    • unknown's avatar
      Merge mysql.com:/home/bk/MERGE/mysql-5.0-merge · 7e558c68
      unknown authored
      into  mysql.com:/home/bk/MERGE/mysql-5.1-merge
      
      
      BitKeeper/triggers/post-commit:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/slave.cc:
        Manual merge
      7e558c68
    • unknown's avatar
      Merge mysql.com:/home/bk/MERGE/mysql-4.1-merge · 6f276969
      unknown authored
      into  mysql.com:/home/bk/MERGE/mysql-5.0-merge
      
      
      BitKeeper/triggers/post-commit:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/log_event.h:
        Manual merge
      sql/slave.cc:
        Manual merge
      6f276969