1. 24 May, 2011 1 commit
  2. 20 May, 2011 2 commits
  3. 19 May, 2011 4 commits
    • Luis Soares's avatar
      BUG#11746302 · 7970ef5b
      Luis Soares authored
      Manual merged mysql-5.1-gca into latest mysql-5.5.
      
      Conflicts
      =========
      Text conflict in mysql-test/suite/rpl/r/rpl_relayspace.result
      Text conflict in mysql-test/suite/rpl/t/rpl_relayspace.test
      7970ef5b
    • Luis Soares's avatar
      BUG#11746302 · b0866997
      Luis Soares authored
      Automerge mysql-5.1-gca into latest mysql-5.1.
      b0866997
    • Luis Soares's avatar
      BUG#11746302: 25228: RPL_RELAYSPACE.TEST FAILS ON POWERMACG5, · 72d5f27b
      Luis Soares authored
                    VM-WIN2003-32-A, SLES10-IA64-A 
            
      The test case waits for master_pos_wait not to timeout, which
      means that the deadlock between SQL and IO threads was 
      succesfully and automatically dealt with.
            
      However, very rarely, master_pos_wait reports a timeout. This
      happens because the time set for master_pos_wait to wait was
      too small (6 seconds). On slow test env this could be a 
      problem.
            
      We fix this by setting the timeout inline with the one used
      in sync_slave_with_master (300 seconds). In addition we 
      refactored the test case and refined some comments.
      72d5f27b
    • Mikael Ronström's avatar
      merge · dc5be0fe
      Mikael Ronström authored
      dc5be0fe
  4. 18 May, 2011 6 commits
    • Mayank Prasad's avatar
      Bug#11764633 : 57491: THD->MAIN_DA.IS_OK() ASSERT IN EMBEDDED · a8e53a82
      Mayank Prasad authored
      Issue:
      While running embedded server, if client issues TEE command (\T foo/bar) and
      "foo/bar" directory doesn't exist, it is suppose to give error. But it was
      aborting.  This was happening because wrong error handler was being called.
      
      Solution:
      Modified calls to correct error handler. In embedded server case, there are 
      two error handler (client and server) which are supposed to be called based 
      on which context code is in. If it is in client context, client error handler
      should be called otherwise server.
      
      Test case:
      Test case automation is not possible as current (following) code doesn't 
      allow '\T' to be executed from command line (OR command read from a file):
      [client/mysql.cc]
      ...
       static int
       com_tee(String *buffer __attribute__((unused)),
               char *line __attribute__((unused)))
       {
         char file_name[FN_REFLEN], *end, *param;
      
         if (status.batch) << THIS IS TRUE WHILE EXECUTING FROM COMMAND LINE.
            return 0;
       ...
      So, not adding test case in GA. WIll add a test case in mysql-trunk after 
      removing above code so that this could be properly tested before GA.
      
      libmysqld/lib_sql.cc:
        Added code to call client/server error handler based on in control is in 
        client/server code respectively.
      sql/mysql_priv.h:
        Added comments for THR_THD, THR_MALLOC keys.
      sql/sql_class.cc:
        Function definition of new function restore_global to removes thread specific 
        data from stack (which was stored in store global).
      sql/sql_class.h:
        Function declaration of new function restore_global.
      a8e53a82
    • Mayank Prasad's avatar
      merge from 5.1 for bug#11764633 · 5b56de08
      Mayank Prasad authored
      5b56de08
    • Mikael Ronström's avatar
      merge · 2b912450
      Mikael Ronström authored
      2b912450
    • Mikael Ronström's avatar
      d7b4504b
    • Sergey Glukhov's avatar
      5.1 -> 5.5 merge · 20a79478
      Sergey Glukhov authored
      20a79478
    • Sergey Glukhov's avatar
      Bug#12403504 AFTER FIX FOR #11889186 : ASSERTION FAILED: DELSUM+(INT) Y/4-TEMP > 0 · b4f510ba
      Sergey Glukhov authored
      There are two problems:
      1. There is a missing check for 'year' parameter(year can not be greater than 9999) in
         makedate function. fix: added check that year can not be greater than 9999.
      2. There is a missing check for zero date in from_days() function.
         fix: added zero date check into Item_func_from_days::get_date()
         function.
      
      
      mysql-test/r/func_time.result:
        test case
      mysql-test/t/func_time.test:
        test case
      sql/item_timefunc.cc:
        --added check that year can not be greater than 9999 for makedate() function
        --added zero date check into Item_func_from_days::get_date() function
      b4f510ba
  5. 16 May, 2011 6 commits
  6. 14 May, 2011 2 commits
  7. 13 May, 2011 7 commits
    • Marc Alff's avatar
      Bug#12552516 LF_HASH REQUIRES MY_THREAD_INIT() · 7ed4bbba
      Marc Alff authored
      Before this fix, a thread instrumented for the performance schema,
      that would perform file io operations, could crash inside the LF_HASH
      implementation, in cases when my_thread_init is not called.
      
      The crash itself has not been reported in 5.5 but similar crashes have
      been found in 5.6-based development branches, using LF_HASH for
      more instrumentation.
      
      The possibility of a crash in 5.5 is confirmed by code analysis.
      
      The problem is that, when my_thread_init() is not called,
      which can happen for threads in storage engines or thirs party code,
      my_thread_var is NULL.
      
      Using my_thread_var->stacks_ends_here in mysys/lf_alloc-pin.c is unsafe.
      
      Given that my_thread_var is used:
      - only for stacks_ends_here
      - only on platform with HAVE_ALLOCA
      - only when there is enough room on the stack
      and given that the LF_HASH implementation has a fallback
      algorythm implemented already when using alloca is not possible,
      using my_thread_var->stacks_ends_here is in fact not a strict requirement,
      and can be relaxed.
      
      The fix is to:
      - test explicitly if my_thread_var is NULL, to account for cases
        when my_thread_init() is not used by the calling thread.
      - not use alloca in this case, and rely on the fall back code already in place.
        so that the LF_HASH can be supported even without my_thread_init().
      
      The implementation of mysys/lf_alloc-pin.c has been fixed to support this new usage.
      The units tests in unittest/mysys/lf-t.c have been adjusted accordingly.
      7ed4bbba
    • Mikael Ronstrom's avatar
    • Mikael Ronström's avatar
      merge · 14f5c36e
      Mikael Ronström authored
      14f5c36e
    • Bjorn Munch's avatar
      null upmerge · f70f32c1
      Bjorn Munch authored
      f70f32c1
    • Bjorn Munch's avatar
      merge from 5.1-mtr · 632d7e63
      Bjorn Munch authored
      632d7e63
    • Bjorn Munch's avatar
      merge from 5.5-mtr · 3c32bf93
      Bjorn Munch authored
      3c32bf93
    • MySQL Build Team's avatar
      changed the VERSION tag to 14 · 7a7b4898
      MySQL Build Team authored
      7a7b4898
  8. 12 May, 2011 12 commits
    • unknown's avatar
      BUG#12549572 : CMake file does not include gcov option · a5352244
      unknown authored
      This patch inserts an 'ENABLE_GCOV' option for enabling gcov compilation
      on Linux machines. It modifies the CMakeLists.txt setting this option
      to 'OFF' by default.
      
      Note: The option requires a debug build. For example, 
            -DCMAKE_BUILD_TYPE:string="Debug" 
      a5352244
    • Mikael Ronström's avatar
      merge · 593a39a1
      Mikael Ronström authored
      593a39a1
    • Bjorn Munch's avatar
      null upmerge · 6c69b7eb
      Bjorn Munch authored
      6c69b7eb
    • Bjorn Munch's avatar
      null upmerge · 264e2859
      Bjorn Munch authored
      264e2859
    • Bjorn Munch's avatar
      merge from 5.5 main · d06070b2
      Bjorn Munch authored
      d06070b2
    • Jon Olav Hauglid's avatar
      Bug#12346411 SQL/LOG.CC:6509: ASSERTION `PREPARED_XIDS > 0' FAILED · 99b53189
      Jon Olav Hauglid authored
      This assert could be triggered during two phase commit if binary
      log was used as transaction coordinator log. The triggered assert
      checks that the same number of transaction IDs are processed in
      the prepare and commit phases.
      
      The reason it was triggered, was that the transaction consisted
      of an INSERT/UPDATE IGNORE that had an ignorable error. Since it
      had an error, no row log events were made and therefore
      prepared_xids was 0. However, since it was an IGNORE statement,
      the statement started a read/write statement transaction, committed
      it and completed successfully.
      
      This patch fixes the problem by adjusting the assert to take
      this possibility into account.
      
      Test case added to binlog.binlog_innodb_row.test.
      99b53189
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 3cd699fa
      Tatjana Azundris Nuernberg authored
      3cd699fa
    • Mikael Ronström's avatar
      merge · 54a4263e
      Mikael Ronström authored
      54a4263e
    • Bjorn Munch's avatar
      merge from 5.1 main · 3f5199de
      Bjorn Munch authored
      3f5199de
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 5fc506f1
      Tatjana Azundris Nuernberg authored
      5fc506f1
    • Tatjana Azundris Nuernberg's avatar
      auto-merge · 64bc10d7
      Tatjana Azundris Nuernberg authored
      64bc10d7
    • Tatjana Azundris Nuernberg's avatar
      Bug#11902767/Bug#60580: Statement improperly replicated crashes slave SQL thread · 2ab84e49
      Tatjana Azundris Nuernberg authored
      If LOAD DATA INFILE featured a SET clause, the name=value pairs
      would be regenerated using item::print. Unfortunately, that code
      is mostly optimized for EXPLAIN EXTENDED output and such, and can
      not be relied on to return valid SQL.
      
      We now name each value its original, user-supplied form and use
      that to create LOAD DATA INFILE statements for statement-based
      replication.
      
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        minor change in syntactic sugar
      mysql-test/suite/rpl/r/rpl_loaddatalocal.result:
        add test case
      mysql-test/suite/rpl/t/rpl_loaddatalocal.test:
        add test case
      sql/sql_load.cc:
        Do not try to item::print values in LOAD DATA INFILE's
        SET clause; they might not even be valid SQL at this
        point. Use our saved version instead.
      sql/sql_yacc.yy:
        If LOAD DATA INFILE has SET name=val clauses, tag the
        individual val-parts with the user's version so we can
        later replicate that, rather than the smashed pieces
        we'd get from item::print once the optimizer's through
        with our poor values.
      2ab84e49