- 14 Feb, 2021 1 commit
-
-
Monty authored
When creating a summary temporary table with bit fields used in the sum expression with several parameters, like GROUP_CONCAT(), the counting of bits needed in the record was wrong. The reason we got an assert in Aria was because the bug caused a memory overwrite in the record and Aria noticed that the data was 'impossible.
-
- 12 Feb, 2021 1 commit
-
-
Jan Lindström authored
Problem was that when engine substitution is allowd (e.g. sql_mode='') we must also check db_type. Additionally, we did not resolve default storage engine on that case and used that to check is TOI possible or not.
-
- 11 Feb, 2021 3 commits
-
-
Otto Kekäläinen authored
The Readline library is no longer available in Debian Sid. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980504 Add the dependency on-the-fly in autobake-deb.sh for older distro versions and keep the native build in a state that works on Debian Sid as-is.
-
Otto Kekäläinen authored
The older MariaDB.org packages were built against libreadline5 and depend on it to install. As it was removed from Sid (and Bullseye), fetch and install it from Buster. This can eventually be removed once we stop backwards compat testing for older MariaDB versions (new ones don't depend on it). Upstreamed from Debian packaging repository commit https://salsa.debian.org/mariadb-team/mariadb-10.5/-/commit/4b729db7f89f573dbe92d601a2d984fab158fc4f
-
Daniel Black authored
and S3_HOST_NAME. Required environment variables are now S3_ACCESS_KEY and S3_SECRET_KEY. Or a running minio instance on localhost:9000.
-
- 09 Feb, 2021 1 commit
-
-
Daniel Black authored
Was added in 10.5.2 (MDEV-21975)
-
- 08 Feb, 2021 4 commits
-
-
Monty authored
A few of the failures was because of missing sync_slave_to_master in the test suite. However, the biggest reason for most faulures was that in case of ALTER PARTITION the master writes the query to the binary log before it has updated the .frm and .par files. This causes a problem for an S3 slave as it will start execute the ALTER PARTITION but get old .frm and .par files from S3 which causes "open table" to fail, either with an error or in some case with a crash. Fixed
-
Monty authored
This allow one to remove some casts like: maria_data_root= (char *)"."; It also removes warnings from icc.
-
Monty authored
One should not change the program arguments! This change also reduces warnings from the icc compiler. Almost all changes are just syntax changes (adding const to 'get_one_option function' declarations). Other changes: - Added a few cast of 'argument' from 'const char*' to 'char *'. This was mainly in calls to 'external' functions we don't have control of. - Ensure that all reset of 'password command line argument' are similar. (In almost all cases it was just adding a comment and a cast) - In mysqlbinlog.cc and mysqld.cc there was a few cases that changed the command line argument. These places where changed to instead allocate the option in a MEM_ROOT to avoid changing the argument. Some of this code was changed to ensure that different programs did parsing the same way. Added a test case for the changes in mysqlbinlog.cc - Changed a few variables that took their value from command line options from 'char *' to 'const char *'.
-
Monty authored
-
- 07 Feb, 2021 2 commits
-
-
Marko Mäkelä authored
The condition variables that were introduced in commit 7cffb5f6 (MDEV-23399) are never instrumented with PERFORMANCE_SCHEMA. Let us avoid the storage overhead and dead code.
-
Marko Mäkelä authored
-
- 03 Feb, 2021 1 commit
-
-
Monty authored
The test case was setting aria_sort_buffer_size to MAX_ULONGLONG-1 which was not handled gracefully by my_malloc() or safemalloc(). Fixed by ensuring that the malloc functions returns 0 if the size is too big. I also added some protection to Aria repair: - Limit sort_buffer_size to 16G (after that a bigger sort buffer will not help that much anyway) - Limit sort_buffer_size also according to sort file size. This will help by not allocating less memory if someone sets the buffer size too high.
-
- 02 Feb, 2021 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
This is caused by commit c92f7e28(MDEV-8139). InnoDB fails to set the page status as FREED in buffer pool while freeing the extent.
-
- 01 Feb, 2021 3 commits
-
-
Vladislav Vaintroub authored
With the fix, new connection without THDs will now show NULL in thread_pool_queues.CONNECTION_ID.
-
Sergei Golubchik authored
filter out tpool
-
Marko Mäkelä authored
ha_innobase::commit_inplace_alter_table(): Fix a regression that was introduced in 6d1f1b61 (MDEV-24564).
-
- 30 Jan, 2021 2 commits
-
-
David CARLIER authored
-
FX Coudert authored
-
- 29 Jan, 2021 5 commits
-
-
Sergei Petrunia authored
Also update the SEL_ARG graph weight in: - sel_add() - SEL_ARG::clone() Make key_{and,or}_with_limit() to also verify weight for the arguments (There is no single point to verify SEL_ARG graphs constructed from conditions that are not AND-OR formulas, so we hope that those are connected with AND/OR and do it here).
-
Marko Mäkelä authored
The purpose of the test was to ensure that the SX (update) mode of index tree and buffer page latches are being used. The test has become unstable, possibly due to changes related to buf_pool.mutex and buf_pool.page_hash, or to the use of MDL in the purge of transaction history. In 10.6, the test depends on instrumentation that was refactored or removed in MDEV-24142. The use of different latching modes can better be indirectly observed through high-concurrency benchmarks. For MDEV-14637, a performance test was conducted where the finer-grained latching and BTR_CUR_FINE_HISTORY_LENGTH were removed. It caused a 20% performance regression for UPDATE and somewhat smaller for INSERT. Any new problem with latching granularity should be easily caught by performance testing, or by stress tests with Random Query Generator.
-
Vladislav Vaintroub authored
There are no IO threads anymore.
-
Sergei Petrunia authored
(Variant #5, full patch, for 10.5) Do not produce SEL_ARG graphs that would yield huge numbers of ranges. Introduce a concept of SEL_ARG graph's "weight". If we are about to produce a graph whose "weight" exceeds the limit, remove the parts of SEL_ARG graph that represent the biggest key parts. Do so until the graph's is within the limit. Includes - debug code to verify SEL_ARG graph weight - A user-visible @@optimizer_max_sel_arg_weight to control the optimization - Logging the optimization into the optimizer trace.
-
sjaakola authored
The implementation for MDEV-17048 apperas to be direct copy from mysql version. The group commit works differently in mariadb and the assert in wsrep_unregister_from_group_commit() is too strict. The reason is that in: Wsrep_high_priority_service::log_dummy_write_set(), the transaction will undergo full rollback: { cs.before_rollback(); cs.after_rollback(); } After that, the client's transaction state is set to be: wsrep::transaction::s_aborted. The execution then continues execution by: ... wsrep_register_for_group_commit(m_thd); ... wsrep_unregister_from_group_commit(m_thd); The bogus assert in wsrep_unregister_from_group_commit() allows only transactions states of :s_ordered_commit or s_aborting. As the fix, I brought back the same assert as is present in MariaDB 10.4 version.
-
- 28 Jan, 2021 5 commits
-
-
Anel Husakovic authored
a. The change makes `mariadb-upgrade` detect if `MYSQL_JSON` data type is needed. b. Install the data type if it's not installed. c. Uninstalls the data type once finished. d. Create `.opt` and `.inc` files `have_type_mysql_json` and adapt the tests Reviewed by: vicentiu@mariadb.org
-
Marko Mäkelä authored
Ever since commit 007f68c3, ALTER TABLE no longer invokes handler::open() after handler::commit_inplace_alter_table(). ha_innobase::reload_statistics(): Reload or recompute statistics after ALTER TABLE. innodb_notify_tabledef_changed(): A new function to invoke ha_innobase::reload_statistics(). handlerton::notify_tabledef_changed(): Add the parameter handler* so that ha_innobase::reload_statistics() can be invoked. ha_partition::notify_tabledef_changed(), partition_notify_tabledef_changed(): Pass through the call to any partitions or subpartitions. This is based on code that was supplied by Monty.
-
Vlad Lesin authored
The check is added.
-
Thirunarayanan Balathandayuthapani authored
During recovery, InnoDB fails if it tries to apply a FREE_PAGE and WRITE record to the page. InnoDB encryption thread accesses the freed page and writes redo log for it. This is similar to commit deadec4e (MDEV-24569) InnoDB is missing buf_page_free() while freeing the segment. To avoid accessing of freed page in buffer pool, InnoDB should mark the pages as FREED while freeing the segment. Also to avoid reading of freed page, InnoDB should check the allocation bitmap page. fseg_free_step(): Mark the page in buffer pool as FREED fseg_free_step_not_header(): Mark the page in buffer pool as FREED buf_dump(): Ignore the freed pages while dumping the buffer pool content fil_crypt_get_page_throttle_func(): Skip the rotation for FREED page to avoid the assert failure during recovery fil_crypt_rotate_page(): Skip the rotation for the freed page Reviewed-by: Marko Mäkelä
-
Marko Mäkelä authored
-
- 27 Jan, 2021 3 commits
-
-
Thirunarayanan Balathandayuthapani authored
MDEV-24693 LeakSanitizer: detected memory leaks in mem_heap_create_block_func / fts_optimize_create_msg - This issue is caused by the commit bf1f9b59 (MDEV-24638). Delay the creation of SYNC message in fts_optimize_request_sync_table. So that InnoDB can avoid creating the message if the table already has SYNC message in fts_optimize_wq queue
-
Jan Lindström authored
* galera * galera_sr * galera_3nodes
-
Jan Lindström authored
Correct test.
-
- 26 Jan, 2021 1 commit
-
-
Roman Nozdrin authored
the top level
-
- 25 Jan, 2021 7 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-