1. 30 Nov, 2004 1 commit
    • unknown's avatar
      two-line fix for BUG#6732 "FLUSH TABLES WITH READ LOCK + COMMIT makes next... · 352ad815
      unknown authored
      two-line fix for BUG#6732 "FLUSH TABLES WITH READ LOCK + COMMIT makes next FLUSH...LOCK hang forever"
      (originally reported as "second run of innobackup hangs forever and can even hang server").
      Plus testcase for the bugfix and comments about global read locks.
      
      
      mysql-test/r/flush_block_commit.result:
        result update
      mysql-test/t/flush_block_commit.test:
        testing bugfix (originally: second run of innobackup hangs)
      sql/lock.cc:
        When we are in start_waiting_global_read_lock(), if we ourselves have
        the global read lock, there is nothing to start. This makes a pair with how 
        wait_if_global_read_lock() behaves when we ourselves have the global read lock.
        Previously, start_waiting_global_read_lock() decremented protect... whereas wait_if_global_read_lock()
        hadn't incremented it => very wrong => hangs.
        Descriptive comments on how global read lock works.
      352ad815
  2. 26 Nov, 2004 2 commits
    • unknown's avatar
      srv0srv.c: · 59abcd44
      unknown authored
        srv_lock_timeout_and_monitor_thread(): write to srv_monitor_file
        only if --innodb_status_file=1
      
      
      innobase/srv/srv0srv.c:
        srv_lock_timeout_and_monitor_thread(): write to srv_monitor_file
        only if --innodb_status_file=1
      59abcd44
    • unknown's avatar
      Fixes while reviewing code · 60af9206
      unknown authored
      (Cleanups and better bug fixes)
      
      
      mysql-test/r/select.result:
        Fixed test after wrong merge
      mysql-test/t/select.test:
        Fixed test after wrong merge
      scripts/mysql_fix_privilege_tables.sh:
        Don't read defaults files
      sql/item_cmpfunc.cc:
        Fix wrong value for not_null_tables_cache
      sql/item_cmpfunc.h:
        Remove wrong patch (flags are set in fix_length_and_dec())
      sql/item_func.h:
        Fix wrong value for not_null_tables_cache
      sql/slave.cc:
        Fixed indentation
      60af9206
  3. 25 Nov, 2004 4 commits
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/4.0-virgin · fecd27a1
      unknown authored
      into mysql.com:/home/timka/mysql/src/4.0-master
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      fecd27a1
    • unknown's avatar
      Merge for BUG#3759 which was missing from the main tree for some reason. · 0dcb55f4
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      sql/item_cmpfunc.h:
        Auto merged
      mysql-test/r/select.result:
        Merge for BUG#3759
      mysql-test/t/select.test:
        Merge for BUG#3759
      0dcb55f4
    • unknown's avatar
      Merge mysql.com:/space/bkroot/mysql-4.0 · 467c4814
      unknown authored
      into mysql.com:/space/bk/b6148-mysql-4.0
      
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      467c4814
    • unknown's avatar
      Fix for Bug#6148. Only rewind read position in binary log when the · 6f2cf12a
      unknown authored
      slave SQL thread is started.
      
      
      sql/slave.cc:
        Adding threads to init as parameter to init_master_info.
        Only rewind read position when starting SQL thread.
      sql/slave.h:
        Adding threads to init as parameter to init_master_info.
        Only rewind read position when starting SQL thread.
      sql/sql_repl.cc:
        Adding threads to init as parameter to init_master_info.
        Only rewind read position when starting SQL thread.
      sql/repl_failsafe.cc:
        Adding threads to init as parameter to init_master_info.
        Only rewind read position when starting SQL thread.
      6f2cf12a
  4. 24 Nov, 2004 1 commit
  5. 23 Nov, 2004 1 commit
    • unknown's avatar
      Change "Do-compile" to make automatic build log analysis easier and · a9aff01e
      unknown authored
      to run the standard tests with "--force" (default, can be switched off).
      
      
      Build-tools/Do-compile:
        1) For an automated log analysis, we need a clear marker in the build log
           whether compile + link succeeded: Write it after successful "make".
        2) Ensure the standard tests are run with "--force" in the default case,
           but allow the old behaviour by an option "--one-error".
        3) Correct a typing error in the usage message.
      a9aff01e
  6. 22 Nov, 2004 4 commits
  7. 19 Nov, 2004 1 commit
  8. 18 Nov, 2004 1 commit
  9. 17 Nov, 2004 1 commit
  10. 16 Nov, 2004 1 commit
    • unknown's avatar
      ha_innodb.cc: · 16d735ad
      unknown authored
        Fix InnoDB bug #6287: if one uses INSERT IGNORE to insert several rows at a time, and the first inserts are ignored because of a duplicate key collision, then InnoDB in a replication slave assigns AUTO_INCREMENT values 1 bigger than in the master
      
      
      sql/ha_innodb.cc:
        Fix InnoDB bug #6287: if one uses INSERT IGNORE to insert several rows at a time, and the first inserts are ignored because of a duplicate key collision, then InnoDB in a replication slave assigns AUTO_INCREMENT values 1 bigger than in the master
      16d735ad
  11. 15 Nov, 2004 1 commit
    • unknown's avatar
      Proposed fix for bug #6439 "from_unixtime() function returns wrong datetime · e1509cf7
      unknown authored
      values for too big argument".
      
      Added range checking for from_unixtime() argument, cleaned up code 
      a bit.
      
      
      mysql-test/r/func_time.result:
        Test for bug #6439 "from_unixtime() function returns wrong datetime 
        values for too big argument".
      mysql-test/t/func_time.test:
        Test for bug #6439 "from_unixtime() function returns wrong datetime 
        values for too big argument".
      sql/item_timefunc.cc:
        Item_func_from_unixtime: 
          Added error range checking for function argument + small code clean up.
      e1509cf7
  12. 12 Nov, 2004 4 commits
  13. 11 Nov, 2004 4 commits
  14. 10 Nov, 2004 3 commits
    • unknown's avatar
      Merge paul@bk-internal.mysql.com:/home/bk/mysql-4.0 · 4bbec092
      unknown authored
      into kite-hub.kitebird.com:/src/extern/MySQL/bk/mysql-4.0
      
      
      4bbec092
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 93cbaf03
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      93cbaf03
    • unknown's avatar
      Fix for BUG#6522 "Replication fails due to a rolled back transaction in the binlog" · 12fbc41f
      unknown authored
      When we are writing a transaction to the binlog, we log BEGIN/COMMIT with zero error code.
      Example: all statements of trans succeeded, connection lost and so implicit rollback:
      we don't want ER_NET* errors to be logged in the BEGIN/ROLLBACK events, while statement
      events have 0. If there was really a serious error code, it's already in the statement events.
      
      
      sql/log.cc:
        When we write the cached binlog segment to disk binlog at COMMIT/ROLLBACK time:
        imagine this is rollback due to net timeout, after all statements of
        the transaction succeeded. Then we want a zero-error code in BEGIN.
        In other words, if there was a really serious error code it's already
        in the transaction's statement events.
      sql/sql_table.cc:
        out of date comment
      12fbc41f
  15. 09 Nov, 2004 1 commit
  16. 08 Nov, 2004 1 commit
    • unknown's avatar
      mysql.h: · 01c80f55
      unknown authored
        Adding a prototype for the new function.
      
      
      include/mysql.h:
        Adding a prototype for the new function.
      01c80f55
  17. 05 Nov, 2004 9 commits