1. 26 Jul, 2006 1 commit
    • unknown's avatar
      BUG#21206: memory corruption when too many cursors are opened at once · 35945019
      unknown authored
      Too many cursors (more than 1024) could lead to memory corruption.
      This affects both, stored routines and C API cursors, and the
      threshold is per-server, not per-connection.  Similarly, the
      corruption could happen when the server was under heavy load
      (executing more than 1024 simultaneous complex queries), and this is
      the reason why this bug is fixed in 4.1, which doesn't support
      cursors.
      
      The corruption was caused by a bug in the temporary tables code, when
      an attempt to create a table could lead to a write beyond allocated
      space.  Note, that only internal tables were affected (the tables
      created internally by the server to resolve the query), not tables
      created with CREATE TEMPORARY TABLE.  Another pre-condition for the
      bug is TRUE value of --temp-pool startup option, which, however, is a
      default.
      
      The cause of a bug was that random memory was overwritten in
      bitmap_set_next() due to out-of-bound memory access.
      
      
      mysys/my_bitmap.c:
        Local 'bitmap_size' is measured in bytes, no need to multiply it by 8.
      sql/sql_select.cc:
        Clear the temp_pool_slot bit only if we have set it previously.
      35945019
  2. 24 Jul, 2006 5 commits
  3. 23 Jul, 2006 1 commit
  4. 20 Jul, 2006 1 commit
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · c988ef94
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.19983
      
      
      libmysqld/lib_sql.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      c988ef94
  5. 19 Jul, 2006 2 commits
    • unknown's avatar
      Bug #21135 Crash in test "func_time" · d7c0c667
      unknown authored
       - backport patch from 5.0
       - "table" can be NULL in temporary fields used for type conversion
      
      
      sql/field.cc:
        table can be NULL in temporary fields used for type conversion.
        Store value in field as if db_low_byte_first was set.
      sql/field.h:
        table can be NULL in temporary fields used for type conversion.
        Store value in field as if db_low_byte_first was set.
      d7c0c667
    • unknown's avatar
      mysql.spec.sh: · b53e47a1
      unknown authored
        Added new "mysql_explain_log" man page
        Added missing install of "myisam_ftdump" man page
        Added missing install of "mysqlman" man page
      
      
      support-files/mysql.spec.sh:
        Added new "mysql_explain_log" man page
        Added missing install of "myisam_ftdump" man page
        Added missing install of "mysqlman" man page
      b53e47a1
  6. 18 Jul, 2006 3 commits
    • unknown's avatar
      Merge moonbone.local:/home/evgen/bk-trees/mysql-4.1 · 6abe1c71
      unknown authored
      into  moonbone.local:/work/tmp_merge-4.1-opt-mysql
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      6abe1c71
    • unknown's avatar
      Merge moonbone.local:/work/mysql-4.1 · 5a77e566
      unknown authored
      into  moonbone.local:/work/tmp_merge-4.1-opt-mysql
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      5a77e566
    • unknown's avatar
      Backporting Kostja's changes made for 5.0 into 4.1. · d39e8532
      unknown authored
      Please use "ul" when merging this changeset to 5.0.
      
      
      sql/item_timefunc.cc:
        Fix a valgrind warning in type_date test.
      sql/sql_locale.cc:
        Fix a Windows build failure:  "false" -> FALSE
      d39e8532
  7. 17 Jul, 2006 2 commits
    • unknown's avatar
      Changes to make "sql/sql_locale.cc" compile + link on Windows: · 73328544
      unknown authored
      1) When initializing a boolean variable, do not use string representations '"false"' and '"true"' 
          but rather the boolean values 'false' and 'true'.
      2) Add the module to the various Windows description files.
      
      
      VC++Files/libmysqld/libmysqld.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/libmysqld/libmysqld.vcproj:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/libmysqld/libmysqld_ia64.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/mysqldemb/mysqldemb.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/mysqldemb/mysqldemb.vcproj:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/mysqldemb/mysqldemb_ia64.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/sql/mysqld.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/sql/mysqld.vcproj:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/sql/mysqld_ia64.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/sql/mysqldmax.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      VC++Files/sql/mysqldmax_ia64.dsp:
        Add "sql/sql_locale.cpp" with similar settings as the other files.
      sql/sql_locale.cc:
        When initializing a boolean variable, do not use stringrepresentations '"false"' and '"true"' 
        but rather the boolean values 'false' and 'true'.
      73328544
    • unknown's avatar
      strings/strtod.c : Ensure the definition of "EOVERFLOW" is available. · e732d352
      unknown authored
      In 5.0, this is already solved, so that is a null-merge ("ul").
      
      
      strings/strtod.c:
        This file needs the definition of "EOVERFLOW",
        which is on some platforms (Windows, OpenBSD) provided only by "my_base.h".
        As this in turn includes "my_global.h", the include file name can be changed.
      e732d352
  8. 15 Jul, 2006 1 commit
  9. 14 Jul, 2006 5 commits
  10. 13 Jul, 2006 6 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · ae3d1248
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.16017
      
      
      ae3d1248
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · d9992cc7
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.16017
      
      
      include/sql_common.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      libmysqld/libmysqld.c:
        merging
      d9992cc7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 3c2bdb59
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/m41-maint--07AB5
      
      
      3c2bdb59
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 5392be95
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/m41-maint--07AB5
      
      
      5392be95
    • unknown's avatar
      Merge igreenhoe@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 4bdc4251
      unknown authored
      into  anubis.greendragongames.com:/home/greenman/workspace-mysql/mysql/pending/bug-4.1-15977
      
      
      4bdc4251
    • unknown's avatar
      Bug#20432: mysql client interprets commands in comments · 76215977
      unknown authored
      do not look for client-specific commands while inside a multi-line comment.
      we will allow multi-comments pretty much anywhere within SQL-statements,
      but client-specific commands (help, use, print, ...) must be the first token
      in the input.
      
      
      client/mysql.cc:
        Bug#20432: mysql client interprets commands in comments
      mysql-test/r/mysql_client.result:
        Bug#20432: mysql client interprets commands in comments
        test client-side parsing of comments and client-specific commands
      mysql-test/t/mysql_client.test:
        Bug#20432: mysql client interprets commands in comments
        test client-side parsing of comments and client-specific commands
      76215977
  11. 12 Jul, 2006 4 commits
    • unknown's avatar
      Merge dl145k.mysql.com:/data0/mkindahl/bkroot/mysql-4.1 · 17870724
      unknown authored
      into  dl145k.mysql.com:/data0/mkindahl/bk/mysql-4.1-rpl
      
      
      17870724
    • unknown's avatar
      Bug #17212 results not sorted correctly by ORDER BY when using index · 41445430
      unknown authored
        * don't use join cache when the incoming data set is already ordered
          for ORDER BY
          This choice must be made because join cache will effectively
          reverse the join order and the results will be sorted by the index
          of the table that uses join cache.
      
      
      mysql-test/r/innodb_mysql.result:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * Test suite for the bug
      mysql-test/t/innodb_mysql.test:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * Test suite for the bug
      sql/sql_select.cc:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * don't use join cache when the incoming data set is already sorted
      41445430
    • unknown's avatar
      Merge cmiller@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0f7258e0
      unknown authored
      into  maint1.mysql.com:/data/localhome/cmiller/mysql-4.1
      
      
      0f7258e0
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · e2c448fb
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      e2c448fb
  12. 11 Jul, 2006 8 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 03dbc219
      unknown authored
      into  moonbone.local:/work/18503-bug-4.1-mysql
      
      
      sql/sql_select.cc:
        Auto merged
      03dbc219
    • unknown's avatar
      Fixed bug#18503: Queries with a quantified subquery returning empty set · d2bbf288
      unknown authored
      may return a wrong result.
      
      An Item_sum_hybrid object has the was_values flag which indicates whether any
      values were added to the sum function. By default it is set to true and reset
      to false on any no_rows_in_result() call. This method is called only in
      return_zero_rows() function. An ALL/ANY subquery can be optimized by MIN/MAX
      optimization. The was_values flag is used to indicate whether the subquery
      has returned at least one row. This bug occurs because return_zero_rows() is
      called only when we know that the select will return zero rows before
      starting any scans but often such information is not known.
      In the reported case the return_zero_rows() function is not called and
      the was_values flag is not reset to false and yet the subquery return no rows
      Item_func_not_all and Item_func_nop_all functions return a wrong
      comparison result.
      
      The end_send_group() function now calls no_rows_in_result() for each item
      in the fields_list if there is no rows were found for the (sub)query.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      mysql-test/r/subselect.result:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      sql/sql_select.cc:
        Fixed bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
        
        The end_send_group() function now calls no_rows_in_result() for each item
        in the fields_list if there is no matching rows were found.
      d2bbf288
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 26ddd5cb
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/m41-maint--07AB5
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      26ddd5cb
    • unknown's avatar
      Bug#20729: Bad date_format() call makes mysql server crash · ed001f18
      unknown authored
          
      The problem is that the author used the wrong function to send a warning to the 
      user about truncation of data.  push_warning() takes a constant string and 
      push_warning_printf() takes a format and variable arguments to fill it.
      
      Since the string we were complaining about contains percent characters, the 
      printf() code interprets the "%Y" et c. that the user sends.  That's wrong, and
      often causes a crash, especially if the date mentions seconds, "%s".
      
      A alternate fix would be to use  push_warning_printf(..., "%s", warn_buff) .
      
      
      mysql-test/r/date_formats.result:
        Test that an invalid date doesn't crash the server.  We should get a warning back 
        instead of a dead socket.
      mysql-test/t/date_formats.test:
        Test that an invalid date doesn't crash the server.  We should get a warning back 
        instead of a dead socket.
      sql/time.cc:
        Don't try to use warn_buf as the start of a varible arguement list to send 
        to a warning-formatted my_vsnprintf() .
      ed001f18
    • unknown's avatar
      ndb - (4.1) trivial fix to error.log (wday=0 was printed as "x") · 27721ce5
      unknown authored
      
      ndb/src/kernel/error/TimeModule.cpp:
        0=Sunday
      27721ce5
    • unknown's avatar
      Merge moonbone.local:/work/allany-4.1-mysql · bf01313c
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      
      bf01313c
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 7642d181
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-4.1-opt
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      7642d181
    • unknown's avatar
      Merge zippy.(none):/home/cmiller/work/mysql/mysql-4.0__bug19006 · d1a31ef5
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/merge/mysql-4.1
      
      
      client/sql_string.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/sql_string.h:
        Auto merged
      configure.in:
        Null merge.
      sql/item_strfunc.cc:
        Null merged
      d1a31ef5
  13. 10 Jul, 2006 1 commit