An error occurred fetching the project authors.
  1. 19 Apr, 2006 1 commit
  2. 18 Apr, 2006 1 commit
  3. 12 Apr, 2006 1 commit
    • kroki@mysql.com's avatar
      Bug#16461: connection_id() does not work properly inside trigger · c8e22ff7
      kroki@mysql.com authored
      CONNECTION_ID() was implemented as a constant Item, i.e. an instance of
      Item_static_int_func class holding value computed at creation time.
      Since Items are created on parsing, and trigger statements are parsed
      on table open, the first connection to open a particular table would
      effectively set its own CONNECTION_ID() inside trigger statements for
      that table.
      
      Re-implement CONNECTION_ID() as a class derived from Item_int_func, and
      compute connection_id on every call to fix_fields().
      c8e22ff7
  4. 29 Mar, 2006 1 commit
    • dlenev@mysql.com's avatar
      Proposed fix for bug #17764 "Trigger crashes MyISAM table" · 17785d16
      dlenev@mysql.com authored
      A table with an on insert trigger was reported as crashed when the insert
      was processed with bulk insert mode on (handler::start_bulk_insert).
      The trigger was also selecting from the same table, and that caused
      the "crash".
      The same problem was present when an insert statement, which was processed
      in bulk mode, also used a stored function that was reading the same table.
      
      This fix disables bulk inserts if a statement uses functions or invokes
      triggers. Implementing more granular checks will require much more code and
      therefore can hardly be done in 5.0
      17785d16
  5. 24 Mar, 2006 1 commit
  6. 04 Mar, 2006 1 commit
    • dlenev@mysql.com's avatar
      Fix for bug #17866 "Problem with renaming table with triggers with fully · efe09006
      dlenev@mysql.com authored
      qualified subject table" which was introduced during work on bug #13525
      "Rename table does not keep info of triggers".
      
      The bug was caused by the fact that during reconstruction of CREATE TRIGGER
      statement stored in .TRG file which happened during RENAME TABLE we damaged
      trigger definition in case when it contained fully qualified name of subject
      table (see comment for sql_yacc.yy for more info).
      efe09006
  7. 27 Feb, 2006 1 commit
  8. 24 Feb, 2006 1 commit
  9. 28 Jan, 2006 1 commit
  10. 24 Jan, 2006 1 commit
  11. 05 Jan, 2006 1 commit
    • monty@mysql.com's avatar
      Review fixes of new pushed code · 6e22e29d
      monty@mysql.com authored
      - Fixed tests
      - Optimized new code
      - Fixed some unlikely core dumps
      - Better bug fixes for:
        - #14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
        - #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null
      6e22e29d
  12. 11 Dec, 2005 1 commit
  13. 22 Nov, 2005 2 commits
    • bell@sanja.is.com.ua's avatar
      7bd691f1
    • bell@sanja.is.com.ua's avatar
      Fix for BUG#13549 "Server crash with nested stored procedures · 2bcd6897
      bell@sanja.is.com.ua authored
      if inner routine has more local variables than outer one, and
      one of its last variables was used as argument to NOT operator".
      
      THD::spcont was non-0 when we were parsing stored routine/trigger
      definition during execution of another stored routine. This confused
      methods of Item_splocal and forced them use wrong runtime context.
      Fix ensures that we always have THD::spcont equal to zero during
      routine/trigger body parsing. This also allows to avoid problems
      with errors which occur during parsing and SQL exception handlers.
      2bcd6897
  14. 17 Nov, 2005 1 commit
  15. 14 Sep, 2005 1 commit
    • dlenev@mysql.com's avatar
      Fix for bug #12704 "Server crashes during trigger execution". · e231ebe5
      dlenev@mysql.com authored
      This bug occurs when some trigger for table used by DML statement is created
      or changed while statement was waiting in lock_tables(). In this situation
      prelocking set which we have calculated becames invalid which can easily lead
      to errors and even in some cases to crashes.
      
      With proposed patch we no longer silently reopen tables in lock_tables(),
      instead caller of lock_tables() becomes responsible for reopening tables and
      recalculation of prelocking set.
      e231ebe5
  16. 02 Sep, 2005 1 commit
    • konstantin@mysql.com's avatar
      Implement WL#2661 "Prepared Statements: Dynamic SQL in Stored Procedures". · 38486e83
      konstantin@mysql.com authored
      The idea of the patch is to separate statement processing logic,
      such as parsing, validation of the parsed tree, execution and cleanup, 
      from global query processing logic, such as logging, resetting
      priorities of a thread, resetting stored procedure cache, resetting
      thread count of errors and warnings.
      This makes PREPARE and EXECUTE behave similarly to the rest of SQL
      statements and allows their use in stored procedures.
      This patch contains a change in behaviour:
      until recently for each SQL prepared statement command, 2 queries
      were written to the general log, e.g.
      [Query]   prepare stmt from @stmt_text;
      [Prepare] select * from t1 <-- contents of @stmt_text
      The chagne was necessary to prevent [Prepare] commands from being written
      to the general log when executing a stored procedure with Dynamic SQL.
      We should consider whether the old behavior is preferrable and probably
      restore it.
      This patch refixes Bug#7115, Bug#10975 (partially), Bug#10605 (various bugs
      in Dynamic SQL reported before it was disabled).
      38486e83
  17. 18 Aug, 2005 1 commit
  18. 15 Aug, 2005 2 commits
    • monty@mysql.com's avatar
      Fixed typo in error numbers · d0c66bba
      monty@mysql.com authored
      d0c66bba
    • monty@mysql.com's avatar
      Save and clear run context before executing a stored function or trigger and restore it afterwards. · df32f7d6
      monty@mysql.com authored
      This allows us to use statement replication with functions and triggers
      The following things are fixed with this patch:
      - NOW() and automatic timestamps takes the value from the main event for functions and triggers (which allows these to replicate with statement level logging)
      - No side effects for triggers or functions with auto-increment values(), last_insert_id(), rand() or found_rows()
      - Triggers can't return result sets
      
      Fixes bugs:
      #12480: NOW() is not constant in a trigger
      #12481: Using NOW() in a stored function breaks statement based replication
      #12482: Triggers has side effects with auto_increment values
      #11587: trigger causes lost connection error
      df32f7d6
  19. 10 Aug, 2005 1 commit
  20. 09 Aug, 2005 1 commit
  21. 30 Jul, 2005 1 commit
  22. 28 Jul, 2005 1 commit
  23. 19 Jul, 2005 2 commits
  24. 13 Jul, 2005 2 commits
  25. 09 Jul, 2005 2 commits
  26. 29 Jun, 2005 1 commit
  27. 30 May, 2005 1 commit
  28. 24 May, 2005 1 commit
    • dlenev@brandersnatch.localdomain's avatar
      Fix for bugs: · 007a2059
      dlenev@brandersnatch.localdomain authored
       #5860 "Multi-table UPDATE does not activate update triggers"
       #6812 "Triggers are not activated for INSERT ... SELECT"
       #8755 "Trigger is not activated by LOAD DATA".
      This patch also implements proper handling of triggers for special forms
      of insert like REPLACE or INSERT ... ON DUPLICATE KEY UPDATE. 
      Also now we don't call after trigger in case when we have failed to
      inserted/update or delete row. Trigger failure should stop statement
      execution.
      
      I have not properly tested handling of errors which happen inside of
      triggers in this patch, since it is simplier to do this once we will be
      able to access tables from triggers.
      007a2059
  29. 27 Mar, 2005 1 commit
  30. 04 Jan, 2005 1 commit
    • monty@mysql.com's avatar
      After merge fixes · 7cf8285b
      monty@mysql.com authored
      Add support for warnings for prepare of prepared statements
      Fixed test to work with --ps-protocol
      Fixed some test results
      7cf8285b
  31. 03 Jan, 2005 1 commit
  32. 24 Nov, 2004 1 commit
    • dlenev@brandersnatch.localdomain's avatar
      Fix for bug #5888 "Triggers with nonexistent columns cause packets · d2010746
      dlenev@brandersnatch.localdomain authored
      out of order". (final version)
      
      Now instead of binding Item_trigger_field to TABLE objects during
      trigger definition parsing at table open, we perform pass through
      special list of all such objects in trigger. This allows easily check
      all references to fields in old/new version of row in trigger during
      execution of CREATE TRIGGER statement (this is more courtesy for users
      since we can't check everything anyway).
      We also report that such reference is bad by returning error from
      Item_trigger_field::fix_fields() method (instead of setup_field())
      This means that if trigger is broken we will bark during trigger
      execution instead of trigger definition parsing at table open.
      (i.e. now we allow to open tables with broken triggers).
      d2010746
  33. 12 Nov, 2004 1 commit
  34. 08 Oct, 2004 1 commit
  35. 09 Sep, 2004 1 commit