An error occurred fetching the project authors.
  1. 09 Nov, 2009 2 commits
  2. 05 Nov, 2009 1 commit
  3. 04 Nov, 2009 1 commit
  4. 03 Nov, 2009 5 commits
    • Jonathan Perkin's avatar
      Merge to mysql-next-mr-bugfixing. · 470e843a
      Jonathan Perkin authored
      470e843a
    • Jonathan Perkin's avatar
      Additional change required for bug#46834, find the std_data directory · 25067ea7
      Jonathan Perkin authored
      correctly in RPMs.
      25067ea7
    • Alexey Botchkov's avatar
      Bug#41371 Select returns 1 row with condition "col is not null and col is null" · d9ea0d0c
      Alexey Botchkov authored
          For application compatibility reasons  MySQL converts "<autoincrement_column> IS NULL"
          predicates to "<autoincrement_column> = LAST_INSERT_ID()" in the first SELECT following an
          INSERT regardless of whether they're top level predicates or not. This causes wrong and
          obscure results when these predicates are combined with others on the same columns. Fixed
          by only doing the transformation on a single top-level predicate if a special SQL mode is
          turned on (sql_auto_is_null).
          Also made sql_auto_is_null off by default.
      
      per-file comments:
        mysql-test/r/func_isnull.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
          test result updated
      
        mysql-test/t/func_isnull.test
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
          test case added
      
        sql/mysqld.cc
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
          sql_auto_is_null now is OFF by default.
      
        sql/sql_select.cc
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
          remove_eq_conds() split in two parts - one only checks the upper condition,
          the req_remove_eq_conds() recursively checks all the condition tree.
      
        mysql-test/extra/rpl_tests/rpl_insert_id.test
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              test fixed (set the sql_auto_is_null variable)
      
        mysql-test/r/mysqlbinlog.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/r/mysqlbinlog2.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/r/odbc.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/r/query_cache.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/r/user_var-binlog.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/suite/binlog/r/binlog_row_ctype_ucs.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/suite/rpl/r/rpl_insert_id.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/suite/rpl/r/rpl_row_mysqlbinlog.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/suite/rpl/r/rpl_sp.result
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              result updated
      
        mysql-test/t/odbc.test
      Bug#41371      Select returns 1 row with condition "col is not null and col is null"
              test fixed (set the sql_auto_is_null variable)
      d9ea0d0c
    • Vladislav Vaintroub's avatar
      merge · 5c4423c5
      Vladislav Vaintroub authored
      5c4423c5
    • Vladislav Vaintroub's avatar
      Bug #47423 mtr connects to wrong database · 2377eed3
      Vladislav Vaintroub authored
      The reason for the bug is that mysqtest as well as other client tools
      running in test suite (mysqlbinlog, mysqldump) will first try to connect 
      whatever database has created shared memory with default base name 
      "MySQL" and use this. (Same effect could be seen on Unix if mtr would
      not care to calculate "port" and "socket" parameter).
            
      The fix ensures that all client tools and  running in mtr use unique  
      per-database shared memory base parameters, so there is no possibility
      to clash with already installed one. We use socket name for shared memory 
      base (it's known to be unique). This shared-memory-base is written to the
      MTR config file to the [client] and [mysqld] sections. Fix made also made 
      sure all client tools understand and correctly handle --shared-memory-base.
      Prior to this patch  it was not the case for  mysqltest, mysqlbinlog and 
      mysql_client_test.
            
      All new connections done from mtr scripts via connect() will by default 
      set shared-memory-base. And finally, there is a possibility to force 
      shared memory or pipe connection and overwrite shared memory/pipe base name
      from within mtr scripts via optional PIPE or SHM modifier. This functionality
      was manually backported from 6.0
      (original patch  http://lists.mysql.com/commits/74749)
      2377eed3
  5. 02 Nov, 2009 3 commits
    • Vladislav Vaintroub's avatar
      merge · e57e4107
      Vladislav Vaintroub authored
      e57e4107
    • Vladislav Vaintroub's avatar
      Bug#47571: idle named pipe connection is unkillable · e0800807
      Vladislav Vaintroub authored
      Bug#31621: Windows server hanging during shutdown using named pipes 
                 and idle connection
                  
      Problem: when idle pipe connection is forcefully closed with KILL
      statement or when the server goes down, thread that is closing connection
      would hang infinitely in CloseHandle(). The reason for the hang is that 
      named pipe operations are performed synchronously. In this mode all IOs
      on pipe are serialized, that is CloseHandle() will not abort ReadFile() 
      in another thread, but wait for ReadFile() to complete.
                  
      The fix implements asynchrnous mode for named pipes, where operation of file
      are not synchronized. Read/Write operation would fire an async IO and wait for
      either IO completion or timeout.
                  
      Note, that with this patch timeouts are properly handled for named pipes.
            
      Post-review: Win32 timeout code has been fixed for named pipes and shared
      memory. We do not store pointer to NET in vio structure, only the read and 
      write timeouts.
      
      
      include/violite.h:
        Add pipe_overlapped to Vio structure for async IO for named pipes.
      sql-common/client.c:
        Use asynchronous pipe IO.
      sql/mysqld.cc:
        Use asynchronous pipe IO.
      vio/vio.c:
        -Refactor timeouts for win32 protocols: shared memory and named pipes.
        Store read/write timeout in VIO structure, instead of storing pointer
        to NET. New function vio_win32_timeout called indirectly via 
        vio_timeout changes these values.
      vio/vio_priv.h:
        Remove vio_ignore_timeout.
        Add vio_win32_timeout to be used for named pipes and shared memory.
      vio/viosocket.c:
        Use async IO for named pipes.
        After issuing IO, wait for either IO completion, pipe_close_event
        or timeout.
                
        Refactor timeouts for named pipe and shared memory.
      e0800807
    • Marc Alff's avatar
      Bug#9801 Views: imperfect error message · 587a696a
      Marc Alff authored
      Backport for 5.5
      
      The root cause of this bug is that the grammar for GROUP BY clauses,
      when using WITH CUBE or WITH ROLLUP, cause conflicts with the grammar
      for VIEW, when using WITH CHECK OPTION.
      
      The solution is to implement two token look ahead when parsing a WITH token,
      to disambiguate the non standard WITH CUBE and WITH ROLLUP syntaxes.
      
      Patch based on code from Marc Alff and Antony Curtis
      587a696a
  6. 31 Oct, 2009 5 commits
  7. 29 Oct, 2009 6 commits
  8. 28 Oct, 2009 4 commits
    • Tor Didriksen's avatar
    • Tor Didriksen's avatar
      Bug#48060 Memory leak - Item::val_bool() (item.cc:184) from optimizer_subquery grammar · b2baeed4
      Tor Didriksen authored
      Item_sum::set_aggregator() may be called multiple times during query preparation.
      On subsequent calls: verify that the aggregator type is the same,
      and re-use the existing Aggregator.
      
      
      sql/item_sum.cc:
        In Item_sum::set_aggregator(): re-use existing Aggregator if already set.
        
        Remove some friend declarations, add some accessor functions.
        Cleanup some DBUG_ENTER and DBUG_RETURN code.
      sql/item_sum.h:
        Make some member fields private, add accessors instead.
        Remove some un-necessary friend declarations.
        Remove some default arguments from constructors.
      sql/opt_sum.cc:
        Use accessor functions in Item_sum.
      sql/sql_select.cc:
        Fix mis-spelled DBUG_ENTER text.
        Use accessor functions in Item_sum.
      sql/sql_yacc.yy:
        Use explicit true/false rather than default arguments when constructing
        Item_sum_xxx objects.
      b2baeed4
    • Alexey Botchkov's avatar
      WL#4991 mysql_upgrade --fix-privilege-tables · 36299d59
      Alexey Botchkov authored
         (backport)
         mysql_upgrade script accepts --upgrade-system-tables option,
         fixing only system tables in this case.
      
      per-file comments:
        client/mysql_upgrade.c
      WL#4991 mysql_upgrade --fix-privilege-tables
          --upgrade-system-tables option added.
         if it is set, the tool won't look for the mysqlcheck then
         run_mysqlcheck_fixnames() and run_mysqlcheck_upgrade won't be called.
        mysql-test/r/mysql_upgrade.result
      WL#4991 mysql_upgrade --fix-privilege-tables
          test result added
        mysql-test/t/mysql_upgrade.test
      WL#4991 mysql_upgrade --fix-privilege-tables
          test case added
      36299d59
    • Alexander Nozdrin's avatar
      Automerge from mysql-next-mr. · 55b8f07a
      Alexander Nozdrin authored
      55b8f07a
  9. 27 Oct, 2009 9 commits
  10. 26 Oct, 2009 4 commits
    • Dmitry Lenev's avatar
      Fix for bug #45143 "All connections hang on concurrent ALTER TABLE". · 86c23fa7
      Dmitry Lenev authored
      Concurrent execution of statements which require non-table-level
      write locks on several instances of the same table (such as
      SELECT ... FOR UPDATE which uses same InnoDB table twice or a DML
      statement which invokes trigger which tries to update same InnoDB
      table directly and through stored function) and statements which
      required table-level locks on this table (e.g. LOCK TABLE ... WRITE,
      ALTER TABLE, ...) might have resulted in a deadlock.
      
      The problem occured when a thread tried to acquire write lock
      (TL_WRITE_ALLOW_WRITE) on the table but had to wait since there was
      a pending write lock (TL_WRITE, TL_WRITE_ALLOW_READ) on this table
      and we failed to detect that this thread already had another instance
      of write lock on it (so in fact we were trying to acquire recursive
      lock) because there was also another thread holding write lock on the
      table (also TL_WRITE_ALLOW_WRITE). When the latter thread released
      its lock neither the first thread nor the thread trying to acquire
      TL_WRITE/TL_WRITE_ALLOW_READ were woken up (as table was still write
      locked by the first thread) so we ended up with a deadlock.
      
      This patch solves this problem by ensuring that thread which
      already has write lock on the table won't wait when it tries
      to acquire second write lock on the same table.
      
      mysql-test/r/lock_sync.result:
        Added test case for bug #45143 "All connections hang on concurrent
        ALTER TABLE".
      mysql-test/t/lock_sync.test:
        Added test case for bug #45143 "All connections hang on concurrent
        ALTER TABLE".
      mysys/thr_lock.c:
        Ensured that thread can acquire write lock on the table without
        waiting if it already has write lock on it even if there are other
        threads holding write locks on this table (this is normal situation
        for, e.g., TL_WRITE_ALLOW_WRITE type of lock).
        
        Adjusted comments to better explain why it is OK to do so and added
        asserts to prevent introduction of scenarios in which this can cause
        problems.
      86c23fa7
    • Vladislav Vaintroub's avatar
      Bug #48317 cannot build innodb as static library. · 1dd88254
      Vladislav Vaintroub authored
      The problem here is that the latest innodb push contains
      both MYSQL_STORAGE_ENGINE(INNOBASE) and MYSQL_STORAGE_ENGINE(INNOBASE)
      in the same CMakeLists.txt, to make the resulting library
      ha_innodb.dll, instead of ha_innobase.dll.
      
      Using multiple MYSQL_STORAGE_ENGINE within the same  CMakeLists.txt
      conflicts with the fix for the bug Bug #47795 "CMake, storage engine
      name different from directory name". Top-level CMakeLists.txt now 
      parses storage engine's  CMakeLists.txt to extract engines name from 
      MYSQL_STORAGE_ENGINE().
      
      For innodb, it concludes that there is not storage engine named
      INNOBASE, hence WITH_INNOBASE_STORAGE_ENGINE has no effect.
      
      The fix is to use SET_TARGET_PROPERTIES(... PROPERTIES OUTPUT_NAME ...),
      instead of renaming the engine to have plugins named ha_innodb.dll.
      1dd88254
    • Alexander Barkov's avatar
    • Sergey Glukhov's avatar
      Bug#35427 INFORMATION_SCHEMA.TABLES.TABLE_CATALOG is NULL, should be "def" · 90e2ad95
      Sergey Glukhov authored
      additional fix(Betony)
      
      90e2ad95