- 24 Sep, 2021 1 commit
-
-
Marko Mäkelä authored
-
- 18 Sep, 2021 2 commits
-
-
Marko Mäkelä authored
dict_stats_process_entry_from_defrag_pool(): Acquire MDL on the table for which we are invoking dict_stats_save_defrag_stats(), to avoid any race condition with DROP TABLE or similar operations.
-
Marko Mäkelä authored
dict_stats_process_entry_from_defrag_pool(): Restore a condition as it was before commit 82b7c561.
-
- 17 Sep, 2021 9 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Monty authored
The issue is that max_length for prepared statements are different from normal queries, which can optimize the max_length based on the result length.
-
Marko Mäkelä authored
When computing statistics, let us play it safe and check whether an insert into an empty table is in progress, once we have acquired the root page latch. If yes, let us pretend that the table is empty, just like MVCC reads would do. It is unlikely that this race condition could lead into any crashes before MDEV-24621, because the index tree structure should be protected by the page latches. But, at least we can avoid some busy work and return earlier. As part of this, some code that is only used for statistics calculation is being moved into static functions in that compilation unit.
-
Marko Mäkelä authored
btr_root_block_get(): Check for index->page == FIL_NULL. btr_root_get(): Declare static. Other callers can invoke btr_root_block_get() directly. btr_get_size(): Remove conditions that are checked in btr_root_block_get().
-
Krunal Bauskar authored
* buffer pool has latches that protect access to pages. * there is a latch per N pages. (check page_hash_table for more details) * N is calculated based on the cacheline size. * for example: if cacheline size is : 64 then 7 pages pointers + 1 latch can be hosted on the same cacheline : 128 then 15 pages pointers + 1 latch can be hosted on the same cacheline * arm generally have wider cacheline so with arm 1 latch is used to access 15 pages vs with x86 1 latch is used to access 7 pages. Naturally, the contention is more with arm case. * said patch help relax this contention by limiting the elements per cacheline to 7 (+ 1 latch slot). for wider-cacheline (say 128), the remaining 8 slots are kept empty. this ensures there are no 2 latches on the same cacheline to avoid latch level contention. Based on suggestion from Marko, the same logic is now extended to lock_sys_t::hash_table.
-
Julius Goryavsky authored
MDEV-19950 addendum: galera_ssl_upgrade removed from the list of disabled tests and adapted for 10.4+
-
Jan Lindström authored
Problem was that there was extra condition !thd->lex->no_write_to_binlog before call to begin TOI. It seems that this variable is not initialized. TRUNCATE does not support [NO_WRITE_TO_BINLOG | LOCAL] keywords, thus we should not check this condition. All this was hidden in a macro, so I decided to remove those macros that were used only a few places with actual function calls.
-
Marko Mäkelä authored
-
- 16 Sep, 2021 5 commits
-
-
Marko Mäkelä authored
innodb_max_purge_lag_wait_update(): To align with purge_coordinator_state::refresh(), we must trigger a page flush batch if the last log checkpoint is too old. This was caught in a hang of the test innodb_gis.rtree_compress.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
buf_flush_page_cleaner(): Always try to advance the log checkpoint, even when no pages were flushed during the latest batch. Maybe, since the previous batch, there was an LRU flush that removed the last dirty pages. Failure to advance the log checkpoint will cause unnecessary work in Mariabackup and on crash recovery.
-
Monty authored
This was required as I added a new error code to my_base.h and rocksdb is adding it's own errors after the last official one Updated result file also for index_merge_rocksdb2. This is a big test and we have probably not before noticed that some optimizer changes caused a difference.
-
Eugene Kosov authored
MDEV-26621 assertion failue "index->table->persistent_autoinc" in /storage/innobase/btr/btr0btr.cc during IMPORT dict_index_t::clear_instant_alter(): when searhing for an AUTO_INCREMENT column don't skip the beginning of the list because the field can be at the beginning of the list
-
- 15 Sep, 2021 4 commits
-
-
Monty authored
This bug happens when one runs aria_chk on multiple tables. It does not affect REPAIR TABLE. aria_chk tries to optimize the sort buffer size to minimize memory usage when used with small tables. The bug was that the adjusted value was used as a base for the next table, which could cause problems.
-
Monty authored
Fixed also an error in suite/perfschema/t/transaction_nested_events-master.opt
-
Monty authored
- Error on commit now returns HA_ERR_COMMIT_ERROR instead of HA_ERR_INTERNAL_ERROR - If checkpoint fails, it will now print out where it failed.
-
Monty authored
-
- 14 Sep, 2021 7 commits
-
-
Monty authored
instead of original name of the column When doing refactoring of temporary table field creation a mistake was done when copying the column name when creating internal temporary tables. For internal temporary tables we should use the original field name, not the item name (= alias).
-
Marko Mäkelä authored
This should be equivalent to pull request #1889 by Krunal Bauskar. The existing logic in purge_coordinator_state::do_purge() activates a number of the configured innodb_purge_threads based on the history list length. Activating more purge worker tasks should shrink the history list faster. But, more purge workers will also generate more redo log, which may slow down writes by user connections. row_purge_parse_undo_rec(): Revert the work-around that was added in commit 46904424. purge_coordinator_state: Keep track of the redo log fill factor (how big percentage of innodb_log_file_size is being occupied by log records that were generated since the latest checkpoint). If the redo log is getting full, log checkpoints will be triggered more frequently, and user threads may end up waiting in log_free_check(). We try to reduce purge-induced jitter in overall throughput by throttling down the active number of purge tasks as the log checkpoint age is approaching the log size (in other words, the redo log fill factor is approaching 100%).
-
Marko Mäkelä authored
purge_coordinator_timer_callback(): Remove. We will have purge_coordinator_timer invoke purge_coordinator_callback() directly. srv_master_callback(): Invoke srv_wake_purge_thread_if_not_active() instead of purge_coordinator_timer_callback(). That is, we will trigger purge_coordinator_callback() once per second if there is any work to be done. purge_state::do_purge(): Replaces srv_do_purge(), purge_coordinator_callback_low(), and purge_coordinator_timer_callback(). The static variables inside srv_do_purge() were moved to purge_state data members.
-
Marko Mäkelä authored
In commit ff5d306e we removed dbug_after_task_callback but forgot to revert the rest of commit bada05a8.
-
Daniel Black authored
Thanks to Fabian Vogt for noticing the mutual exclusions of these open flags on tmpfs caused by mariadb opening it incorrectly. As such we clear the O_CREAT flag while opening it as O_TMPFILE.
-
Daniele Sciascia authored
Fix sporadic failure for MTR test galera_sr.GCF-1018B. The test sometimes fails due to an error that is logged to the error log unnecessarily. A deterministic test case (included in this patch) shows that the error is loggen when a transaction is BF aborted right before it opens the streaming log table to perform fragment removal. When that happens, the attempt to open the table fails and consequently an error is logged. There is no need to log this error, as an ER_LOCK_DEADLOCK error is returned to the client. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>
-
Otto Kekäläinen authored
The debian/salsa-ci.yml used to work also on upstream MariaDB.org branches, but has recently regressed and several jobs stopped working. These fixes are necessary to get it working again. * Partially revert 8642f592 that never worked, as MariaDB 10.2 does not have a mysql.global table nor a mariadb.sys user. Those features weren't introduced until MariaDB 10.4. * Partially revert 0268b871 as we don't want ColumnStore as part of the native Debian build. It should build only when the build is triggered via autobake-deb.sh (MariaDB.org builds). * Adjust salsa-ci.yml to cope with various Stretch to Sid upgrade issues and remove the legacy mariadb-connector-c job completely as that package hasn't been around for years anymore. * Extend Lintian overrides to be otherwise Lintian clean
-
- 13 Sep, 2021 1 commit
-
-
Marko Mäkelä authored
row_purge_remove_clust_if_poss_low(): The table identified by SYS_INDEXES.TABLE_ID is protected by exclusive dict_sys.latch. There is no need to touch its reference count.
-
- 12 Sep, 2021 1 commit
-
-
Sergei Golubchik authored
set_item() uses 1UL << bit, so is_set_item() must do the same. This fixes sporadic perfschema.show_aggregate failures (sporadic, because `bit` is the thread id, so depending on how many tests were run before perfschema.show_aggregate it can be above or below 32).
-
- 11 Sep, 2021 10 commits
-
-
Vladislav Vaintroub authored
# Conflicts: # appveyor.yml
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Marko Mäkelä authored
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
# Conflicts: # appveyor.yml
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
# Conflicts: # cmake/os/Windows.cmake # sql/sql_yacc.yy
-
Vladislav Vaintroub authored
-