1. 19 Nov, 2020 1 commit
  2. 18 Nov, 2020 1 commit
    • Marko Mäkelä's avatar
      MDEV-24224 Gap lock on delete in 10.5 using READ COMMITTED · 33d41167
      Marko Mäkelä authored
      When MDEV-19544 (commit 1a6f4704)
      simplified the initialization of the local variable
      set_also_gap_locks, an inadvertent change was included.
      Essentially, all code branches that are executed when
      set_also_gap_locks hold must also ensure that
      trx->isolation_level > TRX_ISO_READ_COMMITTED holds.
      This was being violated in a few code paths.
      
      It turns out that there is an even simpler fix: Remove the test
      of thd_is_select() completely. In that way, the first part of
      UPDATE or DELETE should work exactly like SELECT...FOR UPDATE.
      
      thd_is_select(): Remove.
      33d41167
  3. 17 Nov, 2020 7 commits
  4. 16 Nov, 2020 7 commits
  5. 14 Nov, 2020 6 commits
  6. 13 Nov, 2020 9 commits
  7. 12 Nov, 2020 6 commits
    • Sujatha's avatar
      Merge branch '10.3' into 10.4 · b2029c03
      Sujatha authored
      b2029c03
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 972dc6ee
      Marko Mäkelä authored
      972dc6ee
    • Sujatha's avatar
      Merge branch '10.2' into 10.3 · bafb011a
      Sujatha authored
      bafb011a
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 150f447a
      Marko Mäkelä authored
      150f447a
    • Sujatha's avatar
      MDEV-4633: multi_source.simple test fails sporadically · 984a06db
      Sujatha authored
      Analysis:
      ========
      Writes to 'rli->log_space_total' needs to be synchronized, otherwise both
      SQL_THREAD and IO_THREAD can try to modify the variable simultaneously
      resulting in incorrect rli->log_space_total.  In the current test scenario
      SQL_THREAD is trying to decrement 'rli->log_space_total' in 'purge_first_log'
      and IO_THREAD is trying to increment the 'rli->log_space_total' in
      'queue_event' simultaneously. Hence test occasionally fails with  result
      mismatch.
      
      Fix:
      ===
      Convert 'rli->log_space_total' variable to atomic type.
      984a06db
    • Marko Mäkelä's avatar
      MDEV-24196 WITH_UBSAN: member call on null pointer of log_phys_t · 97569d3c
      Marko Mäkelä authored
      MDEV-12353 deliberately tries to avoid memory alignment overhead in
      log_phys_t, storing the stream of log records bytes straight after
      a header object. But, offsetof() is not allowed on C++ data objects,
      and neither are attempts to emulate it by invoking a member function
      on a null pointer.
      
      log_phys_t::len: Remove. Make it part of the byte stream that
      immediately follow the object. Thanks to Eugene Kosov for this idea.
      
      log_phys_t::start(): The start address of the following byte stream.
      
      log_phys_t::len(): Compute len.
      
      log_phys_t::alloc_size(): Use a simple sizeof calculation.
      97569d3c
  8. 11 Nov, 2020 3 commits
    • Marko Mäkelä's avatar
      Merge mariadb-10.2.36 into 10.2 · dd33a70d
      Marko Mäkelä authored
      dd33a70d
    • Marko Mäkelä's avatar
      Merge mariadb-10.3.27 into 10.3 · 340feb01
      Marko Mäkelä authored
      340feb01
    • sjaakola's avatar
      MDEV-24119 MDL BF-BF Conflict caused by TRUNCATE TABLE · 2fbcddbe
      sjaakola authored
      A follow-up fix, for original fix for MDEV-21577, which did not handle well
      temporary tables.
      
      OPTIMIZE and REPAIR TABLE statements can take a list of tables as argument,
      and some of the tables may be temporary. Proper handling of temporary tables
      is to skip them and continue working on the real tables. The bad version, skipped all tables,
      if a single temporary table was in the argument list. And this resulted so that FK parent
      tables were not scnanned for the remaining real tables. Some mtr tests, using OPTIMIZE or REPAIR
      for temporary tables caused regressions bacause of this, e.g. galera.galera_optimize_analyze_multi
      
      The fix in this PR opens temporary and real tables first, and in the table handling loop skips
      temporary tables, FK parent scanning is done only for real tables.
      
      The test has new scenario for OPTIMIZE and REPAIR issued for two tables of which one is temporary table.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      2fbcddbe