- 02 Apr, 2020 6 commits
-
-
Sergei Golubchik authored
MDEV-22113 SIGSEGV, ASAN use-after-poison, Assertion `next_insert_id == 0' in handler::ha_external_lock if the lookup_handler is allocated on the THD's memroot, it may not live long enough to be deleted in handler::ha_external_lock()
-
Daniel Black authored
Prevent errors like on FreeBSD [ 56%] Linking CXX shared module ha_test_sql_discovery.so cd /usr/home/dan/build-mariadb-server-10.5/storage/test_sql_discovery && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/test_sql_discovery.dir/link.txt --verbose=1 /usr/bin/c++ -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -shared -o ha_test_sql_discovery.so CMakeFiles/test_sql_discovery.dir/test_sql_discovery.cc.o -lpthread ../../libservices/libmysqlservices.a -lmysqld -lpthread /usr/bin/ld: error: unable to find library -lmysqld Also tested on OpenIndiana successfully. Closes #1480
-
Rasmus Johansson authored
-
Otto Kekäläinen authored
Ubuntu Bionic 18.04 LTS will be around until 2023 while Xenial is only to 2021. Thus Bionic is much more suitable as the Travis-CI default build environment for the 10.5 branch. For now, still keep one Xenial build to ensure backwards compatibility. Disable main.udf test until MDEV-21976 is addressed.
-
Otto Kekäläinen authored
Number of jobs dropped from 23 -> 17 and build time from 8-10 hours to 3-4 hours. Drop GCC 6 and Clang 6 from build dependencies and version 6 is dropped from the jobs matrix. Also ignore arm64 and ppc64le on Bionic builds since they sporadically fail.
-
Marko Mäkelä authored
innodb_buffer_pool_evict_uncompressed(): Remove the mutex acquisition that was inadvertently added in 1a6f708e.
-
- 01 Apr, 2020 5 commits
-
-
Marko Mäkelä authored
In MDEV-12353, the calls to mtr_t::memo_modify_page() were accidentally removed along with mlog_open_and_write_index() and its callers. Let us resurrect the function to enable better debug checks. mtr_t::flag_modified(): Renamed from mtr_t::set_modified() and made private. mtr_t::set_modified(): Take const buf_block_t& as a parameter. In several mtr_t member functions, replace const buf_page_t& parameters with const buf_block_t&, so that we can pass the parameter to set_modified(). mtr_t::modify(): Add a MTR_MEMO_MODIFY entry for a block that is guaranteed to be modified in the mini-transaction.
-
Marko Mäkelä authored
page_zip_clear_rec(): Explicitly initialize len in non-debug builds to avoid a warning about possibly invalid memset() length.
-
Marko Mäkelä authored
copy_keys_from_share(): Use reinterpret_cast instead of manipulating a reference to a type-punned pointer. This cleans up after the cleanup commit 0515577d.
-
Marko Mäkelä authored
In commit a5584b13 some scrubbing-related status variables were removed along with the background scrubbing code. The status variable INNODB_ENCRYPTION_NUM_KEY_REQUESTS was inadvertently removed as part of that. innodb_status_variables[]: Restore "encryption_num_key_requests". We introduce the test innodb.innodb_status_variables in order to catch similar regressions in the future.
-
Marko Mäkelä authored
Because InnoDB is not freeing undo pages to the normal free-page management, old undo log pages can be reused. Due to that, it is possible (but unlikely) that the fields TRX_UNDO_NEEDS_PURGE and TRX_UNDO_LOG_START relative to the free offset that is stored at TRX_UNDO_PAGE_HDR + TRX_UNDO_PAGE_START already have the correct value. Hence, we must pass the mtr_t::OPT template parameter to silence the debug assertion. Other writes in trx_undo_header_create() that are using the default template parameter seem to be correct (the data fields should be guaranteed to change even in the event of reusing pages).
-
- 31 Mar, 2020 18 commits
-
-
Nikita Malyavin authored
-
Sergei Golubchik authored
that is don't call alloc_lookup_buffer() and create_lookup_handler() for every row also, don't call ha_check_overlaps() for every partition, after it was already done on the ha_partition level
-
Nikita Malyavin authored
* The overlaps check is implemented on a handler level per row command. It creates a separate cursor (actually, another handler instance) and caches it inside the original handler, when ha_update_row or ha_insert_row is issued. Cursor closes on unlocking the handler. * Containing the same key in index means unique constraint violation even in usual terms. So we fetch left and right neighbours and check that they have same key prefix, excluding from the key only the period part. If it doesnt match, then there's no such neighbour, and the check passes. Otherwise, we check if this neighbour intersects with the considered key. * The check does not introduce new error and fails with ER_DUPP_KEY error. This might break REPLACE workflow and should be fixed separately
-
Sergei Golubchik authored
* rename to a generic name * move remaning initializations from query exec to prepare time * simplify/unify key handling in open_table_from_share and delayed * remove dead code * move tests where they belong
-
Nikita Malyavin authored
-
Nikita Malyavin authored
key_copy is supposed to take field values from the from_record argument, but it was mostly ignoring it and instead relying on the caller to set field->ptr pointers accordingly. Inconsistently, it was checking the null bitmap in the from_record, not at the field->null_ptr. Now key_copy correctly takes all field values from the from_record.
-
Nikita Malyavin authored
-
Nikita Malyavin authored
-
Nikita Malyavin authored
Sergei's commit ac6b3c44 implemented handler status counters compensation for underlying handlers like ha_partition. `index_read_idx_map` is missing there, but it should have been fixed as well (proof: ha_partition::index_read_idx_map never calls ha_partition::index_read_map). Note: all this compensation logic could be broken for subpartitions! (We can experience double decrement)
-
Nikita Malyavin authored
-
Nikita Malyavin authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
Remove special treatment for Aria. Add a test with --help and mysql.plugin table being InnoDB MyISAM is still treated specially, as we need to be able to initialize global_system_variables.table_plugin reliably
-
Sergei Golubchik authored
where PK is neither required nor implied
-
Sergei Golubchik authored
-
Marko Mäkelä authored
When MDEV-19514 removed the change buffer merges in the background, it introduced a minor regression: After a DDL operation that drops or rebuilds a table or partition, any entries in the change buffer could survive until a slow shutdown (innodb_fast_shutdown=0) is executed. fil_delete_tablespace(). Before returning, invoke ibuf_delete_for_discarded_space(). With this, the only way to have change buffer ‘leaks’ is to kill and restart the server at an appropriate moment and never initiate a slow shutdown.
-
Marko Mäkelä authored
There is no background change buffer merge any more. Change buffer merge will only take place during a slow shutdown (a shutdown initiated after SET GLOBAL innodb_fast_shutdown=0).
-
Marko Mäkelä authored
The definition of the member function ha_cassandra::records_in_range() was inadvertently removed (renamed to a non-member function) in commit ff64152b. Let us define the overridden member function inline, and add C++11 override qualifiers.
-
- 30 Mar, 2020 9 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
recv_sys.recovery_on: Replaces recv_recovery_on. recv_sys_t::apply(): Replaces recv_apply_hashed_log_recs(). recv_sys_var_init(): Remove. recv_sys_t::recover_low(): Attempt to initialize a page based on buffered redo log records.
-
Marko Mäkelä authored
In commit f8a9f906 we removed support for crash-upgrade from older versions, but forgot to remove a check for recovering TRUNCATE TABLE if MariaDB 10.2.18 or 10.3.9 or earlier were killed and we are attempting to upgrade to MariaDB 10.5.2 or later. Already MariaDB 10.4 would refuse to recover such TRUNCATE operations.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
If a table is altered using the MDEV-11369/MDEV-15562/MDEV-13134 ALGORITHM=INSTANT, it can force the table to use a non-canonical format: * A hidden metadata record at the start of the clustered index is used to store each column's DEFAULT value. This makes it possible to add new columns that have default values without rebuilding the table. * Starting with MDEV-15562 in MariaDB Server 10.4, a BLOB in the hidden metadata record is used to store column mappings. This makes it possible to drop or reorder columns without rebuilding the table. This also makes it possible to add columns to any position or drop columns from any position in the table without rebuilding the table. If a column is dropped without rebuilding the table, old records will contain garbage in that column's former position, and new records will be written with NULL values, empty strings, or dummy values. This is generally not a problem. However, there may be cases where users may want to avoid putting a table into this format. For example, users may want to ensure that future UPDATE operations after an ADD COLUMN will be performed in-place, to reduce write amplification. (Instantly added columns are essentially always variable-length.) Users might also want to avoid bugs similar to MDEV-19916, or they may want to be able to export tables to older versions of the server. We will introduce the option innodb_instant_alter_column_allowed, with the following values: * never (0): Do not allow instant add/drop/reorder, to maintain format compatibility with MariaDB 10.x and MySQL 5.x. If the table (or partition) is not in the canonical format, then any ALTER TABLE (even one that does not involve instant column operations) will force a table rebuild. * add_last (1, default in 10.3): Store a hidden metadata record that allows columns to be appended to the table instantly (MDEV-11369). In 10.4 or later, if the table (or partition) is not in this format, then any ALTER TABLE (even one that does not involve column changes) will force a table rebuild. Starting with 10.4: * add_drop_reorder (2, default): Like 'add_last', but allow the metadata record to store a column map, to support instant add/drop/reorder of columns (MDEV-15562).
-
Thirunarayanan Balathandayuthapani authored
partition does rebuild - In ha_innobase::commit_inplace_alter_table() assumes that all partition should do the same kind of alter operations. During DDL, if one partition requires table rebuild and other partition doesn't need rebuild then all partition should be forced to rebuild.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Varun Gupta authored
MDEV-22019: Sig 11 in next_breadth_first_tab | max_sort_length setting + double GROUP BY leads to crash No need to create a temp table for aggregation if we have encountered some error.
-
- 28 Mar, 2020 2 commits
-
-
Marko Mäkelä authored
For ENGINE=Aria, we work around bugs in various tests that catch writes of uninitialized bytes from the Aria page cache. (Why do we even write anything on DROP TABLE?)
-
Marko Mäkelä authored
MemorySanitizer (clang -fsanitize=memory) requires that all code be compiled with instrumentation enabled. The C runtime library is an exception. Failure to use instrumented libraries will cause bogus messages about memory being uninitialized. In WITH_MSAN builds, we must avoid calling getservbyname(), because even though it is a standard library function, it is not instrumented, not even in clang 10. The following cmake options were tested: -DCMAKE_C_FLAGS='-march=native -O2' -DCMAKE_CXX_FLAGS='-stdlib=libc++ -march=native -O2' -DWITH_EMBEDDED_SERVER=OFF -DWITH_UNIT_TESTS=OFF -DCMAKE_BUILD_TYPE=Debug -DWITH_INNODB_{BZIP2,LZ4,LZMA,LZO,SNAPPY}=OFF -DPLUGIN_{ARCHIVE,TOKUDB,MROONGA,OQGRAPH,ROCKSDB,CONNECT,SPIDER}=NO -DWITH_SAFEMALLOC=OFF -DWITH_{ZLIB,SSL,PCRE}=bundled -DHAVE_LIBAIO_H=0 -DWITH_MSAN=ON MEM_MAKE_DEFINED(): An alias for VALGRIND_MAKE_MEM_DEFINED() and in the future, __msan_unpoison(). For now, neither MEM_MAKE_DEFINED() nor MEM_UNDEFINED() perform any action under MSAN. Enabling them will catch more bugs, but will also require some more fixes or work-arounds. Json_writer::add_double(): Work around a frequently occurring failure in optimizer tests, related to EXPLAIN FORMAT=JSON. dtoa(): Disable MSAN altogether. For some reason, this function is triggering a lot of trouble, especially when invoked for DBUG functions. The MDL default timeout is dd=86400 seconds, and for some reason it is claimed to be uninitialized. InnoDB: Define UNIV_DEBUG_VALGRIND also WITH_MSAN. ut_crc32_8_hw(), ut_crc32_64_low_hw(): Use the compiler built-in functions instead of inline assembler when building WITH_MSAN. This will require at least -msse4.2 when building for IA-32 or AMD64. The inline assembler would not be instrumented, and would thus cause bogus failures.
-