- 03 Apr, 2020 17 commits
-
-
Aleksey Midenkov authored
-
Aleksey Midenkov authored
- Ignore system-invisible fields (as well as for setting default value); - Handle rename of system time and period fields.
-
Aleksey Midenkov authored
-
Aleksey Midenkov authored
libmariadb revision updated.
-
Sergey Vojtovich authored
-
Marko Mäkelä authored
This bug was introduced by MDEV-15528 commit a35b4ae8. In the case that I analyzed, we failed to apply an EXTENDED,INSERT_REUSE_REDUNDANT redo log record whose preceding record points to unallocated area after PAGE_HEAP_TOP. Had we properly written the FREE_PAGE record for the page, recovery would have processed it, because during the checkpoint, the log had been completely written past the LSN of the missed write. fseg_free_page_low(): Always invoke mtr_t::free(). The other call is in fsp_free_page().
-
Daniel Black authored
-
Sergey Vojtovich authored
Let auto repair table and truncate table routines flush TABLE_SHARE directly. Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
TDC_RT_REMOVE_ALL -> tdc_remove_table(). Some occurrences replaced with TDC_element::flush() (whenver TABLE_SHARE is available). TDC_RT_REMOVE_NOT_OWN[_KEEP_SHARE] -> TDC_element::flush(). These modes assume that current thread owns TABLE_SHARE reference, which means we can avoid hash lookup and flush unused TABLE instances directly. TDC_RT_REMOVE_UNUSED -> TDC_element::flush_unused(). Only [ab]used by mysql_admin_table() currently. Should be removed eventually. Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
As tc_purge() never marks share flushed, let tdc_remove_table() do it directly. Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
Aim of this patch is to remove tdc_remove_table(TDC_RT_REMOVE_UNUSED), which was mistakenly introduced by 055a3334. InnoDB allows only one open TABLE instance while performing table truncation. To fulfill this requirement: 1. MDL_EXCLUSIVE has to be acquired to block concurrent threads from accessing given table 2. cached TABLE instances have to be flushed 3. another InnoDB requirement is such that TABLE_SHARE and remaining TABLE instance have to be invalidated and re-opened after truncation This goes more or less inline with what regular TRUNCATE TABLE does. Alternative solution would be handler::ha_delete_all_rows(), but InnoDB doesn't implement it unfortunately. Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
Let DROP SERVER and ALTER SERVER perform fair affected tables flushing. That is acquire MDL_EXCLUSIVE and do tdc_remove_table(TDC_RT_REMOVE_ALL). Aim of this patch is elimination of another inconsistent use of TDC_RT_REMOVE_UNUSED. It fixes (to some extent) a problem described in the beginning of sql_server.cc, when close_cached_connection_tables() interferes with concurrent transaction. A better fix should probably introduce proper MDL locks for server objects? Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
Removed redundant tdc_remove_table(TDC_RT_REMOVE_ALL). Share was marked flushed by preceding wait_while_table_is_used() and eventually flushed by close_all_tables_for_name(). Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
close_all_tables_for_name() is always preceded by wait_while_table_is_used(), which makes tdc_remove_table() redundant. The only (now fixed) exception was close_cached_tables(). Part of MDEV-17882 - Cleanup refresh version
-
Sergey Vojtovich authored
Rather than flushing caches with tdc_remove_table(TDC_RT_REMOVE_UNUSED) flush them with extra(HA_EXTRA_FLUSH) instead. This goes inline with regular FTWRL. Part of MDEV-17882 - Cleanup refresh version
-
Marko Mäkelä authored
The template parameter mtr_t::OPT refers to optional, not optimized. Also the default parameter mtr_t::NORMAL refers to optimized writes. The name MAYBE_NOP would be more descriptive, conveying the idea that a write to a durable page might not actually have any effect.
-
Marko Mäkelä authored
mtr_t::log_write(): Fix an off-by-one error.
-
- 02 Apr, 2020 7 commits
-
-
Daniel Black authored
MDEV-18851: multiple sized large page support (linux)
-
Sergei Golubchik authored
MDEV-22113 SIGSEGV, ASAN use-after-poison, Assertion `next_insert_id == 0' in handler::ha_external_lock if the lookup_handler is allocated on the THD's memroot, it may not live long enough to be deleted in handler::ha_external_lock()
-
Daniel Black authored
Prevent errors like on FreeBSD [ 56%] Linking CXX shared module ha_test_sql_discovery.so cd /usr/home/dan/build-mariadb-server-10.5/storage/test_sql_discovery && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/test_sql_discovery.dir/link.txt --verbose=1 /usr/bin/c++ -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -shared -o ha_test_sql_discovery.so CMakeFiles/test_sql_discovery.dir/test_sql_discovery.cc.o -lpthread ../../libservices/libmysqlservices.a -lmysqld -lpthread /usr/bin/ld: error: unable to find library -lmysqld Also tested on OpenIndiana successfully. Closes #1480
-
Rasmus Johansson authored
-
Otto Kekäläinen authored
Ubuntu Bionic 18.04 LTS will be around until 2023 while Xenial is only to 2021. Thus Bionic is much more suitable as the Travis-CI default build environment for the 10.5 branch. For now, still keep one Xenial build to ensure backwards compatibility. Disable main.udf test until MDEV-21976 is addressed.
-
Otto Kekäläinen authored
Number of jobs dropped from 23 -> 17 and build time from 8-10 hours to 3-4 hours. Drop GCC 6 and Clang 6 from build dependencies and version 6 is dropped from the jobs matrix. Also ignore arm64 and ppc64le on Bionic builds since they sporadically fail.
-
Marko Mäkelä authored
innodb_buffer_pool_evict_uncompressed(): Remove the mutex acquisition that was inadvertently added in 1a6f708e.
-
- 01 Apr, 2020 5 commits
-
-
Marko Mäkelä authored
In MDEV-12353, the calls to mtr_t::memo_modify_page() were accidentally removed along with mlog_open_and_write_index() and its callers. Let us resurrect the function to enable better debug checks. mtr_t::flag_modified(): Renamed from mtr_t::set_modified() and made private. mtr_t::set_modified(): Take const buf_block_t& as a parameter. In several mtr_t member functions, replace const buf_page_t& parameters with const buf_block_t&, so that we can pass the parameter to set_modified(). mtr_t::modify(): Add a MTR_MEMO_MODIFY entry for a block that is guaranteed to be modified in the mini-transaction.
-
Marko Mäkelä authored
page_zip_clear_rec(): Explicitly initialize len in non-debug builds to avoid a warning about possibly invalid memset() length.
-
Marko Mäkelä authored
copy_keys_from_share(): Use reinterpret_cast instead of manipulating a reference to a type-punned pointer. This cleans up after the cleanup commit 0515577d.
-
Marko Mäkelä authored
In commit a5584b13 some scrubbing-related status variables were removed along with the background scrubbing code. The status variable INNODB_ENCRYPTION_NUM_KEY_REQUESTS was inadvertently removed as part of that. innodb_status_variables[]: Restore "encryption_num_key_requests". We introduce the test innodb.innodb_status_variables in order to catch similar regressions in the future.
-
Marko Mäkelä authored
Because InnoDB is not freeing undo pages to the normal free-page management, old undo log pages can be reused. Due to that, it is possible (but unlikely) that the fields TRX_UNDO_NEEDS_PURGE and TRX_UNDO_LOG_START relative to the free offset that is stored at TRX_UNDO_PAGE_HDR + TRX_UNDO_PAGE_START already have the correct value. Hence, we must pass the mtr_t::OPT template parameter to silence the debug assertion. Other writes in trx_undo_header_create() that are using the default template parameter seem to be correct (the data fields should be guaranteed to change even in the event of reusing pages).
-
- 31 Mar, 2020 11 commits
-
-
Nikita Malyavin authored
-
Sergei Golubchik authored
that is don't call alloc_lookup_buffer() and create_lookup_handler() for every row also, don't call ha_check_overlaps() for every partition, after it was already done on the ha_partition level
-
Nikita Malyavin authored
* The overlaps check is implemented on a handler level per row command. It creates a separate cursor (actually, another handler instance) and caches it inside the original handler, when ha_update_row or ha_insert_row is issued. Cursor closes on unlocking the handler. * Containing the same key in index means unique constraint violation even in usual terms. So we fetch left and right neighbours and check that they have same key prefix, excluding from the key only the period part. If it doesnt match, then there's no such neighbour, and the check passes. Otherwise, we check if this neighbour intersects with the considered key. * The check does not introduce new error and fails with ER_DUPP_KEY error. This might break REPLACE workflow and should be fixed separately
-
Sergei Golubchik authored
* rename to a generic name * move remaning initializations from query exec to prepare time * simplify/unify key handling in open_table_from_share and delayed * remove dead code * move tests where they belong
-
Nikita Malyavin authored
-
Nikita Malyavin authored
key_copy is supposed to take field values from the from_record argument, but it was mostly ignoring it and instead relying on the caller to set field->ptr pointers accordingly. Inconsistently, it was checking the null bitmap in the from_record, not at the field->null_ptr. Now key_copy correctly takes all field values from the from_record.
-
Nikita Malyavin authored
-
Nikita Malyavin authored
-
Nikita Malyavin authored
Sergei's commit ac6b3c44 implemented handler status counters compensation for underlying handlers like ha_partition. `index_read_idx_map` is missing there, but it should have been fixed as well (proof: ha_partition::index_read_idx_map never calls ha_partition::index_read_map). Note: all this compensation logic could be broken for subpartitions! (We can experience double decrement)
-
Nikita Malyavin authored
-
Nikita Malyavin authored
-