1. 28 Aug, 2019 1 commit
  2. 25 Aug, 2019 1 commit
  3. 24 Aug, 2019 2 commits
  4. 23 Aug, 2019 16 commits
    • Monty's avatar
      Updated result for rocksdb tests after merge · 2bacce8b
      Monty authored
      2bacce8b
    • Monty's avatar
      Decrease stack space usage of mysql_execute_command() · 1fbaf8b6
      Monty authored
      The extensive usage of stack space, especially when used with ASan
      (AdressSanitizer) of mysql_execute_command caused the test
      rpl.rpl_row_sp011 to fail because it did run out of stack.  In this
      test case mysql_execute_command is called recursively for each
      function all.
      
      Changes done:
      - Changed a few functions that used big local variables to be marked
        __attribute__ ((noinline))
      - Moved sub parts that used big local variables to external functions.
      - Changed wsrep_commit_empty() from inline to normal function as this used
        more than 1K of stack space and because there is no reason for this
        rarely used function to be inline.
      
      End result (with gcc 7.4.1 on Intel Xeon):
      
      Starting point for stack space usage:
      
      gcc -O:                                  7800
      gcc with -fsanitize=address -O (ASan) : 27240
      
      After this patch:
      
      gcc -O:                                  1160
      gcc -O0 (debug build)                    1584
      gcc with -fsanitize=address -O (ASan):   4424
      gcc with -fsanitize=address -O2 (ASan):  3874
      
      A 6x improvement and will allow us to run all mtr tests with ASan.
      1fbaf8b6
    • Sergei Golubchik's avatar
      Decrease stack space usage of mysql_execute_command() · e21408b7
      Sergei Golubchik authored
      - WSREP_DEBUG called WSREP_LOG which allocated a 1K variable on stack
        for each macro usage (at least gcc can't reuse the stack space).
        Move this concatenation to happen compile-time, not run-time.
      e21408b7
    • Sergei Golubchik's avatar
      hide have_sanitizer variable in non-ASAN builds · f8018a35
      Sergei Golubchik authored
      and change its semantics so that it could in the future
      be used for MSAN, UBSAN, and other sanitizer too.
      f8018a35
    • Monty's avatar
      Added asan options to mysql-test-run · d90fa9ad
      Monty authored
      - Leak detection is now enabled by default
      - Also added to mysql-test suppression files for asan and lsan
      d90fa9ad
    • Monty's avatar
      Fixed issues when running mtr with --valgrind · 97dd0577
      Monty authored
      - Note that some issues was also fixed in 10.2 and 10.4. I also fixed them
        here to be able to continue with making 10.5 valgrind safe again
      - Disable connection threads warnings when doing shutdown
      97dd0577
    • Monty's avatar
      b444b6b9
    • Monty's avatar
      Fixed compiler warnings from connect engine · a38f47e9
      Monty authored
      - clang complains about register in C++
      - Removed not used variables
      - Fixed bug when printing date in filamdbf.cpp
      - Added {} to fix warning about dangling else
      - Changed connect_done_func() to be global to remove conflict with header
        files
      - Added extra () around assignment in if
      a38f47e9
    • Monty's avatar
      Fixed some test that failed randomly · de8b51fd
      Monty authored
      de8b51fd
    • Monty's avatar
      Removed some compiler warnings found by clang · 76ce6ae4
      Monty authored
      - Fixed some unitialized variables
      - Removed some warnings:
        -Wno-parentheses-equality gives warnings from macro-expressions
        -Wno-string-plus-int is not a common problem and it's not trivial to
        fix it in connect
      76ce6ae4
    • Monty's avatar
      Fixed BUILD scripts for gcc 6.x · 4a75b480
      Monty authored
      Added also -DTRASH_FREE_MEMORY to valgrind builds
      4a75b480
    • Sergei Golubchik's avatar
      move Aria/S3 specific flag into Aria code · e6bad1c7
      Sergei Golubchik authored
      it doesn't belong in include/my_base.h
      e6bad1c7
    • Monty's avatar
      MDEV-20306 Assert when converting encrypted Aria table to S3 · 1b5e5bde
      Monty authored
      Changes:
      - maria_create() now uses a bit in the parameter flags to check if table
        should be encrypted instead of using maria_encrypted_tables.
      - Don't encrypt tables that are to be converted to S3
      - Added encrypted flag to ARIA_TABLE_CAPABILITIES
      - maria_chk --description now prints if table is encrypted. Other
        operations is not allowed on encrypted tables.
      1b5e5bde
    • Monty's avatar
      Fixed assertion Assertion `!table->pos_in_locked_tables' failed · bb6d674d
      Monty authored
      MDEV-19591
      Assertion `!table->pos_in_locked_tables' failed in tc_release_table upon
      altering table into S3 under lock.
      
      The problem was that thd->open_tables->pos_in_locked_tables was not reset
      when alter table failed to reopen a locked table.
      bb6d674d
    • Sergei Golubchik's avatar
      alloc_on_stack: simplify the API · 2e665fb2
      Sergei Golubchik authored
      2e665fb2
    • Monty's avatar
      MDEV-20279 Increase Aria index length limit · 6c50875a
      Monty authored
      Limit increased from 1000 to 2000.
      
      Avoiding stack overflow by only storing keys and pages on the stack in
      recursive functions if there is plenty of space on it.
      
      Other things:
      - Use less stack space for b-tree operations as we now only allocate as
        much space as needed instead of always allocating HA_MAX_KEY_LENGTH.
      - Replaced most usage of my_safe_alloca() in Aria with the stack_alloc
        interface.
      - Moved my_setstacksize() to mysys/my_pthread.c
      6c50875a
  5. 22 Aug, 2019 3 commits
  6. 19 Aug, 2019 1 commit
  7. 17 Aug, 2019 1 commit
    • Monty's avatar
      Updated spider result file · da53fb6d
      Monty authored
      Kentoku told me that this is ok and that he just had forgot
      to do that as part of an earlier bug fix
      da53fb6d
  8. 16 Aug, 2019 9 commits
    • Alexander Barkov's avatar
      MDEV-20363 Assertion `is_unsigned() == attr.unsigned_flag' failed in... · cb4dcf39
      Alexander Barkov authored
      MDEV-20363 Assertion `is_unsigned() == attr.unsigned_flag' failed in Type_handler_longlong::make_table_field
      cb4dcf39
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 67ddb650
      Marko Mäkelä authored
      67ddb650
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · c221bcdc
      Marko Mäkelä authored
      c221bcdc
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 395e1dcd
      Marko Mäkelä authored
      395e1dcd
    • Marko Mäkelä's avatar
      MDEV-19200: shutdown timeout on innodb.undo_truncate_recover · fe6eac0c
      Marko Mäkelä authored
      Optimize the test by dropping the table early and by using only
      one undo log thread, so that purge will be doing more useful work
      and less busy work of suspending and resuming the worker threads.
      
      The test used to cause shutdown timeout on 10.4 on buildbot, and
      for me locally when using --mysqld=--innodb-sync-debug.
      With these tweaks, it passes for me with --mysqld=--innodb-sync-debug.
      fe6eac0c
    • Marko Mäkelä's avatar
      MDEV-8588/MDEV-19740: Restore a condition · 555af003
      Marko Mäkelä authored
      It looks like the merge of MySQL 5.7.9 to MariaDB 10.2.2 conflicted with
      earlier changes that were made in MDEV-8588.
      
      row_search_mvcc(): If the page is corrupted, avoid invoking
      btr_cur_store_position(). The caller should not try to fetch
      the next record after a hard error.
      555af003
    • Jan Lindström's avatar
      Remove file accidentally pushed. · 3bbf0080
      Jan Lindström authored
      3bbf0080
    • Marko Mäkelä's avatar
      Silence GCC 9.2.1 -Warray-bounds · 130d9490
      Marko Mäkelä authored
      No memory access violated the bounds of fake_extra_buf[],
      but GCC does not like the fact that the pointer fake_extra
      ends up pointing before the array.
      Allocate a dummy element at the start of fake_extra_buf[]
      in order to silence the warning.
      130d9490
    • Jan Lindström's avatar
      MDEV-18778: mysql_tzinfo_to_sql does not work correctly in MariaDB Galera · e6b505fd
      Jan Lindström authored
      There were two problems:
      
      (1) If user wanted same time zone information on all nodes in the Galera
      cluster all updates were not replicated as time zone information was
      stored on MyISAM tables. This is fixed on Galera by altering time zone
      tables to InnoDB while they are modified.
      
      (2) If user wanted different time zone information to nodes in the Galera
      cluster TRUNCATE TABLE for time zone tables was replicated by Galera
      destroying time zone information from other nodes. This is fixed
      on Galera by introducing new option for mysql_tzinfo_to_sql_symlink
      tool --skip-write-binlog to disable Galera replication while
      time zone tables are modified.
      
      Changes to be committed:
              modified:   mysql-test/r/mysql_tzinfo_to_sql_symlink.result
              modified:   mysql-test/suite/wsrep/r/mysql_tzinfo_to_sql_symlink.result
              new file:   mysql-test/suite/wsrep/r/mysql_tzinfo_to_sql_symlink_skip.result
              new file:   mysql-test/suite/wsrep/t/mysql_tzinfo_to_sql_symlink_skip.test
              modified:   sql/tztime.cc
      
      This is 10.4 version of commit fa740888
      e6b505fd
  9. 15 Aug, 2019 6 commits