1. 01 Mar, 2005 6 commits
    • unknown's avatar
      Merge · 42557374
      unknown authored
      
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/select_found.result:
        Auto merged
      mysql-test/r/show_check.result:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      mysql-test/t/show_check.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      strings/ctype-bin.c:
        Auto merged
      sql/sql_select.cc:
        SCCS merged
      42557374
    • unknown's avatar
    • unknown's avatar
      Fix for Bug#8801: the bug was in co-operation of Item_ref · 679088a2
      unknown authored
      with view-merge algorithm and prepared statements: in case when some
      Item_ref pointing to a view column was substituted with a reference 
      pointing to the view expression for that column
      Item_ref::ref member of the original Item_ref was left pointing to 
      not_found_item (0x1).
      As we currently perform expression substition part of the view-merge 
      algorithm per each execution of a prepared statement or stored procedure, 
      we need to preserve original Item_ref objects usable.
      
      
      sql/item.cc:
        Set member Item_ref::ref to null whenever the item itself is substituted 
        with another item.
        This is necessary if we want to re-execute a prepared statement next time.
        
        Additionally Item_ref::fix_fields() implementation was cleaned up
        (by Monty and myself) to reduce the number of if branches. This
        doesn't change the logic of this function.
      679088a2
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 59158b85
      unknown authored
      into mysql.com:/usr/home/ram/work/4.1.b6089
      
      
      sql/sql_select.cc:
        Auto merged
      59158b85
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 4dc33bc8
      unknown authored
      into mysql.com:/usr/home/ram/work/4.1.b6089
      
      
      sql/sql_select.cc:
        Auto merged
      4dc33bc8
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 81dea6cd
      unknown authored
      into mysql.com:/usr/home/ram/work/4.1.b5615
      
      
      mysql-test/r/show_check.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      81dea6cd
  2. 28 Feb, 2005 21 commits
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · ad1c1e07
      unknown authored
      into mysql.com:/home/cps/mysql/devel/im-fix-review
      
      
      mysys/default.c:
        Auto merged
      ad1c1e07
    • unknown's avatar
      fix compilation failure on sunfire280 · e99c035f
      unknown authored
      e99c035f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · ef7570c7
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/sql_repl.cc:
        Auto merged
      ef7570c7
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 8400a5a4
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      8400a5a4
    • unknown's avatar
      Fix for BUG#8726: In JOIN::optimize on ER_TOO_BIG_SELECT error set JOIN::error to -1 to cause · d2ead18b
      unknown authored
      the error to be sent to the client.
      
      
      mysql-test/r/select_safe.result:
        Testcase for BUG#8726
      mysql-test/t/select_safe.test:
        Testcase for BUG#8726
      sql/sql_select.cc:
        Fix for BUG#8726: On ER_TOO_BIG_SELECT set JOIN::error to -1 to cause the error to be sent to the client.
      d2ead18b
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · ed3b4499
      unknown authored
      into mysql.com:/home/timka/mysql/src/5.0-bug-8532
      
      
      ed3b4499
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · cef636d9
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      cef636d9
    • unknown's avatar
      Fixed BUG#8760: Stored Procedures: Invalid SQLSTATE is allowed in · 110f6abd
      unknown authored
                      a DECLARE ? HANDLER FOR stmt.
      
      
      mysql-test/r/sp-error.result:
        New test case for BUG#8776 (check format of sqlstates in handler declarations).
      mysql-test/t/sp-error.test:
        New test case for BUG#8776 (check format of sqlstates in handler declarations).
      sql/share/errmsg.txt:
        New error message for malformed SQLSTATEs.
      sql/sp_pcontext.cc:
        Added function for checking SQLSTATE format.
      sql/sp_pcontext.h:
        Added function for checking SQLSTATE format.
      sql/sql_yacc.yy:
        Check format of SQLSTATE in handler declaration.
      110f6abd
    • unknown's avatar
      merging · f9dd79c7
      unknown authored
      
      mysql-test/r/ps.result:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      f9dd79c7
    • unknown's avatar
    • unknown's avatar
      Fixed BUG#7646: Stored procedure hang if show binlog events · cfff7e6e
      unknown authored
        Return false from show_binlog_events() if successful, otherwise stored
        procedures will think it failed.
      
      
      sql/sql_repl.cc:
        Return false from show_binlog_events() if successful, otherwise stored
        procedures will think it failed.
      cfff7e6e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 1b002905
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      include/mysql_com.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      1b002905
    • unknown's avatar
      Fix for BUG#8532. · 7a703d6a
      unknown authored
      The problem was in that the code that analyses the applicability of the
      QUICK_GROUP_MIN_MAX access method for DISTINC queries assumed that there
      are no duplicate column references in the DISTINCT clause, and it added
      non-exiting key parts for the duplicate column references. 
      
      The solution adds a test to check whether the select list already contained
      a field with the same name. If such field was already present, then it was
      already decided to use its key part for index access. In this such case we
      must skip the duplicate field instead of counting it as a new field.
      
      
      mysql-test/r/group_min_max.result:
        Added test results for BUG#8532.
      mysql-test/t/group_min_max.test:
        Added tests for BUG#8532.
      sql/opt_range.cc:
        The problem was in that the code that analyses the applicability of the
        QUICK_GROUP_MIN_MAX access method for DISTINC queries assumed that there
        are no duplicate column references in the DISTINCT clause, and it added
        non-exiting key parts for the duplicate column references. 
        
        The solution adds a test to check whether the select list already contained
        a field with the same name. If such field was already present, then it was
        already decided to use its key part for index access. In this such case we
        must skip the duplicate field instead of counting it as a new field.
      7a703d6a
    • unknown's avatar
      merging · 7865746c
      unknown authored
      
      mysql-test/r/show_check.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7865746c
    • unknown's avatar
      portability fix · d4c2c747
      unknown authored
      d4c2c747
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.0 · ebdbe9e5
      unknown authored
      into mysql.com:/home/psergey/mysql-4.0-look
      
      
      ebdbe9e5
    • unknown's avatar
      Merge · c8b3d65c
      unknown authored
      c8b3d65c
    • unknown's avatar
      merge with 4.1 · 45a26d44
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      innobase/dict/dict0dict.c:
        Auto merged
      innobase/fil/fil0fil.c:
        Auto merged
      innobase/row/row0sel.c:
        Auto merged
      mysql-test/r/select_found.result:
        Auto merged
      mysql-test/r/type_set.result:
        Auto merged
      mysys/default.c:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      include/mysql_com.h:
        Merge
      sql/filesort.cc:
        merge
      45a26d44
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 8e3addf9
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      BitKeeper/etc/ignore:
        added support-files/ndb-config-2-node.ini
      8e3addf9
    • unknown's avatar
      Fixed wrong memory references found by purify · 8b8c9452
      unknown authored
      (No really critical errors found, but a few possible wrong results)
      
      
      innobase/dict/dict0dict.c:
        Replace memcmp with comparison of characters to avoid warnings from purify when 'sptr' points to a very short string
      mysql-test/r/select_found.result:
        Add missing drop table
      mysql-test/r/type_set.result:
        More tests
      mysql-test/t/select_found.test:
        Add missing drop table
      mysql-test/t/type_set.test:
        More tests
      mysys/my_init.c:
        Avoid warning from purify (purify doesn't handle getrusage() properly)
      sql/field.h:
        enum & set are sorted as numbers. This fixes an access to uninitialized memory when enum/set are multi-byte characters
      sql/filesort.cc:
        enum & set are sorted as numbers. This fixes an access to uninitialized memory when enum/set are multi-byte characters
      sql/item_cmpfunc.cc:
        Fixed warning from purify. (Not critical as the arguments are passed to a function but not used)
        Allocate Arg_comparator() with 'new' instead of sql_alloc() to ensure proper initialization
      sql/mysqld.cc:
        Wait for signal handler to stop when running --bootstrap
        (Fixes warning from purify)
      sql/sql_insert.cc:
        Initialize slot used by innodb.cc (not critical)
      sql/sql_lex.h:
        Better comments
      sql/sql_repl.cc:
        memcmp -> bcmp() to avoid warning from purify
      sql/sql_select.cc:
        Fix for out-of-bound memory reference when doing DISTINCT on const expressions
      strings/ctype-simple.c:
        Fixes to not access uninitialized memory
        (Not critical)
      8b8c9452
    • unknown's avatar
      Fixed small error in comment · 03a5cacc
      unknown authored
      03a5cacc
  3. 27 Feb, 2005 5 commits
    • unknown's avatar
      Merge mysql.com:/space/pekka/ndb/version/my50 · 4ef7991d
      unknown authored
      into mysql.com:/space/pekka/ndb/version/my50-ndb
      
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      4ef7991d
    • unknown's avatar
      ndb - bugfix to ordered index create, could show up as charset error · 108702a3
      unknown authored
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        bugfix: bad signal to ACC for ordered index
      108702a3
    • unknown's avatar
      Merge mysql.com:/home/cps/mysql/trees/mysql-5.0 · b3028227
      unknown authored
      into mysql.com:/home/cps/mysql/devel/im-fix-review
      
      
      include/my_sys.h:
        Auto merged
      b3028227
    • unknown's avatar
      post-review fixes + cleanup + some minor fixes · dc9059e0
      unknown authored
      
      server-tools/instance-manager/buffer.cc:
        coding style fixes
      server-tools/instance-manager/buffer.h:
        wrong constructor initialisation fixed
      server-tools/instance-manager/commands.cc:
        cleanup
      server-tools/instance-manager/guardian.cc:
        cleanup + added lock/unlock routines
      server-tools/instance-manager/guardian.h:
        GUARD_NODE moved to the header
      server-tools/instance-manager/instance.cc:
        Fix for the linuxthreads/POSIX signal handling problem (see comments in the code)
      server-tools/instance-manager/instance.h:
        condition variable renamed and commented
      server-tools/instance-manager/instance_map.cc:
        We need to refresh guardian during flush_instances
      server-tools/instance-manager/instance_map.h:
        removed obsolete function declaration
      server-tools/instance-manager/instance_options.cc:
        added caching of computed values
      server-tools/instance-manager/instance_options.h:
        added vars to cache some option values
      server-tools/instance-manager/listener.cc:
        check whether we are running on the linux threads
      server-tools/instance-manager/manager.cc:
        lock guardian before init()
      server-tools/instance-manager/parse_output.cc:
        cleanup
      server-tools/instance-manager/priv.cc:
        added global variables to detect whether we are running on the LinuxThreads
      server-tools/instance-manager/priv.h:
        added global variables to detect whether we are running on the LinuxThreads
      dc9059e0
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · 87a48cdf
      unknown authored
      into mysql.com:/home/svoj/devel/mysql/stddev-mysql-5.0
      
      
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      87a48cdf
  4. 26 Feb, 2005 7 commits
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 85b82a8a
      unknown authored
      into mysql.com:/space/pekka/ndb/version/my50-ndb
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      85b82a8a
    • unknown's avatar
      NdbDictionaryImpl.cpp: · 1f9a2667
      unknown authored
        fix error code
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        fix error code
      1f9a2667
    • unknown's avatar
      ndb - wl-1203 alignment fix · 477205f7
      unknown authored
      
      ndb/include/ndb_constants.h:
        consistent names
      ndb/include/ndbapi/NdbDictionary.hpp:
        consistent names
      ndb/include/util/NdbSqlUtil.hpp:
        consistent names
      ndb/src/common/util/NdbSqlUtil.cpp:
        minor completion
      ndb/src/ndbapi/NdbOperationInt.cpp:
        alignment fix
      477205f7
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7cc7a628
      unknown authored
      into mysql.com:/usr/local/home/marty/MySQL/test/mysql-5.0-ndb
      
      
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7cc7a628
    • unknown's avatar
      Fix for BUG#8560: Set max_sort_char for any 8-bit charset with binary... · 1a72e219
      unknown authored
      Fix for BUG#8560: Set max_sort_char for any 8-bit charset with binary collation. max_sort_char is needed by
      my_like_range_simple to produce upper bound constants for LIKE "str_%" and similar expressions.
      
      
      mysql-test/r/ctype_cp1251.result:
        Test for BUG#8560
      mysql-test/t/ctype_cp1251.test:
        Test for BUG#8560
      1a72e219
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 8167f5e5
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      8167f5e5
    • unknown's avatar
      Fixes while during review of last pull · 25e03cdf
      unknown authored
      Temporary patch to remove some warnings
      
      
      sql/item.cc:
        Trivial optimization
      sql/protocol.cc:
        Fixed spelling error
      sql/sql_parse.cc:
        Fix to not get warnings during inital temp open (should be deleted after Dimitri's next push)
        Style fixes
      sql/table.cc:
        Ensure that cleanup is done, even if we get an error
      25e03cdf
  5. 25 Feb, 2005 1 commit
    • unknown's avatar
      trx0trx.c, trx0trx.h: · 2ab324db
      unknown authored
        Fix wrong spelling
      
      
      innobase/include/trx0trx.h:
        Fix wrong spelling
      innobase/trx/trx0trx.c:
        Fix wrong spelling
      2ab324db