1. 20 Mar, 2018 2 commits
  2. 17 Mar, 2018 1 commit
  3. 16 Mar, 2018 1 commit
  4. 15 Mar, 2018 5 commits
  5. 14 Mar, 2018 1 commit
    • Daniel Black's avatar
      MDEV-8743: where O_CLOEXEC is available, use for innodb buf_dump · fafec1a9
      Daniel Black authored
      As this is the only moderately critical fopened for writing file,
      create an alternate path to use open and fdopen for non-glibc platforms
      that support O_CLOEXEC (BSDs).
      
      Tested on Linux (by modifing the GLIBC defination) to take this
      alternate path:
      
      $ cd /proc/23874
      $ more fdinfo/71
      pos:    0
      flags:  02100001
      mnt_id: 24
      $ ls -la fd/71
      l-wx------. 1 dan dan 64 Mar 14 13:30 fd/71 -> /dev/shm/var_auto_i7rl/mysqld.1/data/ib_buffer_pool.incomplete
      fafec1a9
  6. 13 Mar, 2018 4 commits
  7. 12 Mar, 2018 10 commits
  8. 11 Mar, 2018 1 commit
  9. 10 Mar, 2018 4 commits
    • Marko Mäkelä's avatar
      MDEV-15529 IMPORT TABLESPACE unnecessarily uses the doublewrite buffer · 112df069
      Marko Mäkelä authored
      fil_space_t::atomic_write_supported: Always set this flag for
      TEMPORARY TABLESPACE and during IMPORT TABLESPACE. The page
      writes during these operations are by definition not crash-safe
      because they are not written to the redo log.
      
      fil_space_t::use_doublewrite(): Determine if doublewrite should
      be used.
      
      buf_dblwr_update(): Add assertions, and let the caller check whether
      doublewrite buffering is desired.
      
      buf_flush_write_block_low(): Disable the doublewrite buffer for
      the temporary tablespace and for IMPORT TABLESPACE.
      
      fil_space_set_imported(), fil_node_open_file(), fil_space_create():
      Initialize or revise the space->atomic_write_supported flag.
      
      buf_page_io_complete(), buf_flush_write_complete(): Add the parameter
      dblwr, to indicate whether doublewrite was used for writes.
      
      buf_dblwr_sync_datafiles(): Remove an unnecessary flush of
      persistent tablespaces when flushing temporary tablespaces.
      (Move the call to buf_dblwr_flush_buffered_writes().)
      112df069
    • Marko Mäkelä's avatar
      MDEV-15524 Do not disable page checksums for temporary tables · 54765aaa
      Marko Mäkelä authored
      buf_flush_init_for_writing(): Remove the parameter skip_checksum.
      54765aaa
    • Marko Mäkelä's avatar
      MDEV-15524 Do not write garbage for temporary tables · 4fa18d52
      Marko Mäkelä authored
      fsp_init_file_page_low(): Always initialize the page.
      4fa18d52
    • Marko Mäkelä's avatar
      1e4cb840
  10. 09 Mar, 2018 3 commits
  11. 08 Mar, 2018 2 commits
  12. 07 Mar, 2018 5 commits
    • Alexander Barkov's avatar
      MDEV-15497 Wrong empty value in a GEOMETRY column on LOAD DATA · 6ec3de5d
      Alexander Barkov authored
      - Adding a new virtual method Field::load_data_set_no_data().
      - Overriding Field_timestamp::load_data_set_no_data() and moving
        the TIMESTAMP specific code there.
      - Overriding Field_geom::load_data_set_no_data() and implementing
        GEOMETRY specific behavior, to prevent writing empty strings
        when the loaded file ends unexpectedly. This fixes the bug.
      - Adding a new test gis-loaddaata.test.
      - The test in loaddata.test for CHAR was added simply to record behavior.
        The CHAR data type did not change its behaviour (only GEOMRYRY did).
      - Additionally, moving duplicate code into a new method
        Field::load_data_set_value() and reusing it in three places.
      6ec3de5d
    • Marko Mäkelä's avatar
      MDEV-14904 Backport innodb_default_row_format · 8ef727b3
      Marko Mäkelä authored
      InnoDB in Debian uses utf8mb4 as default character set since
      version 10.0.20-2. This leads to major pain due to keys longer
      than 767 bytes.
      
      MariaDB 10.2 (and MySQL 5.7) introduced the setting
      innodb_default_row_format that is DYNAMIC by default. These
      versions also changed the default values of the parameters
      innodb_large_prefix=ON and innodb_file_format=Barracuda.
      This would allow longer column index prefixes to be created.
      The original purpose of these parameters was to allow InnoDB
      to be downgraded to MySQL 5.1, which is long out of support.
      
      Every InnoDB version since MySQL 5.5 does support operation
      with the relaxed limits.
      
      We backport the parameter innodb_default_row_format to
      MariaDB 10.1, but we will keep its default value at COMPACT.
      This allows MariaDB 10.1 to be configured so that CREATE TABLE
      is less likely to encounter a problem with the limitation:
      
      	loose_innodb_large_prefix=ON
      	loose_innodb_default_row_format=DYNAMIC
      
      (Note that the setting innodb_large_prefix was deprecated in
      MariaDB 10.2 and removed in MariaDB 10.3.)
      
      The only observable difference in the behaviour with the default
      settings should be that ROW_FORMAT=DYNAMIC tables can be created
      both in the system tablespace and in .ibd files, no matter what
      innodb_file_format has been assigned to. Unlike MariaDB 10.2,
      we are not changing the default value of innodb_file_format,
      so ROW_FORMAT=COMPRESSED tables cannot be created without
      changing the parameter.
      8ef727b3
    • Daniel Black's avatar
      my_fdopen: list all args in comment · 2ef2863c
      Daniel Black authored
      2ef2863c
    • Ian Gilfillan's avatar
      08fa3218
    • Ian Gilfillan's avatar
      a0501897
  13. 06 Mar, 2018 1 commit