1. 29 Nov, 2018 2 commits
    • Marko Mäkelä's avatar
      Remove some unnecessary InnoDB #include · 447e4931
      Marko Mäkelä authored
      447e4931
    • Marko Mäkelä's avatar
      MDEV-17859: Clean up the FOREIGN KEY handling · be998bfd
      Marko Mäkelä authored
      dict_create_add_foreigns_to_dictionary(): Do not commit the transaction.
      The operation can still fail in dict_load_foreigns(), and we want
      to be able to roll back the transaction.
      
      create_table_info_t::create_table(): Never reset m_drop_before_rollback,
      and never commit the transaction. We use a single point of rollback
      in ha_innobase::create(). Merge the logic from
      row_table_add_foreign_constraints().
      be998bfd
  2. 28 Nov, 2018 2 commits
    • Marko Mäkelä's avatar
      MDEV-17859 Operating system errors in file operations after failed CREATE · b26e603a
      Marko Mäkelä authored
      This is a regression due to MDEV-17816.
      
      When creating a table fails, we must roll back the dictionary
      transaction. Because the rollback may rename tables, and because
      InnoDB lacks proper undo logging for CREATE operations, we must
      drop the incompletely created table before rolling back the
      transaction, which could include a RENAME operation.
      But, we must not blindly drop the table by name; after all,
      the operation could have failed because another table by the
      same name already existed.
      
      create_table_info_t::m_drop_before_rollback: A flag that is set
      if the table needs to be dropped before transaction rollback.
      
      create_table_info_t::create_table(): Remove some duplicated
      error handling.
      
      ha_innobase::create(): On error, only drop the table if it was
      actually created.
      b26e603a
    • Sergei Petrunia's avatar
      MDEV-13155: XA recovery not supported for RocksDB · 0485e519
      Sergei Petrunia authored
      Added a testcase
      0485e519
  3. 27 Nov, 2018 4 commits
  4. 26 Nov, 2018 5 commits
    • Marko Mäkelä's avatar
      MDEV-17816: Follow-up fix · 861038f2
      Marko Mäkelä authored
      When dropping a partially created table due to failure,
      use SQLCOM_TRUNCATE instead of SQLCOM_DROP_DB, so that
      no foreign key constraints will be touched. If any
      constraints were added as part of the creation, they would
      be reverted as part of the transaction rollback.
      
      We need an explicit call to row_drop_table_for_mysql(),
      because InnoDB does not do proper undo logging for CREATE TABLE,
      but would only drop the table at the end of the rollback.
      This would not work if the transaction combines both
      RENAME and CREATE, like TRUNCATE now does.
      861038f2
    • Marko Mäkelä's avatar
      MDEV-17831 TRUNCATE TABLE removes ROW_FORMAT=COMPRESSED · 971e1d86
      Marko Mäkelä authored
      If a table had a KEY_BLOCK_SIZE attribute, but no ROW_FORMAT,
      it would be created as ROW_FORMAT=COMPRESSED in InnoDB.
      However, TRUNCATE TABLE would lose the KEY_BLOCK_SIZE attribute
      and create the table with the innodb_default_row_format (DYNAMIC).
      
      This is a regression that was introduced by MDEV-13564.
      
      update_create_info_from_table(): Copy also KEY_BLOCK_SIZE.
      971e1d86
    • Jan Lindström's avatar
      9669536c
    • Marko Mäkelä's avatar
      MDEV-17816 Crash in TRUNCATE TABLE when table creation fails · 2a31b828
      Marko Mäkelä authored
      The error handling in the MDEV-13564 TRUNCATE TABLE was broken
      when an error occurred during table creation.
      
      row_create_index_for_mysql(): Do not drop the table on error.
      
      fts_create_one_common_table(), fts_create_one_index_table():
      Do drop the table on error.
      
      create_index(), create_table_info_t::create_table():
      Let the caller handle the index creation errors.
      
      ha_innobase::create(): If create_table_info_t::create_table()
      fails, drop the incomplete table, roll back the transaction,
      and finally return an error to the caller.
      2a31b828
    • Marko Mäkelä's avatar
      MDEV-14409 Assertion `page_rec_is_leaf(rec)' failed in lock_rec_validate_page · a81fceaf
      Marko Mäkelä authored
      lock_rec_queue_validate(): Assert page_rec_is_leaf(rec), except when
      the record is a page infimum or supremum.
      
      lock_rec_validate_page(): Relax the assertion that failed.
      The assertion was reachable when the record lock bitmap was empty.
      
      lock_rec_insert_check_and_lock(): Assert page_is_leaf().
      a81fceaf
  5. 22 Nov, 2018 5 commits
  6. 21 Nov, 2018 2 commits
  7. 20 Nov, 2018 2 commits
  8. 19 Nov, 2018 14 commits
  9. 17 Nov, 2018 1 commit
  10. 16 Nov, 2018 3 commits