1. 10 Jan, 2017 5 commits
    • Vicențiu Ciorbaru's avatar
      Fix unit test after merge from mysql 5.5.35 perfschema · 4799af09
      Vicențiu Ciorbaru authored
      The problem in MariaDB is introduced by this merge commit:
      c33db2cd
      
      The merge comes from mysql and the original author comes from this
      commit from MySQL:
      ------------------------------------------------
          commit 160b823d146288d66638e4a740d6d2da72f9a689
          Author: Marc Alff <marc.alff@oracle.com>
          Date:   Tue Aug 30 12:14:07 2016 +0200
      
          Bug#22551677 SIGNAL 11 IN LF_PINBOX_PUT_PINS
      
          Backport to 5.6
      ------------------------------------------------
      
      The breaking change is in start_socket_wait_v1 where instead of using
      m_thread_owner, we make use of my_pthread_getspecific_ptr to fetch a
      thread local storage value. Unfortunately this invalidates the
      "m_thread_owner" member when a socket is created. The internals of the
      socket structure have m_thread_owner set to NULL, but when checking for
      ownership we actually look at the current thread's key store.
      
      This seems incorrect however it is not immediately apparent why.
      
      To not diverge from MySQL's reasoning as it is not described what the
      actual problem was that this commit is trying to fix, I have adjusted the
      unittest to account for this new behaviour. We destroy the current
      thread in the unit test, such that the newly created socket actually has
      no thread owner. The m_thread_owner is untouched in all this.
      4799af09
    • Vicențiu Ciorbaru's avatar
      d00d46f4
    • Vicențiu Ciorbaru's avatar
      Fix problems from 5.5 merge · ecdb39a9
      Vicențiu Ciorbaru authored
      * Update mysqld_safe script to remove duplicated parameter --crash-script
      * Make --core-file-size accept underscores as well as dashes correctly.
      * Add mysqld_safe_helper to Debian and Ubuntu files.
      * Update innodb minor version to 35
      ecdb39a9
    • Vicențiu Ciorbaru's avatar
    • vicentiu's avatar
  2. 09 Jan, 2017 1 commit
  3. 07 Jan, 2017 2 commits
  4. 06 Jan, 2017 4 commits
    • vicentiu's avatar
    • vicentiu's avatar
      e9aed131
    • Dmitry Lenev's avatar
      MDEV-9084 Calling a stored function from a nested select from temporary table... · e4978d26
      Dmitry Lenev authored
      MDEV-9084 Calling a stored function from a nested select from temporary table causes unpredictable behavior
      
      Cherry-pick: f4a0af070ce49abae60040f6f32e1074309c27fb
      Author: Dmitry Lenev <dmitry.lenev@oracle.com>
      Date:   Mon Jul 25 16:06:52 2016 +0300
      
        Fix for bug #16672723 "CAN'T FIND TEMPORARY TABLE".
      
        Attempt to execute prepared CREATE TABLE SELECT statement which used
        temporary table in the subquery in FROM clause and stored function
        failed with unwarranted ER_NO_SUCH_TABLE error. The same happened
        when such statement was used in stored procedure and this procedure
        was re-executed.
      
        The problem occurred because execution of such prepared statement/its
        re-execution as part of stored procedure incorrectly set
        Query_table_list::query_tables_own_last marker, indicating the last
        table which is directly used by statement. As result temporary table
        used in the subquery was treated as indirectly used/belonging to
        prelocking list and was not pre-opened by open_temporary_tables()
        call before statement execution. Thus causing ER_NO_SUCH_TABLE errors
        since our code assumes that temporary tables need to be correctly
        pre-opened before statement execution.
      
        This problem became visible only in version 5.6 after patches related to
        bug 11746602/27480 "EXTEND CREATE TEMPORARY TABLES PRIVILEGE TO ALLOW
        TEMP TABLE OPERATIONS" since they have introduced pre-opening of temporary
        tables for statements.
      
        Incorrect setting of Query_table_list::query_tables_own_last happened
        in LEX::first_lists_tables_same() method which is called by CREATE TABLE
        SELECT implementation as part of LEX::unlink_first_table(), which temporary
        excludes table list element for table being created from the query table
        list before handling SELECT part.
      
        LEX::first_lists_tables_same() tries to ensure that global table list of
        the statement starts with the first table list element from the first
        statement select. To do this it moves such table list element to the head
        of the global table list. If this table happens to be last directly-used
        table for the statement, query_tables_own_last marker is pointing to it.
        Since this marker was not updated when table list element was moved we
        ended up with all tables except the first table separated by it as if
        they were not directly used by statement (i.e. belonged to prelocked
        tables list).
      
        This fix changes code of LEX::first_lists_tables_same() to update
        query_tables_own_last marker in cases when it points to the table
        being moved. It is set to the table which precedes table being moved
        in this case.
      e4978d26
    • Kristian Nielsen's avatar
      MDEV-10271: Stopped SQL slave thread doesn't print a message to error log like IO thread does · 43378f36
      Kristian Nielsen authored
      Make the slave SQL thread always output to the error log the message "Slave
      SQL thread exiting, replication stopped in ..." whenever it previously
      outputted "Slave SQL thread initialized, starting replication ...".
      
      Before this patch, it was somewhat inconsistent in which cases the message
      would be output and in which not, depending on the exact time and cause of
      the condition that caused the SQL thread to stop.
      43378f36
  5. 05 Jan, 2017 7 commits
    • Elena Stepanova's avatar
      Replication tests fail on valgrind due to waiting-related timeouts · 670b8580
      Elena Stepanova authored
      MTR raises default wait_for_pos_timeout from 300 to 1500 when tests
      are run with valgrind. The same needs to be done for other
      replication-related waits.
      
      The change should fix one of failures mentioned in MDEV-10653
      (rpl.rpl_parallel fails in buildbot with timeout), the one
      on the valgrind builder; but not all of them
      670b8580
    • Elena Stepanova's avatar
      MDEV-10988 Sphinx test suite refuses to run silently · b2b6cf49
      Elena Stepanova authored
      Add diagnostics output if any Sphinx components aren't found
      b2b6cf49
    • Igor Babaev's avatar
      Fixed bug mdev-10705. · ae1b3d19
      Igor Babaev authored
      The fix for bug mdev-5104 did not take into account that
      for any call of setup_order the size of ref_array must
      be big enough. This patch fixes this problem.
      ae1b3d19
    • Marko Mäkelä's avatar
      MDEV-11730 Memory leak in innodb.innodb_corrupt_bit · f0c19b6a
      Marko Mäkelä authored
      Memory was leaked when ALTER TABLE is attempted on a table
      that contains corrupted indexes.
      The memory leak was reported by AddressSanitizer for the test
      innodb.innodb_corrupt_bit. The leak was introduced into
      MariaDB Server 10.0.26, 10.1.15, 10.2.1 by the following:
      
      commit c081c978
      Merge: 1d21b221 a482e76e
      Author: Sergei Golubchik <serg@mariadb.org>
      Date:   Tue Jun 21 14:11:02 2016 +0200
      
         Merge branch '5.5' into bb-10.0
      f0c19b6a
    • Elena Stepanova's avatar
      MDEV-11727 Sequences of tests fail with valgrind warnings in buildbot · 9e528d4f
      Elena Stepanova authored
      The warning is "blocks are still reachable in loss record",
      happens in malloc / _dl_close_worker. Suppression added
      9e528d4f
    • Elena Stepanova's avatar
      MDEV-11700 funcs_2.innodb_charset fails in buldbot on valgrind builder with timeout · 5302ef2c
      Elena Stepanova authored
      When the test is run as a part of the suite with valgrind,
      only allow it to be executed if --big-test is set.
      If the test is run by specifying its name explicitly, it
      will still be executed, even with valgrind without big-test,
      MTR has special logic for that
      5302ef2c
    • Elena Stepanova's avatar
      MDEV-11722 main.join_cache fails in buildbot on very slow builders · f1ee011a
      Elena Stepanova authored
      The guilty part of the test checks for performance degradation on
      a query with numerous joins on an empty table. The test expects
      the query to take less than 1 second, and fails if it is not so
      (which can happen on very slow builders).
      
      The solution is to add more JOINs to the query. On a fixed server,
      it should not have any noticeable impact on the query execution,
      while on the unfixed version the query would take several times
      longer (e.g. 6.5 sec vs 1.5 sec). Thus, we can increase the margin
      for the error, and make the test fail when the query takes longer
      than 5 seconds.
      f1ee011a
  6. 04 Jan, 2017 5 commits
    • Elena Stepanova's avatar
      MDEV-8518 rpl.sec_behind_master-5114 fails sporadically in buildbot · 9bf92706
      Elena Stepanova authored
      - fix the test to avoid false-negatives before MDEV-5114 patch;
      - fix the race condition which made the test fail on slow builders
      9bf92706
    • Sergei Golubchik's avatar
      MDEV-11676 Starting service with mysqld_safe_helper fails in SELINUX "enforcing" mode · f4d12c1d
      Sergei Golubchik authored
      correct the error message in case of setuid/setgid failures
      f4d12c1d
    • Oleksandr Byelkin's avatar
      MDEV-10035: DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE · bc4cac35
      Oleksandr Byelkin authored
      Ability to print lock type added.
      Restoring correct lock type for CREATE VIEW added.
      bc4cac35
    • Elena Stepanova's avatar
      MDEV-10100 main.pool_of_threads fails sporadically in buildbot · e5d7fc96
      Elena Stepanova authored
      Backport the fix to 5.5, because it fails there too
      
      The patch fixes two test failures:
      - on slow builders, sometimes a connection attempt which should
        fail due to the exceeded number of thread_pool_max_threads
        actually succeeds;
      - on even slow builders, MTR sometimes cannot establish the
        initial connection, and check-testcase fails prior to the
        test start
      
      The problem with check-testcase was caused by connect-timeout=2
      which was set for all clients in the test config file. On slow
      builders it might be not enough.
      There is no way to override it for the pre-test check, so it needed
      to be substantially increased or removed.
      
      The other problem was caused by a race condition between sleeps
      that the test performs in existing connections and the connect
      timeout for the connection attempt which was expected to fail.
      If sleeps finished before the connect-timeout was exceeded, it
      would allow the connection to succeed.
      
      To solve each problem without making the other one worse,
      connect-timeout should be configured dynamically during the test.
      Due to the nature of the test (all connections must be busy
      at the moment when we need to change the timeout, and cannot execute
      SET GLOBAL ...), it needs to be done independently from the server.
      
      The solution:
      - recognize 'connect_timeout' as a connection option in mysqltest's
        "connect" command;
      - remove connect-timeout from the test configuration file;
      - use the new connect_timeout option for those connections which
        are expected to fail;
      - re-arrange the test flow to allow running a huge SLEEP
        without affecting the test execution time (because it would be
        interrupted after the main test flow is finished).
      
      The test is still subject to false negatives, e.g. if the connection
      fails due to timeout rather than due to the exceeded number of
      allowed threads, or if the connection on extra port succeeds due
      to a race condition and not because the special logic for the extra
      port. But those false negatives have always been possible there
      on slow builders, they should not be critical because faster builders
      should catch such failures if they appear.
      
      Conflicts:
      	client/mysqltest.cc
      	mysql-test/r/pool_of_threads.result
      	mysql-test/t/pool_of_threads.test
      e5d7fc96
    • Elena Stepanova's avatar
      MDEV-11719 main.subselect_no_exists_to_in failed in buildbot · 0912fbbc
      Elena Stepanova authored
      main.log_slow might leave mysql.slow_log table non-empty,
      and tests which later use it might fail. Make sure that the table
      is properly truncated
      0912fbbc
  7. 03 Jan, 2017 1 commit
    • Marko Mäkelä's avatar
      MDEV-11694 InnoDB tries to create unused table SYS_ZIP_DICT · 80d5d145
      Marko Mäkelä authored
      MariaDB Server 10.0.28 and 10.1.19 merged code from Percona XtraDB
      that introduced support for compressed columns. Much but not all
      of this code was disabled by placing #ifdef HAVE_PERCONA_COMPRESSED_COLUMNS
      around it.
      
      Among the unused but not disabled code is code to access
      some new system tables related to compressed columns.
      
      The creation of these system tables SYS_ZIP_DICT and SYS_ZIP_DICT_COLS
      would cause a crash in --innodb-read-only mode when upgrading
      from an earlier version to 10.0.28 or 10.1.19.
      
      Let us remove all the dead code related to compressed columns.
      Users who already upgraded to 10.0.28 and 10.1.19 will have the two
      above mentioned empty tables in their InnoDB system tablespace.
      Subsequent versions of MariaDB Server will completely ignore those tables.
      80d5d145
  8. 01 Jan, 2017 2 commits
    • Elena Stepanova's avatar
      MDEV-10100 main.pool_of_threads fails sporadically in buildbot · 3871477c
      Elena Stepanova authored
      The patch fixes two test failures:
      - on slow builders, sometimes a connection attempt which should
        fail due to the exceeded number of thread_pool_max_threads
        actually succeeds;
      - on even slow builders, MTR sometimes cannot establish the
        initial connection, and check-testcase fails prior to the
        test start
      
      The problem with check-testcase was caused by connect-timeout=2
      which was set for all clients in the test config file. On slow
      builders it might be not enough.
      There is no way to override it for the pre-test check, so it needed
      to be substantially increased or removed.
      
      The other problem was caused by a race condition between sleeps
      that the test performs in existing connections and the connect
      timeout for the connection attempt which was expected to fail.
      If sleeps finished before the connect-timeout was exceeded, it
      would allow the connection to succeed.
      
      To solve each problem without making the other one worse,
      connect-timeout should be configured dynamically during the test.
      Due to the nature of the test (all connections must be busy
      at the moment when we need to change the timeout, and cannot execute
      SET GLOBAL ...), it needs to be done independently from the server.
      
      The solution:
      - recognize 'connect_timeout' as a connection option in mysqltest's
        "connect" command;
      - remove connect-timeout from the test configuration file;
      - use the new connect_timeout option for those connections which
        are expected to fail;
      - re-arrange the test flow to allow running a huge SLEEP
        without affecting the test execution time (because it would be
        interrupted after the main test flow is finished).
      
      The test is still subject to false negatives, e.g. if the connection
      fails due to timeout rather than due to the exceeded number of
      allowed threads, or if the connection on extra port succeeds due
      to a race condition and not because the special logic for the extra
      port. But those false negatives have always been possible there
      on slow builders, they should not be critical because faster builders
      should catch such failures if they appear.
      3871477c
    • Sachin Setiya's avatar
      MDEV-11636 Extra persistent columns on slave always gets NULL in RBR · d02a77bc
      Sachin Setiya authored
      Problem:- In replication if slave has extra persistent column then these
      column are not computed while applying write-set from master.
      
      Solution:- While applying row events from server, we will generate values
      for extra persistent columns.
      d02a77bc
  9. 27 Dec, 2016 1 commit
  10. 25 Dec, 2016 1 commit
  11. 24 Dec, 2016 2 commits
  12. 23 Dec, 2016 1 commit
    • Olivier Bertrand's avatar
      Fix some XML table type bugs: · e6b563f8
      Olivier Bertrand authored
      - in DOMNODELIST::DropItem
        if (Listp == NULL || Listp->length <= n)
          return true;
      is wrong, should be:
        if (Listp == NULL || Listp->length < n)
          return true;
      - Crash in discovery with libxml2 in XMLColumns because:
                  if (!tdp->Usedom)    // nl was destroyed
                    vp->nl = vp->pn->GetChildElements(g);
      is executed with vp->pn uninitialized. Fixed by adding:
                vp->pn = node;
      line 264.
      -In discovery with libxml2 some columns are not found.
      Because list was not recovered properly, nodes being modified and not reallocated.
      Fixed lines 214 and 277.
        modified:   storage/connect/domdoc.cpp
        modified:   storage/connect/tabxml.cpp
      
      Add support for zipped table files
        modified:   storage/connect/domdoc.cpp
        modified:   storage/connect/domdoc.h
        modified:   storage/connect/filamap.cpp
        modified:   storage/connect/filamap.h
        modified:   storage/connect/filamzip.cpp
        modified:   storage/connect/filamzip.h
        modified:   storage/connect/ha_connect.cc
        modified:   storage/connect/libdoc.cpp
        modified:   storage/connect/plgdbutl.cpp
        modified:   storage/connect/plgxml.cpp
        modified:   storage/connect/plgxml.h
        modified:   storage/connect/tabdos.cpp
        modified:   storage/connect/tabdos.h
        modified:   storage/connect/tabfmt.cpp
        modified:   storage/connect/tabjson.cpp
        modified:   storage/connect/tabxml.cpp
      e6b563f8
  13. 22 Dec, 2016 7 commits
  14. 21 Dec, 2016 1 commit
    • Alexander Barkov's avatar
      MDEV-10386 Assertion `fixed == 1' failed in virtual String*... · 5e051bfa
      Alexander Barkov authored
      MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*)
      
      The patch b96c196f added a new call for
      safe_charset_converter() without a corresponding fix_fields().
      In case of a sub-query the created Item remained in non-fixed state.
      The problem did not show up with literal derived expressions, only
      subselects were affected. This patch adds a corresponding fix_fields()
      to the previously added safe_charset_converter().
      5e051bfa