- 27 Aug, 2018 2 commits
-
-
Igor Babaev authored
a table value constructor shows wrong number of rows This is another attempt to fix this bug. The previous patch did not take into account that a transformation for ALL/ANY subqueries could be applied to the materialized table that wrapped the table value constructor used as a specification of the subselect used an ALL/ANY subquery. In this case the result of the derived table used a sink of the class select_subselect rather than of the class select_unit. Thus the previous fix could cause memory overwrites when running EXPLAIN for queries with table value constructors in ALL/ANY subselects.
-
Jan Lindström authored
MDEV-17058: Test failure on wsrep.variables MDEV-17060: Test failure on galera.galera_var_slave_threads Fix incorrect calculation of increased applier (slave) threads. Note that increase change takes effect "immediately" but we should use proper wait condition to wait it. Reducing the number of slave threads is not immediate as thread will only exit after a replication event.
-
- 25 Aug, 2018 2 commits
-
-
Vicențiu Ciorbaru authored
-
Anel Husakovic authored
Implement according to standard SQL specification 2008. The check_constraints table is used for fetching metadata about the constraints defined for tables in all databases.
-
- 24 Aug, 2018 5 commits
-
-
Sergei Petrunia authored
MDEV-16703: update AUTO_INCREMENT in the UPDATE statement
-
Sergei Golubchik authored
MDEV-17040 sql/sql_yacc_orac.cc is included but sql/sql_yacc_ora.cc isn't included in source archive fix a packaging typo
-
Nikita Malyavin authored
* remove assertion * do not setup `conds` if it's already cached Fixes #823
-
Igor Babaev authored
-
Igor Babaev authored
-
- 23 Aug, 2018 2 commits
-
-
Igor Babaev authored
-
Sergei Petrunia authored
The testcase needs to set in_predicate_conversion_threshold which is only available in debug builds (this is subject to further discussion).
-
- 22 Aug, 2018 1 commit
-
-
Ming Lin authored
Currently RocksDB engine doesn't update AUTO_INCREMENT in the UPDATE statement. For example, CREATE TABLE t1 (pk INT AUTO_INCREMENT, a INT, PRIMARY KEY(pk)) ENGINE=RocksDB; INSERT INTO t1 (a) VALUES (1); UPDATE t1 SET pk = 3; ==> AUTO_INCREMENT should be updated to 4. Without this fix, it hits the Assertion `dd_val >= last_val' failed in myrocks::ha_rocksdb::load_auto_incr_value_from_index.
-
- 21 Aug, 2018 3 commits
-
-
Igor Babaev authored
This patch always provides columns of the temporary table used for materialization of a table value constructor with some names. Before this patch these names were always borrowed from the items of the first row of the table value constructor. When this row contained expressions and expressions were not named then it could cause different kinds of problems. In particular if the TVC is used as the specification of a derived table this could cause a crash. The names given to the expressions used in a TVC are the same as those given to the columns of the result set from the corresponding SELECT.
-
Igor Babaev authored
value constructor shows wrong number of rows If the specification of a derived table contained a table value constructor then the optimizer incorrectly estimated the number of rows in the derived table. This happened because the optimizer did not take into account the number of rows in the constructor. The wrong estimate could lead to choosing inefficient execution plans.
-
Daniel Black authored
-
- 16 Aug, 2018 8 commits
-
-
Monty authored
Note that this option was only designed to work on binaries compiled without DBUG.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Amend commit b853b4fd that was reverted in commit 29150e23. recv_parse_log_recs(): Do check for corrupted redo log or file system before checking for len==0, but only read *ptr if it is not past the end of the buffer (end_ptr). recv_parse_log_rec(): Report incorrect redo log type in a consistent way with recv_parse_or_apply_log_rec_body(). This is a follow-up to commit f30c5af4.
-
Marko Mäkelä authored
The Pool poisoning that was introduced in MDEV-15030 introduced race conditions in AddressSanitizer builds, because concurrent poisoning and unpoisoning were not prevented by any synchronization primitive. Pool::get(): Protect the unpoisoning by m_lock_strategy. Pool::mem_free(): Protect the poisoning by m_lock_strategy. Pool::putl(): Renamed from put(), because now the caller is responsible for invoking m_lock_strategy.
-
Marko Mäkelä authored
If trx_free() and trx_create_low() were called while a call to trx_reference() was pending, we could get a reference to a wrong transaction object. trx_reference(): Return NULL if the trx->id no longer matches. lock_trx_release_locks(): Assign trx->id = 0, so that trx_reference() will not return a reference to this object. trx_cleanup_at_db_startup(): Assign trx->id = 0. assert_trx_is_free(): Assert !trx->n_ref. Assert trx->id == 0, now that it will be cleared as part of a transaction commit.
-
Marko Mäkelä authored
Also, replace reverse iteration with forward iteration. lock_table_has(): Remove a redundant condition.
-
Marko Mäkelä authored
Allocate trx->lock.rec_pool and trx->lock.table_pool directly from trx_t. Remove unnecessary use of std::vector. In order to do this, move some definitions from lock0priv.h to lock0types.h, so that ib_lock_t will not be an opaque type.
-
- 15 Aug, 2018 2 commits
-
-
Daniel Bartholomew authored
-
Vladislav Vaintroub authored
-
- 14 Aug, 2018 3 commits
-
-
Marko Mäkelä authored
row_log_table_get_pk_col(): Replace a condition that was inadvertently removed in MDEV-16365. PRIMARY KEY columns are never allowed to be NULL, and failure to enforce the constraint caused a null pointer to be dereferenced in mem_heap_dup().
-
Daniel Bartholomew authored
-
Vladislav Vaintroub authored
-
- 13 Aug, 2018 6 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
aws_key_management needs current directory to be datadir during initalization, it scans current directory for encrypted keys. Fix is to ensure, that plugin initialization in mariabackup happens after the call to my_setwd(mysql_real_data_home).
-
Jacob Mathew authored
The problem occurs because the statement generated by Spider used an internal function name, ADD_TIME. This problem has been corrected by the fix for bug MDEV-16878 within the server, which enables Spider to generate the statement using the actual SQL function name. I have made some additional changes within Spider to fix related problems that I observed while testing. Author: Jacob Mathew. First Reviewer: Alexander Barkov. Second Reviewer: Kentoku Shiba. Merged: Commit 4b6dccc8 on branch bb-10.3-MDEV-16398
-
Sergei Petrunia authored
Fix a race condition in the test.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 12 Aug, 2018 6 commits
-
-
Sergei Petrunia authored
The test causes simulated server crashes with DBUG_SUICIDE();. It also relies on transactions that were committed right before the crash to be visible after the crash (that is, it requires durability). Run the test with transaction durability enabled: set rocksdb-flush-log-at-trx-commit=1.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-