1. 23 Aug, 2021 7 commits
  2. 22 Aug, 2021 1 commit
  3. 21 Aug, 2021 1 commit
  4. 20 Aug, 2021 3 commits
    • Faustin Lammler's avatar
      Unused flag creates cleaning issue (piuparts) · 557bb344
      Faustin Lammler authored
      The "$mysql_statedir/debian-$MAJOR_VER.flag" is not used by any
      maintainer script ("$mysql_datadir/debian-$MAJOR_VER.flag" is used,
      https://github.com/MariaDB/server/blob/10.6/debian/mariadb-server-10.6.postinst#L164).
      
      See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985870
      
      Fix also some minor typo.
      557bb344
    • Marko Mäkelä's avatar
      MDEV-26443 HAVE_C99_INITIALIZERS is not applicable to C++ · 0b2241ae
      Marko Mäkelä authored
      Designated initializers were introduced in ISO/IEC 9899:1999 (C99),
      but the C code base of MariaDB is supposed to be compatible with the
      1990 version of the standard.
      
      The InnoDB code based was switched from C to C++ in
      MySQL 5.6 and MariaDB 10.0. C++ did not introduce syntax for
      designated initializers until ISO/IEC 14882:2020.
      Our C++ code base is still stuck with the 2011 or earlier version of
      that standard.
      
      Therefore, this check as well as the macro STRUCT_FLD are best removed.
      0b2241ae
    • Daniel Black's avatar
      deb: columnstore not 32bit (fix stretch) · a6621867
      Daniel Black authored
      This corrects the autobake on Stretch
      
      Caused by commit 0268b871
      and commit 3d16e0e1.
      
      For very strange reasons (still a mistery) the above commits caused the
      federatedx, archive and blackhole plugins to be missing in the
      install location even though they where built in the build log.
      
      This only occured on Stretch and not recent Ubuntu and Debian
      distros.
      
      The stretch autobake output contained:
      
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_archive.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_archive.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_blackhole.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_blackhole.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_federatedx.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_federatedx.sodh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_archive.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_archive.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_blackhole.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_blackhole.so
      dh_install: Cannot find (any matches for) "usr/lib/mysql/plugin/ha_federatedx.so" (tried in "." and "debian/tmp")
      dh_install: mariadb-server-10.5 missing files: usr/lib/mysql/plugin/ha_federatedx.so
      a6621867
  5. 19 Aug, 2021 14 commits
    • Vladislav Vaintroub's avatar
      MDEV-19712 backup stages commented out. · 1002703b
      Vladislav Vaintroub authored
      Remove commented out code, so that occasional reader is not confused.
      1002703b
    • Vladislav Vaintroub's avatar
      MDEV-26440 Missing connection id value in I_S.thread_pool_queues · 69b75cb3
      Vladislav Vaintroub authored
      It turns out, Field::set_notnull is required for a nullable I_S field.
      Rework thread_pool_info.test to test request queueing in threadpool.
      69b75cb3
    • Vladislav Vaintroub's avatar
      MDEV-19313 post-fix · 4009e9b2
      Vladislav Vaintroub authored
      If --thread-pool-dedicated-listener is set, worker should not pick up
      events. Dedicated listener constantly drains all events, thus polling
      also from another thread makes no sense.
      4009e9b2
    • Alexey Bychko's avatar
      MDEV-26380 auth_pam_tool has incorrect permissions on CentOS 7 · c9d57c00
      Alexey Bychko authored
      splitted permission setting to the 2 separate calls.
      according to execute_process() doc, output from first command will be
      piped to second which led to race and randomly lost suid bit from
      auth_pam_tool.
      c9d57c00
    • Sujatha's avatar
      MDEV-25958: rpl_semi_sync_fail_over.test fails in buildbot · b0d38448
      Sujatha authored
      Post push fix.
      
      Added a missing WAIT_FOR signal line.
      b0d38448
    • Marko Mäkelä's avatar
      MDEV-20931 fixup: innodb.import_corrtupted test cleanup · d12b5e21
      Marko Mäkelä authored
      In MariaDB 10.6, ALTER TABLE t2 IMPORT TABLESPACE
      will not remove the file t2.ibd on failure.
      
      This fixes a failure of
      ./mtr --no-reorder innodb.import_corrupted innodb.innodb-agregate
      d12b5e21
    • Marko Mäkelä's avatar
      Merge 10.5 to 10.6 · f3fcf5f4
      Marko Mäkelä authored
      f3fcf5f4
    • Marko Mäkelä's avatar
      MDEV-26439 Typo in Foreign Key error message · 17980e35
      Marko Mäkelä authored
      foreign_push_index_error(): Fix a typo of 'match' that was introduced
      in commit 5130f520 (MDEV-20480).
      
      Thanks to Oli Sennhauser for reporting this.
      17980e35
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 06079a4c
      Marko Mäkelä authored
      06079a4c
    • Vlad Lesin's avatar
      MDEV-26206 gap lock is not set if implicit lock exists · a2a0ac7c
      Vlad Lesin authored
      Post-push fix for 10.5+.
      
      The fix influence MDEV-14479. Before the fix
      lock_rec_convert_impl_to_expl() did not create explicit lock if caller's
      transaction owns found implicit lock(see MDEV-14479 for details). After the fix
      lock_rec_convert_impl_to_expl() can create explicit lock under the above
      conditions if the requested lock mode is not LOCK_REC_NOT_GAP. And that
      is why we need to check if the table is X-locked before
      lock_rec_convert_impl_to_expl() call.
      a2a0ac7c
    • Marko Mäkelä's avatar
      MDEV-20931 fixup · 7d2d9f04
      Marko Mäkelä authored
      The merge commit 4a259572
      caused a test failure on Windows. The suppression regexp
      needs to accept the backslash.
      
      fil_invalid_page_access_msg(): Simplify the implementation
      and invoke sql_print_error() directly.
      
      fil_space_t::io(): Invoke fil_invalid_page_access_msg() only from
      one location.
      7d2d9f04
    • Thirunarayanan Balathandayuthapani's avatar
      89723ce1
    • danielnachun's avatar
    • Sujatha's avatar
      MDEV-25958: rpl_semi_sync_fail_over.test fails in buildbot · 475f69b9
      Sujatha authored
      Analysis:
      ========
      In case multi binlog truncation scenario debug sync points are in the
      following order.
      
      Two inserts are done on master as shown below.
      
      INSERT INTO t1 VALUES (4, REPEAT("x", 4100)
      commit_after_release_LOCK_after_binlog_sync
      
      INSERT INTO t1 VALUES (5, REPEAT("x", 4100)
      commit_after_release_LOCK_log
      
      First insert debug sync ensures that transaction is synced to binlog and
      not committed but it reached slave through semi sync.
      
      Second insert debug sync ensures that transaction is synced to binlog and
      not committed. It doesn't ensure that 'INSERT 5' reached slave.
      
      Most of the times INSERT 5 reaches slave, hence when it is promoted as
      master it sends 4,5 to slave. But occasionally 5 may not reach slave in
      those cases post recovery master will have only 4. When row 6 is inserted
      Master has 4-6 and Slave has 4,5,6.
      
      This results in test failure.
      
      Fix:
      ===
      For the first insert use 'commit_before_get_LOCK_commit_ordered' debug sync
      point, it will ensure that binlog was sent to slave and slave has
      acknowledged the receipt. Now enable debug code such that when the next
      transaction is written to binary log, dump thread will read and send it
      across the network and notify the server to be get killed. Insert row 5
      and wait for notification from dump thread. Kill the server. This ensures
      that both 4 and 5 have reached the semi-sync slave.
      
      Added a new test case:
      Insert two rows on master such that first is present in master's binlog and
      reached semi sync slave. Second insert should be flushed to binlog but not
      sent to slave. Now crash and fail over to slave. The promoted master will send
      the extra transaction to slave.
      475f69b9
  6. 18 Aug, 2021 13 commits
  7. 17 Aug, 2021 1 commit