1. 18 May, 2017 2 commits
    • Oleksandr Byelkin's avatar
      Make IF clear. · 4a846e01
      Oleksandr Byelkin authored
      4a846e01
    • Sachin Setiya's avatar
      MDEV-11092 Assertion `!writer.checksum_len || writer.remains == 0' failed · b5cdf014
      Sachin Setiya authored
      Problem:-
      This crash happens because logged stmt is quite big and while writing
      Annotate_rows_log_event it throws EFBIG error  but we ignore this error
      and do not call cache_data->set_incident().
      
      Solution:-
      When we normally write Binlog_log_event we check for error EFBIG, but we did
      do this for Annotate_rows_log_event. We check for this error and call
      cache_data->set_incident() accordingly.
      
      # Conflicts:
      #	sql/log.cc
      b5cdf014
  2. 17 May, 2017 2 commits
    • Igor Babaev's avatar
      Fixed the bug mdev-12812. · efb9f261
      Igor Babaev authored
      This is another correction of the patch for bug mdev-12670.
      If a derived table is merged into a select with STRAIGHT_JOIN
      modifier all IN subquery predicates contained in the
      specification of the derived table cannot be subject to
      conversion to semi-joins.
      efb9f261
    • Igor Babaev's avatar
      Fixed the bug mdev-12817/mdev-12820. · 7e971631
      Igor Babaev authored
      This patch is a correction of the patch for bug mdev-12670.
      With the current code handling semi-joins the following must
      be taken into account.
      Conversion of an IN subquery predicate into semi-join
      has to be blocked if the predicate occurs:
      (a) in the ON expression of an outer join
      (b) in the ON expression of an inner join embedded directly
          or indirectly in the inner nest of an outer join.
      The patch for mdev-12670 blocked conversion to semi-joins only
      in the case (a), but not in the case (b). This patch blocks
      the conversion in both cases.
      7e971631
  3. 16 May, 2017 1 commit
    • Igor Babaev's avatar
      Fixed the bug mdev-7791. · 934b8312
      Igor Babaev authored
      When an IN subquery predicate was converted to a semi-join that were
      materialized and the result of the materialization happened to be
      the last in the execution plan then any conjunctive condition with RAND()
      turned out to be lost.
      
      Fixed by attaching this condition to the last top base table.
      934b8312
  4. 15 May, 2017 2 commits
    • Sergei Golubchik's avatar
      MDEV-12799 Buffer overflow · 2e1428c0
      Sergei Golubchik authored
      with a specially corrupted master.info one can
      get an invalid heartbeat_period that will
      trigger a heap overflow.
      2e1428c0
    • Igor Babaev's avatar
      Fixed the bug mdev-7599. · e0352fb0
      Igor Babaev authored
      At some conditions the function opt_sum_query() can apply MIN/MAX
      optimizations to to Item_sum objects of a select These optimizations
      becomes invalid if this select is the subquery of an IN subquery
      predicate that is converted to a EXISTS subquery. Thus in this case
      the MIX/MAX optimizations that have been applied in opt_sum_query()
      must be rolled back.
      This bug appeared in 5.3 when the code for the cost base choice between
      materialization and in-to-exists transformation of non-correlated
      IN subqueries was introduced. Before this code in-to-exists
      transformations were always performed before the call of opt_sum_query().
      e0352fb0
  5. 12 May, 2017 1 commit
  6. 09 May, 2017 1 commit
    • Igor Babaev's avatar
      Fixed the bugs mdev-12670 and mdev-12675. · 6b97fe06
      Igor Babaev authored
      The code that blocked conversion of a IN subselect pedicate to a semi-join
      if it occurred in the ON expression of an outer join did not do it correctly.
      As a result, the conversion was blocked for IN subselect predicates
      encountered in ON expressions of INNER joins or in WHERE conditions
      of mergeable views / derived tables. This patch fixes this problem.
      6b97fe06
  7. 05 May, 2017 1 commit
    • Igor Babaev's avatar
      Fixed the bug mdev-12673. · 15f9931f
      Igor Babaev authored
      This patch corrects the fix for the bug mdev-10693.
      It is critical for the function get_best_combination() not to call
      create_ref_for_key() for constant tables.
      This bug could manifest itself only in multi-table subqueries where
      one of the tables is accessed by a constant primary key.
      15f9931f
  8. 02 May, 2017 1 commit
  9. 30 Apr, 2017 1 commit
    • Daniel Black's avatar
      mysqld_safe_help - remove warning · dbe2c3c5
      Daniel Black authored
      /home/travis/build/MariaDB/server/extra/mysqld_safe_helper.c:62:21: warning: too many arguments in call to 'do_usage'
          do_usage(argv[0]);
          ~~~~~~~~        ^
      1 warning generated.
      dbe2c3c5
  10. 24 Apr, 2017 1 commit
    • Igor Babaev's avatar
      Fixed the bug mdev-10693. · 2e7ba70a
      Igor Babaev authored
      The code that chooses between materialization of a non-correlated
      IN subquery and its transformation into an EXISTS correlated
      subquery assumes that the execution plan for the outer select
      has been already built. However it was not always so if subqueries
      occurred in the expressions used for ref access to tables of
      the outer select. A call of the function create_ref_for_key() in
      get_best_combination() could trigger a premature execution of
      the above mentioned code when the execution plan structures for
      the outer select were not fully built. This could cause a crash
      of the server.
      
      The fix postpones the calls of create_ref_for_key() until the
      structures for the execution plan is fully built.
      2e7ba70a
  11. 20 Apr, 2017 6 commits
  12. 19 Apr, 2017 1 commit
    • Oleksandr Byelkin's avatar
      Fix use of `require` in mysql-test-run. · d185f1d6
      Oleksandr Byelkin authored
      The motivation for this is that Perl is moving towards not having
      current directory ./ in @INC by default. This is causing
      mysql-test-run.pl to fail in latest Debian Unstable:
      
        https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html
      
      However, we have `use "lib"`, there is no need for current directory
      in @INC, except for a gross hack. In mtr_cases.pm, there is a
      `require "mtr_misc.pl"`, which hides mtr_misc.pl away in mtr_cases
      namespace. And things only work because mysql-test-run.pl loads it
      with a different name, `require "lib/mtr_misc.pl"`! (Perl will
      `require` only once for each unique filename).
      
      Fix this by only using `require` in main program, and referencing
      functions with :: scope from other namespaces. For multi-use in
      different namespaces, proper `use` modules should be used.
      Signed-off-by: default avatarKristian Nielsen <knielsen@knielsen-hq.org>
      d185f1d6
  13. 13 Apr, 2017 1 commit
  14. 11 Apr, 2017 1 commit
  15. 07 Apr, 2017 1 commit
  16. 04 Apr, 2017 1 commit
    • Igor Babaev's avatar
      Fixed the bug mdev-12429 and its duplicates mdev-12145 and mdev-9886. · b0395d87
      Igor Babaev authored
      Also fixed a wrong result for a test case for mdev-7691
      (the alternative one).
      The test  cases for all these bug have materialized semi-joins used
      inside dependent sub-queries.
      
      The patch actually reverts the change inroduced by Monty in 2003.
      It looks like this change is not valid anymore after the implementation
      of semi-joins.
      Adjusted output from EXPLAIN for many other test cases.
      b0395d87
  17. 24 Mar, 2017 1 commit
  18. 21 Mar, 2017 1 commit
  19. 18 Mar, 2017 1 commit
    • Bharathy Satish's avatar
      Bug #25717383: MYSQLDUMP MAY EXECUTE ANY ARBITRARY QUERY · 6fa5e081
      Bharathy Satish authored
      While writing comments if database object names has a new
      line character, then next line is considered a command, rather
      than a comment.
      This patch fixes the way comments are constructed in mysqldump.
      
      (cherry picked from commit 1099f9d17b1c697c2760f86556f5bae7d202b444)
      6fa5e081
  20. 17 Mar, 2017 1 commit
  21. 14 Mar, 2017 2 commits
  22. 13 Mar, 2017 1 commit
  23. 12 Mar, 2017 1 commit
  24. 10 Mar, 2017 1 commit
  25. 09 Mar, 2017 1 commit
  26. 08 Mar, 2017 6 commits