1. 08 Jun, 2007 1 commit
    • unknown's avatar
      Bug#27684 undocumented difference between SHOW ENGINES and I_S.ENGINES · 4c2f2ac5
      unknown authored
      Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
      For this: removed the functions mysqld_show_storage_engines and show_handlerton, and
      made SHOW ENGINES work via the common function iter_schema_engines.
      There in no test case because an engine (except of MyISAM) may be not compiled or disabled
      which may affect the test result.
      
      
      sql/sql_parse.cc:
        Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
      sql/sql_show.cc:
        Changed SHOW ENGINES to work in the same way as I_S.ENGINES.
        For this: removed the functions mysqld_show_storage_engines and show_handlerton, and
        made SHOW ENGINES work via the common function iter_schema_engines.
      4c2f2ac5
  2. 07 Jun, 2007 1 commit
    • unknown's avatar
      bug #28309 First insert violates UNIQUE constraint - was "memory" table empty? · a42a9777
      unknown authored
        
      If we have lower_case_table_names == 2 (usually on case insensitive file
      systems) we sometimes make 'homedir' part of the path sent to the
      handler into lowercase. So in this case HEAP engine couldn't properly
      find and remove HP_SHARE, what caused the bug.
      
      
      sql/handler.cc:
        bug #28309 First insert violates UNIQUE constraint - was "memory" table empty?
            
        we don't turn homedirectory part of the path into lowercase
      sql/mysql_priv.h:
        bug #28309 First insert violates UNIQUE constraint - was "memory" table empty?
            
        mysql_data_home_len introduced
      sql/mysqld.cc:
        bug #28309 First insert violates UNIQUE constraint - was "memory" table empty?
            
        mysql_data_home_len value is set with the mysql_data_home
      a42a9777
  3. 06 Jun, 2007 3 commits
    • unknown's avatar
      Bug#28007 Wrong default value for I_S.PARTITIONS.PARTITION_COMMENT · 62e88b77
      unknown authored
      The value of the PARTITION_COMMENT column is an empty string if there is no partition comment.
      
      
      mysql-test/r/information_schema_part.result:
        result fix
      mysql-test/r/ndb_dd_alter.result:
        result fix
      mysql-test/r/ndb_dd_backuprestore.result:
        result fix
      mysql-test/r/ndb_partition_range.result:
        result fix
      sql/sql_show.cc:
        The value of the PARTITION_COMMENT column is an empty string if there is no partition comment.
      62e88b77
    • unknown's avatar
      Bug#28580 Repeatation of status variables · 64255a37
      unknown authored
      removed duplicated variable declarations
      
      
      mysql-test/r/variables.result:
        test result
      mysql-test/t/variables.test:
        test case
      sql/set_var.cc:
        removed duplicated variable declarations
      64255a37
    • unknown's avatar
      merging fix · a6f7f8a4
      unknown authored
      a6f7f8a4
  4. 05 Jun, 2007 2 commits
  5. 04 Jun, 2007 7 commits
    • unknown's avatar
      Bug #28488: Incorrect information in file: './test/t1_test#.frm' · fce63f8f
      unknown authored
      While executing ALTER TABLE ... PARTITION the server uses 
      a temporary "shadow" table to create the updated table.
      This shadow table then gets renamed as the original table.
      The shadow table was not prefixed with the special prefix that
      marks temporary tables so it was picked up by SHOW TABLE STATUS.
      Fixed by isolating the code to create the shadow table name in a
      separate function and prefixing the shadow table name with the
      special prefix to exclude it from the list of user tables.
      See bug 18775 and WL1324 for details.
      
      
      mysql-test/r/partition.result:
        Bug #28488: test case
      mysql-test/t/partition.test:
        Bug #28488: test case
      sql/mysql_priv.h:
        Bug #28488: prefix shadow file with the temp prefix
      sql/sql_partition.cc:
        Bug #28488: prefix shadow file with the temp prefix
      sql/sql_table.cc:
        Bug #28488: prefix shadow file with the temp prefix
      fce63f8f
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · ddf48bed
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/udf_example.c:
        Auto merged
      ddf48bed
    • unknown's avatar
      Post-merge fix. · 4be1d786
      unknown authored
      4be1d786
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 5a19274e
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt-merge
      
      
      include/thr_lock.h:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      mysql-test/t/subselect3.test:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/udf_example.c:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      sql/sql_view.cc:
        Manual merge.
      5a19274e
    • unknown's avatar
      Post-merge fix. · e65eb0e4
      unknown authored
      e65eb0e4
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e409a8a5
      unknown authored
      into  dl145s.mysql.com:/dev/shm/mhansson/my50-bug27741
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      e409a8a5
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.1 · f4caa302
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt-merge
      
      
      mysql-test/r/alter_table.result:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/r/user_var.result:
        Auto merged
      mysql-test/t/alter_table.test:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      mysql-test/t/subselect3.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Manual merge.
      mysql-test/r/ps_3innodb.result:
        Manual merge.
      mysql-test/r/ps_4heap.result:
        Manual merge.
      mysql-test/r/ps_5merge.result:
        Manual merge.
      mysql-test/r/ps_7ndb.result:
        Manual merge.
      sql/sql_table.cc:
        Manual merge.
      sql/sql_view.cc:
        Manual merge.
      f4caa302
  6. 03 Jun, 2007 12 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · 272a5456
      unknown authored
      into  dl145s.mysql.com:/dev/shm/mhansson/my51-bug27741-mpush
      
      
      272a5456
    • unknown's avatar
      item_func.h, item_func.cc: · 92fb5da3
      unknown authored
        Post merge fix for the bug#28494.
      
      
      sql/item_func.h:
        Post merge fix for the bug#28494.
      sql/item_func.cc:
        Post merge fix for the bug#28494.
      92fb5da3
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 7b8af0f5
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28728
      
      
      7b8af0f5
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 687191a0
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/user_var.result:
        Auto merged
      mysql-test/t/user_var.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      687191a0
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · eb958aff
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql
      
      
      eb958aff
    • unknown's avatar
      user_var.result: · e19dcfa9
      unknown authored
        Corrected test case result for the bug#28494.
      item_func.h, item_func.cc:
        Corrected function names after fix for the bug#28494.
      
      
      mysql-test/r/user_var.result:
        Corrected test case result for the bug#28494.
      sql/item_func.h:
        Corrected function names after fix for the bug#28494.
      sql/item_func.cc:
        Corrected function names after fix for the bug#28494.
      e19dcfa9
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a6f1d558
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql
      
      
      a6f1d558
    • unknown's avatar
      user_var.result, user_var.test: · 4ef02860
      unknown authored
        Extended test case for the bug#28494.
      
      
      mysql-test/t/user_var.test:
        Extended test case for the bug#28494.
      mysql-test/r/user_var.result:
        Extended test case for the bug#28494.
      4ef02860
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 6c403ec9
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28728
      
      
      6c403ec9
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · b313fe13
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B26162-5.0-opt
      
      
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      b313fe13
    • unknown's avatar
      Bug #26162: Trigger DML ignores low_priority_updates setting · f9a41f9f
      unknown authored
        
      The value of "low-priority-updates" option and the LOW PRIORITY
      prefix was taken into account at parse time.
      This caused triggers (among others) to ignore this flag (if
      supplied for the DML statement).
      Moved reading of the LOW_PRIORITY flag at run time.
      Fixed an incosistency when handling
      SET GLOBAL LOW_PRIORITY_UPDATES : now it is in effect for
      delayed INSERTs.
      Tested by checking the effect of LOW_PRIORITY flag via a 
      trigger.
      
      
      include/thr_lock.h:
        Bug #26162: moved reading of the LOW PRIORITY flag at run time
      mysql-test/r/trigger.result:
        Bug #26162: test case
      mysql-test/t/trigger.test:
        Bug #26162: test case
      sql/set_var.cc:
        Bug #26162: fixed the handling of the "low-priority-updates" option
      sql/sql_base.cc:
        Bug #26162: moved reading of the LOW PRIORITY flag at run time
      sql/sql_yacc.yy:
        Bug #26162: moved reading of the LOW PRIORITY flag at run time
      f9a41f9f
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 8b0afa63
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      sql/item_func.cc:
        Manually merged
      8b0afa63
  7. 02 Jun, 2007 10 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 04e2d152
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28728
      
      
      04e2d152
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 8ded1e81
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql
      
      
      8ded1e81
    • unknown's avatar
      item_func.cc: · 684653b8
      unknown authored
        Post fix for bug#28494.
        The Item_func_set_user_var::check method now silently doesn't use result_field
        if it isn't defined.
      
      
      sql/item_func.cc:
        Post fix for bug#28494.
        The Item_func_set_user_var::check method now silently doesn't use result_field
        if it isn't defined.
      684653b8
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql · 45714d35
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      mysql-test/r/user_var.result:
        Manual merge
      mysql-test/t/user_var.test:
        Manual merge
      45714d35
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 5c23a1c7
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28728
      
      
      5c23a1c7
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · bce9860d
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.0-opt-mysql
      
      
      bce9860d
    • unknown's avatar
      Bug#28494: Grouping by Item_func_set_user_var produces incorrect result. · 8ab1830f
      unknown authored
      This is an additional fix.
      Item::val_xxx methods are supposed to use original data source and
      Item::val_xxx_result methods to use the item's result field. But for the
      Item_func_set_user_var class val_xxx_result methods were mapped to val_xxx
      methods. This leads, in particular, to producing bad sort keys and thus
      wrong order of the result set of queries with group by/order by clauses.
      
      The set of val_xxx_result methods is added to the Item_func_set_user_var
      class. It's the same as the val_xxx set of method but uses the result_field
      to return a value.
      
      
      mysql-test/t/user_var.test:
        Corrected test case for hte bug#28494.
      mysql-test/r/user_var.result:
        Corrected test case for hte bug#28494.
      sql/item_func.cc:
        Bug#28494: Grouping by Item_func_set_user_var produces incorrect result.
        The set of val_xxx_result methods is added to the Item_func_set_user_var
        class. It's the same as the val_xxx set of method but uses the result_field
        to return a value.
      sql/item_func.h:
        Bug#28494: Grouping by Item_func_set_user_var produces incorrect result.
        The set of val_xxx_result methods is added to the Item_func_set_user_var
        class.
      8ab1830f
    • unknown's avatar
      Fixed bug #28728: a crash when executing EXPLAIN EXTENDED for a query · 8c4ff24b
      unknown authored
      using a derived table over a grouping subselect.
      
      This crash happens only when materialization of the derived tables 
      requires creation of auxiliary temporary table, for example when
      a grouping operation is carried out with usage of a temporary table.
      
      The crash happened because EXPLAIN EXTENDED when printing the query
      expression made an attempt to use the objects created in the mem_root
      of the temporary table which has been already freed by the moment
      when printing is called.
      
      This bug appeared after the method Item_field::print() had been 
      introduced.    
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #28728.
      mysql-test/t/subselect.test:
        Added a test case for bug #28728.
      sql/sql_select.cc:
        Fixed bug #28728: a crash when executing EXPLAIN EXTENDED for a query
        using a derived table over a grouping subselect.
        The crash happened because EXPLAIN EXTENDED when printing the query
        expression made an attempt to use the objects created in the mem_root
        of the temporary table which has been already freed by the moment
        when printing is accomplished.
        The fix in JOIN::exec() ensures using existing objects when printing 
        subselects for a derived tables by EXPLAIN EXTENDED.
      8c4ff24b
    • unknown's avatar
      BUG#28427: fix typo, s/bool/uint/ · b85d7da2
      unknown authored
      b85d7da2
    • unknown's avatar
      Post-merge fix. · 0ec40a45
      unknown authored
      0ec40a45
  8. 01 Jun, 2007 4 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 5697c0c1
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
      
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      mysql-test/t/subselect3.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_view.cc:
        Manual merge
      5697c0c1
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · a5128d70
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      sql/mysqld.cc:
        Auto merged
      a5128d70
    • unknown's avatar
      Bug#28427: Columns were renamed instead of moving by ALTER TABLE. · cfd1e67a
      unknown authored
      To avoid unnecessary work the mysql_alter_table function takes the
      list of table fields and applies all changes to it (drops/moves/renames/etc).
      Then this function compares the new list and the old one. If the changes
      require only .frm to be modified then the actual data isn't copied. To detect
      changes all columns attributes but names are compared. When a column has been
      moved and has replaced another column with the same attributes except name
      the mysql_alter_table function wrongly decides that two fields has been just
      renamed. As a result the data from the moved column and from all columns
      after it is not copied.
      
      Now the mysql_alter_table function forces table data copying by setting
      the need_copy_table flag when it finds a moved column. The flag is set at
      the stage when the modified fields are created.
      
      
      
      sql/sql_table.cc:
        Bug#28427: Columns were renamed instead of moving by ALTER TABLE.
        Now the mysql_alter_table function forces table data copying by setting
        the need_copy_table flag when it finds a moved column. The flag is set at
        the stage when the modified fields are created.
      mysql-test/r/alter_table.result:
        Added a test case for the bug#28427: Columns were renamed instead of moving by ALTER TABLE.
      mysql-test/t/alter_table.test:
        Added a test case for the bug#28427: Columns were renamed instead of moving by ALTER TABLE.
      cfd1e67a
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · 0484d44e
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/t/mysqltest.test:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      0484d44e