1. 27 Apr, 2023 9 commits
  2. 26 Apr, 2023 8 commits
    • Marko Mäkelä's avatar
      Merge 10.9 into 10.10 · ce6616aa
      Marko Mäkelä authored
      ce6616aa
    • Marko Mäkelä's avatar
      After-merge fix · 09fdd3ac
      Marko Mäkelä authored
      This fixes up commit e3f6e1c9
      09fdd3ac
    • Marko Mäkelä's avatar
      Merge 10.8 into 10.9 · e3f6e1c9
      Marko Mäkelä authored
      e3f6e1c9
    • Marko Mäkelä's avatar
      Merge 10.6 into 10.8 · c15c8ef3
      Marko Mäkelä authored
      c15c8ef3
    • Marko Mäkelä's avatar
      MDEV-31132 Deadlock between DDL and purge of InnoDB history · 5740638c
      Marko Mäkelä authored
      log_free_check(): Assert that the caller must not hold
      exclusive lock_sys.latch. This was the case for calls from
      ibuf_delete_for_discarded_space(). This caused a deadlock with
      another thread that would be holding a latch on a dirty page
      that would need to be written so that the checkpoint would advance
      and log_free_check() could return. That other thread was waiting
      for a shared lock_sys.latch.
      
      fil_delete_tablespace(): Do not invoke ibuf_delete_for_discarded_space()
      because in DDL operations, we will be holding exclusive lock_sys.latch.
      
      trx_t::commit(std::vector<pfs_os_file_t>&), innodb_drop_database(),
      row_purge_remove_clust_if_poss_low(), row_undo_ins_remove_clust_rec(),
      row_discard_tablespace_for_mysql():
      Invoke ibuf_delete_for_discarded_space() on the deleted tablespaces after
      releasing all latches.
      5740638c
    • Marko Mäkelä's avatar
      MDEV-26055: Correct the formula for adaptive flushing · d4265fbd
      Marko Mäkelä authored
      page_cleaner_flush_pages_recommendation(): If dirty_pct is
      between innodb_max_dirty_pages_pct_lwm
      and innodb_max_dirty_pages_pct,
      scale the effort relative to how close we are to
      innodb_max_dirty_pages_pct.
      
      The previous formula was missing a multiplication by 100.
      
      Tested by: Axel Schwenke
      d4265fbd
    • Sergei Golubchik's avatar
      MDEV-30218 update test result · b942f414
      Sergei Golubchik authored
      followup for d1a46c68
      b942f414
    • Sergei Golubchik's avatar
      MDEV-11356 Option skip-core-file does not work · b3817425
      Sergei Golubchik authored
      remove ancient hard-coded treatment of --core-file. This enables
      normal my_getopt behavior for the already existing sysvar
      b3817425
  3. 25 Apr, 2023 6 commits
    • Julius Goryavsky's avatar
      MDEV-30804 addendum for 10.6+ branches · 898320b5
      Julius Goryavsky authored
      This addition to MDEV-30804 is relevant for 10.6+, it excludes
      the mixed transaction section using both innodb and aria storage
      engines from the galera_var_replicate_aria_off test, since such
      transactions cannot be executed unless aria supports two-phase
      transaction commit. No additional tests are required as this
      commit fixes the mtr test itself.
      898320b5
    • Andrei's avatar
      MDEV-30620 Trying to lock uninitialized LOCK_parallel_entry · e22a57da
      Andrei authored
      The error was seen by a number of mtr tests being caused
      by overdue initialization of rpl_parallel::LOCK_parallel_entry.
      Specifically, SHOW-SLAVE-STATUS might find in
      rpl_parallel::workers_idle() a gtid domain hash entry
      already inserted whose mutex had not done
      mysql_mutex_init().
      
      Fixed with swapping the mutex init and the its entry's stack insertion.
      
      Tested with a generous number of `mtr --repeat` of a few of the reported
      to fail tests, incl rpl.parallel_backup.
      e22a57da
    • Marko Mäkelä's avatar
      MDEV-26827 fixup: Prevent a hang in LRU eviction · c22ab93f
      Marko Mäkelä authored
      buf_pool_t::page_cleaner_wakeup(): If for_LRU=true, wake up the page
      cleaner immediately, also when it is in a timed wait. This avoids an
      unnecessary delay of up to 1 second.
      c22ab93f
    • Sergei Petrunia's avatar
      MDEV-31121: ANALYZE statement produces 0 for all timings in embedded server · a72b2c3f
      Sergei Petrunia authored
      Timers require my_timer_init() call.
      It was made only in mysqld_main(). Call it also from init_embedded_server().
      a72b2c3f
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 818d5e48
      Marko Mäkelä authored
      818d5e48
    • Marko Mäkelä's avatar
      MDEV-31124 Innodb_data_written miscounts doublewrites · 50f3b7d1
      Marko Mäkelä authored
      When commit a5a2ef07
      implemented asynchronous doublewrite, the writes via
      the doublewrite buffer started to be counted incorrectly,
      without multiplying them by innodb_page_size.
      
      srv_export_innodb_status(): Correctly count the
      Innodb_data_written.
      
      buf_dblwr_t: Remove submitted(), because it is close to written()
      and only Innodb_data_written was interested in it. According to
      its name, it should count completed and not submitted writes.
      
      Tested by: Axel Schwenke
      50f3b7d1
  4. 24 Apr, 2023 10 commits
    • Brandon Nesterenko's avatar
      MDEV-31038: Parallel Replication Breaks if XA PREPARE Fails Updating Slave GTID State · 31f09e36
      Brandon Nesterenko authored
      If a replica failed to update the GTID slave state when committing
      an XA PREPARE, the replica would retry the transaction and get an
      out-of-order GTID error. This is because the commit phase of an XA
      PREPARE is bifurcated. That is, first, the prepare is handled by the
      relevant storage engines. Then second, the GTID slave state is
      updated as a separate autocommit transaction. If the second phase
      fails, and the transaction is retried, then the same transaction is
      attempted to be committed again, resulting in a GTID out-of-order
      error.
      
      This patch fixes this error by immediately stopping the slave and
      reporting the appropriate error. That is, there was logic to bypass
      the error when updating the GTID slave state table if the underlying
      error is allowed for retry on a parallel slave. This patch adds a
      parameter to disallow the error bypass, thereby forcing the error
      state to still happen.
      
      Reviewed By
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      31f09e36
    • Brandon Nesterenko's avatar
      MDEV-30430: Enabling system versioning on tables without primary key breaks replication · 29fb0410
      Brandon Nesterenko authored
      When replicating MDL events for a table that uses system versioning
      without primary keys, ensure that for data sets with duplicate
      records, the updates to these records with duplicates are enacted on
      the correct row. That is, there was a bug (reported in MDEV-30430)
      such that the function to find the row to update would stop after
      finding the first matching record. However, in the absence of
      primary keys, the version of the record is needed to compare the row
      to ensure we are updating the correct one.
      
      The fix, therefore, updates the record comparison functionality to
      use system version columns when there are no primary keys on the
      table.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      29fb0410
    • Brandon Nesterenko's avatar
      MDEV-28798: Cosmetic Changes Only · 4ec3dca3
      Brandon Nesterenko authored
      Removed trailing whitespaces
      4ec3dca3
    • Brandon Nesterenko's avatar
      MDEV-28798: Previously Binlog Encrypted Master Segfaults on Binlog Dump with Using_Gtid=Slave_Pos · d3e7dba3
      Brandon Nesterenko authored
      Problem:
      ========
      A master can segfault if it can't set up decryption for its binary
      log during a binlog dump with Using_Gtid=Slave_Pos. If slave
      connects using GTID mode, the master will call into
      log.cc::get_gtid_list_event(), which iterate through binlog events
      looking for a Gtid_list_log_event. On an encrypted binlog that the
      master cannot decrypt, the first event will be a
      START_ENCRYPTION_EVENT which will call into the following decryption branch
      
      if (fdle->start_decryption((Start_encryption_log_event*) ev))
        errormsg= ‘Could not set up decryption for binlog.’;
      
      The event iteration however, does not stop in spite of this error.
      The master will try to read the next event, but segfault while
      trying to decrypt it because decryption failed to initialize.
      
      Solution:
      ========
      Break the event iteration if decryption cannot be set up.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      d3e7dba3
    • Igor Babaev's avatar
      MDEV-31102 Crash when pushing condition into view defined as union · 5dc9a6b4
      Igor Babaev authored
      This bug could manifest itself at the first execution of prepared statement
      created for queries using a materialized view defined as union. A crash
      could happen for sure if the query contained a condition pushable into
      the view and this condition was over the column defined via a complex string
      expression requiring implicit conversion from one charset to another for
      some of its sub-expressions. The bug could cause crashes when executing
      PS for some other queries whose optimization needed building clones for
      such expressions.
      
      This bug was introduced in the patch for MDEV-29988 where the class
      Item_direct_ref_to_item was added. The implementations of the virtual
      methods get_copy() and build_clone() were invalid for the class and this
      could cause crashes after the method build_clone() was called for
      expressions containing objects of the Item_direct_ref_to_item type.
      
      Approved by Sergei Golubchik <serg@mariadb.com>
      5dc9a6b4
    • Marko Mäkelä's avatar
      Merge 10.6 into 10.8 · 3c250778
      Marko Mäkelä authored
      3c250778
    • Oleksandr Byelkin's avatar
      Merge branch '10.4' into 10.5 · 1d74927c
      Oleksandr Byelkin authored
      1d74927c
    • Marko Mäkelä's avatar
      MDEV-31114 Assertion !...is_waiting() failed in os_aio_wait_until_no_pending_writes() · 0976afec
      Marko Mäkelä authored
      os_aio_wait_until_no_pending_reads(), os_aio_wait_until_pending_writes():
      Add a Boolean parameter to indicate whether the wait should be declared
      in the thread pool.
      
      buf_flush_wait(): The callers have already declared a wait, so let us
      avoid doing that again, just call os_aio_wait_until_pending_writes(false).
      
      buf_flush_wait_flushed(): Do not declare a wait in the rare case that
      the buf_flush_page_cleaner thread has been shut down already.
      
      buf_flush_page_cleaner(), buf_flush_buffer_pool(): In the code that runs
      during shutdown, do not declare waits.
      
      buf_flush_buffer_pool(): Remove a debug assertion that might fail.
      What really matters here is buf_pool.flush_list.count==0.
      
      buf_read_recv_pages(), srv_prepare_to_delete_redo_log_file():
      Do not declare waits during InnoDB startup.
      0976afec
    • Alexander Barkov's avatar
      A cleanup for MDEV-30968 mariadb-backup does not copy Aria logs if aria_log_dir_path is used · d3e394b3
      Alexander Barkov authored
      Fixing buildbot failures on mariabackup.aria_log_dir_path_rel.
      
      The problem was that directory_exists() was called with the
      relative aria_log_dir_path value, while the current directory
      in mariadb-backup is not necessarily equal to datadir when MTR is running.
      
      Fix:
      
      - Moving building the absolute path un level upper:
        from the function copy_back_aria_logs() to the function copy_back().
      - Passing the built absolute path to both directory_exists() and
        copy_back_aria_logs() as a parameter.
      d3e394b3
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-30996 insert.. select in presence of full text index freezes all other commits at commit time · 2c567b2f
      Thirunarayanan Balathandayuthapani authored
      - This patch does the following:
      git revert --no-commit 673243c8
      git revert --no-commit 6c669b95
      git revert --no-commit bacaf2d4
      git checkout HEAD mysql-test
      git revert --no-commit 1fd7d3a9
      
      Above command reverts MDEV-29277, MDEV-25581, MDEV-29342.
      
      When binlog is enabled, trasaction takes a lot of time to do
      sync operation on innodb fts table. This leads to block
      of other transaction commit. To avoid this failure, remove
      the fulltext sync operation during transaction commit. So
      reverted MDEV-25581 related patches.
      
      We filed MDEV-31105 to avoid the memory consumption
      problem during fulltext sync operation.
      2c567b2f
  5. 22 Apr, 2023 1 commit
  6. 21 Apr, 2023 6 commits
    • Alexander Barkov's avatar
      MDEV-30968 mariadb-backup does not copy Aria logs if aria_log_dir_path is used · 9f98a2ac
      Alexander Barkov authored
      - `mariadb-backup --backup` was fixed to fetch the value of the
         @@aria_log_dir_path server variable and copy aria_log* files
         from @@aria_log_dir_path directory to the backup directory.
         Absolute and relative (to --datadir) paths are supported.
      
         Before this change aria_log* files were copied to the backup
         only if they were in the default location in @@datadir.
      
      - `mariadb-backup --copy-back` now understands a new my.cnf and command line
         parameter --aria-log-dir-path.
      
        `mariadb-backup --copy-back` in the main loop in copy_back()
         (when copying back from the backup directory to --datadir)
         was fixed to ignore all aria_log* files.
      
         A new function copy_back_aria_logs() was added.
         It consists of a separate loop copying back aria_log* files from
         the backup directory to the directory specified in --aria-log-dir-path.
         Absolute and relative (to --datadir) paths are supported.
         If --aria-log-dir-path is not specified,
         aria_log* files are copied to --datadir by default.
      
      - The function is_absolute_path() was fixed to understand MTR style
        paths on Windows with forward slashes, e.g.
         --aria-log-dir-path=D:/Buildbot/amd64-windows/build/mysql-test/var/...
      9f98a2ac
    • Marko Mäkelä's avatar
      MDEV-26782 InnoDB temporary tablespace: reclaiming of free space does not work · 51e62cb3
      Marko Mäkelä authored
      The motivation of this change is to allow undo pages for temporary tables
      to be marked free as often as possible, so that we can avoid buf_pool.LRU
      eviction (and writes) of undo pages that contain data that is
      no longer needed. For temporary tables, no MVCC or purge of history
      is needed, and reusing cached undo log pages might not help that much.
      
      It is possible that this may cause some performance regression due to
      more frequent allocation and freeing of undo log pages, but I only
      measured a performance improvement.
      
      trx_write_serialisation_history(): Never cache temporary undo log pages.
      
      trx_undo_reuse_cached(): Assert that the rollback segment is persistent.
      
      trx_undo_assign_low(): Add template<bool is_temp>. Never invoke
      trx_undo_reuse_cached() for temporary tables.
      
      Tested by: Matthias Leich
      51e62cb3
    • Marko Mäkelä's avatar
      Cleanup: MONITOR_EXISTING trx_undo_slots_used, trx_undo_slots_cached · 204e7225
      Marko Mäkelä authored
      Let us remove explicit updates of MONITOR_NUM_UNDO_SLOT_USED
      and MONITOR_NUM_UNDO_SLOT_CACHED, and let us compute the rough values
      from trx_sys.rseg_array[] on demand.
      204e7225
    • Marko Mäkelä's avatar
      MDEV-29593 Purge misses a chance to free not-yet-reused undo pages · 86767bcc
      Marko Mäkelä authored
      trx_purge_truncate_rseg_history(): If all other conditions for
      invoking trx_purge_remove_log_hdr() hold, but the state is
      TRX_UNDO_CACHED instead of TRX_UNDO_TO_PURGE, detach and free it.
      
      Tested by: Matthias Leich
      86767bcc
    • Marko Mäkelä's avatar
      MDEV-26827 fixup: hangs and !os_aio_pending_writes() assertion failures · 40eff3f8
      Marko Mäkelä authored
      buf_LRU_get_free_block(): Always wake up the page cleaner if needed
      before exiting the inner loop.
      
      srv_prepare_to_delete_redo_log_file():
      Replace a debug assertion with a wait in debug builds.
      Starting with commit 7e31a8e7
      the debug assertion ut_ad(!os_aio_pending_writes())
      could occasionally fail, while it would hold in core dumps of crashes.
      The failure can be reproduced more easily by adding a sleep to the
      write completion callback function, right before releasing to
      write_slots.
      
      srv_start(): Remove a bogus debug assertion
      ut_ad(!os_aio_pending_writes()) that could fail in
      mariadb-backup --prepare. In an rr replay trace, we had
      buf_pool.flush_list.count==0 but write_slots->m_cache.m_pos==1
      and buf_page_t::write_complete() was executing u_unlock().
      40eff3f8
    • Daniel Black's avatar
      MDEV-30713 field length handling for CONNECT engine · da1c91fb
      Daniel Black authored
      fp->field_length was unsigned and therefore the negative
      condition around it.
      
      Backport of cc182aca fixes it, however to correct the
      consistent use of types pcf->Length needs to be unsigned
      too.
      
      At one point pcf->Precision is assigned from pcf->Length so
      that's also unsigned.
      
      GetTypeSize is assigned to length and has a length argument.
      A -1 default value seemed dangerious to case, so at least 0
      should assert if every hit.
      da1c91fb