1. 28 Mar, 2021 3 commits
  2. 27 Mar, 2021 4 commits
  3. 26 Mar, 2021 6 commits
    • Michael Okoko's avatar
      Replace mallinfo with mallinfo2 on supported systems · 48141f3c
      Michael Okoko authored
      `mallinfo` is deprecated since glibc 2.33 and has been replaced by mallinfo2.
      The deprecation causes building the server to fail if glibc version is > 2.33.
      
      Check if mallinfo2 exist on the system and use it instead.
      48141f3c
    • Eugene Kosov's avatar
    • Eugene Kosov's avatar
      MDEV-25238 add support for -fsanitize-address-use-after-scope · dfae51de
      Eugene Kosov authored
      Use like this: cmake -DWITH_ASAN=ON -DWITH_ASAN_SCOPE=ON
      dfae51de
    • Marko Mäkelä's avatar
      MDEV-24786: row_upd_clust_step() skips mtr_t::commit() on virtual column error · a6d66fe7
      Marko Mäkelä authored
      The function row_upd_clust_step() is invoking several static functions,
      some of which used to commit the mini-transaction in some cases.
      If innobase_get_computed_value() would fail due to some reason,
      we would fail to invoke mtr_t::commit() and release buffer pool
      page latches. This would likely lead to a hanging server later.
      
      This regression was introduced in
      commit 97db6c15 (MDEV-20618).
      
      row_upd_index_is_referenced(), row_upd_sec_index_entry(),
      row_upd_sec_index_entry(): Cleanup: Replace some ibool with bool.
      
      row_upd_clust_rec_by_insert(), row_upd_clust_rec(): Guarantee that
      the mini-transaction will always remain in active state.
      
      row_upd_del_mark_clust_rec(): Guarantee that
      the mini-transaction will always remain in active state.
      This fixes one "leak" of mini-transaction on DB_COMPUTE_VALUE_FAILED.
      
      row_upd_clust_step(): Use only one return path, which will always
      invoke mtr.commit(). After a failed row_upd_store_row() call, we
      will no longer "leak" the mini-transaction.
      
      This fix was verified by RQG on 10.6 (depending on MDEV-371 that
      was introduced in 10.4). Unfortunately, it is challenging to
      create a regression test for this, and a test case could soon become
      invalid as more bugs in virtual column evaluation are fixed.
      a6d66fe7
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 356c1496
      Marko Mäkelä authored
      356c1496
    • Marko Mäkelä's avatar
      MDEV-25265: ALTER TABLE...IMPORT TABLESPACE fails after DROP INDEX · 2e67b9f6
      Marko Mäkelä authored
      A side effect of the MDEV-24589 bug fix is that if
      FLUSH TABLE...FOR EXPORT is initiated before the history of an
      earlier DROP INDEX operation has been purged, then the data file
      will contain allocated pages that belonged to the dropped indexes.
      These pages would never be freed after a subsequent IMPORT TABLESPACE.
      
      We will work around this regression by making IMPORT TABLESPACE
      tolerate pages that refer to an unknown index.
      2e67b9f6
  4. 25 Mar, 2021 5 commits
  5. 24 Mar, 2021 5 commits
  6. 23 Mar, 2021 13 commits
  7. 22 Mar, 2021 4 commits
    • Rucha Deodhar's avatar
      MDEV-21365: Check $MARIADB_HOME/my.cnf in addition to $MYSQL_HOME/my.cnf · 43ea3d25
      Rucha Deodhar authored
      Currently for the server, we only check if $MYSQL_HOME is set. Added a check
      if $MARIADB_HOME is set and try to read the configuration file from this
      directory. If $MARIADB_HOME is NULL, only then check $MYSQL_HOME.
      43ea3d25
    • Marko Mäkelä's avatar
      MDEV-23076 Misleading "InnoDB: using atomic writes" · 56274bd5
      Marko Mäkelä authored
      As suggested by Vladislav Vaintroub, let us remove misleading
      and malformatted startup messages.
      
      Even if the global variable srv_use_atomic_writes were set, we would
      still invoke my_test_if_atomic_write() to check if writes are atomic
      with a particular page size.
      
      When using the default innodb_page_size=16k, page writes should be
      atomic on NTFS when using ROW_FORMAT=COMPRESSED and KEY_BLOCK_SIZE<=4.
      
      Disabling srv_use_atomic_writes when innodb_file_per_table=OFF does
      not make sense, because that is a dynamic parameter.
      
      We also correct the documentation string of innodb_use_atomic_writes
      and remove the duplicate variable innobase_use_atomic_writes.
      56274bd5
    • Marko Mäkelä's avatar
      MDEV-22653: Remove the useless parameter innodb_simulate_comp_failures · 0f8caadc
      Marko Mäkelä authored
      The debug parameter innodb_simulate_comp_failures injected compression
      failures for ROW_FORMAT=COMPRESSED tables, breaking the pre-existing
      logic that I had implemented in the InnoDB Plugin for MySQL 5.1 to prevent
      compressed page overflows. A much better check is already achieved by
      defining UNIV_ZIP_COPY at the compilation time.
      (Only UNIV_ZIP_DEBUG is part of cmake -DWITH_INNODB_EXTRA_DEBUG=ON.)
      0f8caadc
    • Monty's avatar
      Fixed wrong usage strlen(), should be sizeof() · d902b53c
      Monty authored
      Found by running valgrind on mtr tests
      d902b53c