An error occurred fetching the project authors.
  1. 24 Mar, 2009 1 commit
    • Alexey Kopytov's avatar
      Fix for bug #43801: mysql.test takes too long, fails due to · 8d4d3e13
      Alexey Kopytov authored
                          expired timeout on debx86-b in PB 
      
      Moved the resource-intensive test case for bug #41486 into 
      a separate test file to reduce execution time for mysql.test. 
      
      
      mysql-test/include/wait_until_disconnected.inc:
        Used in mysql-bug41486.test.
      mysql-test/r/mysql-bug41486.result:
        Moved the resource-intensive test case for bug #41486 into 
        a separate test file to reduce execution time for mysql.test.
      mysql-test/r/mysql.result:
        Moved the resource-intensive test case for bug #41486 into 
        a separate test file to reduce execution time for mysql.test.
      mysql-test/t/mysql-bug41486.test:
        Moved the resource-intensive test case for bug #41486 into 
        a separate test file to reduce execution time for mysql.test.
      mysql-test/t/mysql.test:
        Moved the resource-intensive test case for bug #41486 into 
        a separate test file to reduce execution time for mysql.test.
      8d4d3e13
  2. 19 Mar, 2009 1 commit
  3. 18 Mar, 2009 1 commit
    • Alexey Kopytov's avatar
      Fix for bug#41486: extra character appears in BLOB for every · 73a7d993
      Alexey Kopytov authored
                         ~40Mb after mysqldump/import 
              
      When the input string exceeds the maximum allowed size for the 
      internal buffer, batch_readline() returns a truncated string. 
      Since there was no way for a caller to determine whether the 
      string was truncated or not, the command line client assumed 
      batch_readline() to always return the whole input string and 
      appended a newline character. This resulted in garbled data 
      when importing dumps containing strings longer than the 
      maximum input buffer size. 
        
      Fixed by adding a flag to the batch_readline() interface to 
      signal a truncated string to the caller. 
        
      Other minor problems fixed during patch implementation: 
       
      - The maximum allowed buffer size for batch_readline() was set 
      up depending on the client's max_allowed_packet value. It does 
      not actully make any sense, as those variables are not 
      related. The input buffer size limit is now always set to 1 
      MB. 
        
      - fill_buffer() did not always set the EOF flag. 
       
      - The input buffer could actually grow twice as the specified 
      limit due to insufficient checks in intern_read_line(). 
      
      client/my_readline.h:
        Changed the interface of batch_readline().
      client/mysql.cc:
        Honor the truncated flag returned by batch_readline() and do  
        not append the newline character if it was set. Since we can't 
        change the interfaces for readline()/fgets() used in the  
        interactive mode, always assume the returned string was not  
        truncated. In addition, always set the batch_readline()  
        internal buffer to 1 MB, independently from the client's  
        max_allowed_packet.
      client/readline.cc:
        Added the 'truncated' argument do batch_readline() to signal 
        truncated string to a caller. 
        Fixed fill_buffer() to set the EOF flag correctly. 
        Fixed checks in intern_read_line() to not allow the internal  
        buffer grow past the specified limit.
      mysql-test/r/mysql.result:
        Added a test case for bug #41486.
      mysql-test/t/mysql.test:
        Added a test case for bug #41486.
      73a7d993
  4. 24 Feb, 2009 1 commit
    • Georgi Kodinov's avatar
      Bug #31060: MySQL CLI parser bug 2 · 4b05db5c
      Georgi Kodinov authored
            
      There was a problem when a DELIMITER COMMAND is not the first 
      command on the line. I this case an extra line feed was added
      to the glob buffer and this was causing subsequent attempts 
      to enter this delimiter to fail.
      Fixed by not adding a new line to the glob buffer if the 
      command being added is a DELIMITER
      
      client/mysql.cc:
        Bug #31060: Don't add a new line if DELIMTER is added to
        the glob buffer
      mysql-test/r/mysql.result:
        Bug #31060: test case
      mysql-test/t/mysql.test:
        Bug #31060: test case
      4b05db5c
  5. 09 Jan, 2009 1 commit
    • Georgi Kodinov's avatar
      Bug #41437: Value stored in 'case' lacks charset, causes segfault · ac885d5d
      Georgi Kodinov authored
      When substituting system constant functions with a constant result
      the server was not expecting that the function may return NULL.
      Fixed by checking for NULL and returning Item_null (in the relevant
      collation) if the result of the system constant function was NULL.
      
      mysql-test/r/mysql.result:
        Bug #41437: test case
      mysql-test/t/mysql.test:
        Bug #41437: test case.
        Relies on database() returning NULL if no database is
        selected.
      sql/item_strfunc.cc:
        Bug #41437: Check for NULL result on evaluating the system
        constant function and return a constant NULL item.
      ac885d5d
  6. 11 Dec, 2008 1 commit
    • Chad MILLER's avatar
      Bug#33812: mysql client incorrectly parsing DELIMITER · d84690c9
      Chad MILLER authored
      Fix parsing of mysql client commands, especially in relation to
      single-line comments when --comments was specified.
      
      This is a little tricky, because we need to allow single-line
      comments in the middle of statements, but we don't want to allow
      client commands in the middle of statements. So in
      comment-preservation mode, we go ahead and send single-line
      comments to the server immediately when we encounter them on their
      own. 
      
      This is still slightly flawed, in that it does not handle a
      single-line comment with leading spaces, followed by a client-side
      command when --comment has been enabled. But this isn't a new
      problem, and it is quite an edge condition. Fixing it would require
      a more extensive overall of how the mysql client parses commands. 
      d84690c9
  7. 18 Jul, 2008 1 commit
    • Georgi Kodinov's avatar
      Bug 38158: mysql client regression, can't read dump files · 88d66418
      Georgi Kodinov authored
      - Revert the fix for bug 33812
      - fixed a win32 warning
      
      client/mysql.cc:
        revert the fix for bug 33812
      mysql-test/r/mysql.result:
        revert the fix for bug 33812
      mysql-test/t/mysql_delimiter.sql:
        revert the fix for bug 33812
      mysys/default.c:
        fixed a win32 warning
      88d66418
  8. 24 Jun, 2008 1 commit
    • Gleb Shchepa's avatar
      back-port from 5.1. · 2c77798c
      Gleb Shchepa authored
      Bug#33812: mysql client incorrectly parsing DELIMITER
            
      Remove unnecessary and incorrect code that tried
      to pull delimiter commands out of the middle of
      statements.
      2c77798c
  9. 04 Oct, 2007 1 commit
  10. 20 Sep, 2007 1 commit
    • unknown's avatar
      Bug#27747 database metadata doesn't return sufficient column default info · fac190a2
      unknown authored
      added get_field_default_value() function which obtains default value from the field
      (used in store_create_info() & get_schema_column_record() functions)
      
      
      mysql-test/r/alter_table.result:
        result fix
      mysql-test/r/create.result:
        result fix
      mysql-test/r/ctype_collate.result:
        result fix
      mysql-test/r/ctype_recoding.result:
        result fix
      mysql-test/r/default.result:
        result fix
      mysql-test/r/gis.result:
        result fix
      mysql-test/r/grant.result:
        result fix
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/r/key.result:
        result fix
      mysql-test/r/mysql.result:
        result fix
      mysql-test/r/ps_1general.result:
        result fix
      mysql-test/r/show_check.result:
        result fix
      mysql-test/r/sp.result:
        result fix
      mysql-test/r/type_enum.result:
        result fix
      mysql-test/r/type_ranges.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      fac190a2
  11. 30 Aug, 2007 1 commit
    • unknown's avatar
      Bug #30164: Using client side macro inside server side comments generates broken queries · bb986a24
      unknown authored
        
      Problem:
        
      In cases when a client-side macro appears inside a server-side comment, the add_line() function in mysql.cc discarded all characters until the next delimiter to remove macro arguments from the query string. This resulted in broken queries being sent to the server when the next delimiter character appeared past the comment's boundaries, because the comment closing sequence ('*/') was discarded.
        
      Fix:
        
      If a client-side macro appears inside a server-side comment, discard all characters in the comment after the macro (that is, until the end of the comment rather than the next delimiter).
      This is a minimal fix to allow only simple cases used by the mysqlbinlog utility. Limitations that are worth documenting:
        
      - Nested server-side and/or client-side comments are not supported by mysql.cc
      - Using client-side macros in multi-line server-side comments is not supported
      - All characters after a client-side macro in a server-side comment will be omitted from the query string (and thus, will not be sent to server).
      
      
      client/mysql.cc:
        If a client-side macro appears inside a server-side comment, discard all characters in the comment after the macro.
      mysql-test/r/mysql.result:
        Added a test case for bug #30164.
      mysql-test/t/mysql.test:
        Added a test case for bug #30164.
      bb986a24
  12. 23 Apr, 2007 1 commit
  13. 16 Apr, 2007 1 commit
    • unknown's avatar
      Fix for · be90800c
      unknown authored
      bug #27715: mysqld --character-sets-dir buffer overflow
      bug ##26851: Mysql Client --pager Buffer Overflow
      
      Using strmov() to copy an argument may cause overflow 
      if the argument's length is bigger than the buffer:
      use strmake instead.
      Also, we have to encrease the error message buffer size to fit 
      the longest message.
      
      
      client/mysql.cc:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
          - use strmake() instead of strmov() to avoid buffer overflow.
      mysql-test/r/mysql.result:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
        
          - test result.
      mysql-test/t/mysql.test:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
        
          - test case.
      mysys/charset.c:
        Fix for 
        bug #27715: mysqld --character-sets-dir buffer overflow
        bug ##26851: Mysql Client --pager Buffer Overflow
        
          - encrease error message buffer size to fit the (possible) longest message.
      be90800c
  14. 19 Feb, 2007 1 commit
    • unknown's avatar
      Bug#18743: Several test cases fails if "classic" configuration in 5.0 · db36a2aa
      unknown authored
      The problem happened because those tests were using "cp932" and "ucs2" without checking whether these character sets are available. This fix moves test parts to make character set specific parts be tested only if they are:
      - some parts were moved to "ctype_ucs.test" and "ctype_cp932.test"
      - some parts were moved to the newly added tests "innodb-ucs2.test", "mysqlbinglog-cp932.test" and "sp-ucs2.test"
      
      
      mysql-test/r/ctype_cp932.result:
        Moved cp932-specific test case from mysql.test
      mysql-test/r/innodb.result:
        Moved ucs2-specific test cases to innodb-ucs2.test
      mysql-test/r/mysql.result:
        Move cp932-specific test cases to ctype_cp932.test
      mysql-test/r/mysqlbinlog.result:
        Moved cp932-specific test case to mysqlbinlog-cp932.test
      mysql-test/r/sp.result:
        Moved ucs2-specific test case to sp-ucs2.test
      mysql-test/t/ctype_cp932.test:
        Moved cp932-specific test case from mysql.test
      mysql-test/t/ctype_ucs2_def-master.opt:
        Use the comma-separated list of character sets to avoid mysql-test errors when ucs2 is not available in the server
      mysql-test/t/ctype_ucs2_def.test:
        Added requirement for ucs2 in the server
      mysql-test/t/innodb.test:
        Moved ucs2-specific test cases to innodb-ucs2.test
      mysql-test/t/mysql.test:
        Move cp932-specific test cases to ctype_cp932.test
      mysql-test/t/mysqlbinlog.test:
        Moved cp932-specific test case to mysqlbinlog-cp932.test
      mysql-test/t/sp.test:
        Moved ucs2-specific test case to sp-ucs2.test
      sql/mysqld.cc:
        Allow specifying several character sets for test purposes, to make "mysqld" start even if the character set being tested is not compiled:
        mysqld --default-character-set=ucs2,latin1
        The first available character set will be chosen.
      mysql-test/r/innodb-ucs2.result:
        New BitKeeper file ``mysql-test/r/innodb-ucs2.result''
      mysql-test/r/mysqlbinlog-cp932.result:
        New BitKeeper file ``mysql-test/r/mysqlbinlog-cp932.result''
      mysql-test/r/sp-ucs2.result:
        New BitKeeper file ``mysql-test/r/sp-ucs2.result''
      mysql-test/t/innodb-ucs2.test:
        New BitKeeper file ``mysql-test/t/innodb-ucs2.test''
      mysql-test/t/mysqlbinlog-cp932.test:
        New BitKeeper file ``mysql-test/t/mysqlbinlog-cp932.test''
      mysql-test/t/sp-ucs2.test:
        New BitKeeper file ``mysql-test/t/sp-ucs2.test''
      db36a2aa
  15. 28 Nov, 2006 1 commit
  16. 22 Nov, 2006 3 commits
    • unknown's avatar
      Bug#19799 delimiter command not working correctly when sourcing a sql file · 1b3f04ca
      unknown authored
      - Use more appropriate test case.
      
      
      mysql-test/r/mysql.result:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - Alt. Result.
      mysql-test/t/mysql_delimiter.sql:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - Alt. Test
      1b3f04ca
    • unknown's avatar
      Bug#19799 delimiter command not working correctly when sourcing a sql file · bd82fb52
      unknown authored
      - Post Merge Fix.
      
      
      mysql-test/r/mysql.result:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - Post merge fix.
      bd82fb52
    • unknown's avatar
      Bug#19799 delimiter command not working correctly when sourcing a sql file · 0c7d10bd
      unknown authored
      - Client side readline functions unconditionally search for Unix '\n' line
      endings. In this case, the delimiter statement was set to '//\r' instead 
      of the intended '//'. When removing the '\n' check for and remove 
      preceeding '\r' character as well.
      
      
      client/readline.cc:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - When removing the '\n' character, check for and remove preceeding '\r' 
        character as well.
      mysql-test/r/mysql.result:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - Added Results.
      mysql-test/t/mysql_delimiter.sql:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - Added Tests.
      mysql-test/t/mysql_delimiter_19799.sql:
        Bug#19799 delimiter command not working correctly when sourcing a sql file
        - File containing delimiter statement followed by '\r\n' line ending.
      0c7d10bd
  17. 03 Nov, 2006 2 commits
  18. 26 Oct, 2006 1 commit
    • unknown's avatar
      Bug#20894 Reproducible MySQL client segmentation fault · 08d43705
      unknown authored
       - Add two null bytes in  "buff" variable allowing us to call
         get_arg two times also for strings longer than sizeof(buff) 
      
      
      client/mysql.cc:
        Make sure there are _two_ zero bytes at the end of buff, to allow 'get_arg' to be
        called twice on long strings. The first time it will mark end of string with a
        zero and the second time it will "skip ahead" to the first zero, and the find the
        second one indicating end of buff.
      mysql-test/r/mysql.result:
        Update test results
      mysql-test/t/mysql.test:
        Add tests for "com_connect" function in mysql
        Add test reported in bug
      08d43705
  19. 09 Oct, 2006 1 commit
  20. 02 Oct, 2006 1 commit
    • unknown's avatar
      Fix for Bug #21412 (client allows DELIMITER with backslash character) · 89220d07
      unknown authored
      BitKeeper/etc/ignore:
        Added mysql-test/t/tmp.test mysql-test/r/tmp.result client/tmp.diff to the ignore list
      client/mysql.cc:
        Fix for Bug #21412 (client allows DELIMITER with backslash)
      mysql-test/r/mysql.result:
        Added test case for Bug #21412
      mysql-test/t/mysql.test:
        Added test case for Bug #21412
      89220d07
  21. 13 Sep, 2006 1 commit
    • unknown's avatar
      Bug #21618: NULL shown as empty string in client · 306827a5
      unknown authored
      The column's NOT NULL flag doesn't affect what we should print.  Remove the
      wrong logic that does check it.
      
      Also, verify that this and the previous two tests print the same data as 
      other output formats.
      
      
      client/mysql.cc:
        Don't check the column's NOT NULL flag when determining whether to print 
        "NULL" or not.
      mysql-test/r/mysql.result:
        Add results and confirm that the other output forms give the same results
        for other similar tests.
      mysql-test/t/mysql.test:
        Add regression tests for this bug and two similar bugs.
      306827a5
  22. 06 Sep, 2006 1 commit
  23. 24 Aug, 2006 1 commit
    • unknown's avatar
      Bug #11972: client uses wrong character set after reconnect. · 689fae64
      unknown authored
      The mysql client uses the default character set on reconnect.  The default character set is now controled by the client charset command while the client is running.  The charset command now also issues a SET NAMES command to the server to make sure that the client's charset settings are in sync with the server's.
      
      
      client/mysql.cc:
        Client charset command now changes the default character set and issues a SET NAMES command to the server.
      mysql-test/r/mysql.result:
        Corrected results for new behaviour.
      mysql-test/t/mysql.test:
        Removed redundant commands from test.
      689fae64
  24. 16 Aug, 2006 1 commit
    • unknown's avatar
      Bug#20328 mysql client: dumb about trailing spaces on 'help' command · a707d490
      unknown authored
       Fix testcase to also work on windows
      
      
      BitKeeper/deleted/.del-mysql_client.test:
        Delete: mysql-test/t/mysql_client.test
      BitKeeper/deleted/.del-mysql_client.result:
        Delete: mysql-test/r/mysql_client.result
      mysql-test/r/mysql.result:
        Update test result
      mysql-test/t/mysql.test:
        Move tests from mysql_client to mysql
        Fix test case for bug#20328 to work on windows by comparing the output from "help" and "help "
      a707d490
  25. 02 Aug, 2006 1 commit
  26. 31 Jul, 2006 1 commit
    • unknown's avatar
      Bug#21042 mysql client segfaults on importing a mysqldump export · 71c896c2
      unknown authored
       - Use strmake, that will both protect the buffer and make sure it's terminated by a zero
       - Add test case
      
      
      client/mysql.cc:
        Use strmake instead of strxnmov as that function will make sure the string is terminated by 0
      mysql-test/r/mysql.result:
        Update test result
      mysql-test/t/mysql.test:
        Add test case
      71c896c2
  27. 24 Jul, 2006 1 commit
  28. 17 Jul, 2006 1 commit
    • unknown's avatar
      mysql.test, mysql.result: · 9a5daa60
      unknown authored
        Corrected the test case after fixing bug#10977
      
      
      mysql-test/t/mysql.test:
        Corrected the test case after fixing bug#10977
      mysql-test/r/mysql.result:
        Corrected the test case after fixing bug#10977
      9a5daa60
  29. 10 May, 2006 1 commit
    • unknown's avatar
      Bug#19564: mysql displays NULL instead of space · 2e72ae3d
      unknown authored
      Correct a bug (that I introduced, after using Oracle's database software for 
      too many years) where the length of the database-sent data is incorrectly 
      used to infer NULLness.
      
      
      client/mysql.cc:
        No longer use the length of the data to infer whether it is NULL or not.
      mysql-test/r/mysql.result:
        Add result and version marker, and correct previous result.
      mysql-test/t/mysql.test:
        Add test and version marker
      2e72ae3d
  30. 16 Apr, 2006 1 commit
    • unknown's avatar
      Only expand the empty string to the letters "NULL" if the column · 1e2bde0d
      unknown authored
      does not have "NOT NULL" attribute set.  Also, calculate the padding
      characters more safely, so that a negative number doesn't cause it to 
      print MAXINT-n spaces.
      
      
      mysql-test/r/mysql.result:
        Add test result.
      mysql-test/t/mysql.test:
        Add test.
      1e2bde0d
  31. 04 Apr, 2006 1 commit
    • unknown's avatar
      Bug#18265: mysql client: No longer right-justifies numeric columns · 0fae7e3b
      unknown authored
      Also fixes a new bug for which "NULL" wasn't printed (because the 
      data it represents has length zero).  (Discovered my Paul DuBois.)
      
      
      client/mysql.cc:
        Cleaned up the interactive-session table-printing function.
        
        - No longer rely on the length of the data to pad column boundries.
        - Be smarter about how we detect if the column is NULL.
        - Document how multibyte characters affect the output printing.
        - Use more descriptive variable names.
        
        More importantly, (re-)add these features that were crippled in an
        earlier change:
        - Print "NULL".
        - Right-justify numbers.
      mysql-test/r/mysql.result:
        Updated old result and added new case.
      mysql-test/t/mysql.test:
        Added new test case.
      0fae7e3b
  32. 03 Mar, 2006 1 commit
    • unknown's avatar
      Bug#16859 involves truncating column data at NUL characters. Instead, the · 21d6e172
      unknown authored
      client will now substitute spaces for NULs, so that the grid isn't messed up
      due to silently consumed NULs and that the full field is shown.
      
      
      client/mysql.cc:
        For non-numbers, print each character at a time, instead of using the 
        fprintf() facility, which interprets an array of chars as a C string, which 
        is necessarily NUL terminated.  We mustn't terminate on NULs, and since we 
        know the length of the data, we needn't.
      mysql-test/r/mysql.result:
        Add a test.
      mysql-test/t/mysql.test:
        Add a test.
      21d6e172
  33. 09 Feb, 2006 1 commit
    • unknown's avatar
      BUG#16217 forced to introduce a separate mysql client command to adopt its · e025e47a
      unknown authored
      internal charset to one associated with currently being handled query. 
      To note such a query can come from interactive client either.
      
      There was a discussion within replication team and Monty who's suggestion won.
      It avoids straightforward parsing of all `set' queries that could affect client side 
      character set. 
      According to the idea, mysql client does not parse `set' queries but rather cares of
      `charset new_cs_name' command.
      This command is generated by mysqlbinlog in form of exclaiming comment (Lars' suggestion)
      so that enlightened clients like `mysql' knows what to do with it.
      
      Interactive human can switch between many multi-byte charsets during the session 
      providing the command explicitly. 
      To note that setting new internal mysql's charset does not
      trigger sending any `SET' sql statement to the server. 
      
      
      client/mysql.cc:
        BUG#16217 revealed the problem of switching between charsets in mysql client.
        Such switching is necessary in a case when being scanned query consists of 
        multi-byte chars and internal charset was initialized differently. mysql finds 
        `/' escape and misiterprete it 
        while in fact one could be a part of a multi-byte symbol like the bug page reported. 
        
        This patch extends mysql `charset' command, '\C' shortcut.
      mysql-test/r/ctype_ucs_binlog.result:
        comment line generated by mysqlbinlog for processing of logs with multi-byte chars.
      mysql-test/r/mysql.result:
        results are altered due to #16217
      mysql-test/r/mysqlbinlog.result:
        Results are altered due to #16217
      mysql-test/r/mysqlbinlog2.result:
        commeted command for mysql client due to multi-byte binlog
      mysql-test/r/rpl_charset.result:
        commented command for mysql due to multi-byte binlogs
      mysql-test/r/rpl_timezone.result:
        commented command for mysql client due to multi-byte binlogs
      mysql-test/r/user_var-binlog.result:
        commented command for mysql client due to multi-byte binlogs
      mysql-test/t/mysql.test:
        Main test for mysql client is extended to check `charset' command.
      mysql-test/t/mysqlbinlog.test:
        Checking how /*! \C cs_name */ are added to the output of mysqlbinlog.
        The exclaiming comment is for further processing by mysql client.
        The added part mimics the failure to recover tables from binlog - see BUG#16217.
      sql/log_event.cc:
        Sending into output instructions for mysql client to switch internally 
        to appropriate charset.
        mysql client is supposed to be invoked with --default-character-set=
        "to default character set of the server created the binlog".
      e025e47a
  34. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · c807724f
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      c807724f
  35. 09 Aug, 2005 1 commit
    • unknown's avatar
      Fix 'source' command in mysql client to handle delimiter command · d2c97cde
      unknown authored
      in sourced file properly. (Bug #11523)
      
      
      client/mysql.cc:
        Rename read_lines() to read_and_execute() and change interface so it
        is clear when we are reading and processing lines interactively versus
        in batch mode or from a file being sourced.
      mysql-test/r/mysql.result:
        Add results
      mysql-test/t/mysql_delimiter.sql:
        Add new test
      mysql-test/t/mysql_delimiter_source.sql:
        New BitKeeper file ``mysql-test/t/mysql_delimiter_source.sql''
      d2c97cde
  36. 03 Jun, 2005 1 commit
    • unknown's avatar
      BUG#9998 MySQL client hangs on "USE database" · 1d6addd9
      unknown authored
       Use open_normal_and_derived_tables instead of open_and_lock_tables when reading metadata for a table.
       Add two test cases, one for "USE database" and one for "SHOW COLUMNS FROM table"
      
      
      mysql-test/r/lock_multi.result:
        Updated test results for test case for bug9998
      mysql-test/r/mysql.result:
        Updated results for test case for bug9998
      mysql-test/t/lock_multi.test:
        Test that "show columsn from t1" is not locked by another thread having a write lock on t1
      mysql-test/t/mysql.test:
        Add test case for BUG9998
          - lock table t1 for write from mysql-test, then execute 'mysql' and call "USE test". This will test exactly what caused the bug.
      sql/sql_show.cc:
        Open tables without locking when reading metadata
      1d6addd9
  37. 17 May, 2005 1 commit