1. 28 May, 2018 3 commits
  2. 27 May, 2018 4 commits
  3. 26 May, 2018 5 commits
  4. 25 May, 2018 3 commits
    • Andrei Elkin's avatar
      MDEV-13727 top-level query timestamp reset at stored func/trigger internal statements · 3bbc30c7
      Andrei Elkin authored
      Being executed under slow_log is ON the test revealed a "side-effect"
      in MDEV-8305 implementation which inadvertently made the trigger or
      stored function statements to reset the top-level query's
      THD::start_time et al. (Details of the test failure analysis are footnoted).
      Unlike the SP case the SF and Trigger's internal statement should not
      do that.
      
      Fixed with revising the MDEV-8305 decision to backup/reset/restore
      the session timestamp inside sp_instr_stmt::execute(). The timestamp
      actually remains reset in the SP case by its caller per statement basis by ever
      existing logics.
      
      Timestamps related tests are extended to cover the trigger and stored function case.
      
      Note, commit 3395ab73 is reverted as its struct QUERY_START_TIME_INFO
      declaration is not in use anymore after this patch.
      
      Footnote:
      --------
      Specifically to the failing test, a query on the master was logged
      okay with a timestamp of the query's top-level statement but its post
      update trigger managed to compute one more (later) timestamp which got
      inserted into another table. The latter table master-vs-slave
      no fractional part timestamp discrepancy became evident
      thanks to different execution time of the trigger combined with the
      fact of the logged with micro-second fractional part master timestamp
      was truncated on the slave. On master when the fractional part was
      close to 1 the trigger execution added up its own latency to overflow
      to next second value. That's how the master timestamp surprisingly
      turned out to bigger than the slave's one.
      3bbc30c7
    • Marko Mäkelä's avatar
      Make a test independent of VERSION · 83ec8c88
      Marko Mäkelä authored
      83ec8c88
    • Daniel Bartholomew's avatar
      bump the VERSION · c86ea540
      Daniel Bartholomew authored
      c86ea540
  5. 24 May, 2018 8 commits
  6. 23 May, 2018 6 commits
    • Elena Stepanova's avatar
      List of unstable tests for 10.3.7 release · 4a49f7f8
      Elena Stepanova authored
      The list was created based on 10.2.15 list, with the addition
      of failures and modifications which happened during the last week
      before the tentative 10.3.7 release commit
      4a49f7f8
    • Sergey Vojtovich's avatar
      Use std::isfinite in C++ code · 54999f4e
      Sergey Vojtovich authored
      This is addition to parent revision fixing build failures.
      54999f4e
    • Howard Su's avatar
      remove check for finite/isfinite · 031fa6d4
      Howard Su authored
      finite is not used anymore in code base. isfinite is part of C99 and we
      assume we only support compilers that support C99.
      031fa6d4
    • Eugene Kosov's avatar
      cleanup TABLE_LIST · c13e3c37
      Eugene Kosov authored
      c13e3c37
    • Sergei Petrunia's avatar
      MDEV-16262: rocksdb.issue255 test sometimes fails in buildbot · fdb8d018
      Sergei Petrunia authored
      Fix an obvious typo: replace_column should be applied to SHOW TABLE STATUS,
      not to SELECT * FROM t1.
      fdb8d018
    • Alexander Barkov's avatar
      MDEV-16244 sql_mode=ORACLE: Some keywords do not work in variable declarations · 611488e3
      Alexander Barkov authored
      1. Adding LEX::make_item_sysvar() and reusing it
         in sql_yacc.yy and sql_yacc_ora.yy.
         Removing the "opt_component" rule.
      
      2. Renaming rules to better reflect their purpose:
         - keyword to keyword_ident
         - keyword_sp to keyword_label
         - keyword_sp_not_data_type to keyword_sp_var_and_label
      
         Also renaming:
         - sp_decl_ident_keyword to keyword_sp_decl for naming consistency
         - keyword_alias to keyword_table_alias,
           for consistency with ident_table_alias
         - keyword_sp_data_type to keyword_data_type,
           as it has nothing SP-specific.
      
      3. Moving GLOBAL_SYM, LOCAL_SYM, SESSION_SYM from
         keyword_sp_var_and_label to a separate rule keyword_sysvar_type.
         We don't have system variables with these names anyway.
         Adding ident_sysvar_name and using it in the grammar that needs
         a system variable name instead of ident_or_text.
         This removed a number of shift/reduce conflicts
         between GLOBAL_SYM/LOCAL_SYM/SESSION_SYM as a variable scope and
         as a variable name.
      
      4. Moving keywords BEGIN_SYM, END (in both *.yy fiels)
         and EXCEPTION_SYM (in sql_yacc_ora.yy) into a separate
         rule keyword_sp_block_section, because in Oracle verb keywords
         (COMMIT, DO, HANDLER, OPEN, REPAIR, ROLLBACK, SAVEPOINT, SHUTDOWN, TRUNCATE)
         are good variables names and can appear in e.g. DECLARE,
         while block keywords (BEGIN, END, EXCEPTION) are not good variable names
         and cannot appear in DECLARE.
      
      5. Further splitting keyword_directly_not_assignable in sql_yacc_ora.yy:
         moving keyword_sp_verb_clause out. Renaming the rest of
         keyword_directly_not_assignable to keyword_sp_head,
         which represents keywords that can appear in optional
         clauses in CREATE PROCEDURE/FUNCTION/TRIGGER.
      
      6. Renaming keyword_sp_verb_clause to keyword_verb_clause,
         as now it does not contains anything SP-specific.
      
         As a result or #4,#5,#6, the rule keyword_directly_not_assignable
         was replaced to three separate rules:
         - keyword_sp_block
         - keyword_sp_head
         - keyword_verb_clause
         Adding the same rules in sql_yacc.yy, for unification.
      
      6. Adding keyword_sp_head and keyword_verb_clause into keyword_sp_decl.
         This fixes MDEV-16244.
      
      7. Reorganizing the rest of keyword related rules into two groups:
        a. Rules defining a list of keywords and consisting of only terminal symbols:
          - keyword_sp_var_not_label
          - keyword_sp_head
          - keyword_sp_verb_clause
          - keyword_sp_block_section
          - keyword_sysvar_type
      
        b. Rules that combine the above lists into keyword places:
          - keyword_table_alias
          - keyword_ident
          - keyword_label
          - keyword_sysvar_name
          - keyword_sp_decl
        Rules from the group "b" use on the right side only rules
        from the group "a" (with optional terminal symbols added).
        Rules from the group "b" DO NOT mutually use each other any more.
        This makes them easier to read (and see the difference between them).
      
        Sorting the right sides of the group "b" keyword rules alphabetically,
        for yet better readability.
      611488e3
  7. 22 May, 2018 11 commits