1. 08 Sep, 2006 1 commit
    • unknown's avatar
      Bug#21555: incorrect behavior with INSERT ... ON DUPL KEY UPDATE and VALUES · 54caf667
      unknown authored
       VALUES() was considered a constant. This caused replacing 
       (or pre-calculating) it using uninitialized values before the actual
       execution takes place.
       Mark it as a non-constant (still not dependent of tables) to prevent
       the pre-calculation.
      
      
      mysql-test/r/insert_update.result:
        Bug#21555: incorrect behavior with INSERT ... ON DUPL KEY UPDATE and VALUES
         - test case.
         - EXPLAIN output changed due to VALUES() not being considered a constant 
           anymore
      mysql-test/t/insert_update.test:
        Bug#21555: incorrect behavior with INSERT ... ON DUPL KEY UPDATE and VALUES
         - test case.
      sql/item.h:
        Bug#21555: incorrect behavior with INSERT ... ON DUPL KEY UPDATE and VALUES
         - mark Item_insert_value as non-constant to prevent early calculation.
      54caf667
  2. 05 Sep, 2006 2 commits
  3. 04 Sep, 2006 2 commits
    • unknown's avatar
      Bug #21392: multi-table delete with alias table name fails with · 1431966d
      unknown authored
                  1003: Incorrect table name
      in multi-table DELETE the set of tables to delete from actually 
      references then tables in the other list, e.g:
      DELETE alias_of_t1 FROM t1 alias_of_t1 WHERE ....
      is a valid statement.
      So we must turn off table name syntactical validity check for alias_of_t1 
      because it's not a table name (even if it looks like one).
      In order to do that we add a special flag (TL_OPTION_ALIAS) to 
      disable the name checking for the aliases in multi-table DELETE.
      
      
      mysql-test/r/delete.result:
        Bug #21392: multi-table delete with alias table name fails with
                    1003: Incorrect table name
         - test case
      mysql-test/t/delete.test:
        Bug #21392: multi-table delete with alias table name fails with
                    1003: Incorrect table name
         - test case
      sql/mysql_priv.h:
        Bug #21392: multi-table delete with alias table name fails with
                    1003: Incorrect table name
         - add a special flag to disable the name checking for the aliases
           in multi-table DELETE
      sql/sql_parse.cc:
        Bug #21392: multi-table delete with alias table name fails with
                    1003: Incorrect table name
         - add a special flag to disable the name checking for the aliases
           in multi-table DELETE
      sql/sql_yacc.yy:
        Bug #21392: multi-table delete with alias table name fails with
                    1003: Incorrect table name
         - add a special flag to disable the name checking for the aliases
           in multi-table DELETE
      1431966d
    • unknown's avatar
      BUG#21787: COUNT(*) + ORDER BY + LIMIT returns wrong result · 10395408
      unknown authored
      Fix an error in the bug fix.
      
      
      sql/sql_select.cc:
        Use a local variable to iterate over group items, since
        'group' is used later in a condition.
      10395408
  4. 01 Sep, 2006 6 commits
    • unknown's avatar
      Merge lamia.home:/home/timka/mysql/src/4.1-virgin · b133be17
      unknown authored
      into  lamia.home:/home/timka/mysql/src/4.1-bug-21787
      
      
      sql/sql_select.cc:
        Auto merged
      b133be17
    • unknown's avatar
      Fix for BUG#21787: COUNT(*) + ORDER BY + LIMIT returns wrong result · b017caef
      unknown authored
        
      The problem was due to a prior fix for BUG 9676, which limited
      the rows stored in a temporary table to the LIMIT clause. This
      optimization is not applicable to non-group queries with aggregate
      functions. The fix disables the optimization in this case.
      
      
      mysql-test/r/limit.result:
        Test case for BUG#21787
      mysql-test/t/limit.test:
        Test case for BUG#21787
      sql/sql_select.cc:
        If there is an aggregate function in a non-group query,
        materialize all rows in the temporary table no matter if
        there is a LIMIT clause. This is necessary, since the
        aggregate functions must be computed over all result rows,
        not just the first LIMIT rows.
      b017caef
    • unknown's avatar
      Backport from 5.0 · 49e2267e
      unknown authored
       - Dont test "encrypt" in ctype_ucs
      
      
      mysql-test/r/ctype_ucs.result:
        Don't test "encrypt" function in ctype_ucs.test
      mysql-test/t/ctype_ucs.test:
        Don't test "encrypt" function in ctype_ucs.test
      49e2267e
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1-maint · 6453d413
      unknown authored
      into  shellback.(none):/home/msvensson/mysql/mysql-4.1-maint
      
      
      6453d413
    • unknown's avatar
      Add target to make "mtr", shortcut for running test suite · 1bb1679c
      unknown authored
      
      BitKeeper/etc/ignore:
        Added mysql-test/mtr to the ignore list
      1bb1679c
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1-maint · f6aec93d
      unknown authored
      into  rama.(none):/home/jimw/my/mysql-4.1-21288
      
      
      f6aec93d
  5. 31 Aug, 2006 3 commits
  6. 30 Aug, 2006 8 commits
    • unknown's avatar
      Merge maint2.mysql.com:/data/localhome/tsmith/bk/g41 · 0f342b6a
      unknown authored
      into  maint2.mysql.com:/data/localhome/tsmith/bk/41
      
      
      0f342b6a
    • unknown's avatar
      Merge maint2.mysql.com:/data/localhome/tsmith/bk/bfx/41 · f468d000
      unknown authored
      into  maint2.mysql.com:/data/localhome/tsmith/bk/41
      
      
      BUILD/SETUP.sh:
        Auto merged
      f468d000
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug04053/my40-bug04053 · 8fb0f8a2
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/bug04053/my41-bug04053
      
      
      mysys/my_read.c:
        Auto merged
      8fb0f8a2
    • unknown's avatar
      Bug#4053: too many of "error 1236: 'binlog truncated in the middle of \ · 626abc52
      unknown authored
      	event' from master"
      
      Since there is no repeatable test case, and this is obviously wrong, this is
      the most conservative change that might possibly work.  
      
      The syscall  read()  wasn't checked for a negative return value for an
      interrupted read.  The kernel  sys_read()  returns -EINTR, and the "library" 
      layer maps that to return value of -1 and sets  errno  to EINTR.  It's 
      impossible (on Linux) for  read()  to set errno EINTR without the return 
      value being -1 .
      
      So, if we're checking for EINTR behavior, we should not require that the
      return value be zero.
      
      
      mysys/my_read.c:
        The read() syscall should check for negative one, since that (usually) signals
        errors (like being interrupted) and zero (usually) signals end-of-file .
      626abc52
    • unknown's avatar
    • unknown's avatar
      portability fix in BUILD/* for solaris · 71583c89
      unknown authored
      71583c89
    • unknown's avatar
      Merge maint2.mysql.com:/data/localhome/tsmith/bk/bfx/40 · 4321eb12
      unknown authored
      into  maint2.mysql.com:/data/localhome/tsmith/bk/bfx/41
      
      
      BUILD/SETUP.sh:
        SCCS merged
      4321eb12
    • unknown's avatar
      Bug#20393 User name truncation in mysql client · ddb9f866
      unknown authored
      Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
      
      
      include/mysql_com.h:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        added new constants NAME_BYTE_LEN, USERNAME_BYTE_LENGTH, SYSTEM_CHARSET_MBMAXLEN
      mysql-test/r/ctype_utf8.result:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        test case
      mysql-test/t/ctype_utf8.test:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        test case
      sql-common/client.c:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        increased buffers for user name & db
      sql/sql_acl.cc:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        check that user name is not longer than USERNAME_LENGTH symbols
      sql/sql_parse.cc:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        increased buffers for user name & db
      sql/table.cc:
        Bug#20393 User name truncation in mysql client
        Bug#21432 Database/Table name limited to 64 bytes, not chars, problems with multi-byte
        check that db name is not longer than NAME_LEN symbols
      ddb9f866
  7. 29 Aug, 2006 1 commit
  8. 28 Aug, 2006 2 commits
  9. 27 Aug, 2006 1 commit
  10. 26 Aug, 2006 2 commits
  11. 25 Aug, 2006 6 commits
  12. 24 Aug, 2006 6 commits
    • unknown's avatar
      BUG#16255: Post-review fixes: adjust the testcase. · f895a16c
      unknown authored
      
      mysql-test/r/subselect.result:
        BUG#16255: A proper testcase
      mysql-test/t/subselect.test:
        BUG#16255: A proper testcase
      f895a16c
    • unknown's avatar
      Bug #16255: Subquery in WHERE (the cset by Georgi Kodinov) · c74c8195
      unknown authored
       Must not use Item_direct_ref in HAVING because it points to
       the new value (witch is not yet calculated for the first row).
      
      
      mysql-test/r/subselect.result:
        Bug #16255: Subquery in where
         - test case
      mysql-test/t/subselect.test:
        Bug #16255: Subquery in where
         - test case
      sql/item_subselect.cc:
        Bug #16255: Subquery in where
         Must not use Item_direct_ref in HAVING because it points to
         the new value (witch is not yet calculated for the first row).
      c74c8195
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/bug17194/my41-bug17194 · 91c9600b
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-4.1-maint
      
      
      support-files/mysql.spec.sh:
        Auto merged
      91c9600b
    • unknown's avatar
      Merge tim@tsmith.mysql.internal:m/bk/41 · 95f8e047
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/41
      
      
      95f8e047
    • unknown's avatar
      Merge siva.hindu.god:/usr/home/tim/m/bk/b21531-41 · 66d91348
      unknown authored
      into  siva.hindu.god:/usr/home/tim/m/bk/41
      
      
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      66d91348
    • unknown's avatar
      Bug #21531: EXPORT_SET() doesn't accept args with coercible character sets · b2a0d025
      unknown authored
      - Fix typo in Item_func_export_set::fix_length_and_dec() which caused character set aggregation to fail
      - Remove default argument from last arg of agg_arg_charsets() function, to reduce potential errors
      
      
      mysql-test/r/func_misc.result:
        Test EXPORT_SET() with charset coersion (bug #21531)
      mysql-test/t/func_misc.test:
        Test EXPORT_SET() with charset coersion (bug #21531)
      sql/item_func.h:
        Remove default argument from last arg of agg_arg_charsets() function, to reduce potential errors.
      sql/item_strfunc.cc:
        Fix typo in Item_func_export_set::fix_length_and_dec() which caused character set aggregation to fail.
      b2a0d025