An error occurred fetching the project authors.
  1. 21 Nov, 2006 1 commit
    • unknown's avatar
      ndb - bug#24447 · 537f7c10
      unknown authored
        api disconnect just after SCAN_TABREQ
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        1) add error insert for faking DISCONNECT of API just after SCAN_TABREQ
        2) handle error :-)
      ndb/test/ndbapi/testScan.cpp:
        Add etstcase for bug 24447
      ndb/test/run-test/daily-basic-tests.txt:
        Add etstcase for bug 24447
      537f7c10
  2. 26 Sep, 2006 1 commit
    • unknown's avatar
      ndb - bug#22672 · 63f72ecc
      unknown authored
        handle also CS_CONNECTED as "abort" in handleFailedApi to keep from falling on assertion in releaseApiCon
          in case of committed dirtyRead
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        handle also CS_CONNECTED as "abort" to keep from falling on assertion in releaseApiCon
          in case of committed dirtyRead
      63f72ecc
  3. 01 Aug, 2006 1 commit
    • unknown's avatar
      ndb - bug#21384 · a88f5071
      unknown authored
        handle error in TCKEYREQ during TCINDXREQ better
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        new error code
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Add 3 values to isIndexOp
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        handle error in TCKEYREQ during TCINDXREQ
      ndb/test/ndbapi/testIndex.cpp:
        Add testcase
      ndb/test/run-test/daily-basic-tests.txt:
        Add testcase
      a88f5071
  4. 21 Jun, 2006 1 commit
    • unknown's avatar
      ndb - bug#20197 · 4ffb274b
      unknown authored
        also close scan which are in "delivered" state, as it's impossible to release locks afterwards
      
        backport from 5.1
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        ndb - bug#20197
          also close scan which are in "delivered" state, as it's impossible to release locks afterwards
      4ffb274b
  5. 01 Jun, 2006 1 commit
    • unknown's avatar
      ndb - bug#20185 · 0eb906ef
      unknown authored
        Dont be too aggressive in Dbtc::nodeFailCheckTransaction
        let it timeout by 1, so that it does not assert that it has waited too long
        old impl. set timeotu value to 0, making timeout = (ctcTimer - 0) which could be quite big.
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        error codes
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        2 new error inserts
        7030 - delay in GCP_PREPARE until checkLocalNodefailComplete is true
        7031 - delay in GCP_PREPARE and die
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Dont set api con timer to 0, as this might trigger asserion in timeoutfound lab if state == PREPARE_TO_COMMIT
      ndb/test/ndbapi/testNodeRestart.cpp:
        testcase
      ndb/test/run-test/daily-basic-tests.txt:
        autotest
      0eb906ef
  6. 25 Apr, 2006 1 commit
    • unknown's avatar
      ndb - bug#18597 · 17741f9c
      unknown authored
        Handle early abort of scan, so that resources are correctly freed
      
      
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Handle early abort
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Handle early abort so that require on running.empty() does not fire
      17741f9c
  7. 22 Mar, 2006 1 commit
    • unknown's avatar
      ndb - bug#18414 · 55faad67
      unknown authored
        Fix timeout during ABORT when ZABORT_TIMEOUT_BREAK is outstanding
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        New error code
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        remove dumping of LCP info during NF
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Fix timeout during ABORT when ZABORT_TIMEOUT_BREAK is outstanding
      ndb/test/ndbapi/testNodeRestart.cpp:
        Add testcase for bug18414
      ndb/test/ndbapi/testTimeout.cpp:
        Fix error code checking
      ndb/test/run-test/daily-basic-tests.txt:
        Add testcase for bug18414
      55faad67
  8. 20 Mar, 2006 2 commits
    • unknown's avatar
      ndb - wl2610, bug#18352 · bdc9de60
      unknown authored
        Remove useless and tricky state fiddleing in TC
          to syncronize NF_CompleteRep as code is already present in DIH aswell
        Keep broadcast of TAKEOVER_TCCONF for online upgrade
      
      
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Add clever dump for showing active operations
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Remove useless and tricky state fiddleing in TC
          to syncronize NF_CompleteRep as code is already present in DIH aswell
          Keep broadcast of TAKEOVER_TCCONF for online upgrade
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Remove useless and tricky state fiddleing in TC
          to syncronize NF_CompleteRep as code is already present in DIH aswell
          Keep broadcast of TAKEOVER_TCCONF for online upgrade
      bdc9de60
    • unknown's avatar
      ndb - wl2610 · eb61f47c
      unknown authored
        Activly abort transactions (that's affected) during NF
        This removes a lot of bugs that can occur otherwise is using
          high value for TransactionDeadLockTimout
      
      
      ndb/include/kernel/signaldata/TcContinueB.hpp:
        New continueb for active transaction abort on nf
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        Add bitmask of participating nodes to transaction record
        Add bitmask of node fail steps, so that NF_CompleteRep is not sent until all steps has completed
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Active transaction baortion
      eb61f47c
  9. 12 Dec, 2005 1 commit
    • unknown's avatar
      ndb - bug#15685 · b00fbda2
      unknown authored
        Error in abort handling in TC when timeout during abort
        
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        New error codes
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        New error codes
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Dont release transaction record to early
      ndb/test/ndbapi/testNodeRestart.cpp:
        Test case
      ndb/test/run-test/daily-basic-tests.txt:
        Test case
      b00fbda2
  10. 21 Oct, 2005 1 commit
  11. 15 Sep, 2005 1 commit
    • unknown's avatar
      ndb - bug#9994 backpatch fixes from 5.0 · 73f0ed05
      unknown authored
            IGNORE on merge 4.1->5.0
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        bug#9994 backpatch fixes from 5.0
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        bug#9994 backpatch fixes from 5.0
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        bug#9994 backpatch fixes from 5.0
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        bug#9994 backpatch fixes from 5.0
      ndb/src/kernel/blocks/dbtup/DbtupTrigger.cpp:
        bug#9994 backpatch fixes from 5.0
      73f0ed05
  12. 02 Sep, 2005 1 commit
    • unknown's avatar
      ndb - bug#12608 · a4337300
      unknown authored
        Always abort if node failure occured between startTransaction and commit
        (can later be improved by wl#2610)
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Always abort if node failure occured between startTransaction and commit
      a4337300
  13. 18 Aug, 2005 1 commit
    • unknown's avatar
      bug#12118 - ndb alter table data loss · 337fa5e1
      unknown authored
        Split table version into 2 (major, minor)
        Impl. signaling to API when table has been altered
        Allow running transactions to use any minor number for transactions
      
      
      mysql-test/r/ndb_alter_table.result:
        Allow running transactions to use old table definition when possible.
      mysql-test/t/ndb_alter_table.test:
        Allow running transactions to use old table definition when possible.
      ndb/include/kernel/BlockNumbers.h:
        remove GREP
      ndb/include/kernel/GlobalSignalNumbers.h:
        Add ALTER_TABL_REP and API_BROADCAST_REP
      ndb/include/kernel/kernel_types.h:
        table_version_major
      ndb/include/kernel/signaldata/AlterTable.hpp:
        New error code for alter table during rolling upgrade
      ndb/include/ndbapi/NdbDictionary.hpp:
        Add state on table object to represent an altered but still valid table object
      ndb/src/common/debugger/BlockNames.cpp:
        remove GREP
      ndb/src/common/util/version.c:
        Fix upgrades
      ndb/src/kernel/SimBlockList.cpp:
        remove GREP
      ndb/src/kernel/blocks/Makefile.am:
        remove GREP
      ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        remove GREP
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Split tableSchemaVersion into 2 part
        24 bit real version
         8 bit for online alter table where old table definition is still usable
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Check for same ndb versions
      ndb/src/kernel/blocks/dbdict/printSchemaFile.cpp:
        Update schema printer
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        remove grep
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        1) Use table_ version_major when checking table version
        2) Dummy fix for BUG that tableSchemaVersion is only 16 bit in LQHKEYREQ
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        1) Use table_ version_major when checking table version
        2) Dummy fix for BUG that tableSchemaVersion is only 16 bit in LQHKEYREQ
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        1) Use table_ version_major when checking table version
        2) Dummy fix for BUG that tableSchemaVersion is only 16 bit in LQHKEYREQ
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        remove GREP
      ndb/src/kernel/blocks/qmgr/Qmgr.hpp:
        Add support for sending REP to ALL api nodes
      ndb/src/kernel/blocks/qmgr/QmgrInit.cpp:
        Add support for sending REP to ALL api nodes
      ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Add support for sending REP to ALL api nodes
      ndb/src/kernel/blocks/suma/Suma.cpp:
        remove GREP
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        remove GREP
      ndb/src/ndbapi/DictCache.cpp:
        Add support for alter_table_rep
          by setting status to Altered
        
        NOTE special handling of tables in state RETREIVING
      ndb/src/ndbapi/DictCache.hpp:
        Add support for alter_table_rep
          by setting status to Altered
        
        NOTE special handling of tables in state RETREIVING
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Change alter table so that remove from global cache is used wo/ retreiving it from there first
          as ALTER_TABLE_REP might already have changed the table object...
      ndb/src/ndbapi/TransporterFacade.cpp:
        Add support for ALTER_TABLE_REP
      sql/ha_ndbcluster.cc:
        Allow running transactions to use tables in state ALTERED...but new transactions may not...
      ndb/include/kernel/signaldata/ApiBroadcast.hpp:
        New BitKeeper file ``ndb/include/kernel/signaldata/ApiBroadcast.hpp''
      337fa5e1
  14. 13 Jun, 2005 1 commit
    • unknown's avatar
      logging_ok: · fa405f97
      unknown authored
        Logging to logging@openlogging.org accepted
      DbtcMain.cpp, testTimeout.cpp:
        Bug  #11290 TransactionInactiveTimeout = 0 does not result in infinite timeout
      
      
      ndb/test/ndbapi/testTimeout.cpp:
        Bug  #11290 TransactionInactiveTimeout = 0 does not result in infinite timeout
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Bug  #11290 TransactionInactiveTimeout = 0 does not result in infinite timeout
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      fa405f97
  15. 05 May, 2005 1 commit
    • unknown's avatar
      bug#10142 - ndb unique index · 5e56e620
      unknown authored
        post review fixes
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        remove printout
        abort transaction instead of operation.
          concider m_exec_flag
      5e56e620
  16. 03 May, 2005 1 commit
    • unknown's avatar
      bug#10142 - ndb unhandle resource shortage in unique index code · f603ef43
      unknown authored
      ndb/src/kernel/blocks/dbtc/Dbtc.hpp:
        remove unneccessary TcSeizedIndexOperation object
      ndb/src/kernel/blocks/dbtc/DbtcInit.cpp:
        remove unneccessary TcSeizedIndexOperation object
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        1) Set transid on starting TCINDXREQ
        2) New error code for out of index operation records
        3) Check accumulating index op for RNIL before dereferencing it
      ndb/src/kernel/error/ErrorReporter.cpp:
        Include NDB version in ndb_X_error.log
      ndb/src/ndbapi/NdbIndexOperation.cpp:
        Let failed tcindxreq abort
      ndb/src/ndbapi/ndberror.c:
        New error code for out of index operation records
      f603ef43
  17. 20 Apr, 2005 1 commit
  18. 03 Mar, 2005 3 commits
  19. 01 Mar, 2005 1 commit
    • unknown's avatar
      bug#8853 - ndb - commit after nodefailure on not TC node · a0ba1e9a
      unknown authored
        set exec_flag in execTC_COMMITREQ so that api will get rollbackrep
      
      
      ndb/include/ndbapi/NdbConnection.hpp:
        Make getConnectedNode public
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Fix TC_COMMITREQ in abort cases
      ndb/test/ndbapi/testNodeRestart.cpp:
        Testcase for bug#8853
      ndb/test/run-test/daily-devel-tests.txt:
        Testcase for bug#8853
      a0ba1e9a
  20. 06 Feb, 2005 1 commit
    • unknown's avatar
      bug8262 - ndb · da00a33c
      unknown authored
        crash if scan is poped from queue before all attrinfo has arrived
      
      
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        only restart scan if all attrinfo has arrived
        otherwise just set remove from queue and set state
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        new error insert - force send attrinfo
      ndb/test/ndbapi/testScan.cpp:
        new test bug8262 many threads - scanning small tables
      ndb/test/run-test/daily-basic-tests.txt:
        run new test case in autotest
      da00a33c
  21. 20 Jan, 2005 1 commit
    • unknown's avatar
      bug#8010 - ndb · 24030efb
      unknown authored
        release connections when last op was simple read
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        bug#8010
          release connections when last op was simple read
      24030efb
  22. 11 Jan, 2005 1 commit
  23. 21 Nov, 2004 1 commit
    • unknown's avatar
      wl2077 - ndb close scan - fix introduced bugs wrt premature close of scan · c292027d
      unknown authored
      ndb/src/common/debugger/signaldata/ScanTab.cpp:
        Fix printout
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Handle already closed fragments
      ndb/src/ndbapi/NdbConnectionScan.cpp:
        Better handling of SCAN_TABREF
      ndb/src/ndbapi/NdbScanOperation.cpp:
        Removed some special cases by setting up them instead
      ndb/test/src/NDBT_Test.cpp:
        Fix createTable(false)
      ndb/tools/select_all.cpp:
        Use full scan as default
      c292027d
  24. 19 Nov, 2004 3 commits
    • unknown's avatar
      wl2077: ndb, disable scanning of backup fragments · 3b282393
      unknown authored
        (temporary)
      
      3b282393
    • unknown's avatar
      wl2077 - scan optimizations · a646f58b
      unknown authored
      (recommit in clean clone)
      
      
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        removed unused variable
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Always give all nodes in DIGETPRIMREQ
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Allow readcommited-scans to scan backup fragments
      ndb/test/ndbapi/testReadPerf.cpp:
        better printous
      a646f58b
    • unknown's avatar
      wl2077 - ndb scan optimizations · 0d75bf43
      unknown authored
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        remove unused variable
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Always supply all nodes
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Enable scanning of backup fragments when read committed
      ndb/test/ndbapi/testReadPerf.cpp:
        Better printout
      0d75bf43
  25. 18 Nov, 2004 1 commit
  26. 09 Nov, 2004 1 commit
    • unknown's avatar
      wl1744 - win compile fixes · 6b93977f
      unknown authored
      ndb/include/kernel/signaldata/RepImpl.hpp:
        more win-compile-fixes
      ndb/include/mgmapi/mgmapi.h:
        more win-compile-fixes
      ndb/include/ndbapi/NdbConnection.hpp:
        more win-compile-fixes
      ndb/src/common/util/Properties.cpp:
        more win-compile-fixes
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        more win-compile-fixes
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        more win-compile-fixes
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        more win-compile-fixes
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        more win-compile-fixes
      ndb/src/kernel/blocks/grep/Grep.cpp:
        more win-compile-fixes
      ndb/src/mgmsrv/Config.cpp:
        more win-compile-fixes
      ndb/src/mgmsrv/ConfigInfo.cpp:
        more win-compile-fixes
      ndb/src/mgmsrv/InitConfigFileParser.cpp:
        more win-compile-fixes
      ndb/src/ndbapi/NdbBlob.cpp:
        more win-compile-fixes
      ndb/src/ndbapi/NdbConnection.cpp:
        more win-compile-fixes
      ndb/src/ndbapi/NdbImpl.hpp:
        more win-compile-fixes
      ndb/src/ndbapi/NdbOperationExec.cpp:
        more win-compile-fixes
      ndb/test/ndbapi/testOperations.cpp:
        more win-compile-fixes
      sql/ha_ndbcluster.cc:
        more win-compile-fixes
      6b93977f
  27. 21 Oct, 2004 1 commit
  28. 13 Oct, 2004 1 commit
    • unknown's avatar
      testBasic -n NoCommit626 · 6c780a65
      unknown authored
      Handle commit of zero operations
      
      
      ndb/test/ndbapi/testBasic.cpp:
        Update usage of HugoOperattions::pkReadRecord
        More test for IgnoreError
      6c780a65
  29. 11 Oct, 2004 1 commit
    • unknown's avatar
      wl1801 - more node failure handling in simple/dirty read · 460cb353
      unknown authored
      ndb/include/kernel/signaldata/TcContinueB.hpp:
        Test NODE_FAILREP arraving before TCKEYCONF w.r.t simple/dirty read
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Test NODE_FAILREP arraving before TCKEYCONF w.r.t simple/dirty read
      ndb/src/ndbapi/NdbConnection.cpp:
        Test NODE_FAILREP arraving before TCKEYCONF w.r.t simple/dirty read
      ndb/src/ndbapi/Ndbif.cpp:
        Test NODE_FAILREP arraving before TCKEYCONF w.r.t simple/dirty read
      ndb/test/ndbapi/testNodeRestart.cpp:
        Test NODE_FAILREP arraving before TCKEYCONF w.r.t simple/dirty read
      460cb353
  30. 08 Oct, 2004 3 commits
    • unknown's avatar
      wl 1801 · a50ec676
      unknown authored
       Testcases for NF
      
      
      ndb/src/kernel/blocks/ERROR_codes.txt:
        Error insert for testing NF handling of committed read
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Error insert for testing NF handling of committed read
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Error insert for testing NF handling of committed read
      ndb/test/include/NDBT_Test.hpp:
        Move sync methods into NDBT_Context
      ndb/test/ndbapi/testIndex.cpp:
        Move sync methods into NDBT_Context
      ndb/test/ndbapi/testNodeRestart.cpp:
        Add test case that verifies committed read during NF
      ndb/test/src/NDBT_Test.cpp:
        Move sync methods into NDBT_Context
      a50ec676
    • unknown's avatar
      Test prg update · 1996eb65
      unknown authored
      - make test node restart test harder
      
      
      ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Removed debug printout
      ndb/test/include/HugoOperations.hpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/include/HugoTransactions.hpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/ndbapi/testBasic.cpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/ndbapi/testNdbApi.cpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/ndbapi/testNodeRestart.cpp:
        Use mixed pkread
        Use rand() no of records
        Use rand() batch size
        Restart node abort (instead of graceful)
      ndb/test/ndbapi/testOperations.cpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/ndbapi/testTransactions.cpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/run-test/daily-devel-tests.txt:
        Run mixed pkread tests instead of just LM_Read (readTuple())
      ndb/test/src/HugoOperations.cpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      ndb/test/src/HugoTransactions.cpp:
        Remove multipl pkRead (simple/dirty)... and replace
          with pkRead(LockMode)
      1996eb65
    • unknown's avatar
      Fix simple/dirty read handling · 103ca57c
      unknown authored
      ndb/include/kernel/signaldata/TcKeyConf.hpp:
        A bit for differenciating between "real" tckey conf and simple read conf
      ndb/include/ndbapi/Ndb.hpp:
        Removed/ifdef's unused stuff
      ndb/include/ndbapi/NdbConnection.hpp:
        Added bitmask that keeps track of used nodes when
          a transaction can be dependant on several nodes
      ndb/include/ndbapi/NdbOperation.hpp:
        removed unused methods
      ndb/include/ndbapi/NdbReceiver.hpp:
        Tween execTCOPCONF to handle TcKeyConf::SimpleReadBit
      ndb/src/common/debugger/signaldata/TcKeyConf.cpp:
        Update printer
      ndb/src/kernel/blocks/dblqh/Dblqh.hpp:
        removed unused define
      ndb/src/ndbapi/NdbApiSignal.cpp:
        Fix length of TC_COMMITREQ
      ndb/test/ndbapi/testOperations.cpp:
        fix simple/dirty read
      103ca57c
  31. 06 Oct, 2004 3 commits