An error occurred fetching the project authors.
  1. 09 Jun, 2022 1 commit
  2. 19 May, 2022 1 commit
  3. 08 Apr, 2022 2 commits
  4. 31 Mar, 2022 1 commit
  5. 10 Mar, 2022 1 commit
  6. 11 Feb, 2022 2 commits
  7. 10 Feb, 2022 12 commits
  8. 26 Jan, 2022 1 commit
  9. 24 Jan, 2022 1 commit
  10. 20 Jan, 2022 1 commit
  11. 15 Jan, 2022 3 commits
  12. 19 Oct, 2021 1 commit
    • Nayuta Yanagisawa's avatar
      MDEV-26158 SIGSEGV in spider_free_mem from ha_spider::open on INSERT · e7208bd9
      Nayuta Yanagisawa authored
      The server crashes due to passing NULL to spider_free().
      
      In some cases, this == pt_handler_share_handlers[0] at the label
      error_get_share in ha_spider::open().
      
      In such cases, to nullify pt_handler_share_handlers[0]->wide_handler
      is nothing but to nullify this->wide_handler. We should not do this
      before freeing this->wide_handler.
      e7208bd9
  13. 21 Apr, 2021 1 commit
    • Vicențiu Ciorbaru's avatar
      cleanup: Refactor select_limit in select lex · 13cf8f5e
      Vicențiu Ciorbaru authored
      Replace
        * select_lex::offset_limit
        * select_lex::select_limit
        * select_lex::explicit_limit
      with select_lex::Lex_select_limit
      
      The Lex_select_limit already existed with the same elements and was used in
      by the yacc parser.
      
      This commit is in preparation for FETCH FIRST implementation, as it
      simplifies a lot of the code.
      
      Additionally, the parser is simplified by making use of the stack to
      return Lex_select_limit objects.
      
      Cleanup of init_query() too. Removes explicit_limit= 0 as it's done a bit later
      in init_select() with limit_params.empty()
      13cf8f5e
  14. 26 Jan, 2021 1 commit
    • Nikita Malyavin's avatar
      MDEV-17556 Assertion `bitmap_is_set_all(&table->s->all_set)' failed · 21809f9a
      Nikita Malyavin authored
      The assertion failed in handler::ha_reset upon SELECT under
      READ UNCOMMITTED from table with index on virtual column.
      
      This was the debug-only failure, though the problem is mush wider:
      * MY_BITMAP is a structure containing my_bitmap_map, the latter is a raw
       bitmap.
      * read_set, write_set and vcol_set of TABLE are the pointers to MY_BITMAP
      * The rest of MY_BITMAPs are stored in TABLE and TABLE_SHARE
      * The pointers to the stored MY_BITMAPs, like orig_read_set etc, and
       sometimes all_set and tmp_set, are assigned to the pointers.
      * Sometimes tmp_use_all_columns is used to substitute the raw bitmap
       directly with all_set.bitmap
      * Sometimes even bitmaps are directly modified, like in
      TABLE::update_virtual_field(): bitmap_clear_all(&tmp_set) is called.
      
      The last three bullets in the list, when used together (which is mostly
      always) make the program flow cumbersome and impossible to follow,
      notwithstanding the errors they cause, like this MDEV-17556, where tmp_set
      pointer was assigned to read_set, write_set and vcol_set, then its bitmap
      was substituted with all_set.bitmap by dbug_tmp_use_all_columns() call,
      and then bitmap_clear_all(&tmp_set) was applied to all this.
      
      To untangle this knot, the rule should be applied:
      * Never substitute bitmaps! This patch is about this.
       orig_*, all_set bitmaps are never substituted already.
      
      This patch changes the following function prototypes:
      * tmp_use_all_columns, dbug_tmp_use_all_columns
       to accept MY_BITMAP** and to return MY_BITMAP * instead of my_bitmap_map*
      * tmp_restore_column_map, dbug_tmp_restore_column_maps to accept
       MY_BITMAP* instead of my_bitmap_map*
      
      These functions now will substitute read_set/write_set/vcol_set directly,
      and won't touch underlying bitmaps.
      21809f9a
  15. 08 Jan, 2021 1 commit
    • Nikita Malyavin's avatar
      MDEV-17556 Assertion `bitmap_is_set_all(&table->s->all_set)' failed · e25623e7
      Nikita Malyavin authored
      The assertion failed in handler::ha_reset upon SELECT under
      READ UNCOMMITTED from table with index on virtual column.
      
      This was the debug-only failure, though the problem is mush wider:
      * MY_BITMAP is a structure containing my_bitmap_map, the latter is a raw
       bitmap.
      * read_set, write_set and vcol_set of TABLE are the pointers to MY_BITMAP
      * The rest of MY_BITMAPs are stored in TABLE and TABLE_SHARE
      * The pointers to the stored MY_BITMAPs, like orig_read_set etc, and
       sometimes all_set and tmp_set, are assigned to the pointers.
      * Sometimes tmp_use_all_columns is used to substitute the raw bitmap
       directly with all_set.bitmap
      * Sometimes even bitmaps are directly modified, like in
      TABLE::update_virtual_field(): bitmap_clear_all(&tmp_set) is called.
      
      The last three bullets in the list, when used together (which is mostly
      always) make the program flow cumbersome and impossible to follow,
      notwithstanding the errors they cause, like this MDEV-17556, where tmp_set
      pointer was assigned to read_set, write_set and vcol_set, then its bitmap
      was substituted with all_set.bitmap by dbug_tmp_use_all_columns() call,
      and then bitmap_clear_all(&tmp_set) was applied to all this.
      
      To untangle this knot, the rule should be applied:
      * Never substitute bitmaps! This patch is about this.
       orig_*, all_set bitmaps are never substituted already.
      
      This patch changes the following function prototypes:
      * tmp_use_all_columns, dbug_tmp_use_all_columns
       to accept MY_BITMAP** and to return MY_BITMAP * instead of my_bitmap_map*
      * tmp_restore_column_map, dbug_tmp_restore_column_maps to accept
       MY_BITMAP* instead of my_bitmap_map*
      
      These functions now will substitute read_set/write_set/vcol_set directly,
      and won't touch underlying bitmaps.
      e25623e7
  16. 07 Sep, 2020 6 commits
  17. 25 Aug, 2020 2 commits
  18. 23 Aug, 2020 2 commits
    • Kentoku SHIBA's avatar
      MDEV-22246 Result rows duplicated by spider engine · 2000d05c
      Kentoku SHIBA authored
      fix the following type mrr scan
      (select 0,`id`,`node` from `auto_test_remote`.`tbl_a` where (`id` <> 0) order by `id`)union all(select 1,`id`,`node` from `auto_test_remote`.`tbl_a` where (`id` <> 0) order by `id`) order by `id`
      2000d05c
    • Kentoku SHIBA's avatar
      MDEV-22246 Result rows duplicated by spider engine · 65ee216c
      Kentoku SHIBA authored
      fix the following type mrr scan
      (select 0,`id`,`node` from `auto_test_remote`.`tbl_a` where (`id` <> 0) order by `id`)union all(select 1,`id`,`node` from `auto_test_remote`.`tbl_a` where (`id` <> 0) order by `id`) order by `id`
      65ee216c