- 13 Aug, 2021 1 commit
-
-
Sujatha authored
1. sync_binlog=1 is needed to ensure that on flush binlog is available on disk. 2. Insert on 'connection master2' should wait for 'master1_ready' from 'connection master1'. Added sync_binlog=1 to all tests that got added as part of MDEV-21117 fix @mysql-test/suite/binlog/t/binlog_truncate_multi_log_unsafe.test @mysql-test/suite/binlog/t/binlog_truncate_multi_engine.test @mysql-test/suite/binlog/t/binlog_truncate_active_log.test @mysql-test/suite/binlog/t/binlog_truncate_multi_log.test
-
- 11 Aug, 2021 1 commit
-
-
Vladislav Vaintroub authored
-
- 09 Aug, 2021 2 commits
-
-
Vladislav Vaintroub authored
CMake Warning (dev) at cmake/plugin.cmake:288 (GET_TARGET_PROPERTY): Policy CMP0045 is not set: Error on non-existent target... Also, fix condition argument in ADD_FEATURE_INFO. It is not a string but boolean
-
-
- 06 Aug, 2021 1 commit
-
-
Dmitry Shulga authored
This test fails in case both embedded and PS mode are on.
-
- 05 Aug, 2021 3 commits
-
-
Daniel Bartholomew authored
-
Vladislav Vaintroub authored
-
nia authored
A getsockopt level of 0 is requied on NetBSD when using Unix-domain socket LOCAL_* options, SOL_SOCKET will not work.
-
- 03 Aug, 2021 2 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
- 02 Aug, 2021 10 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
The call to the function fts_check_corrupt() was removed in commit 09af00cb already.
-
Oleksandr Byelkin authored
-
Nikita Malyavin authored
Server crashes in Field::register_field_in_read_map upon select from partitioned table with indexed by prefix virtual column. After several read-mark fixes a problem has surfaced: Since KEY (c(10),a) uses only a prefix of c, a new field is created, duplicated from table->field[3], with a new length. However, vcol_inco->expr is not copied. Therefore, (*key_info)->key_part[i].field->vcol_info->expr was left NULL in ha_partition::index_init(). Solution: copy vcol_info from table field when it's set up.
-
Oleksandr Byelkin authored
This reverts commit 9b8e207c.
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
- 01 Aug, 2021 1 commit
-
-
Sergei Golubchik authored
according to MDEV-17550 it's informational, not fatal. "last committed" is part of the certification index purge process. depending on what tests and in what order are run it can be triggered at unspecified times during the testing. If the test is happen to shut down the server at this very time, the log will have: [Warning] WSREP: Failed to report last committed XXXYYYZZZ, -77 (File descriptor in bad state)
-
- 31 Jul, 2021 3 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Sergei Golubchik authored
fix main.processlist_notembedded test * before EXPLAINing `select sleep` wait for select to start (fixes "Target is not running an EXPLAINable command") * after killing sleep, wait for it to die (fixes test failures on --repeat when old sleep shows on a test rerun) * unify with 10.3, copy minor changes from there (`--echo End of 5.5` vs `--echo # End of 5.5`, etc)
-
- 30 Jul, 2021 5 commits
-
-
Sergei Golubchik authored
It shouldn't be possible to install an old MariaDB-common with a new MariaDB-server or vice versa.
-
Sergei Golubchik authored
returning NULL (a.k.a. nullptr) from a bool function. followup for add782a1
-
Sergei Golubchik authored
because INSTALL_MYSQL_TEST() cmake macro has PATTERN "*.in" EXCLUDE
-
Sergei Golubchik authored
-
Marko Mäkelä authored
ha_innobase::can_switch_engines(): Use DBUG_RETURN instead of return to match the DBUG_ENTER. This fixes a bootstrap failure of debug builds using the default setting -DWITH_DBUG_TRACE=ON.
-
- 29 Jul, 2021 11 commits
-
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
In commit 2647fd10 (MDEV-19445) we fixed a race condition around the INFORMATION_SCHEMA tables that access the table identified by the global variable innodb_ft_aux_table. Thanks to MDEV-16678 we could fix it even better by using MDL instead of the InnoDB dict_sys latches.
-
Marko Mäkelä authored
Before entering DML or DDL execution in the storage engine, the SQL layer will have acquired metadata lock (MDL) on the current table name as well as the names of FOREIGN KEY (grand)child tables (that is, tables whose REFERENCES clauses point to the current table). The MDL prevents any metadata changes to these tables, such as RENAME, TRUNCATE, DROP, ALTER. While the MDL on the current table prevents dict_table_t::foreign_set from being modified, it does not prevent the table metadata that the stored pointers are pointing to from being modified. The MDL on the child tables will prevent both dict_table_t::referenced_set as well as the pointed child table metadata from being modified. wsrep_row_upd_index_is_foreign(): Do not unnecessarily acquire the data dictionary latch if Galera replication is not enabled. ha_innobase::can_switch_engines(): Rely on MDL. We are not dereferencing any pointers stored in the sets. row_mysql_freeze_data_dictionary(), row_mysql_unfreeze_data_dictionary(): Remove. row_update_for_mysql(): Call init_fts_doc_id_for_ref() only once. In ALTER TABLE...IMPORT TABLESPACE and FLUSH TABLES...FOR EXPORT the SQL layer is protecting the current table with MDL. We do not need InnoDB latches.
-
Marko Mäkelä authored
row_undo(): Remove the unnecessary acquisition and release of dict_sys.latch. This was supposed to prevent the table from being dropped while the undo log record is being rolled back. But, thanks to trx_resurrect_table_locks() that was introduced in mysql/mysql-server@935ba09d52c1908bde273ad1940b5ab919d9763d and commit c291ddfd as well as commit 1bd681c8 (MDEV-25506 part 3) tables will be protected against dropping due to table locks. This reverts commit 0049d5b5 (which had reverted a previous attempt of fixing this) and addresses an earlier race condition with the following: prepare_inplace_alter_table_dict(): If recovered transactions hold locks on the table while we are executing online ADD INDEX, acquire a table lock so that the rollback of those recovered transactions will not interfere with the ADD INDEX.
-
Marko Mäkelä authored
The InnoDB internal SQL parser never supported this syntax.
-
Marko Mäkelä authored
Since commit 1bd681c8 tablespaces are dropped after the table has been dropped. No dict_sys latch protection is relevant during the execution of fil_delete_tablespace().
-
Marko Mäkelä authored
Since commit 1bd681c8 dict_stats_exec_sql() is no longer playing dirty tricks. We can remove the workaround in lock_release().
-
Marko Mäkelä authored
fts_lock_table(): Fix a regression that was introduced in commit da65cb4d (MDEV-25936).
-
Oleksandr Byelkin authored
-
Nikita Malyavin authored
len was containing garbage, since vctempl->mysql_col_offset was containing old value while calling row_mysql_store_col_in_innobase_format from innobase_get_computed_value(). It was not updated after the first ALTER TABLE call, because it's INPLACE logic considered there's nothing to update, and exited immediately from ha_innobase::inplace_alter_table(). However, vcol metadata needs an update, since vcols structure is changed in mysql record. The regression was introduced by 12614af1. There, refcount==1 condition was removed, which turned out to be crucial, though racy. The idea was to update vc_templ after each (sequencing) ALTER TABLE. We should do the same another way, and there may be a plenty of solutions, but the simplest one is to add a following condition: if vcol structure is changed, drop vc_templ; it will be recreated on next ha_innobase::open() call. in prepare_inplace_alter_table. It is safe, since innodb inplace changes require at least HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, which guarantee MDL_EXCLUSIVE on this stage. alter_templ_needs_rebuild() also has to track the columns not indexed, to keep vc_templ correct. Note that vc_templ is always kept constructed and available after ha_innobase::open() call, even on INSERT, though no virtual columns are evaluated during that statement inside innodb. In the test case suplied, it will be recreated on the second ALTER TABLE.
-
Marko Mäkelä authored
ha_innobase::prepare_inplace_alter_table(): Remove always-true conditions. Near the start of the function, we would already have returned if no ALTER TABLE operation flags were set that would require special action from InnoDB. It turns out that the conditions were redundant already when they were introduced in mysql/mysql-server@241387a2b6b61fb8a4f78dc4ad0aaa289400c694 and in commit 068c6197. Thanks to Nikita Malyavin for noticing this.
-