An error occurred fetching the project authors.
  1. 23 Oct, 2006 1 commit
    • unknown's avatar
      Fix for bug#23037 Bug in field "Default" of query "SHOW COLUMNS FROM table" · 29947efc
      unknown authored
        
      To the documentor: The DEFAULT value in SHOW COLUMNS/SELECT FROM I_S.COLUMNS
      was truncated to NAME_LEN (which effectively is 64) characters.
      
      
      mysql-test/r/information_schema.result:
        Update result
        
        Because the length of I_S.COLUMNS.COLUMN_DEFAULT was increased to
        65535 the column changed it's type from varchar(64) to longtext
        The type is longtext if the length is > 65532 (the max varchar len)
      mysql-test/t/information_schema.test:
        test case for bug#23037: Bug in field "Default" of
        query "SHOW COLUMNS FROM table"
        
        Both SHOW COLUMNS and I_S.COLUMNS is TESTED as well the
        value returned by both. Using --replace_regex is unfeasible
        as the repetition value cannot be > 255.
        --replace_regex /A{256}/VALUE/ doesn't work, not to talk about
          /A{65532}/VALUE/
        /(A{255}){255}/VALUE/ is awfully slow. Thus, simple function with
        cursor is used to extract the value.
      sql/sql_show.cc:
        Default value can have TIMESTAMP, CHAR, VARCHAR, ENUM
        VARCHAR can have the longest value, up to 65535. However, because
        of table handler limitations the actual limit is 65532 characters,
        latin1 charset. However, here is used MAX_FIELD_VARCHARLENGTH macro,
        because there could be a storage engine without such limitation.
      29947efc
  2. 15 Aug, 2006 1 commit
    • unknown's avatar
      BUG#21648 information_schema test fails --with-ndbcluster · 3106a0a5
      unknown authored
      make test work both with and without ndbcluster
      
      
      mysql-test/r/information_schema.result:
        fix test so that it passes --with-ndbcluster
        
        add conditions to ignore the table_schema='cluster' on some queries as different
        tables are in the cluster database if ndb is running or not.
      mysql-test/t/information_schema.test:
        ignore the 'cluster' database as results differ if --with-ndbcluster or without
        
        explictly use schema 'test' for bug7476 check.
      3106a0a5
  3. 25 Jul, 2006 1 commit
    • unknown's avatar
      Fixed bug #21231: wrong results for a simple query with a · d64f605e
      unknown authored
      a non-correlated single-row subquery over information schema.
      
      The function get_all_tables filling all information schema
      tables reset lex->sql_command to SQLCOM_SHOW_FIELDS. After
      this the function could evaluate partial conditions related to
      some columns. If these conditions contained a subquery over
      information schema it led to a wrong evaluation and a wrong 
      result set.
      This bug was already fixed in 5.1.
      This patch follows the way how it was done in 5.1 where
      the value of lex->sql_command is set to SQLCOM_SHOW_FIELDS
      in get_all_tables only for the calls of the function 
      open_normal_and_derived_tables and is restored after these
      calls.
      
      
      mysql-test/r/information_schema.result:
        Added a test case for bug #21231.
      mysql-test/t/information_schema.test:
        Added a test case for bug #21231.
      d64f605e
  4. 22 Jul, 2006 1 commit
    • unknown's avatar
      Fixed bug #18925: wrong results for queries with · 43df9fd3
      unknown authored
      subqueries on information schema that use MIN/MAX aggregation.
      
      Execution of some correlated subqueries may set the value
      of null_row to 1 for tables used in the subquery.
      If the the subquery is on information schema it causes
      rejection of any row for the following executions of
      the subquery in the case when an optimization filtering
      by some condition is applied.
      
      The fix restores the value of the null_row flag for 
      each execution of a subquery on information schema.
      
      
      mysql-test/r/information_schema.result:
        Added a test case for bug #18925.
      mysql-test/t/information_schema.test:
        Added a test case for bug #18925.
      sql/sql_show.cc:
        Fixed bug #18925.
        Execution of some correlated subqueries may set the value
        of null_row to 1 for tables used in the subquery.
        If the the subquery is on information schema it causes
        rejection of any row for the following execitions of
        the subquery in the case when an optimization filtering
        by some condition is applied.
        
        The fix restores the value of the null_row flag for 
        each execution of a subquery on information schema.
      43df9fd3
  5. 29 Jun, 2006 1 commit
    • unknown's avatar
      Bug#20230: routine_definition is not null · 8368f437
      unknown authored
      SHOW CREATE PROCEDURE and SHOW CREATE FUNCTION are fixed as well as
      INFORMATION_SCHEMA.ROUTINES.ROUTINE_NAME.
      
      
      mysql-test/r/information_schema.result:
        Add result for bug#20230.
      mysql-test/t/information_schema.test:
        Add test case for bug#20230.
      sql/sp_head.cc:
        Return NULL for routine definition if the user doesn't have enough
        privilege to see it.
      sql/sql_show.cc:
        Make INFORMATION_SCHEMA.ROUTINES.ROUTINE_NAME NULL-able.  Return
        NULL if the user doesn't have enough privilege to see routine
        definition.
      8368f437
  6. 20 Jun, 2006 1 commit
    • unknown's avatar
      SHOW STATUS does not anymore change local status variables (except... · f3a56a17
      unknown authored
      SHOW STATUS does not anymore change local status variables (except com_show_status). Global status variables are still updated.
      SHOW STATUS are not anymore put in slow query log because of no index usage.
      
      Implemntation done by removing orig_sql_command and moving logic of SHOW STATUS to mysql_excute_command()
      This simplifies code and allows us to remove some if statements all over the code.
      
      Upgraded uc_update_queries[] to sql_command_flags and added more bitmaps to better categorize commands.
      This allowed some overall simplifaction when testing sql_command.
      
      Fixes bugs:
      Bug#10210: running SHOW STATUS increments counters it shouldn't
      Bug#19764: SHOW commands end up in the slow log as table scans
      
      
      mysql-test/r/grant_cache.result:
        Fixed results after SHOW STATUS doesn't anymore affect status variables
      mysql-test/r/information_schema.result:
        Added extra test to cover more code
      mysql-test/r/query_cache.result:
        Remove resuts from previous tests
      mysql-test/r/status.result:
        Added more tests for testing of last_query_cost and how SHOW STATUS affects status variables.
        (Bug#10210)
      mysql-test/r/temp_table.result:
        Fixed results after SHOW STATUS doesn't anymore affect status variables
      mysql-test/r/union.result:
        Fixed results after SHOW STATUS is not logged to slow query log
        (Bug#19764)
      mysql-test/t/events_microsec.test:
        Disable warnings at init
      mysql-test/t/information_schema.test:
        Added extra test to cover more code
      mysql-test/t/query_cache.test:
        Remove resuts from previous tests
      mysql-test/t/status.test:
        Added more tests for testing of last_query_cost and how SHOW STATUS affects status variables.
        (Bug #10210)
      sql/mysql_priv.h:
        Added 'sql_command_flags'
      sql/sql_class.cc:
        New function add_diff_to_status(), used to update global status variables when using SHOW STATUS
      sql/sql_class.h:
        New function 'fill_information_schema_tables()'
        (One could not anymore use fill_derived_tables() for this as only_view_structures() is not relevant for information schema tables)
        Added defines for bit flags in sql_command_flags[]
      sql/sql_lex.cc:
        Remove orig_sql_command
      sql/sql_lex.h:
        Remove orig_sql_command
      sql/sql_parse.cc:
        Rename uc_update_queries -> sql_command_flags.
        Enhanced 'sql_command_flags' to better classify SQL commands
        uc_update_queries[] != 0 is changed to (sql_command_flags[] & CF_CHANGES_DATA)
        lex->orig_sql_command == SQLCOM_END is changed to (sql_command_flags[lex->sql_command] & CF_STATUS_COMMAND) == 0)
        
        Simplify incrementing of thd->status_var.com_stat[] as we don't have to do special handling for SHOW commands.
        
        Split SQLCOM_SELECT handling in mysql_execute_command() to a separate function.
        Added special handling of SHOW STATUS commands in mysql_execute_command() and call common SQLCOM_SELECT handling.
        These changes allows us to easily fix that we save and restore status variables during execution of a SHOW STATUS command.
        Don't log SHOW STATUS commands to slow query log.
        
        This fixes Bug#10210 and Bug#19764 without adding additional 'if' code.
        (The new code is faster than the original as we now have fewer if's than before)
      sql/sql_prepare.cc:
        Clean up prepare-check handling of SQLCOM commands by using sql_command_flags[]
        This simplifes code and ensures that code works even if someone forgets to put a new status commands into the switch statement.
      sql/sql_select.cc:
        Remove special handling of SHOW STATUS.
        (This is now done in SQLCOM_SHOW_STATUS part in mysql_execute_command())
      sql/sql_show.cc:
        Remove orig_sql_command
        Only change sql_command during 'open_normal_and_derived_tables()' (for views) and not for the full duration of generating data.
        Changed 'show status' to use thd->initial_status_var to ensure that the current statement is not affecting the to-be-used values.
        Use thd->fill_information_schema_tables() instead of 'thd->fill_derived_tables()' as the later wrongly checks the value of sql_command.
      sql/sql_yacc.yy:
        Remove usage of orig_sql_command.
        One side effect of this is that we need to test for cursors if the current command is a SELECT or a SHOW command.
      sql/structs.h:
        Updated comment
      f3a56a17
  7. 06 Jun, 2006 2 commits
  8. 23 May, 2006 2 commits
  9. 12 May, 2006 2 commits
    • unknown's avatar
      Fix for bug#18177 any access to INFORMATION_SCHEMA.ROUTINES crashes · 9ffa09be
      unknown authored
      replaced get_field(MEM_ROOT *mem, Field *field) with 
      get_field(MEM_ROOT *mem, Field *field, String *res).
      It allows to avoid strlen().
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#18177 any access to INFORMATION_SCHEMA.ROUTINES crashes
        test case
      mysql-test/t/information_schema.test:
        Fix for bug#18177 any access to INFORMATION_SCHEMA.ROUTINES crashes
        test case
      9ffa09be
    • unknown's avatar
      Fix for bug#19236 bad COLUMNS.CHARACTER_MAXIMUM_LENGHT and CHARACTER_OCTET_LENGTH · af797c16
      unknown authored
      mysql-test/r/information_schema.result:
        Fix for bug#19236 bad COLUMNS.CHARACTER_MAXIMUM_LENGHT and CHARACTER_OCTET_LENGTH
        test case
      mysql-test/r/join.result:
        Fix for bug#19236 bad COLUMNS.CHARACTER_MAXIMUM_LENGHT and CHARACTER_OCTET_LENGTH
        result fix
      mysql-test/t/information_schema.test:
        Fix for bug#19236 bad COLUMNS.CHARACTER_MAXIMUM_LENGHT and CHARACTER_OCTET_LENGTH
        test case
      af797c16
  10. 04 May, 2006 1 commit
    • unknown's avatar
      Bug#18474 Unlistable directories yield no info from information_schema, part2 · 0c7aa68d
      unknown authored
       - Move "chmod" part of information_schema test to separate file
      
      
      mysql-test/r/information_schema.result:
        Move "chmod" part of information_schema test to separate file
      mysql-test/t/information_schema.test:
        Move "chmod" part of information_schema test to separate file
      mysql-test/r/information_schema_chmod.result:
        Move "chmod" part of information_schema test to separate file
      mysql-test/t/information_schema_chmod.test:
        Move "chmod" part of information_schema test to separate file
      0c7aa68d
  11. 24 Apr, 2006 3 commits
    • unknown's avatar
      Revert use of octal numbers for chmod · fefc0452
      unknown authored
      fefc0452
    • unknown's avatar
      Test it it works better to set no read access for a file by using 000 instead of -r · 008da9b9
      unknown authored
      Looks like the trigger.test works that way
      
      
      mysql-test/t/information_schema.test:
        Test it it works better to set no read access for a file by using 000 instead of -r
      008da9b9
    • unknown's avatar
      Bug#17002 mysql-test-run as root user · 1d16bc69
      unknown authored
       - Add test to see if tests are running with root permissions
       - Disables tests that uses chmod if that is the case
      
      
      mysql-test/mysql-test-run.pl:
        Add test to check if mysql-test-run is run with root permission. 
        Set environment variable MYSQL_TEST_ROOT to 'YES' or 'NO'.
      mysql-test/t/information_schema.test:
        Disable test if running as root
      mysql-test/t/rpl_rotate_logs.test:
        Disable test if running as root.
      mysql-test/include/not_as_root.inc:
        New BitKeeper file ``mysql-test/include/not_as_root.inc''
      mysql-test/r/not_as_root.require:
        New BitKeeper file ``mysql-test/r/not_as_root.require''
      1d16bc69
  12. 07 Apr, 2006 1 commit
  13. 04 Apr, 2006 1 commit
    • unknown's avatar
      After merge fix for Bug#12076 --with-extra-charsets has no effect · ff3495c4
      unknown authored
      mysql-test/r/information_schema.result:
        IS_COMPILED is not determenistic
      mysql-test/t/information_schema.test:
        IS_COMPILED is not determenistic
      strings/conf_to_src.c:
        Adding dumping of extra 5.0 fields
      strings/ctype-extra.c:
        Recreating sources according to 5.0 XML files using conf_to_src.
      ff3495c4
  14. 20 Mar, 2006 1 commit
    • unknown's avatar
      Fix for bug#18224 VIEW on information_schema crashes the server · 53862e60
      unknown authored
        additional check for subselect
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#18224 VIEW on information_schema crashes the server
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#18224 VIEW on information_schema crashes the server
          test case
      53862e60
  15. 16 Feb, 2006 1 commit
    • unknown's avatar
      The patch adds PROCESSLIST information schema · 99ea15c9
      unknown authored
      mysql-test/r/information_schema.result:
        Fixing results after PROCESSLIST information schema is added.
      mysql-test/r/information_schema_db.result:
        Fixing results after PROCESSLIST information schema is added.
      mysql-test/t/information_schema.test:
        Test case to check PROCESSLIST information schema.
          (Note that selecting other fields from PROCESSLIST
          can make the test unstable).
      sql/sql_show.cc:
        Code for PROCESSLIST information schema
      sql/table.h:
        Added for PROCESSLIST informarion schema
      99ea15c9
  16. 27 Jan, 2006 1 commit
    • unknown's avatar
      Use MYSQLTEST_VARDIR · f300c891
      unknown authored
      mysql-test/t/information_schema.test:
        Use MYSQLTEST_VARDIR instead of MYSQL_TEST_DIR/var
      f300c891
  17. 24 Jan, 2006 2 commits
    • unknown's avatar
      Fix for bug#15307 GROUP_CONCAT() with ORDER BY returns empty set on information_schema(2nd ver) · 333b1f85
      unknown authored
        Fill schema tables with data before filesort if it's necessary
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#15307 GROUP_CONCAT() with ORDER BY returns empty set on information_schema(2nd ver)
          test result
      mysql-test/t/information_schema.test:
        Fix for bug#15307 GROUP_CONCAT() with ORDER BY returns empty set on information_schema(2nd ver)
          test case
      333b1f85
    • unknown's avatar
      Fix for bug#15851 Unlistable directories yield no info from information_schema · fbc24f33
      unknown authored
        to skip directories which are not allowed for read
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#15851 Unlistable directories yield no info from information_schema
          test result
      mysql-test/t/information_schema.test:
        Fix for bug#15851 Unlistable directories yield no info from information_schema
          test case
      fbc24f33
  18. 19 Jan, 2006 1 commit
    • unknown's avatar
      WL1019: complete patch. Reapplied patch to the clean · 41536fce
      unknown authored
      tree to get rid of multiple typos in CS comments and
      unify the patch.
      
      
      configure.in:
        CSV is compiled in by default now
      include/my_base.h:
        add new ha_extra flag for the log tables
      mysql-test/include/im_check_os.inc:
        we should only run im tests if csv is on for now: im relies
        on mysqld options available only in csv build.
      mysql-test/include/system_db_struct.inc:
        check log tables structure
      mysql-test/lib/init_db.sql:
        create log tables when running tests.
      mysql-test/mysql-test-run.pl:
        Add old logs flag to IM tests. As IM could only deal with
        old logs (this feature is not needed with log tables)
      mysql-test/r/connect.result:
        update result
      mysql-test/r/csv.result:
        update result
      mysql-test/r/im_utils.result:
        update result
      mysql-test/r/information_schema.result:
        update result
      mysql-test/r/mysqlcheck.result:
        update result
      mysql-test/r/show_check.result:
        update result
      mysql-test/r/system_mysql_db.result:
        update result
      mysql-test/t/connect.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/csv.test:
        add tests for concurrent insert (the functionality is added
        to CSV in this patch)
      mysql-test/t/information_schema.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/mysqlcheck.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/show_check.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/system_mysql_db.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/system_mysql_db_fix.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      scripts/mysql_create_system_tables.sh:
        new system tables: slow_log and general_log
      scripts/mysql_fix_privilege_tables.sql:
        add new log tables: use an SP to create them for
        non-csv build to work fine.
      sql/ha_myisam.cc:
        move locking-related checks to the hanlder
      sql/ha_myisam.h:
        new function declared
      sql/handler.h:
        new virtual function is added: we should check for handler-related
        locking issues in the handler
      sql/lock.cc:
        from now on we check for handler-related locking issues
        in the handler itself rather then in lock.cc
      sql/log.cc:
        Add log tables support, refactoring: there are log event
        handlers with common interface. They are used by the LOGGER
        class, which is responsible for their initialization, cleanup
        and managment. Logging to the tables provided by one of the
        log event handler types.
      sql/log.h:
        declare new log classes
      sql/log_event.cc:
        convert old logging routines calls to use new API
      sql/mysql_priv.h:
        define common log routines and objects
      sql/mysqld.cc:
        Add support for the log tables. Their initalization, cleanup
        and specific options.
      sql/share/errmsg.txt:
        add new error messages for the log tables
      sql/slave.cc:
        convert old logging routines calls to use new API
      sql/sql_base.cc:
        TABLE objects used by the logger should be skipped
        during refreshes (as log tables are always opened
        and locked). fix table_is_used to skip them.  This
        is needed for FLUSH LOGS to work
      sql/sql_db.cc:
        convert old logging routines calls to use new API
      sql/sql_delete.cc:
        fix TRUNCATE to work with log tables
      sql/sql_parse.cc:
        command_name is now an array of LEX_STRINGs
      sql/sql_prepare.cc:
        convert old logging routines calls to use new API
      sql/sql_show.cc:
        convert old logging routines calls to use new API
      sql/sql_table.cc:
        don't reoped the log tables for admin purposes
      sql/table.cc:
        mark log tables as such during the open
      sql/table.h:
        add log-related info
      storage/csv/ha_tina.cc:
        add support for concurrent insert (see bk commit - 5.1 tree
        (petr:1.1910) for standalone patch), add log tables-specific
        csv table handling.
      storage/csv/ha_tina.h:
        enable concurrent insert for CSV, add log table flag
      mysql-test/r/log_tables.result:
        New BitKeeper file ``mysql-test/r/log_tables.result''
      mysql-test/t/log_tables.test:
        New BitKeeper file ``mysql-test/t/log_tables.test''
      41536fce
  19. 03 Jan, 2006 1 commit
    • unknown's avatar
      Fix for bug#15533 crash, information_schema, function, view · 5e7cbbcb
      unknown authored
        enable view prepared mode during getting metedata for I_S table
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#15533 crash, information_schema, function, view
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#15533 crash, information_schema, function, view
          test case
      5e7cbbcb
  20. 22 Dec, 2005 1 commit
    • unknown's avatar
      This patch does the following: · 67c96c78
      unknown authored
      1) Fixes breakage in embedded server build for XMLPath push.
      2) Hides PARTITION engine from view.
      3) Add ENGINES information schema (and it should now be clear from this patch on how to turn any show command into an information schema).
      
      
      libmysqld/Makefile.am:
        Fix for embedded server to build.
      mysql-test/r/information_schema.result:
        Fix for additional information_schema
      mysql-test/r/information_schema_db.result:
        Fix for adding additional engines information schema.
      mysql-test/t/information_schema.test:
        Added test to make sure that engines information schema works.
      sql/ha_partition.cc:
        Made PARTITION hidden in information schema.
      sql/sql_parse.cc:
        Added additional case for engine information schema.
      sql/sql_show.cc:
        Code for ENGINES information schema.
      sql/sql_yacc.yy:
        Extended grammer to support new ENGINES information schema
      sql/table.h:
        Comment on dependency in information schema.
      libmysqld/item_xmlfunc.cc:
        New BitKeeper file ``libmysqld/item_xmlfunc.cc''
      67c96c78
  21. 19 Dec, 2005 2 commits
    • unknown's avatar
      Fix for bug#14271 I_S: columns has no size for (var)binary columns · d920097a
      unknown authored
        set character_octet_length, character_maximum_length for
        binary and varbinary field types
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#14271 I_S: columns has no size for (var)binary columns
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#14271 I_S: columns has no size for (var)binary columns
          test case
      d920097a
    • unknown's avatar
      Bug#12770 DESC cannot display the info. about temporary table · 479a02fa
      unknown authored
      Bug#14387 SHOW COLUMNS doesn't work on temporary tables.
      Bug#15224 SHOW INDEX from temporary table doesn't work.
        Restore thd->temporary_tables to be able to process
        temporary tables(only for 'show index' & 'show columns').
        This should be changed when processing of temporary tables for
        I_S tables will be done.
      
      
      mysql-test/r/information_schema.result:
        Bug#12770 DESC cannot display the info. about temporary table
        Bug#14387 SHOW COLUMNS doesn't work on temporary tables.
        Bug#15224 SHOW INDEX from temporary table doesn't work.
          test case
      mysql-test/t/information_schema.test:
        Bug#12770 DESC cannot display the info. about temporary table
        Bug#14387 SHOW COLUMNS doesn't work on temporary tables.
        Bug#15224 SHOW INDEX from temporary table doesn't work.
          test case
      479a02fa
  22. 01 Dec, 2005 1 commit
    • unknown's avatar
      Fix for bug#14476 `information_schema`.`TABLES`.`TABLE_TYPE` with empty value · ba079bad
      unknown authored
        store TABLES.TABLE_TYPE in case of error during table opening
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#14476 `information_schema`.`TABLES`.`TABLE_TYPE` with empty value
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#14476 `information_schema`.`TABLES`.`TABLE_TYPE` with empty value
          test case
      ba079bad
  23. 11 Nov, 2005 1 commit
    • unknown's avatar
      Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail · 53427592
      unknown authored
                        for invalid view
       Permit SHOW CREATE VIEW, SHOW CREATE TABLE, and retrieval of metadata from
       information_schema for invalid views
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail 
                          for invalid view
         test case
      mysql-test/t/information_schema.test:
        Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail 
                          for invalid view
         test case
      53427592
  24. 25 Oct, 2005 1 commit
  25. 21 Oct, 2005 1 commit
    • unknown's avatar
      fix for bug#14089 FROM list subquery always fails when · 4c872f74
      unknown authored
                        information_schema is current database
        skip the check of I_S tables if table is derived table
      
      
      mysql-test/r/information_schema.result:
        fix for bug#14089 FROM list subquery always fails when 
                          information_schema is current database
          test case
      mysql-test/t/information_schema.test:
        fix for bug#14089 FROM list subquery always fails when 
                          information_schema is current database
          test case
      4c872f74
  26. 12 Oct, 2005 1 commit
    • unknown's avatar
      Always test ssl and compress · 2bb0501d
      unknown authored
       - Updated after review
      
      
      client/mysqltest.c:
        Updated after review.
        Fix "connect" command to take SSL and/or COMPRESS as options instead of enable/disable_ssl and enable/disable_compress
        Commented do_connect, added test cases etc.
        Fix safe_get_param to make it possible to call it once for every argument without having any checks inbetween.
        Make a copy for query->first_argument  since safe_get_param will modify query string. Now connect works inside a while loop as well.
      mysql-test/mysql-test-run.pl:
        Updated after review
      mysql-test/r/connect.result:
        Enable test that was previolsy disabled because of "no error handling" in connect
      mysql-test/r/mysqltest.result:
        Added tests for "connect"
      mysql-test/t/compress.test:
        Updated after review, use the option argument to connect
      mysql-test/t/connect.test:
        Enable test that was previolsy disabled because of "no error handling" in connect
        Now it's possible to use "--error" before connect, so let's use it.
      mysql-test/t/information_schema.test:
        Connection user4 was already used
      mysql-test/t/myisam.test:
        Disconnect con1 so the name can be reused
      mysql-test/t/mysqltest.test:
        Added tests for "connect"
      mysql-test/t/openssl_1.test:
        Updated after review, use the option argument to connect
      mysql-test/t/sp-security.test:
        Disconnect user1 connection so the name can be reused
      mysql-test/t/ssl.test:
        Updated after review, use the option argument to connect
      mysql-test/t/ssl_compress.test:
        Updated after review, use the option argument to connect
      sql/mysqld.cc:
        Updated after review, Compression variable is always available
      sql/sql_show.cc:
        Updated after review, Compression variable is always available
      sql/structs.h:
        Updated after review, Compression variable is always available
      2bb0501d
  27. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · c807724f
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      c807724f
  28. 22 Sep, 2005 1 commit
    • unknown's avatar
      Fixed problems found by valgrind · 7d6d4c83
      unknown authored
      Fixed problems in test suite where some test failed
      Fixed access to not initialized memory in federated
      Fixed access to not initialized memory when using BIT fields in internal temporary tables
      
      
      BitKeeper/etc/ignore:
        added libmysqld/sql_cursor.h
      mysql-test/r/information_schema.result:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middlecd
      mysql-test/r/information_schema_inno.result:
        Remove used tables at start
      mysql-test/r/multi_statement.result:
        Remove used tables at start
      mysql-test/r/temp_table.result:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/r/type_bit.result:
        More tests
      mysql-test/t/information_schema.test:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/t/information_schema_inno.test:
        Remove used tables at start
      mysql-test/t/multi_statement.test:
        Remove used tables at start
      mysql-test/t/temp_table.test:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/t/type_bit.test:
        More tests
      mysql-test/valgrind.supp:
        Removed some valgrind warnings that isn't errors
      sql/ha_federated.cc:
        Fixed errors discovered by valgrind:
        - Socket was not initialized
        - share->scheme was deleted while there was still pointer into it from the hash
      sql/item_func.h:
        Remove access to table object from cleanup() as the table object may have been dropped earlier (In case of temporary tables or of close_thread_tables() is run before cleanup())
        This fixed a bug with access to already freed memory
      sql/sql_base.cc:
        Reset variables used by fulltext
      sql/sql_select.cc:
        Fixed various problems with bit fields when used in internal temporary tables.
        Calculate space needed for bit fields correctly (previously we allocated more space than needed for rows in heap/myisam tables)
      7d6d4c83
  29. 13 Sep, 2005 1 commit
    • unknown's avatar
      Bug#9683 INFORMATION_SCH: Creation of temporary table allowed in · 3764875c
      unknown authored
               Information_schema DB 
      Bug#9846 Inappropriate error displayed while
               dropping table from 'INFORMATION_SCHEMA'
      Bug#10734 Grant of privileges other than 'select' and 
               'create view' should fail on schema 
      Bug#10708 SP's can use INFORMATION_SCHEMA as ROUTINE_SCHEMA
      
       cumulative fix for bugs above(after review, 2nd version)
       added privilege check for information schema db & tables
      
      
      3764875c
  30. 07 Sep, 2005 1 commit
  31. 01 Sep, 2005 1 commit
    • unknown's avatar
      Fix for spelling miss and eol junk · a2d8ab0b
      unknown authored
      client/mysqltest.c:
        Fix spelling error
      mysql-test/t/information_schema.test:
        Eol junk detected, added #
      mysql-test/t/rpl_slave_status.test:
        Missing ;
      mysql-test/t/sp.test:
        Eol junk detected, added #
      mysql-test/t/view.test:
        Eol junk detected, added #
      a2d8ab0b
  32. 25 Aug, 2005 1 commit
    • unknown's avatar
      Make test predictable · 8bd9992e
      unknown authored
      mysql-test/r/information_schema.result:
        Ensure that rows are in given order
      mysql-test/t/information_schema.test:
        Ensure that rows are in given order
      8bd9992e
  33. 23 Aug, 2005 1 commit
    • unknown's avatar
      sql_show.cc: · 57f575b2
      unknown authored
        Database name was set incorrectly for any show command
        that used sunqueries in its where condition.
      information_schema.test, information_schema.result:
        Added a test case for bug #12636.
      
      
      mysql-test/r/information_schema.result:
        Added a test case for bug #12636.
      mysql-test/t/information_schema.test:
        Added a test case for bug #12636.
      sql/sql_show.cc:
        Database name was set incorrectly for any show command
        that used sunqueries in its where condition.
      57f575b2