An error occurred fetching the project authors.
  1. 17 Nov, 2008 1 commit
    • Alexey Botchkov's avatar
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server. · 58701cae
      Alexey Botchkov authored
            GLOBAL STATUS is calculated by studying the list of threads. In the
              embedded server threads were not linked to the internal list, so the
              calculation always returns 0. Fixed by 'linking' the embedded-server
              threads to the same list
      
      per-file comments:
        libmysqld/lib_sql.cc
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          Add newly created 'threads' to the internal thread list.
          Remove them from the list as they're freed.
      
        mysql-test/r/information_schema.result
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          test result
      
        mysql-test/t/information_schema.test
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          test case added
      58701cae
  2. 13 Nov, 2008 1 commit
    • Sergey Glukhov's avatar
      Bug#39955 SELECT on INFORMATION_SCHEMA.GLOBAL_VARIABLES takes too long · 3fa2673f
      Sergey Glukhov authored
      VARIABLE_VALUE field is decreased to 1024 symbols.
      (affected I_S tables: GLOBAL_VARIABLES, SESSION_VARIABLES,
       GLOBAL_STATUS, SESSION_STATUS).
      The only variable which can be longer than 1024 is
      init_connect. The variable will be truncated with warning.
      Additional fix:
      Added where condition filter which speed up queries which
      have where condition with expressions which use VARIABLE_NAME
      field.
      3fa2673f
  3. 09 Oct, 2008 1 commit
  4. 25 Mar, 2008 1 commit
  5. 19 Mar, 2008 1 commit
    • mhansson/martin@riffraff.(none)'s avatar
      Bug#34529: Crash on complex Falcon I_S select after ALTER .. PARTITION BY · 86db2a0c
      mhansson/martin@riffraff.(none) authored
        
      When swapping out heap I_S tables to disk, this is done after plan refinement.
      Thus, READ_RECORD::file will still point to the (deleted) heap handler at start
      of execution. This causes segmentation fault if join buffering is used and the 
      query is a star query where the result is found to be empty before accessing
      some table. In this case that table has not been initialized (i.e. had its 
      READ_RECORD re-initialized) before the cleanup routine tries to close the handler.
      Fixed by updating READ_RECORD::file when changing handler.
      86db2a0c
  6. 07 Mar, 2008 1 commit
    • svoj@mysql.com/june.mysql.com's avatar
      BUG#34656 - KILL a query = Assertion failed: m_status == DA_ERROR || · 553d70d0
      svoj@mysql.com/june.mysql.com authored
                  m_status == DA_OK
      
      Reading from information_scema.tables or information_schema.columns
      may cause assertion failure in debug builds. This may happen under
      rare circumstances when information_schema fails to get information
      about a table (e.g. when a connection is killed).
      
      This happens because open_normal_and_derived_tables() can return an
      error without setting an error message in THD. But information_schema
      attempts to get an error message from THD unconditionally.
      
      With this fix information_schema attempts to get an error message
      from THD only in case error message is set in THD.
      553d70d0
  7. 27 Feb, 2008 1 commit
  8. 30 Jan, 2008 1 commit
    • kostja@dipika.(none)'s avatar
      A fix and a test case for Bug#34166 Server crash in SHOW OPEN TABLES and · b46ce809
      kostja@dipika.(none) authored
      pre-locking.
      
      The crash was caused by an implicit assumption in check_table_access() that
      table_list parameter is always a part of lex->query_tables.
      
      When iterating over the passed list of tables, check_table_access() used
      to stop only when lex->query_tables_last_not_own was reached. 
      In case of pre-locking, lex->query_tables_last_own is not NULL and points
      to some element of lex->query_tables. When the parameter
      of check_table_access() was not part of lex->query_tables, loop invariant
      could never be violated and a crash would happen when the current table
      pointer would point beyond the end of the provided list.
      
      The fix is to change the signature of check_table_access() to also accept
      a numeric limit of loop iterations, similarly to check_grant(), and 
      supply this limit in all places when we want to check access of tables
      that are outside lex->query_tables, or just want to check access to one table.
      b46ce809
  9. 04 Dec, 2007 1 commit
  10. 30 Nov, 2007 1 commit
  11. 13 Nov, 2007 1 commit
    • evgen@moonbone.local's avatar
      Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS · 4fa7ee92
      evgen@moonbone.local authored
      command and reported to a client.
      
      The fact that a timestamp field will be set to NO on UPDATE wasn't shown 
      by the SHOW COMMAND and reported to a client through connectors. This led to
      problems in the ODBC connector and might lead to a user confusion.
      
      A new filed flag called ON_UPDATE_NOW_FLAG is added. 
      Constructors of the Field_timestamp set it when a field should be set to NOW
      on UPDATE.
      
      The get_schema_column_record function now reports whether a timestamp field
      will be set to NOW on UPDATE.
      4fa7ee92
  12. 12 Nov, 2007 1 commit
  13. 06 Nov, 2007 1 commit
  14. 02 Nov, 2007 1 commit
  15. 29 Oct, 2007 1 commit
  16. 23 Oct, 2007 1 commit
  17. 17 Oct, 2007 1 commit
  18. 11 Oct, 2007 1 commit
    • davi@moksha.com.br's avatar
      Bug#29223 declare cursor c for SHOW ..... · 2adf38c1
      davi@moksha.com.br authored
      "DECLARE CURSOR FOR SHOW ..." is a syntax that currently appears to work,
      but is untested for some SHOW commands and does not work for other SHOW
      commands.
      
      Since this is an un-intended feature that leaked as a result of a coding bug
      (in the parser grammar), the correct fix is to fix the grammar to not accept
      this construct.
      
      In other words, "DECLARE CURSOR FOR SHOW <other commands that don't work>"
      is not considered a bug, and we will not implement other features to make all
      the SHOW commands usable inside a cursor just because someone exploited a bug.
      2adf38c1
  19. 05 Oct, 2007 1 commit
  20. 04 Oct, 2007 1 commit
  21. 28 Sep, 2007 2 commits
  22. 20 Sep, 2007 1 commit
  23. 20 Aug, 2007 1 commit
  24. 09 Aug, 2007 1 commit
  25. 02 Aug, 2007 1 commit
  26. 11 Jul, 2007 1 commit
  27. 28 Jun, 2007 1 commit
    • anozdrin/alik@ibm.'s avatar
      Patch for the following bugs: · 9fae9ef6
      anozdrin/alik@ibm. authored
        - BUG#11986: Stored routines and triggers can fail if the code
          has a non-ascii symbol
        - BUG#16291: mysqldump corrupts string-constants with non-ascii-chars
        - BUG#19443: INFORMATION_SCHEMA does not support charsets properly
        - BUG#21249: Character set of SP-var can be ignored
        - BUG#25212: Character set of string constant is ignored (stored routines)
        - BUG#25221: Character set of string constant is ignored (triggers)
      
      There were a few general problems that caused these bugs:
      1. Character set information of the original (definition) query for views,
         triggers, stored routines and events was lost.
      2. mysqldump output query in client character set, which can be
         inappropriate to encode definition-query.
      3. INFORMATION_SCHEMA used strings with mixed encodings to display object
         definition;
      
      1. No query-definition-character set.
      
      In order to compile query into execution code, some extra data (such as
      environment variables or the database character set) is used. The problem
      here was that this context was not preserved. So, on the next load it can
      differ from the original one, thus the result will be different.
      
      The context contains the following data:
        - client character set;
        - connection collation (character set and collation);
        - collation of the owner database;
      
      The fix is to store this context and use it each time we parse (compile)
      and execute the object (stored routine, trigger, ...).
      
      2. Wrong mysqldump-output.
      
      The original query can contain several encodings (by means of character set
      introducers). The problem here was that we tried to convert original query
      to the mysqldump-client character set.
      
      Moreover, we stored queries in different character sets for different
      objects (views, for one, used UTF8, triggers used original character set).
      
      The solution is
        - to store definition queries in the original character set;
        - to change SHOW CREATE statement to output definition query in the
          binary character set (i.e. without any conversion);
        - introduce SHOW CREATE TRIGGER statement;
        - to dump special statements to switch the context to the original one
          before dumping and restore it afterwards.
      
      Note, in order to preserve the database collation at the creation time,
      additional ALTER DATABASE might be used (to temporary switch the database
      collation back to the original value). In this case, ALTER DATABASE
      privilege will be required. This is a backward-incompatible change.
      
      3. INFORMATION_SCHEMA showed non-UTF8 strings
      
      The fix is to generate UTF8-query during the parsing, store it in the object
      and show it in the INFORMATION_SCHEMA.
      
      Basically, the idea is to create a copy of the original query convert it to
      UTF8. Character set introducers are removed and all text literals are
      converted to UTF8.
      
      This UTF8 query is intended to provide user-readable output. It must not be
      used to recreate the object.  Specialized SHOW CREATE statements should be
      used for this.
      
      The reason for this limitation is the following: the original query can
      contain symbols from several character sets (by means of character set
      introducers).
      
      Example:
      
        - original query:
          CREATE VIEW v1 AS SELECT _cp1251 'Hello' AS c1;
      
        - UTF8 query (for INFORMATION_SCHEMA):
          CREATE VIEW v1 AS SELECT 'Hello' AS c1;
      9fae9ef6
  28. 09 Jun, 2007 1 commit
  29. 02 May, 2007 1 commit
  30. 05 Apr, 2007 1 commit
  31. 04 Apr, 2007 1 commit
  32. 03 Apr, 2007 1 commit
  33. 02 Apr, 2007 1 commit
  34. 12 Feb, 2007 1 commit
    • gluh@mysql.com/eagle.(none)'s avatar
      Bug#24630 Subselect query crashes mysqld · 47e537b4
      gluh@mysql.com/eagle.(none) authored
      The crash happens because second filling of the same I_S table happens in
      case of subselect with order by. table->sort.io_cache previously allocated
      in create_sort_index() is deleted during second filling
      (function get_schema_tables_result). There are two places where
      I_S table can be filled: JOIN::exec and create_sort_index().
      To fix the bug we should check if the table was already filled
      in one of these places and skip processing of the table in second.
      47e537b4
  35. 01 Feb, 2007 1 commit
  36. 18 Jan, 2007 1 commit
  37. 01 Dec, 2006 2 commits
  38. 21 Nov, 2006 1 commit
    • monty@mysql.com/nosik.monty.fi's avatar
      Added --debug-info to most clients to detect memory leaks in mysql-test-run · f6682e27
      monty@mysql.com/nosik.monty.fi authored
      Moved .progress files into the log directory
      Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name
      Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23
      Fixed some compiler warnings
      Fixed small memory leak in libmysql
      Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1
      f6682e27