- 18 May, 2007 3 commits
-
-
tsmith@quadxeon.mysql.com authored
into quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50
-
tsmith@quadxeon.mysql.com authored
in number_to_datetime(), zero out the MYSQL_TIME structure before setting values, to ensure that all fields are initialized; in particular, ensure that ->neg is set to zero (fixes valgrind warning "Conditional jump ... depends on uninitialised value" in make_date_time)
-
dkatz@damien-katzs-computer.local authored
Fixed a problem and compiler warning on 64bit platforms so that they only allocated UINT_MAX number of BUFFPEKS.
-
- 17 May, 2007 8 commits
-
-
dkatz@damien-katzs-computer.local authored
into damien-katzs-computer.local:/Users/dkatz/50_div_zero
-
dkatz@damien-katzs-computer.local authored
Fixed a compiler warning on platforms where uint != ulong from the first pushed fix.
-
tsmith@siva.hindu.god authored
into siva.hindu.god:/home/tsmith/m/bk/maint/50
-
tsmith@siva.hindu.god authored
into siva.hindu.god:/home/tsmith/m/bk/maint/50
-
tsmith@siva.hindu.god authored
into siva.hindu.god:/home/tsmith/m/bk/maint/50
-
tsmith@siva.hindu.god authored
into siva.hindu.god:/home/tsmith/m/bk/maint/41
-
dkatz@damien-katzs-computer.local authored
into damien-katzs-computer.local:/Users/dkatz/50_div_zero
-
tsmith@siva.hindu.god authored
Fix bad merge of test results
-
- 16 May, 2007 13 commits
-
-
dkatz@damien-katzs-computer.local authored
Added checks to detect integer overflow and fixed other bugs on the error path.
-
msvensson@pilot.blaudden authored
into pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
-
msvensson@pilot.blaudden authored
-
msvensson@pilot.blaudden authored
BDB results fixed (not p/o 5.1 fix)
-
msvensson@pilot.blaudden authored
into pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
-
msvensson@pilot.blaudden authored
Made year 2000 handling more uniform Removed year 2000 handling out from calc_days() The above removes some bugs in date/datetimes with year between 0 and 200 Now we get a note when we insert a datetime value into a date column For default values to CREATE, don't give errors for warning level NOTE Fixed some compiler failures Added library ws2_32 for windows compilation (needed if we want to compile with IOCP support) Removed duplicate typedef TIME and replaced it with MYSQL_TIME Better (more complete) fix for: Bug#21103 "DATE column not compared as DATE" Fixed properly Bug#18997 "DATE_ADD and DATE_SUB perform year2K autoconversion magic on 4-digit year value" Fixed Bug#23093 "Implicit conversion of 9912101 to date does not match cast(9912101 as date)"
-
msvensson@pilot.blaudden authored
into pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
-
msvensson@pilot.blaudden authored
into pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
-
msvensson@pilot.blaudden authored
- mysqldump generated output that set OLD_SQL_MODE twice, to different values (for triggers), or not at all (for routines) in some cases.
-
msvensson@pilot.blaudden authored
- Since isinf() portability across various platforms and compilers is a complicated question, we should not use it directly. Instead, the my_isinf() macro should be used, which is defined as an alias to the system-defined isinf() if it is safe to use, or a workaround implementation otherwise
-
kostja@vajra.(none) authored
-
kostja@vajra.(none) authored
into vajra.(none):/opt/local/work/mysql-5.0-21483
-
kostja@vajra.(none) authored
Bug#21483 "Server abort or deadlock on INSERT DELAYED with another implicit insert" Also fixes and adds test cases for bugs: 20497 "Trigger with INSERT DELAYED causes Error 1165" 21714 "Wrong NEW.value and server abort on INSERT DELAYED to a table with a trigger". Post-review fixes. Problem: In MySQL INSERT DELAYED is a way to pipe all inserts into a given table through a dedicated thread. This is necessary for simplistic storage engines like MyISAM, which do not have internal concurrency control or threading and thus can not achieve efficient INSERT throughput without support from SQL layer. DELAYED INSERT works as follows: For every distinct table, which can accept DELAYED inserts and has pending data to insert, a dedicated thread is created to write data to disk. All user connection threads that attempt to delayed-insert into this table interact with the dedicated thread in producer/consumer fashion: all records to-be inserted are pushed into a queue of the dedicated thread, which fetches the records and writes them. In this design, client connection threads never open or lock the delayed insert table. This functionality was introduced in version 3.23 and does not take into account existence of triggers, views, or pre-locking. E.g. if INSERT DELAYED is called from a stored function, which, in turn, is called from another stored function that uses the delayed table, a deadlock can occur, because delayed locking by-passes pre-locking. Besides: * the delayed thread works directly with the subject table through the storage engine API and does not invoke triggers * even if it was patched to invoke triggers, if triggers, in turn, used other tables, the delayed thread would have to open and lock involved tables (use pre-locking). * even if it was patched to use pre-locking, without deadlock detection the delayed thread could easily lock out user connection threads in case when the same table is used both in a trigger and on the right side of the insert query: the delayed thread would not release locks until all inserts are complete, and user connection can not complete inserts without having locks on the tables used on the right side of the query. Solution: These considerations suggest two general alternatives for the future of INSERT DELAYED: * it is considered a full-fledged alternative to normal INSERT * it is regarded as an optimisation that is only relevant for simplistic engines. Since we missed our chance to provide complete support of new features when 5.0 was in development, the first alternative currently renders infeasible. However, even the second alternative, which is to detect new features and convert DELAYED insert into a normal insert, is not easy to implement. The catch-22 is that we don't know if the subject table has triggers or is a view before we open it, and we only open it in the delayed thread. We don't know if the query involves pre-locking until we have opened all tables, and we always first create the delayed thread, and only then open the remaining tables. This patch detects the problematic scenarios and converts DELAYED INSERT to a normal INSERT using the following approach: * if the statement is executed under pre-locking (e.g. from within a stored function or trigger) or the right side may require pre-locking, we detect the situation before creating a delayed insert thread and convert the statement to a conventional INSERT. * if the subject table is a view or has triggers, we shutdown the delayed thread and convert the statement to a conventional INSERT.
-
- 15 May, 2007 7 commits
-
-
iggy@amd64.(none) authored
into amd64.(none):/src/bug24732/my50-bug24732
-
msvensson@pilot.blaudden authored
-
iggy@amd64.(none) authored
- Manifest requires four part application version. - mysqld does not need requireAdministrator rights to run.
-
msvensson@pilot.blaudden authored
- Give some more protection against "too long socket name by setting the max length when to use a tmpdir for sockets to 70
-
kostja@vajra.(none) authored
into vajra.(none):/opt/local/work/mysql-5.0-runtime
-
kostja@vajra.(none) authored
into vajra.(none):/opt/local/work/mysql-5.0-runtime
-
kostja@vajra.(none) authored
into vajra.(none):/opt/local/work/mysql-4.1-runtime
-
- 14 May, 2007 4 commits
-
-
anozdrin/alik@ibm. authored
-
anozdrin/alik@ibm. authored
-
anozdrin/alik@ibm. authored
-
kostja@vajra.(none) authored
-
- 12 May, 2007 2 commits
-
-
ibabaev@bk-internal.mysql.com authored
into bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
-
igor@olga.mysql.com authored
a crash when the left operand of the predicate is evaluated to NULL. It happens when the rows from the inner tables (tables from the subquery) are accessed by index methods with key values obtained by evaluation of the left operand of the subquery predicate. When this predicate is evaluated to NULL an alternative access with full table scan is used to check whether the result set returned by the subquery is empty or not. The crash was due to the fact the info about the access methods used for regular key values was not properly restored after a switch back from the full scan access method had occurred. The patch restores this info properly. The same problem existed for queries with IN subquery predicates if they were used not at the top level of the queries.
-
- 11 May, 2007 3 commits
-
-
evgen@moonbone.local authored
into moonbone.local:/mnt/gentoo64/work/27878-bug-5.0-opt-mysql
-
evgen@moonbone.local authored
Corrected test case for the bug#27878.
-
dlenev@mockturtle.local authored
-