1. 30 Sep, 2019 1 commit
    • Aleksey Midenkov's avatar
      MDEV-16144 Default TIMESTAMP clause for SELECT from versioned · 58fdf5b2
      Aleksey Midenkov authored
      1. Removed TIMESTAMP/TRANSACTION unit auto-detection in favor of default TIMESTAMP.
      
      Reasons:
      
      1.1. rare practical use and doubtful advantage of such auto-detection;
      1.2. it conflicts with MDEV-16226 (TRX_ID-based versioned tables performance improvement).
      
      Needless check_unit membership removed.
      
      2. SQL: versioning type handling refactoring
      
      Vers_type_handler hierarchy stores versioning properties of type.
      
      virtual Type_handler::vers() accesses specialization of
      Vers_type_handler for specific type.
      
      virtual Vers_type_handler::kind() returns versioning kind
      (timestamp/trx_id).
      
      Removed Type_handler::Vers_history_point_check_unit() in favor of
      Type_handler::vers().
      
      Renames:
      
      require_timestamp() -> require_timestamp_error()
      require_trx_id() -> require_trx_id_error()
      
      EDIT by Alexander Barkov (@abarkov):
      
      check_sys_fields() moved to Vers_type_handler::check_sys_fields()
      58fdf5b2
  2. 29 Sep, 2019 1 commit
  3. 28 Sep, 2019 4 commits
  4. 27 Sep, 2019 10 commits
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 12414cd9
      Marko Mäkelä authored
      12414cd9
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 9b5cdeeb
      Marko Mäkelä authored
      9b5cdeeb
    • Marko Mäkelä's avatar
      MDEV-20117: Fix another scenario · ea2b19de
      Marko Mäkelä authored
      Thanks to Eugene Kosov for noting that the fix is incomplete.
      It turns out that on instant DROP/reorder column (MDEV-15562),
      we must always write the metadata record, even though the table
      was empty. Alternatively, we should guarantee that all undo
      log records for the table have been purged. (Attempting to do
      that by updating table_id leads to other problems; see
      commit 1b31d885.)
      
      It would be tempting to remove dict_index_t::clear_instant_alter()
      altogether, but it turns that we need that when the instant ALTER TABLE
      operation of a first-time DROP COLUMN is being rolled back.
      
      innobase_instant_try(): Clarify a comment. Purge never calls
      dict_index_t::clear_instant_alter(), but it may invoke
      dict_index_t::clear_instant_add(). On first-time instant DROP/reorder,
      always write a metadata record, even if the table is empty.
      ea2b19de
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 2911a9a6
      Marko Mäkelä authored
      2911a9a6
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-20688 Recovery crashes after unnecessarily reading a corrupted page · c76873f2
      Thirunarayanan Balathandayuthapani authored
      The test encryption.innodb-redo-badkey was accidentally disabled
      until commit 23657a21 enabled
      it recently. Once it was enabled, it started failing randomly.
      
      recv_recover_corrupt_page(): Do not assume that any redo log exists
      for the page. A page may be unnecessarily read by read-ahead.
      When noting the corruption, reset recv_addr->state to RECV_PROCESSED,
      so that even if the same page is re-read again, we will only
      decrement recv_sys->n_addrs once.
      c76873f2
    • Marko Mäkelä's avatar
      dict_load_table(): Remove constant parameter cached=true · d874cdec
      Marko Mäkelä authored
      Spotted by Thirunarayanan Balathandayuthapani.
      d874cdec
    • Marko Mäkelä's avatar
      Reduce rw_lock_debug_mutex contention · 718fcee0
      Marko Mäkelä authored
      rw_lock_own(), rw_lock_own_flagged(): Traverse the rw_lock_t::debug_list
      only after quickly checking if the thread is holding X-latch or SX-latch.
      718fcee0
    • Marko Mäkelä's avatar
      Remove a useless large test, and add a debug assertion · 4ec0c346
      Marko Mäkelä authored
      The test innodb_fts.fulltext_table_evict was only creating 1000 tables
      with fulltext indexes, only to check that no tables with fulltext
      indexes are being evicted.
      
      The reason why tables containing fulltext indexes cannot be evicted is
      that fts_optimize_init() invokes dict_table_prevent_eviction().
      4ec0c346
    • Marko Mäkelä's avatar
      MDEV-19740: Fix GCC 9.2.1 -Wmaybe-uninitialized on AMD64 · ca9e0089
      Marko Mäkelä authored
      For CMAKE_BUILD_TYPE=Debug, the default MYSQL_MAINTAINER_MODE=AUTO
      implies -Werror along with other flags in cmake/maintainer.cmake,
      which would break the debug builds when CMAKE_CXX_FLAGS include -O2.
      
      This fix includes a backport of 6dd3f240
      from MariaDB 10.3.
      ca9e0089
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 72f671ab
      Marko Mäkelä authored
      72f671ab
  5. 26 Sep, 2019 10 commits
    • Marko Mäkelä's avatar
      MDEV-20117 Assertion 0 failed in row_sel_get_clust_rec_for_mysql · 1f4ee3fa
      Marko Mäkelä authored
      The crash scenario is as follows:
      
      (1) A non-empty table exists.
      (2) MDEV-15562 instant ADD/DROP/reorder has been invoked.
      (3) Some purgeable undo log exists for the table.
      (4) The table becomes empty, containing not even any delete-marked records,
      only containing the hidden metadata record that was added in (2).
      (5) An instant ADD/DROP/reorder column is executed, and the table
      is emptied and the (2) metadata removed.
      (6) Purge processes an undo log record from (3), which will refer to
      a non-existent clustered index field, because the metadata that
      was created in (2) was remoeved in (5).
      
      We fix this by adjusting step (5) so that we will never remove the
      MDEV-15562-style metadata record. Removing the MDEV-11369 metadata
      record (instant ADD COLUMN to the end of the table) is completely
      fine at any time when the table becomes empty, because
      dict_index_t::n_fields will remain unchanged.
      
      innobase_instant_try(): Never remove the MDEV-15562 metadata record.
      
      page_cur_delete_rec(): Do not reset FIL_PAGE_TYPE when the
      MDEV-15562 metadata record is being removed as part of
      btr_cur_pessimistic_update() invoked by innobase_instant_try().
      1f4ee3fa
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · bb5afc7c
      Marko Mäkelä authored
      bb5afc7c
    • Marko Mäkelä's avatar
      Fix GCC 9 -Wmaybe-uninitialized · 46facaed
      Marko Mäkelä authored
      Always initialize ScopedStatementReplication::saved_binlog_format,
      so that GCC cannot emit a bogus warning about
      ScopedStatementReplication::~ScopedStatementReplication() using the
      variable.
      
      The code was originally introduced in
      commit d998da03.
      46facaed
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 1cf0694d
      Marko Mäkelä authored
      1cf0694d
    • Marko Mäkelä's avatar
      MDEV-20675 Crash in SHOW ENGINE INNODB STATUS with innodb_force_recovery=5 · 3e4931cd
      Marko Mäkelä authored
      lock_print_info::operator(): Do not dereference purge_sys.query in case
      it is NULL. We would not initialize purge_sys if innodb_force_recovery
      is set to 5 or 6.
      
      The test case will be added by merge from 10.2.
      3e4931cd
    • Marko Mäkelä's avatar
      MDEV-19514 preparation: Extend innodb.innodb-change-buffer-recovery · 2d6719d7
      Marko Mäkelä authored
      Test innodb_read_only startup (which will be refused after a crash),
      and test also innodb_force_recovery=5, and extract some change buffer
      merge statistics. Omit any statistics about delete (purge) buffering,
      because purge could happen at any time.
      
      Use the sequence storage engine for populating the table.
      2d6719d7
    • Marko Mäkelä's avatar
      MDEV-20675 Crash in SHOW ENGINE INNODB STATUS with innodb_force_recovery=5 · 23d67545
      Marko Mäkelä authored
      Add a test case. MariaDB Server 10.2 is not affected.
      23d67545
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 574ff87f
      Marko Mäkelä authored
      574ff87f
    • Marko Mäkelä's avatar
      MDEV-13564 follow-up: Remove dead code · e3c39c0b
      Marko Mäkelä authored
      In MariaDB 10.4.0, commit 09af00cb
      removed the crash-upgrade logic for the MariaDB 10.2
      innodb_safe_truncate=OFF TRUNCATE TABLE (which was the only option
      between MariaDB 10.2.2 and 10.2.18), but failed to adjust some
      comments and code.
      
      buf_page_io_complete(): Remove a bogus comment about TRUNCATE.
      
      dict_recreate_index_tree(): Unused function; remove.
      
      fil_space_t::stop_new_ops: Clarify the comment.
      
      fil_space_acquire_low(): Remove a bogus comment about TRUNCATE.
      
      fil_check_pending_ops(), fil_check_pending_io(): Adjust a warning message.
      This code is only invoked as part of DISCARD TABLESPACE or DROP TABLE.
      DROP TABLE is internally used as part of ALTER TABLE, OPTIMIZE TABLE,
      or TRUNCATE TABLE.
      
      RemoteDatafile::create_link_file(): Clarify a comment.
      
      ibuf_delete_for_discarded_space(): Clarify the function comment.
      
      dict_table_x_lock_indexes(), dict_table_x_unlock_indexes():
      Merge with the only remaining caller, row_quiesce_set_state().
      
      page_create_zip(): Remove a bogus comment about TRUNCATE.
      e3c39c0b
    • Alexander Barkov's avatar
  6. 25 Sep, 2019 5 commits
  7. 24 Sep, 2019 9 commits