1. 19 Sep, 2022 2 commits
    • Vlad Lesin's avatar
      MDEV-29515 innodb.deadlock_victim_race is unstable · 5ab78cf3
      Vlad Lesin authored
      The test is unstable because 'UPDATE t SET b = 100' latches a page and
      waits for 'upd_cont' signal in lock_trx_handle_wait_enter sync point, then
      purge requests RW_X_LATCH on the same page, and then 'SELECT * FROM t
      WHERE a = 10 FOR UPDATE' requests RW_S_LATCH, waiting for RW_X_LATCH
      requested by purge. 'UPDATE t SET b = 100' can't release page latch as
      it waits for upd_cont signal, which must be emitted after 'SELECT * FROM
      t WHERE a = 10 FOR UPDATE' acquired RW_S_LATCH. So we have a deadlock,
      which is resolved by finishing the debug sync point wait by timeout, and
      the 'UPDATE t SET b = 100' releases it's record locks rolling back the
      transaction, and 'SELECT * FROM t WHERE a = 10 FOR UPDATE' is finished
      successfully instead of finishing by lock wait timeout.
      
      The fix is to forbid purging during the test by opening read view in a
      separate connection before the first insert into the table.
      
      Besides, 'lock_wait_end' syncpoint is not needed, as it enough to wait
      the end of the SELECT execution to let the UPDATE to continue.
      5ab78cf3
    • Daniel Bartholomew's avatar
      bump the VERSION · a762dad4
      Daniel Bartholomew authored
      a762dad4
  2. 15 Sep, 2022 1 commit
    • Daniel Black's avatar
      MDEV-16708: ps_missed_cmds test - HELP deconflict · 5e270ca2
      Daniel Black authored
      To make it possible to update the HELP text of UPDATE without
      changing this test every time, the test is changed to look
      for a faked help topic. A non-existant help topic generates
      different metadata and wasn't suitable as a test.
      
      Requested by Ian Gilfillan.
      
      Reviewed by Dmitry Shulga
      5e270ca2
  3. 13 Sep, 2022 1 commit
  4. 12 Sep, 2022 2 commits
  5. 09 Sep, 2022 1 commit
    • Andrei's avatar
      MDEV-24660 MYSQL_BIN_LOG::cleanup(): Assertion `b->xid_count == 0' · bc12478a
      Andrei authored
      The shutdown time assert was caused by untimely deactivation of
      the binlog background thread and related structs destruction.
      It could specifically occur when a transaction is replication unsafe
      and has to be completed with a ROLLBACK event in binlog.
      
      This gets fixed with the binlog background thread stop relocation
      to a point and user transactions have been completed.
      A test case is added to binlog.binlog_checkpoint which
      also receives as a bonus a minor correction to reactivate a MDEV-4322 test
      case that originally required a shutdown phase (that ceased to do).
      bc12478a
  6. 08 Sep, 2022 3 commits
    • Nayuta Yanagisawa's avatar
    • Marko Mäkelä's avatar
      MDEV-29440 InnoDB instant ALTER TABLE recovery must use READ UNCOMMITTED · d2e649ae
      Marko Mäkelä authored
      In commit 8f8ba758 (MDEV-27234)
      the data dictionary recovery was changed to use READ COMMITTED
      so that table-rebuild operations (OPTIMIZE TABLE, TRUNCATE TABLE,
      some forms of ALTER TABLE) would be recovered correctly.
      
      However, for operations that avoid a table rebuild thanks to
      being able to instantly ADD, DROP or reorder columns, recovery
      must use the READ UNCOMMITTED isolation level so that changes to
      the hidden metadata record can be rolled back.
      
      We will detect instant operations by detecting uncommitted changes
      to SYS_COLUMNS in case there is no uncommitted change of SYS_TABLES.ID
      for the table. In any table-rebuilding DDL operation, the SYS_TABLES.ID
      (and likely also the table name) will be updated.
      
      As part of rolling back the instant ALTER TABLE operation, after the
      operation on the hidden metadata record has been rolled back, a rollback
      of an INSERT into SYS_COLUMNS in row_undo_ins_remove_clust_rec() will
      invoke trx_t::evict_table() to discard the READ UNCOMMITTED definition
      of the table. After that, subsequent recovery steps will load and use
      the correct table definition.
      
      Reviewed by: Thirunarayanan Balathandayuthapani
      Tested by: Matthias Leich
      d2e649ae
    • Vlad Lesin's avatar
      MDEV-29433 innodb.lock_delete_updated is unstable · 0fa4dd07
      Vlad Lesin authored
      Use suspend thread syncpoint instead of include/wait_condition.inc to
      make sure DELETE created waiting lock before the next UPDATE begins
      locking.
      0fa4dd07
  7. 07 Sep, 2022 11 commits
  8. 06 Sep, 2022 6 commits
  9. 05 Sep, 2022 5 commits
    • Daniel Black's avatar
      MDEV-29443: prevent uring access to galera sst /notify scripts · fd8dbe0d
      Daniel Black authored
      The resources like uring in MariaDB aren't intended for spawned
      processes so we restrict access using the io_uring_ring_dontfork
      liburing library call.
      fd8dbe0d
    • Jan Lindström's avatar
      Merge 10.5 into 10.6 · 9fefd440
      Jan Lindström authored
      9fefd440
    • Jan Lindström's avatar
      Merge 10.4 into 10.5 · ba987a46
      Jan Lindström authored
      ba987a46
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 3c7887a8
      Marko Mäkelä authored
      3c7887a8
    • Marko Mäkelä's avatar
      MDEV-29438 Recovery or backup of instant ALTER TABLE is incorrect · 244fdc43
      Marko Mäkelä authored
      This bug was found in MariaDB Server 10.6 thanks to the
      OPT_PAGE_CHECKSUM record that was implemented
      in commit 4179f93d for catching
      this type of recovery failures.
      
      page_cur_insert_rec_low(): If the previous record is the page infimum,
      correctly limit the end of the record. We do not want to copy data from
      the header of the page supremum. This omission caused the incorrect
      recovery of DB_TRX_ID in an instant ALTER TABLE metadata record, because
      part of the DB_TRX_ID was incorrectly copied from the n_owned of the
      page supremum, which in recovery would be updated after the copying,
      but in normal operation would already have been updated at the time the
      common prefix was being determined.
      
      log_phys_t::apply(): If a data page is found to be corrupted, do not
      flag the log corrupted but instead return a new status APPLIED_CORRUPTED
      so that the caller may discard all log for this page. We do not want
      the recovery of unrelated pages to fail in recv_recover_page().
      
      No test case is included, because the known test case would only work
      in 10.6, and even after this fix, it would trigger another bug in
      instant ALTER TABLE crash recovery.
      244fdc43
  10. 03 Sep, 2022 2 commits
    • Andrei's avatar
      MDEV-28827 Minor unsafe statement warning message improvement · f501f815
      Andrei authored
      The replication unsafe warning's pattern gets corrected in the
      punctuation part.
      f501f815
    • Brandon Nesterenko's avatar
      MDEV-28530: Revoking privileges from a non-existing user on a master breaks... · 47812017
      Brandon Nesterenko authored
      MDEV-28530: Revoking privileges from a non-existing user on a master breaks replication on the slave in the presence of replication filters
      
      Problem:
      ========
      Replication can break while applying a query log event if its
      respective command errors on the primary, but is ignored by the
      replication filter within Grant_tables on the replica. The bug
      reported by MDEV-28530 shows this with REVOKE ALL PRIVILEGES using a
      non-existent user. The primary will binlog the REVOKE command with
      an error code, and the replica will think the command executed with
      success because the replication filter will ignore the command while
      accessing the Grant_tables classes. When the replica performs an
      error check, it sees the difference between the error codes, and
      replication breaks.
      
      Solution:
      ========
      If the replication filter check done by Grant_tables logic ignores
      the tables, reset thd->slave_expected_error to 0 so that
      Query_log_event::do_apply_event() can be made aware that the
      underlying query was ignored when it compares errors.
      
      Note that this bug also effects DROP USER if not all users exist
      in the provided list, and the patch fixes and tests this case.
      
      Reviewed By:
      ============
      andrei.elkin@mariadb.com
      47812017
  11. 02 Sep, 2022 1 commit
    • anson1014's avatar
      Remove unused French translations in Connect engine (#2252) · 84813c39
      anson1014 authored
      These files are currently not being used nor compiled in MariaDB. The
      use of large lists of 'case' statements in these source files are also
      not a great way to represent translated strings. This git history can
      be referred to when a better translation interface can be implemented
      in the future.
      
      Therefore, these files can be removed to cleanup the MariaDB codebase.
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer
      Amazon Web Services, Inc.
      84813c39
  12. 01 Sep, 2022 3 commits
  13. 31 Aug, 2022 2 commits
    • Marko Mäkelä's avatar
      MDEV-27983: InnoDB hangs after loading a ROW_FORMAT=COMPRESSED page · 92032499
      Marko Mäkelä authored
      If multiple threads invoke buf_page_get_low() on a ROW_FORMAT=COMPRESSED
      page that does not reside in the buffer pool, then one of the threads
      will end up acquiring an exclusive page latch (the "if" statement
      right before the new wait_for_unzip: label) and other threads will
      end up waiting for a shared latch while holding a buffer-fix.
      The exclusive latch holder would then wait for the buffer-fixes to
      be released while the buffer-fix holders are waiting for the shared latch.
      
      buf_page_get_low(): Prevent the hang that was introduced
      in commit 9436c778 (MDEV-27058),
      by releasing the buffer-fix, sleeping some time, and retrying the
      page lookup.
      92032499
    • Marko Mäkelä's avatar
      MDEV-29374 InnoDB recovery fails with "Data structure corruption" · bdf62ece
      Marko Mäkelä authored
      recv_sys_t::free_corrupted_page(): Identify the corrupted page in
      an error or warning message.
      
      buf_page_free(): Just in case, register the page as modified.
      This should already have been done in mtr_t::free() as part of
      fseg_free_page_low().
      
      mtr_t::memo_push(): Simplify a condition, so that when invoked
      with MTR_MEMO_PAGE_X_MODIFY, we will do the right thing.
      
      fseg_free_page_low(): Remove an accidentally added return statement
      that prevented mtr_t::free() from being called. This fixes a regression
      that was introduced in
      commit 0b47c126 (MDEV-13542).
      bdf62ece