1. 10 Feb, 2004 9 commits
    • unknown's avatar
      Merge with 4.0.18 · 5b2c3126
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      mysql-test/r/ctype_tis620.result-old:
        Merge rename: mysql-test/r/ctype_tis620.result -> mysql-test/r/ctype_tis620.result-old
      BUILD/compile-pentium-max:
        Auto merged
      BitKeeper/etc/config:
        Auto merged
      Build-tools/Bootstrap:
        Auto merged
      Build-tools/Do-compile:
        Auto merged
      configure.in:
        Auto merged
      mysql-test/t/ctype_tis620.test-old:
        Merge rename: mysql-test/t/ctype_tis620.test -> mysql-test/t/ctype_tis620.test-old
      Docs/Makefile.am:
        Auto merged
      client/mysqldump.c:
        Auto merged
      client/mysqltest.c:
        Auto merged
      include/my_global.h:
        Auto merged
      include/my_pthread.h:
        Auto merged
      include/my_sys.h:
        Auto merged
      include/myisam.h:
        Auto merged
      innobase/btr/btr0cur.c:
        Auto merged
      innobase/ibuf/ibuf0ibuf.c:
        Auto merged
      innobase/include/dict0dict.h:
        Auto merged
      innobase/include/srv0srv.h:
        Auto merged
      innobase/include/ut0mem.h:
        Auto merged
      innobase/log/log0log.c:
        Auto merged
      innobase/row/row0ins.c:
        Auto merged
      innobase/row/row0sel.c:
        Auto merged
      innobase/srv/srv0start.c:
        Auto merged
      innobase/ut/ut0mem.c:
        Auto merged
      myisam/mi_check.c:
        Auto merged
      myisam/mi_dynrec.c:
        Auto merged
      myisam/mi_key.c:
        Auto merged
      myisam/myisam_ftdump.c:
        Auto merged
      myisam/myisamdef.h:
        Auto merged
      mysql-test/mysql-test-run.sh:
        Auto merged
      mysql-test/r/alter_table.result:
        Auto merged
      mysql-test/r/bdb.result:
        Auto merged
      mysql-test/r/bigint.result:
        Auto merged
      mysql-test/r/fulltext.result:
        Auto merged
      5b2c3126
    • unknown's avatar
      Wrong type of an argument was sent to my_printf_error(), which · dc792940
      unknown authored
      caused UDF functions to segmenation fault when they tried to
      print an error during wrong usage.
      
      
      dc792940
    • unknown's avatar
      An include was missing. · 4138b2ac
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      4138b2ac
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 65ec6a41
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      
      65ec6a41
    • unknown's avatar
    • unknown's avatar
      8ee9f87d
    • unknown's avatar
      Code cleanups · 30d52f53
      unknown authored
      
      client/mysqlbinlog.cc:
        Ensure that errors are returned to upper levels instead of just doing 'exit/die' in sub function.
      sql/handler.h:
        Indentation cleanup
      sql/sql_insert.cc:
        Indentation cleanup
      30d52f53
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 2282ec0f
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      2282ec0f
    • unknown's avatar
      after merge & valgrind test fixes (BUG#2120) · ecb11989
      unknown authored
      
      sql/sql_derived.cc:
        memory leack fixed
      sql/sql_lex.cc:
        flag to avoid double cleaning
      sql/sql_lex.h:
        flag to avoid double cleaning
      sql/sql_select.cc:
        right way to cleanup JOIN_TAB
      sql/sql_select.h:
        right way to cleanup JOIN_TAB
      sql/sql_union.cc:
        flag to avoid double cleaning
      ecb11989
  2. 09 Feb, 2004 12 commits
    • unknown's avatar
      Fix for the rpl_until.test. · d5b3cb44
      unknown authored
      Don't use --command in tests; use command.
      
      
      mysql-test/r/rpl_until.result:
        result update
      mysql-test/t/rpl_until.test:
        real-sleep is incorrect syntax; mysqltest knows only real_sleep.
        Tip: don't use -- before commands; if mysqltest does not recognize the command
        after -- it just says "it must be a comment", so there is no syntax error detection.
        If you don't use the -- it will report the syntax error.
        The typo caused no sleep, so the slave did not have time to stop.
        Now it has time so we needn't replace the Slave_SQL_Running
        (and it's better to not replace it, because if we don't see that it
        is running, it will trigger errors just a bit later).
      d5b3cb44
    • unknown's avatar
      row0mysql.c: · e2646f09
      unknown authored
        Allow always DROPping of a table which is only referenced by FOREIGN KEY constraints from the same table
      Many files:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      
      
      sql/ha_innodb.cc:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      sql/sql_insert.cc:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      sql/ha_innodb.h:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      sql/handler.h:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      innobase/dict/dict0dict.c:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      innobase/include/dict0dict.h:
        Do not let REPLACE to perform internally an UPDATE if the table is referenced by a FOREIGN KEY: the manual says that REPLACE must resolve a duplicate key error semantically with DELETE(s) + INSERT, and not by an UPDATE; the internal update caused foreign key checks and cascaded operations to behave in a semantically wrong way
      innobase/row/row0mysql.c:
        Allow always DROPping of a table which is only referenced by FOREIGN KEY constraints from the same table
      e2646f09
    • unknown's avatar
      row0mysql.c: · 17d4afc6
      unknown authored
        Fix crash in InnoDB RENAME TABLE if 'databasename/tablename' is shorter than 5 characters (Bug #2689); reported by Sergey Petrunia
      
      
      innobase/row/row0mysql.c:
        Fix crash in InnoDB RENAME TABLE if 'databasename/tablename' is shorter than 5 characters (Bug #2689); reported by Sergey Petrunia
      17d4afc6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · da81724a
      unknown authored
      into mysql.com:/home/kostja/mysql/mysql-4.1-root
      
      
      da81724a
    • unknown's avatar
      switch off SERVER_MORE_RESULTS_EXISTS, but · c4d0631b
      unknown authored
      don't set other flags: it breaks future extensions
      
      
      c4d0631b
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · d4767576
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      mysql-test/r/derived.result:
        Auto merged
      mysql-test/t/derived.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      d4767576
    • unknown's avatar
      Ensure that result from date_format() is binary · 74b81a80
      unknown authored
      Removed warnings from test suite
      
      
      mysql-test/r/ctype_utf8.result:
        Update results after fix of return argument from date_format()
      mysql-test/r/date_formats.result:
        Remove unnecessary warnings
      mysql-test/r/type_decimal.result:
        Remove unnecessary warnings
      mysql-test/r/warnings.result:
        Remove unnecessary warnings
      mysql-test/t/ctype_utf8.test:
        Fixed test
      mysql-test/t/date_formats.test:
        Remove unnecessary warnings
      mysql-test/t/type_decimal.test:
        Remove unnecessary warnings
      mysql-test/t/warnings.test:
        Remove unnecessary warnings
      sql/field.cc:
        Optimize
      sql/item_timefunc.cc:
        Ensure that result from date_format() is binary
      strings/ctype-simple.c:
        Better names for arguments
      74b81a80
    • unknown's avatar
      ufter revview fix (BUG#2120) · 61f0e69c
      unknown authored
      
      mysql-test/r/derived.result:
        test of error handling in derived tables with UPDATE & DELETE
      mysql-test/t/derived.test:
        test of error handling in derived tables with UPDATE & DELETE
      sql/mysql_priv.h:
        opened tables counter added to avoid loop of tables calculating in lock_tables
      sql/sql_acl.cc:
        opened tables counter added to avoid loop of tables calculating in lock_tables, here it is just for compatibility
      sql/sql_base.cc:
        removed unneeded assignment
        opened tables counter added to avoid loop of tables calculating in lock_tables
        commentary fixed
      sql/sql_derived.cc:
        mysql_derived made static
        variable res moved in place where it used
        priveleges written in correct place
      sql/sql_handler.cc:
        opened tables counter added to avoid loop of tables calculating in lock_tables
      sql/sql_parse.cc:
        mistyping in commentary fixed
      61f0e69c
    • unknown's avatar
      merge · 1c810278
      unknown authored
      1c810278
    • unknown's avatar
      Added --compact to mysqlbinlog · 35b1f544
      unknown authored
      Fixed output from mysqlbinlog when using --skip-comments
      Fixed warnings from valgrind
      Fixed ref_length when used with HEAP tables
      More efficent need_conversion()
      Fixed error handling in UPDATE with not updateable tables
      Fixed bug in null handling in CAST to signed/unsigned
      
      
      
      client/client_priv.h:
        cleanup & added OPT_COMPACT
      client/mysqldump.c:
        Added option --compact to get a compact readable dump.
        Ensure that SET CHARACTER_SET_CLIENT is not done if we have not remembered the old character set
        Print optimization comments even if --skip-comments are given as these are not true comments. (Before these where only printed at end, which was a bug)
      mysql-test/r/cast.result:
        More cast tests
      mysql-test/r/derived.result:
        Removed warnings
      mysql-test/r/mysqldump.result:
        Update results after fixing mysqlbinlog
      mysql-test/r/query_cache.result:
        Make test usable with --extern
        more tests
      mysql-test/r/rpl_until.result:
        Make test repeatable under valgrind
      mysql-test/r/sql_mode.result:
        Fix test result
      mysql-test/r/subselect.result:
        Make test smaller. Update wrong results
      mysql-test/t/cast.test:
        More cast tests
      mysql-test/t/derived.test:
        Removed warnings
      mysql-test/t/query_cache.test:
        Make test usable with --extern
        more tests
      mysql-test/t/rpl_until.test:
        fix for valgrind.  Becasue of unknown reason one got 'Slave_SQL_Running=yes' in this setup
      mysql-test/t/subselect.test:
        Make test case smaller
      sql/field.cc:
        Updated need_conversion() to use new arguments
      sql/ha_heap.cc:
        Moved initialization of ref_length to right place. This fixed problem that we had a ref_length of 8 for heap tables, which was not efficent.
      sql/item_func.cc:
        Cleanup
      sql/item_func.h:
        Fixed bug in null_handling for cast to signed/unsigned
      sql/item_strfunc.cc:
        Optimized/cleaned up Item_func_conv_charset3
      sql/item_sum.cc:
        Cleanup.
        Ensure that some flag variables are cleared in cleanup()
      sql/item_sum.h:
        Fixed references to uninitialized memory
      sql/opt_range.cc:
        Fixed spelling error
      sql/sql_class.cc:
        Fixed wrong return code, which could case protocol problems
      sql/sql_class.h:
        After merge fix
      sql/sql_prepare.cc:
        Added comments
      sql/sql_show.cc:
        Cleanup
      sql/sql_string.cc:
        Optimzed usage of need_conversion().
        - Removed not used argument
        - Save diff lenght in 'offset' to not have to recalculate length several times.
        Cleaned up comment
        Optimized copy_aligned() based on the knowledge that it's only called when you have wrong data
      sql/sql_string.h:
        Updated need_conversion() and copy_aligned() to use new arguments
      sql/sql_update.cc:
        Fixed error handling with non-updateable tables
      sql/sql_yacc.yy:
        Ensure that lex->lock_options are set correctly (to get rid of warnings from valgrind)
        Ensure that cast_type sets lex->charset and lex->length. Without these CONVERT() didn't work properly
      35b1f544
    • unknown's avatar
      follow-up to bug #2628: attempt to make · 3da94694
      unknown authored
      alter table rename a bit more efficient in case of
      lower_case_table_names.
      
      
      3da94694
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 584ddfda
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-derived2-4.1
      
      
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      584ddfda
  3. 08 Feb, 2004 2 commits
    • unknown's avatar
      Many files: · cd361b41
      unknown authored
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      sync0sync.c:
        UNIV_SYNC_DEBUG caused assertion in the creation of the doublewrite buffer, if we do not allow thousands of latches per thread
      
      
      innobase/dict/dict0crea.c:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      innobase/dict/dict0dict.c:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      innobase/include/dict0crea.h:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      innobase/include/dict0dict.h:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      innobase/include/ut0mem.h:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      innobase/row/row0mysql.c:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      innobase/sync/sync0sync.c:
        UNIV_SYNC_DEBUG caused assertion in the creation of the doublewrite buffer, if we do not allow thousands of latches per thread
      innobase/ut/ut0mem.c:
        Fix bug #2167: generate foreign key id's locally for each table, in the form databasename/tablename_ibfk_number; if the user gives the constraint name explicitly remember it; these changes should ensure that foreign key id's in a slave are the same as in the master, and DROP FOREIGN KEY does not break replication
      cd361b41
    • unknown's avatar
      ha_innodb.cc: · b0076aad
      unknown authored
        If AUTOCOMMIT=1, then we do not need to make a plain SELECT set shared locks even on the SERIALIZABLE isolation level, because we know the transaction is read-only: a read-only transaction can always be performed on the REPEATABLE READ level, and that does not endanger the serializability
      
      
      sql/ha_innodb.cc:
        If AUTOCOMMIT=1, then we do not need to make a plain SELECT set shared locks even on the SERIALIZABLE isolation level, because we know the transaction is read-only: a read-only transaction can always be performed on the REPEATABLE READ level, and that does not endanger the serializability
      b0076aad
  4. 06 Feb, 2004 7 commits
    • unknown's avatar
      Delete: COPYING.LIB · 496cbfe8
      unknown authored
      496cbfe8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 629dda9c
      unknown authored
      into mysql.com:/home/kostja/mysql/mysql-4.0-merge
      
      
      629dda9c
    • unknown's avatar
      fixed bug #1378 "mysqlbinlog for remote host is broken" · 7db76e5a
      unknown authored
      
      client/mysqlbinlog.cc:
        fixed bug #1378 "mysqlbinlog for remote host is broken"
        by using shared part of code for local and remote variant 
        (function process_event)
      mysql-test/r/mysqlbinlog.result:
        fixed results for remote variant 
        (they are the same as for local now)
      mysql-test/t/mysqlbinlog.test:
        discarded note 'V. Vagin should ...' 
        because V.Vagin done
      sql/log_event.cc:
        added special local_fname flag to Load_log_event for 
        using in Load_log_event::check_fname_outside_temp_buf 
        instead of ugly condition
      sql/log_event.h:
        added special local_fname flag to Load_log_event for 
        using in Load_log_event::check_fname_outside_temp_buf 
        instead of ugly condition
      7db76e5a
    • unknown's avatar
      3.23 -> 4.0 merge: after merge fixes · 854076da
      unknown authored
      854076da
    • unknown's avatar
      Problem fix: · faa8a41b
      unknown authored
      http://bugs.mysql.com/bug.php?id=2366
      Wrong utf8 behaviour when data is trancated
      
      
      faa8a41b
    • unknown's avatar
      merge 3.23 -> 4.0, 2003/02/06 · 5db2d195
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      mysql-test/r/func_math.result:
        Auto merged
      mysql-test/t/func_math.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      5db2d195
    • unknown's avatar
      Fix for bug #2628 "ALTER TABLE destroys table and reports success" · b5819094
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      mysql-test/r/alter_table.result:
        Fix for bug #2628: test result fixed
      mysql-test/t/alter_table.test:
        Fix for bug #2628: test case added
      sql/sql_table.cc:
        Fix for bug #2628:
        We need to take into account database name when checking if source and 
        destination table names are equal.
        Note, that after merge to 4.0 we also need to check for 
        lower_case_table_names.
      b5819094
  5. 05 Feb, 2004 10 commits